[GitHub] merlimat commented on a change in pull request #1812: Allow to configure BK for low latency busy-wait settings

merlimat commented on a change in pull request #1812: Allow to configure BK for low latency busy-wait settings URL: https://github.com/apache/bookkeeper/pull/1812#discussion_r240823344 ## File path: bookkeeper-common/pom.xml ## @@ -30,6 +30,11 @@ bookkeeper-stats-ap

[GitHub] codingwangqi commented on issue #1863: EtcdLedgerManager doesn't support layout versioning

codingwangqi commented on issue #1863: EtcdLedgerManager doesn't support layout versioning URL: https://github.com/apache/bookkeeper/issues/1863#issuecomment-446416384 @ivankelly I am a bit confused now. Per my understanding, layout version is controlling the layout of how

[GitHub] sijie commented on issue #1812: Allow to configure BK for low latency busy-wait settings

sijie commented on issue #1812: Allow to configure BK for low latency busy-wait settings URL: https://github.com/apache/bookkeeper/pull/1812#issuecomment-446423577 run integration tests This is an automated message from the A

[GitHub] sijie closed pull request #1881: [CI] Update precommit job captions with trigger phrase

sijie closed pull request #1881: [CI] Update precommit job captions with trigger phrase URL: https://github.com/apache/bookkeeper/pull/1881 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this

[GitHub] sijie commented on issue #1870: [stats][doc] Add @StatsDoc annotation for journal stats

sijie commented on issue #1870: [stats][doc] Add @StatsDoc annotation for journal stats URL: https://github.com/apache/bookkeeper/pull/1870#issuecomment-446424143 run bookkeeper-server bookie tests This is an automated messag

[GitHub] sijie closed pull request #1871: [stats][doc] Add @StatsDoc annotation for entrylogger stats

sijie closed pull request #1871: [stats][doc] Add @StatsDoc annotation for entrylogger stats URL: https://github.com/apache/bookkeeper/pull/1871 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[GitHub] sijie commented on a change in pull request #1875: [stats][doc] Add @StatsDoc annotation for garbage collector stats

sijie commented on a change in pull request #1875: [stats][doc] Add @StatsDoc annotation for garbage collector stats URL: https://github.com/apache/bookkeeper/pull/1875#discussion_r240852738 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/ScanAndCompareGa

[GitHub] sijie commented on issue #1875: [stats][doc] Add @StatsDoc annotation for garbage collector stats

sijie commented on issue #1875: [stats][doc] Add @StatsDoc annotation for garbage collector stats URL: https://github.com/apache/bookkeeper/pull/1875#issuecomment-446425000 run bookkeeper-server remaining tests This is an aut

[GitHub] sijie commented on issue #1873: [stats][doc] Add @StatsDoc annotation for memtable stats

sijie commented on issue #1873: [stats][doc] Add @StatsDoc annotation for memtable stats URL: https://github.com/apache/bookkeeper/pull/1873#issuecomment-446424925 run integration tests This is an automated message from the A

[GitHub] sijie commented on issue #1874: [stats][doc] Add @StatsDoc annotation for db ledger storage stats

sijie commented on issue #1874: [stats][doc] Add @StatsDoc annotation for db ledger storage stats URL: https://github.com/apache/bookkeeper/pull/1874#issuecomment-446425087 run bookkeeper-server bookie tests This is an automa

[GitHub] sijie closed pull request #1876: [stats][doc] Add @StatsDoc annotation for bookie state manager stats

sijie closed pull request #1876: [stats][doc] Add @StatsDoc annotation for bookie state manager stats URL: https://github.com/apache/bookkeeper/pull/1876 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provena

[GitHub] sijie closed pull request #1877: [stats][doc] Add @StatsDoc annotation for interleaved ledger storage stats

sijie closed pull request #1877: [stats][doc] Add @StatsDoc annotation for interleaved ledger storage stats URL: https://github.com/apache/bookkeeper/pull/1877 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of p

[GitHub] sijie closed pull request #1878: [stats][doc] Add @StatsDoc annotation for bookkeeper client stats

sijie closed pull request #1878: [stats][doc] Add @StatsDoc annotation for bookkeeper client stats URL: https://github.com/apache/bookkeeper/pull/1878 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance

[GitHub] eolivelli commented on a change in pull request #1875: [stats][doc] Add @StatsDoc annotation for garbage collector stats

eolivelli commented on a change in pull request #1875: [stats][doc] Add @StatsDoc annotation for garbage collector stats URL: https://github.com/apache/bookkeeper/pull/1875#discussion_r240891957 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/ScanAndCompa

[GitHub] ivankelly commented on issue #1863: EtcdLedgerManager doesn't support layout versioning

ivankelly commented on issue #1863: EtcdLedgerManager doesn't support layout versioning URL: https://github.com/apache/bookkeeper/issues/1863#issuecomment-446528211 We are using the metadataFormatVersion in the metadata itself to control the version of the individual pieces of metadata. Th

[GitHub] ivankelly commented on issue #1863: EtcdLedgerManager doesn't support layout versioning

ivankelly commented on issue #1863: EtcdLedgerManager doesn't support layout versioning URL: https://github.com/apache/bookkeeper/issues/1863#issuecomment-446530544 Once #1866 is in, I'll push a change to pin etcd to version 2, so that this doesn't surprise us in the future. -

[GitHub] sijie commented on issue #1863: EtcdLedgerManager doesn't support layout versioning

sijie commented on issue #1863: EtcdLedgerManager doesn't support layout versioning URL: https://github.com/apache/bookkeeper/issues/1863#issuecomment-446600066 sorry I am also a bit confused now. why do we need this maximum version format stored in ledger layout? I think I am lost

[GitHub] sijie commented on issue #1863: EtcdLedgerManager doesn't support layout versioning

sijie commented on issue #1863: EtcdLedgerManager doesn't support layout versioning URL: https://github.com/apache/bookkeeper/issues/1863#issuecomment-446602686 @ivankelly : also it seems that we added new fields to the layout format without bump layout version I #1858. it doesn't sound ri

[GitHub] ivankelly commented on issue #1863: EtcdLedgerManager doesn't support layout versioning

ivankelly commented on issue #1863: EtcdLedgerManager doesn't support layout versioning URL: https://github.com/apache/bookkeeper/issues/1863#issuecomment-446603587 > why do we need this maximum version format stored in ledger layout? Because if we don't clients which understand bina

[GitHub] ivankelly commented on issue #1863: EtcdLedgerManager doesn't support layout versioning

ivankelly commented on issue #1863: EtcdLedgerManager doesn't support layout versioning URL: https://github.com/apache/bookkeeper/issues/1863#issuecomment-446605053 This was discussed on dev back in july: https://lists.apache.org/thread.html/4341f414edc55f8a976a56d7f8f4e80545cc3fce752b3

[GitHub] sijie commented on issue #1863: EtcdLedgerManager doesn't support layout versioning

sijie commented on issue #1863: EtcdLedgerManager doesn't support layout versioning URL: https://github.com/apache/bookkeeper/issues/1863#issuecomment-446607366 Lets come up with a BP, as we anyway need documentation for this. --

[GitHub] sijie commented on issue #1863: EtcdLedgerManager doesn't support layout versioning

sijie commented on issue #1863: EtcdLedgerManager doesn't support layout versioning URL: https://github.com/apache/bookkeeper/issues/1863#issuecomment-446607671 4.9.0 will anyway be blocked for documentation if you don't have any. because metadata format changes require tools and documenta

[GitHub] ivankelly commented on issue #1863: EtcdLedgerManager doesn't support layout versioning

ivankelly commented on issue #1863: EtcdLedgerManager doesn't support layout versioning URL: https://github.com/apache/bookkeeper/issues/1863#issuecomment-446613405 Starting to think a client configuration option would be better. Can't remember why I went with a cluster wide. Need to think

[GitHub] eolivelli commented on issue #1863: EtcdLedgerManager doesn't support layout versioning

eolivelli commented on issue #1863: EtcdLedgerManager doesn't support layout versioning URL: https://github.com/apache/bookkeeper/issues/1863#issuecomment-446616168 @ivankelly we can have several different BK clients on the same cluster, even from different applications. It is common in

[GitHub] ivankelly commented on issue #1863: EtcdLedgerManager doesn't support layout versioning

ivankelly commented on issue #1863: EtcdLedgerManager doesn't support layout versioning URL: https://github.com/apache/bookkeeper/issues/1863#issuecomment-446616970 moving this to dev@ as an issue about etcd isn't the right forum

[GitHub] merlimat commented on issue #1812: Allow to configure BK for low latency busy-wait settings

merlimat commented on issue #1812: Allow to configure BK for low latency busy-wait settings URL: https://github.com/apache/bookkeeper/pull/1812#issuecomment-446723791 run integration tests This is an automated message from th

[GitHub] jiazhai removed a comment on issue #1840: Add get method for rest endpoint gc

jiazhai removed a comment on issue #1840: Add get method for rest endpoint gc URL: https://github.com/apache/bookkeeper/pull/1840#issuecomment-446768084 run bookkeeper replication tests This is an automated message from the A

[GitHub] jiazhai commented on issue #1840: Add get method for rest endpoint gc

jiazhai commented on issue #1840: Add get method for rest endpoint gc URL: https://github.com/apache/bookkeeper/pull/1840#issuecomment-446768084 run bookkeeper replication tests This is an automated message from the Apache Gi

[GitHub] jiazhai commented on issue #1840: Add get method for rest endpoint gc

jiazhai commented on issue #1840: Add get method for rest endpoint gc URL: https://github.com/apache/bookkeeper/pull/1840#issuecomment-446768201 run replication tests This is an automated message from the Apache Git S

[GitHub] jiazhai commented on issue #1840: Add get method for rest endpoint gc

jiazhai commented on issue #1840: Add get method for rest endpoint gc URL: https://github.com/apache/bookkeeper/pull/1840#issuecomment-446769006 run bookkeeper-server replication tests This is an automated message from the Ap

[GitHub] jiazhai removed a comment on issue #1840: Add get method for rest endpoint gc

jiazhai removed a comment on issue #1840: Add get method for rest endpoint gc URL: https://github.com/apache/bookkeeper/pull/1840#issuecomment-446768201 run replication tests This is an automated message from the Apac

[GitHub] jiazhai commented on issue #1840: Add get method for rest endpoint gc

jiazhai commented on issue #1840: Add get method for rest endpoint gc URL: https://github.com/apache/bookkeeper/pull/1840#issuecomment-446769830 retest this please This is an automated message from the Apache Git Service. To

[GitHub] jiazhai removed a comment on issue #1840: Add get method for rest endpoint gc

jiazhai removed a comment on issue #1840: Add get method for rest endpoint gc URL: https://github.com/apache/bookkeeper/pull/1840#issuecomment-446769006 run bookkeeper-server replication tests This is an automated message fro

[GitHub] jiazhai removed a comment on issue #1840: Add get method for rest endpoint gc

jiazhai removed a comment on issue #1840: Add get method for rest endpoint gc URL: https://github.com/apache/bookkeeper/pull/1840#issuecomment-446769830 retest this please This is an automated message from the Apache Git Serv

[GitHub] jiazhai commented on issue #1840: Add get method for rest endpoint gc

jiazhai commented on issue #1840: Add get method for rest endpoint gc URL: https://github.com/apache/bookkeeper/pull/1840#issuecomment-446770447 update with latest master This is an automated message from the Apache Git Servi

[GitHub] jiazhai edited a comment on issue #1840: Add get method for rest endpoint gc

jiazhai edited a comment on issue #1840: Add get method for rest endpoint gc URL: https://github.com/apache/bookkeeper/pull/1840#issuecomment-446770447 updated with latest master This is an automated message from the Apache G

[GitHub] reddycharan opened a new pull request #1883: (WIP) Enhance EnsemblePlacementPolicy and DNSResolverDecorator to log relevant metrics.

reddycharan opened a new pull request #1883: (WIP) Enhance EnsemblePlacementPolicy and DNSResolverDecorator to log relevant metrics. URL: https://github.com/apache/bookkeeper/pull/1883 Descriptions of the changes in this PR: Make changes to EnsemblePlacementPolicy so that it

[GitHub] reddycharan commented on issue #1883: (WIP) Enhance EnsemblePlacementPolicy and DNSResolverDecorator to log relevant metrics.

reddycharan commented on issue #1883: (WIP) Enhance EnsemblePlacementPolicy and DNSResolverDecorator to log relevant metrics. URL: https://github.com/apache/bookkeeper/pull/1883#issuecomment-446809762 hey @sijie @athanatos before I get into full implementation, I would like to get your fee

[GitHub] merlimat commented on issue #1808: Allow to configure sticky reads

merlimat commented on issue #1808: Allow to configure sticky reads URL: https://github.com/apache/bookkeeper/pull/1808#issuecomment-446865316 @eolivelli @jvrao @dlg99 @sijie @ivankelly I have updated the PR with the following: * When enabled, `LedgerHandle` has the notion of a sti

[GitHub] sijie commented on issue #1883: (WIP) Enhance EnsemblePlacementPolicy and DNSResolverDecorator to log relevant metrics.

sijie commented on issue #1883: (WIP) Enhance EnsemblePlacementPolicy and DNSResolverDecorator to log relevant metrics. URL: https://github.com/apache/bookkeeper/pull/1883#issuecomment-446991106 @reddycharan looks good to me

[GitHub] sijie closed pull request #1873: [stats][doc] Add @StatsDoc annotation for memtable stats

sijie closed pull request #1873: [stats][doc] Add @StatsDoc annotation for memtable stats URL: https://github.com/apache/bookkeeper/pull/1873 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As thi

[GitHub] sijie closed pull request #1840: Add get method for rest endpoint gc

sijie closed pull request #1840: Add get method for rest endpoint gc URL: https://github.com/apache/bookkeeper/pull/1840 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull r

[GitHub] sijie closed pull request #1874: [stats][doc] Add @StatsDoc annotation for db ledger storage stats

sijie closed pull request #1874: [stats][doc] Add @StatsDoc annotation for db ledger storage stats URL: https://github.com/apache/bookkeeper/pull/1874 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance

[GitHub] sijie closed pull request #1879: [stats][doc] Add @StatsDoc annotation for bookkeeper autorecovery stats

sijie closed pull request #1879: [stats][doc] Add @StatsDoc annotation for bookkeeper autorecovery stats URL: https://github.com/apache/bookkeeper/pull/1879 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of prov

[GitHub] sijie commented on issue #1872: [stats][doc] Add @StatsDoc annotation for ledger cache stats

sijie commented on issue #1872: [stats][doc] Add @StatsDoc annotation for ledger cache stats URL: https://github.com/apache/bookkeeper/pull/1872#issuecomment-446998682 run pr validation This is an automated message from the A

[GitHub] sijie commented on a change in pull request #1875: [stats][doc] Add @StatsDoc annotation for garbage collector stats

sijie commented on a change in pull request #1875: [stats][doc] Add @StatsDoc annotation for garbage collector stats URL: https://github.com/apache/bookkeeper/pull/1875#discussion_r241435528 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/ScanAndCompareGa

[GitHub] sijie commented on a change in pull request #1808: Allow to configure sticky reads

sijie commented on a change in pull request #1808: Allow to configure sticky reads URL: https://github.com/apache/bookkeeper/pull/1808#discussion_r241438417 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandle.java ## @@ -180,6 +194,13 @

[GitHub] pasha-kuznetsov opened a new issue #1884: BUG: dir_*_usage stats are reported as 0 for read-only bookies after a restart

pasha-kuznetsov opened a new issue #1884: BUG: dir_*_usage stats are reported as 0 for read-only bookies after a restart URL: https://github.com/apache/bookkeeper/issues/1884 When a read-only bookie is restarted it keeps reporting `dir_*_usage` stats as `0` until it becomes writable again.

[GitHub] athanatos commented on issue #1883: (WIP) Enhance EnsemblePlacementPolicy and DNSResolverDecorator to log relevant metrics.

athanatos commented on issue #1883: (WIP) Enhance EnsemblePlacementPolicy and DNSResolverDecorator to log relevant metrics. URL: https://github.com/apache/bookkeeper/pull/1883#issuecomment-447153185 I don't really get why isEnsembleFellbackToRandom needs to work like that. Can't we just p

[GitHub] pasha-kuznetsov opened a new pull request #1885: Issue #1884: (@bug W-5697664@) dir_*_usage stats are reported as 0 ...

pasha-kuznetsov opened a new pull request #1885: Issue #1884: (@bug W-5697664@) dir_*_usage stats are reported as 0 ... URL: https://github.com/apache/bookkeeper/pull/1885 bookies after a restart ### Motivation Fixing the Issue #1884: When a read-only bookie is restarte

[GitHub] sijie commented on issue #1870: [stats][doc] Add @StatsDoc annotation for journal stats

sijie commented on issue #1870: [stats][doc] Add @StatsDoc annotation for journal stats URL: https://github.com/apache/bookkeeper/pull/1870#issuecomment-447171304 run bookkeeper-server remaining tests This is an automated mes

[GitHub] sijie commented on issue #1872: [stats][doc] Add @StatsDoc annotation for ledger cache stats

sijie commented on issue #1872: [stats][doc] Add @StatsDoc annotation for ledger cache stats URL: https://github.com/apache/bookkeeper/pull/1872#issuecomment-447172214 run pr validation This is an automated message from the A

[GitHub] sijie closed pull request #1870: [stats][doc] Add @StatsDoc annotation for journal stats

sijie closed pull request #1870: [stats][doc] Add @StatsDoc annotation for journal stats URL: https://github.com/apache/bookkeeper/pull/1870 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this

[GitHub] sijie commented on issue #1872: [stats][doc] Add @StatsDoc annotation for ledger cache stats

sijie commented on issue #1872: [stats][doc] Add @StatsDoc annotation for ledger cache stats URL: https://github.com/apache/bookkeeper/pull/1872#issuecomment-447182500 run pr validation This is an automated message from the A

[GitHub] sijie closed pull request #1868: BP-37: Improve configuration management for better documentation

sijie closed pull request #1868: BP-37: Improve configuration management for better documentation URL: https://github.com/apache/bookkeeper/pull/1868 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] sijie closed issue #1884: BUG: dir_*_usage stats are reported as 0 for read-only bookies after a restart

sijie closed issue #1884: BUG: dir_*_usage stats are reported as 0 for read-only bookies after a restart URL: https://github.com/apache/bookkeeper/issues/1884 This is an automated message from the Apache Git Service. To resp

[GitHub] sijie closed pull request #1885: Issue #1884: (@W-5697664@) dir_*_usage stats are reported as 0 ...

sijie closed pull request #1885: Issue #1884: (@W-5697664@) dir_*_usage stats are reported as 0 ... URL: https://github.com/apache/bookkeeper/pull/1885 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenanc

[GitHub] sijie commented on issue #1755: Configure Netty allocator in bookie and client

sijie commented on issue #1755: Configure Netty allocator in bookie and client URL: https://github.com/apache/bookkeeper/pull/1755#issuecomment-447185528 @merlimat it seems this PR requires rebase and there are some checkstyle issues needs to be fixed as well. ---

[GitHub] jvrao opened a new issue #1886: Handle double bookie failures with outstanding metadata change.

jvrao opened a new issue #1886: Handle double bookie failures with outstanding metadata change. URL: https://github.com/apache/bookkeeper/issues/1886 Is this a question, feature request, bug report, or bookkeeper proposal? **QUESTION** Have you checked our documentation at htt

[GitHub] jvrao opened a new pull request #1887: Issue#1886 Handle double bookie failures

jvrao opened a new pull request #1887: Issue#1886 Handle double bookie failures URL: https://github.com/apache/bookkeeper/pull/1887 For this race condition to happen: 1. ZK metadata version is different from Client write ledger handle - Replication worker 2. Client made an ensemb

[GitHub] jvrao commented on a change in pull request #1887: Issue#1886 Handle double bookie failures

jvrao commented on a change in pull request #1887: Issue#1886 Handle double bookie failures URL: https://github.com/apache/bookkeeper/pull/1887#discussion_r241910418 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandle.java ## @@ -1972,6

[GitHub] athanatos commented on a change in pull request #1887: Issue#1886 Handle double bookie failures

athanatos commented on a change in pull request #1887: Issue#1886 Handle double bookie failures URL: https://github.com/apache/bookkeeper/pull/1887#discussion_r241914188 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandle.java ## @@ -22

[GitHub] athanatos commented on issue #1887: Issue#1886 Handle double bookie failures

athanatos commented on issue #1887: Issue#1886 Handle double bookie failures URL: https://github.com/apache/bookkeeper/pull/1887#issuecomment-447503537 I don't really have a problem with the test stub, tbh. This is an automate

[GitHub] jvrao commented on a change in pull request #1887: Issue#1886 Handle double bookie failures

jvrao commented on a change in pull request #1887: Issue#1886 Handle double bookie failures URL: https://github.com/apache/bookkeeper/pull/1887#discussion_r241915956 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandle.java ## @@ -,9

[GitHub] reddycharan commented on a change in pull request #1887: Issue#1886 Handle double bookie failures

reddycharan commented on a change in pull request #1887: Issue#1886 Handle double bookie failures URL: https://github.com/apache/bookkeeper/pull/1887#discussion_r241927011 ## File path: bookkeeper-server/src/test/java/org/apache/bookkeeper/client/BookieWriteLedgerTest.java ###

[GitHub] reddycharan commented on a change in pull request #1887: Issue#1886 Handle double bookie failures

reddycharan commented on a change in pull request #1887: Issue#1886 Handle double bookie failures URL: https://github.com/apache/bookkeeper/pull/1887#discussion_r241927153 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandle.java ## @@ -

[GitHub] jvrao commented on a change in pull request #1887: Issue#1886 Handle double bookie failures

jvrao commented on a change in pull request #1887: Issue#1886 Handle double bookie failures URL: https://github.com/apache/bookkeeper/pull/1887#discussion_r241929561 ## File path: bookkeeper-server/src/test/java/org/apache/bookkeeper/client/BookieWriteLedgerTest.java ## @

[GitHub] jvrao commented on a change in pull request #1887: Issue#1886 Handle double bookie failures

jvrao commented on a change in pull request #1887: Issue#1886 Handle double bookie failures URL: https://github.com/apache/bookkeeper/pull/1887#discussion_r241929495 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandle.java ## @@ -2113,6

[GitHub] eolivelli commented on a change in pull request #1808: Allow to configure sticky reads

eolivelli commented on a change in pull request #1808: Allow to configure sticky reads URL: https://github.com/apache/bookkeeper/pull/1808#discussion_r241944851 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandle.java ## @@ -1972,4 +200

[GitHub] sijie commented on issue #1869: Introduce a configuration framework for better organizing and documentating configuration settings

sijie commented on issue #1869: Introduce a configuration framework for better organizing and documentating configuration settings URL: https://github.com/apache/bookkeeper/pull/1869#issuecomment-447610939 run bookkeeper-server remaining tests run integration tests -

[GitHub] sijie commented on issue #1872: [stats][doc] Add @StatsDoc annotation for ledger cache stats

sijie commented on issue #1872: [stats][doc] Add @StatsDoc annotation for ledger cache stats URL: https://github.com/apache/bookkeeper/pull/1872#issuecomment-447610984 run pr validation This is an automated message from the A

[GitHub] sijie commented on a change in pull request #1875: [stats][doc] Add @StatsDoc annotation for garbage collector stats

sijie commented on a change in pull request #1875: [stats][doc] Add @StatsDoc annotation for garbage collector stats URL: https://github.com/apache/bookkeeper/pull/1875#discussion_r241965453 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/ScanAndCompareGa

[GitHub] sijie closed pull request #1875: [stats][doc] Add @StatsDoc annotation for garbage collector stats

sijie closed pull request #1875: [stats][doc] Add @StatsDoc annotation for garbage collector stats URL: https://github.com/apache/bookkeeper/pull/1875 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance

[GitHub] sijie closed pull request #1872: [stats][doc] Add @StatsDoc annotation for ledger cache stats

sijie closed pull request #1872: [stats][doc] Add @StatsDoc annotation for ledger cache stats URL: https://github.com/apache/bookkeeper/pull/1872 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[GitHub] jvrao commented on issue #1887: Issue#1886 Handle double bookie failures

jvrao commented on issue #1887: Issue#1886 Handle double bookie failures URL: https://github.com/apache/bookkeeper/pull/1887#issuecomment-447921998 rebuild java8 This is an automated message from the Apache Git Service. To

[GitHub] jvrao commented on issue #1887: Issue#1886 Handle double bookie failures

jvrao commented on issue #1887: Issue#1886 Handle double bookie failures URL: https://github.com/apache/bookkeeper/pull/1887#issuecomment-448059537 @ivankelly @sijie @eolivelli can one of you review this please? This is an au

[GitHub] reddycharan commented on issue #1883: (WIP) Enhance EnsemblePlacementPolicy and DNSResolverDecorator to log relevant metrics.

reddycharan commented on issue #1883: (WIP) Enhance EnsemblePlacementPolicy and DNSResolverDecorator to log relevant metrics. URL: https://github.com/apache/bookkeeper/pull/1883#issuecomment-448135479 @athanatos as we discussed, it is way more convoluted to propagate that information up th

[GitHub] reddycharan commented on issue #1883: Enhance EnsemblePlacementPolicy and DNSResolverDecorator to log relevant metrics.

reddycharan commented on issue #1883: Enhance EnsemblePlacementPolicy and DNSResolverDecorator to log relevant metrics. URL: https://github.com/apache/bookkeeper/pull/1883#issuecomment-448143057 @sijie @athanatos this is ready for review. ---

[GitHub] reddycharan commented on a change in pull request #1883: Enhance EnsemblePlacementPolicy and DNSResolverDecorator to log relevant metrics.

reddycharan commented on a change in pull request #1883: Enhance EnsemblePlacementPolicy and DNSResolverDecorator to log relevant metrics. URL: https://github.com/apache/bookkeeper/pull/1883#discussion_r242448708 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/c

[GitHub] athanatos commented on issue #1883: Enhance EnsemblePlacementPolicy and DNSResolverDecorator to log relevant metrics.

athanatos commented on issue #1883: Enhance EnsemblePlacementPolicy and DNSResolverDecorator to log relevant metrics. URL: https://github.com/apache/bookkeeper/pull/1883#issuecomment-448340146 LGTM This is an automated messag

[GitHub] reddycharan opened a new pull request #1888: Bring back statslogger to BookKeeper client in ReplicationWorker process.

reddycharan opened a new pull request #1888: Bring back statslogger to BookKeeper client in ReplicationWorker process. URL: https://github.com/apache/bookkeeper/pull/1888 Descriptions of the changes in this PR: - https://github.com/apache/bookkeeper/commit/2837f6257baf15dc9dd9eb

[GitHub] reddycharan commented on issue #1888: Bring back statslogger to BookKeeper client in ReplicationWorker process.

reddycharan commented on issue #1888: Bring back statslogger to BookKeeper client in ReplicationWorker process. URL: https://github.com/apache/bookkeeper/pull/1888#issuecomment-448424305 @pasha-kuznetsov fyi. This is an autom

[GitHub] sijie commented on a change in pull request #1883: Enhance EnsemblePlacementPolicy and DNSResolverDecorator to log relevant metrics.

sijie commented on a change in pull request #1883: Enhance EnsemblePlacementPolicy and DNSResolverDecorator to log relevant metrics. URL: https://github.com/apache/bookkeeper/pull/1883#discussion_r242781460 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/

[GitHub] sijie commented on a change in pull request #1883: Enhance EnsemblePlacementPolicy and DNSResolverDecorator to log relevant metrics.

sijie commented on a change in pull request #1883: Enhance EnsemblePlacementPolicy and DNSResolverDecorator to log relevant metrics. URL: https://github.com/apache/bookkeeper/pull/1883#discussion_r242781707 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/

[GitHub] sijie commented on a change in pull request #1883: Enhance EnsemblePlacementPolicy and DNSResolverDecorator to log relevant metrics.

sijie commented on a change in pull request #1883: Enhance EnsemblePlacementPolicy and DNSResolverDecorator to log relevant metrics. URL: https://github.com/apache/bookkeeper/pull/1883#discussion_r242781635 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/

[GitHub] sijie commented on issue #1887: Issue#1886 Handle double bookie failures

sijie commented on issue #1887: Issue#1886 Handle double bookie failures URL: https://github.com/apache/bookkeeper/pull/1887#issuecomment-448457391 run integration tests This is an automated message from the Apache Git Service

[GitHub] sijie commented on issue #1887: Issue#1886 Handle double bookie failures

sijie commented on issue #1887: Issue#1886 Handle double bookie failures URL: https://github.com/apache/bookkeeper/pull/1887#issuecomment-448504949 @jvrao oh I see. it seems the integration tests job was changed in master. I think we can ignore the integration job for merging this. ---

[GitHub] sijie commented on issue #1887: Issue#1886 Handle double bookie failures

sijie commented on issue #1887: Issue#1886 Handle double bookie failures URL: https://github.com/apache/bookkeeper/pull/1887#issuecomment-448504971 IGNORE IT CI This is an automated message from the Apache Git Service. To resp

[GitHub] sijie closed pull request #1888: Bring back statslogger to BookKeeper client in ReplicationWorker process.

sijie closed pull request #1888: Bring back statslogger to BookKeeper client in ReplicationWorker process. URL: https://github.com/apache/bookkeeper/pull/1888 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of pr

[GitHub] eolivelli commented on a change in pull request #1888: Bring back statslogger to BookKeeper client in ReplicationWorker process.

eolivelli commented on a change in pull request #1888: Bring back statslogger to BookKeeper client in ReplicationWorker process. URL: https://github.com/apache/bookkeeper/pull/1888#discussion_r242887704 ## File path: site/_data/config/bk_server.yaml ## @@ -538,6 +538,9 @@

[GitHub] sijie commented on issue #1869: Introduce a configuration framework for better organizing and documentating configuration settings

sijie commented on issue #1869: Introduce a configuration framework for better organizing and documentating configuration settings URL: https://github.com/apache/bookkeeper/pull/1869#issuecomment-448581896 run integration tests --

[GitHub] ivankelly opened a new pull request #1889: Multiple calls to LedgerHandle#close should wait on actual close

ivankelly opened a new pull request #1889: Multiple calls to LedgerHandle#close should wait on actual close URL: https://github.com/apache/bookkeeper/pull/1889 The previous behaviour was to complete successfully immediately if close had already been called on the handle. This allowed for

[GitHub] ivankelly commented on issue #1889: Multiple calls to LedgerHandle#close should wait on actual close

ivankelly commented on issue #1889: Multiple calls to LedgerHandle#close should wait on actual close URL: https://github.com/apache/bookkeeper/pull/1889#issuecomment-448623578 run integration tests This is an automated messag

[GitHub] ivankelly commented on issue #1889: Multiple calls to LedgerHandle#close should wait on actual close

ivankelly commented on issue #1889: Multiple calls to LedgerHandle#close should wait on actual close URL: https://github.com/apache/bookkeeper/pull/1889#issuecomment-448649766 run pr validation This is an automated message fr

[GitHub] ivankelly opened a new pull request #1890: Revert maxLedgerMetadataFormatVersion changes in layout

ivankelly opened a new pull request #1890: Revert maxLedgerMetadataFormatVersion changes in layout URL: https://github.com/apache/bookkeeper/pull/1890 There is ongoing discussions about how to do this, so I'm reverting this change for now to allow 4.9 release to proceed. The change modif

[GitHub] ivankelly commented on issue #1889: Multiple calls to LedgerHandle#close should wait on actual close

ivankelly commented on issue #1889: Multiple calls to LedgerHandle#close should wait on actual close URL: https://github.com/apache/bookkeeper/pull/1889#issuecomment-448724956 run pr validation This is an automated message fr

[GitHub] ivankelly commented on issue #1890: Revert maxLedgerMetadataFormatVersion changes in layout

ivankelly commented on issue #1890: Revert maxLedgerMetadataFormatVersion changes in layout URL: https://github.com/apache/bookkeeper/pull/1890#issuecomment-448725632 rebuild java8 run pr validation run bookkeeper-server bookie tests run integration tests -

[GitHub] athanatos opened a new issue #1891: Error paths in Bookie.start() don't stop the LifecycleComponent in Main.doMain

athanatos opened a new issue #1891: Error paths in Bookie.start() don't stop the LifecycleComponent in Main.doMain URL: https://github.com/apache/bookkeeper/issues/1891 It looks to me like calling shutdown() in the error paths doesn't actually result in the LifecycleComponent in Main.doMai

[GitHub] sijie commented on a change in pull request #1889: Multiple calls to LedgerHandle#close should wait on actual close

sijie commented on a change in pull request #1889: Multiple calls to LedgerHandle#close should wait on actual close URL: https://github.com/apache/bookkeeper/pull/1889#discussion_r243158576 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandle.java

[GitHub] sijie commented on issue #1869: Introduce a configuration framework for better organizing and documentating configuration settings

sijie commented on issue #1869: Introduce a configuration framework for better organizing and documentating configuration settings URL: https://github.com/apache/bookkeeper/pull/1869#issuecomment-449053136 rebuild java9 run integration tests -

<    5   6   7   8   9   10   11   12   13   14   >