[GitHub] reddycharan commented on issue #1094: BP-27 (part 1): New BookKeeper CLI Skeleton
reddycharan commented on issue #1094: BP-27 (part 1): New BookKeeper CLI Skeleton URL: https://github.com/apache/bookkeeper/pull/1094#issuecomment-366124429 it is matter of convenience and less error-prone to not have '-' in script filename/command name. When we spell it, people might take it incorrectly as an option, "bookkeeper -cli". Anyhow I'll leave the decision to public opinion. LGTM! for the first iteration. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] reddycharan commented on issue #1094: BP-27 (part 1): New BookKeeper CLI Skeleton
reddycharan commented on issue #1094: BP-27 (part 1): New BookKeeper CLI Skeleton URL: https://github.com/apache/bookkeeper/pull/1094#issuecomment-366037024 overall LGTM. Other than the need of reflection and naming script/command with '-'. Regarding help usage message, it can be improved, like it is showing [options] unnecessarily in couple of places and from the help usage command it is not clear what is command vs sub-command. But for now I'm fine with it, hoping it can be improved/enhanced later. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] reddycharan commented on issue #1094: BP-27 (part 1): New BookKeeper CLI Skeleton
reddycharan commented on issue #1094: BP-27 (part 1): New BookKeeper CLI Skeleton URL: https://github.com/apache/bookkeeper/pull/1094#issuecomment-366035855 "@reddycharan updated this PR to use "bookkeeper-cli" instead of "bookie-shell" in the command output, to avoid confusion." im not in favor of having '-' in command name and script file name. People make all kind of mistakes with usage of '-' in the script file name/command name. Probably removing '-' and making it "bookkeepercli" might be better. But again we are having this script file (bookkeeper-cli) only for running shell commands right? its not for starting bookies, or localbookie, right? in that case having word shell in the script file name or command name might be better say - "bookieshellcli" or "bookkeepershellcli". If we are planning to have bookie start and localbookie start functionality as well in that script then we can just leave it as "bookkeepercli" This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services