[GitHub] eolivelli commented on a change in pull request #742: Issue-744 BP-18 introduce write flags

2017-12-01 Thread GitBox
eolivelli commented on a change in pull request #742: Issue-744 BP-18 introduce write flags URL: https://github.com/apache/bookkeeper/pull/742#discussion_r154375957 ## File path: site/docs/latest/api/ledger-api.md ## @@ -471,3 +471,304 @@ mvn exec:java

[GitHub] eolivelli commented on a change in pull request #742: Issue-744 BP-18 introduce write flags

2017-12-01 Thread GitBox
eolivelli commented on a change in pull request #742: Issue-744 BP-18 introduce write flags URL: https://github.com/apache/bookkeeper/pull/742#discussion_r154375634 ## File path: site/docs/latest/api/ledger-api.md ## @@ -471,3 +471,304 @@ mvn exec:java

[GitHub] eolivelli commented on a change in pull request #742: Issue-744 BP-18 introduce write flags

2017-12-01 Thread GitBox
eolivelli commented on a change in pull request #742: Issue-744 BP-18 introduce write flags URL: https://github.com/apache/bookkeeper/pull/742#discussion_r154369538 ## File path: site/docs/latest/api/ledger-api.md ## @@ -36,12 +36,12 @@ If you're using

[GitHub] eolivelli commented on a change in pull request #742: Issue-744 BP-18 introduce write flags

2017-12-01 Thread GitBox
eolivelli commented on a change in pull request #742: Issue-744 BP-18 introduce write flags URL: https://github.com/apache/bookkeeper/pull/742#discussion_r154369521 ## File path: site/docs/latest/api/ledger-api.md ## @@ -20,7 +20,7 @@ If you're using

[GitHub] eolivelli commented on a change in pull request #742: Issue-744 BP-18 introduce write flags

2017-12-01 Thread GitBox
eolivelli commented on a change in pull request #742: Issue-744 BP-18 introduce write flags URL: https://github.com/apache/bookkeeper/pull/742#discussion_r154369476 ## File path: site/.ruby-version ## @@ -0,0 +1 @@ +2.4.1 Review comment: it is my local ruby "rbenv",

[GitHub] eolivelli commented on a change in pull request #742: Issue-744 BP-18 introduce write flags

2017-11-28 Thread GitBox
eolivelli commented on a change in pull request #742: Issue-744 BP-18 introduce write flags URL: https://github.com/apache/bookkeeper/pull/742#discussion_r153552849 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/api/WriteFlag.java ## @@ -0,0

[GitHub] eolivelli commented on a change in pull request #742: Issue-744 BP-18 introduce write flags

2017-11-28 Thread GitBox
eolivelli commented on a change in pull request #742: Issue-744 BP-18 introduce write flags URL: https://github.com/apache/bookkeeper/pull/742#discussion_r153552867 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/api/WriteFlag.java ## @@ -0,0

[GitHub] eolivelli commented on a change in pull request #742: Issue-744 BP-18 introduce write flags

2017-11-28 Thread GitBox
eolivelli commented on a change in pull request #742: Issue-744 BP-18 introduce write flags URL: https://github.com/apache/bookkeeper/pull/742#discussion_r153552837 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/api/WriteFlag.java ## @@ -0,0

[GitHub] eolivelli commented on a change in pull request #742: Issue-744 BP-18 introduce write flags

2017-11-23 Thread GitBox
eolivelli commented on a change in pull request #742: Issue-744 BP-18 introduce write flags URL: https://github.com/apache/bookkeeper/pull/742#discussion_r152822846 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/api/WriteFlag.java ## @@ -0,0

[GitHub] eolivelli commented on a change in pull request #742: Issue-744 BP-18 introduce write flags

2017-11-21 Thread GitBox
eolivelli commented on a change in pull request #742: Issue-744 BP-18 introduce write flags URL: https://github.com/apache/bookkeeper/pull/742#discussion_r152333935 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/api/WriteFlag.java ## @@ -0,0

[GitHub] eolivelli commented on a change in pull request #742: Issue-744 BP-18 introduce write flags

2017-11-21 Thread GitBox
eolivelli commented on a change in pull request #742: Issue-744 BP-18 introduce write flags URL: https://github.com/apache/bookkeeper/pull/742#discussion_r152332174 ## File path: bookkeeper-server/src/test/java/org/apache/bookkeeper/client/api/WriteFlagTest.java ## @@

[GitHub] eolivelli commented on a change in pull request #742: Issue-744 BP-18 introduce write flags

2017-11-21 Thread GitBox
eolivelli commented on a change in pull request #742: Issue-744 BP-18 introduce write flags URL: https://github.com/apache/bookkeeper/pull/742#discussion_r152332135 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/api/WriteFlag.java ## @@ -20,14

[GitHub] eolivelli commented on a change in pull request #742: Issue-744 BP-18 introduce write flags

2017-11-21 Thread GitBox
eolivelli commented on a change in pull request #742: Issue-744 BP-18 introduce write flags URL: https://github.com/apache/bookkeeper/pull/742#discussion_r152331321 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/api/CreateBuilder.java ## @@

[GitHub] eolivelli commented on a change in pull request #742: Issue-744 BP-18 introduce write flags

2017-11-21 Thread GitBox
eolivelli commented on a change in pull request #742: Issue-744 BP-18 introduce write flags URL: https://github.com/apache/bookkeeper/pull/742#discussion_r152331090 ## File path: bookkeeper-proto/src/main/proto/BookkeeperProtocol.proto ## @@ -112,6 +112,7 @@ message