eolivelli commented on issue #643: BP-14 part 2 - client side changes
URL: https://github.com/apache/bookkeeper/pull/643#issuecomment-339746879
Thank you @sijie I will send patches soon. I will close old pull requests as
far as I am sure to have addresses all if the comments.
Other p
eolivelli commented on issue #643: BP-14 part 2 - client side changes
URL: https://github.com/apache/bookkeeper/pull/643#issuecomment-339708273
@sijie this is an example of patch 1 "introducing ledgertype":
see above comments
https://github.com/eolivelli/bookkeeper/commit/2a1b27b
eolivelli commented on issue #643: BP-14 part 2 - client side changes
URL: https://github.com/apache/bookkeeper/pull/643#issuecomment-339332761
@sijie I am splitting the patch following your suggestions, some question:
> I think there are three main changes here:
> 1) write ent
eolivelli commented on issue #643: BP-14 part 2 - client side changes
URL: https://github.com/apache/bookkeeper/pull/643#issuecomment-337734123
Thank you @sijie
I will address your comments as soon as possible but as you are suggesting
it is better to split the work using a different sc
eolivelli commented on issue #643: BP-14 part 2 - client side changes
URL: https://github.com/apache/bookkeeper/pull/643#issuecomment-337705813
I forgot to include part of the needed changes, so most of the failed. I
willbfix this pr before sending the next
