ivankelly commented on a change in pull request #649: Pool AddCompletions URL: https://github.com/apache/bookkeeper/pull/649#discussion_r146470461
########## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/PerChannelBookieClient.java ########## @@ -832,28 +836,7 @@ private void writeAndFlush(final Channel channel, } try{ - channel.writeAndFlush(request) - .addListener(new ChannelFutureListener() { - @Override - public void operationComplete(ChannelFuture future) - throws Exception { - if (future.isSuccess()) { - if (LOG.isDebugEnabled()) { - LOG.debug("Successfully wrote request {} to {}", - requestToString(request), - channel.remoteAddress()); - } - } else { - if (!(future.cause() - instanceof ClosedChannelException)) { - LOG.warn("Writing request {} to {} failed : ", - requestToString(request), - channel, future.cause()); - } - errorOut(key); Review comment: @eolivelli Yes. Any write error will result in an exception on the channel, which will result in the channel being closed, which will result in all active keys being errored out. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services