[GitHub] ivankelly commented on issue #1133: Integration smoke test

2018-02-14 Thread GitBox
ivankelly commented on issue #1133: Integration smoke test URL: https://github.com/apache/bookkeeper/pull/1133#issuecomment-365771167 @sijie ok to merge this? This is an automated message from the Apache Git Service. To

[GitHub] ivankelly commented on issue #1133: Integration smoke test

2018-02-12 Thread GitBox
ivankelly commented on issue #1133: Integration smoke test URL: https://github.com/apache/bookkeeper/pull/1133#issuecomment-364964911 > so the question here is more about whether we want to expose sync method for every method we are adding, or just providing a util class or let the

[GitHub] ivankelly commented on issue #1133: Integration smoke test

2018-02-12 Thread GitBox
ivankelly commented on issue #1133: Integration smoke test URL: https://github.com/apache/bookkeeper/pull/1133#issuecomment-364959123 > can use FutureUtils.result(...) which already unwrap the exception from ExecutionException, so you can catch specific exceptions. Wrapping all

[GitHub] ivankelly commented on issue #1133: Integration smoke test

2018-02-12 Thread GitBox
ivankelly commented on issue #1133: Integration smoke test URL: https://github.com/apache/bookkeeper/pull/1133#issuecomment-36490 > what are the issues blocking using it in tests. @sijie Nothing blocking persay, but I want the asyncClose issue revolved before I start using them.

[GitHub] ivankelly commented on issue #1133: Integration smoke test

2018-02-09 Thread GitBox
ivankelly commented on issue #1133: Integration smoke test URL: https://github.com/apache/bookkeeper/pull/1133#issuecomment-364432617 regarding the api, I'd like to see some issues resolved with it before I start using it in tests. It's something I'm planning to come back to, but I wanted