jiazhai opened a new issue #731: Refine LedgerEntry interface URL: https://github.com/apache/bookkeeper/issues/731 In review of #727, @sijie suggested to refine the LedgerEntry interface: The LedgerEntry interface is completely a mess. getEntry() and getEntryBuffer() have completely different behaviors. getEntry() releases bytebuf automatically, while getEntryBuffer() returns the bytebuf (if you don't call getEntry, you are responsible for releasing the entry buffer. suggest: removing getEntry() from LedgerEntry, or make it reenterable. make LedgerEntry implement AutoCloseable. LedgerEntry should be responsible for releasing the bytebuf it is holding. LedgerEntry should implement duplicate method. iterator here should have a separate copy of LedgerEntry and make a slice of the underlying bytebuf.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
