sijie commented on a change in pull request #1115: Change default ledger
manager factory from `Flat` to `Hierachical`
URL: https://github.com/apache/bookkeeper/pull/1115#discussion_r165787436
##########
File path: deploy/kubernetes/gke/bookkeeper.statefulset.yml
##########
@@ -39,8 +39,6 @@ data:
BK_ledgerDirectories: "/bookkeeper/data/ledgers"
BK_indexDirectories: "/bookkeeper/data/ledgers"
BK_zkServers: zookeeper
- # the default manager is flat, which is not good for supporting large
number of ledgers
- BK_ledgerManagerType: "hierarchical"
Review comment:
`ledgerMangerType` is already deprecated long time ago. it doesn't make any
sense to leave it here. we used the wrong parameter here so I don't see a
reason to have it though. for people who is new to bookkeeper, he should be
knowing less settings as possible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
