[GitHub] sijie commented on issue #1121: [Merge Yahoo repo]: AsyncReadLastEntry should trigger callback with error when ledger is empty

2018-02-16 Thread GitBox
sijie commented on issue #1121: [Merge Yahoo repo]: AsyncReadLastEntry should trigger callback with error when ledger is empty URL: https://github.com/apache/bookkeeper/pull/1121#issuecomment-366288061 IGNORE CI This is an au

[GitHub] sijie commented on issue #1121: [Merge Yahoo repo]: AsyncReadLastEntry should trigger callback with error when ledger is empty

2018-02-16 Thread GitBox
sijie commented on issue #1121: [Merge Yahoo repo]: AsyncReadLastEntry should trigger callback with error when ledger is empty URL: https://github.com/apache/bookkeeper/pull/1121#issuecomment-366287892 all CI jobs are green except "Integration Tests". but this change is adding a new method

[GitHub] sijie commented on issue #1121: [Merge Yahoo repo]: AsyncReadLastEntry should trigger callback with error when ledger is empty

2018-02-14 Thread GitBox
sijie commented on issue #1121: [Merge Yahoo repo]: AsyncReadLastEntry should trigger callback with error when ledger is empty URL: https://github.com/apache/bookkeeper/pull/1121#issuecomment-365796195 @jvrao can you review this PR again since you were involved in this PR?

[GitHub] sijie commented on issue #1121: [Merge Yahoo repo]: AsyncReadLastEntry should trigger callback with error when ledger is empty

2018-02-14 Thread GitBox
sijie commented on issue #1121: [Merge Yahoo repo]: AsyncReadLastEntry should trigger callback with error when ledger is empty URL: https://github.com/apache/bookkeeper/pull/1121#issuecomment-365796214 retest this please This

[GitHub] sijie commented on issue #1121: [Merge Yahoo repo]: AsyncReadLastEntry should trigger callback with error when ledger is empty

2018-02-08 Thread GitBox
sijie commented on issue #1121: [Merge Yahoo repo]: AsyncReadLastEntry should trigger callback with error when ledger is empty URL: https://github.com/apache/bookkeeper/pull/1121#issuecomment-364080969 @jiazhai as we chatted offline, I don't think you need to wait for #898. you can cherry-

[GitHub] sijie commented on issue #1121: [Merge Yahoo repo]: AsyncReadLastEntry should trigger callback with error when ledger is empty

2018-02-05 Thread GitBox
sijie commented on issue #1121: [Merge Yahoo repo]: AsyncReadLastEntry should trigger callback with error when ledger is empty URL: https://github.com/apache/bookkeeper/pull/1121#issuecomment-363186519 @jiazhai I think this cherry-pick is not correct. You need to cherry-pick changes