sijie commented on issue #1281: Issue #570: Introducing EntryLogManager.
URL: https://github.com/apache/bookkeeper/pull/1281#issuecomment-381868889
retest this please
This is an automated message from the Apache Git Service.
sijie commented on issue #1281: Issue #570: Introducing EntryLogManager.
URL: https://github.com/apache/bookkeeper/pull/1281#issuecomment-377391260
> @sijie if you are ok with my comment regarding currentLogId, I can send
next iteration change.
go for it now. I will think of how to
sijie commented on issue #1281: Issue #570: Introducing EntryLogManager.
URL: https://github.com/apache/bookkeeper/pull/1281#issuecomment-376631793
@ivankelly :
appreciate you are working on this change. Here are my thought below:
> If there are circular dependencies, then
sijie commented on issue #1281: Issue #570: Introducing EntryLogManager.
URL: https://github.com/apache/bookkeeper/pull/1281#issuecomment-376311538
@ivankelly :
> Move into its own java file. EntryLogger is already huge.
> Move into it's own file.
I see you left a few
