[GitHub] sijie commented on issue #853: BP-14 WriteFlag DEFERRED_SYNC Client Side Implementation

2018-05-22 Thread GitBox
sijie commented on issue #853: BP-14 WriteFlag DEFERRED_SYNC Client Side Implementation URL: https://github.com/apache/bookkeeper/pull/853#issuecomment-390909464 @jvrao please review this PR again This is an automated

[GitHub] sijie commented on issue #853: BP-14 WriteFlag DEFERRED_SYNC Client Side Implementation

2018-05-15 Thread GitBox
sijie commented on issue #853: BP-14 WriteFlag DEFERRED_SYNC Client Side Implementation URL: https://github.com/apache/bookkeeper/pull/853#issuecomment-389220787 @eolivelli > My point about LAC: I think @jvrao and me discussed before, we agreed on 2). that's why we don't

[GitHub] sijie commented on issue #853: BP-14 WriteFlag DEFERRED_SYNC Client Side Implementation

2018-02-05 Thread GitBox
sijie commented on issue #853: BP-14 WriteFlag DEFERRED_SYNC Client Side Implementation URL: https://github.com/apache/bookkeeper/pull/853#issuecomment-363180119 Will try to see if I have cycles to help This is an automated

[GitHub] sijie commented on issue #853: BP-14 WriteFlag DEFERRED_SYNC Client Side Implementation

2018-02-05 Thread GitBox
sijie commented on issue #853: BP-14 WriteFlag DEFERRED_SYNC Client Side Implementation URL: https://github.com/apache/bookkeeper/pull/853#issuecomment-363153812 @eolivelli it is always good to complete server side changes before adding logics/functionality at client side. otherwise you

[GitHub] sijie commented on issue #853: BP-14 WriteFlag DEFERRED_SYNC Client Side Implementation

2018-02-05 Thread GitBox
sijie commented on issue #853: BP-14 WriteFlag DEFERRED_SYNC Client Side Implementation URL: https://github.com/apache/bookkeeper/pull/853#issuecomment-363147064 I know the journal change was merged. My question is is all server side changes are done?

[GitHub] sijie commented on issue #853: BP-14 WriteFlag DEFERRED_SYNC Client Side Implementation

2018-02-05 Thread GitBox
sijie commented on issue #853: BP-14 WriteFlag DEFERRED_SYNC Client Side Implementation URL: https://github.com/apache/bookkeeper/pull/853#issuecomment-363143430 Will review it. Just one question, is server side change done?