[jira] [Commented] (CALCITE-4256) RexSimplify should not simplify P AND P to P, if it contains a call to RAND or RAND_INTEGER

2020-09-14 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17195833#comment-17195833 ] Chunwei Lei commented on CALCITE-4256: -- Agree with [~danny0405]. In our system, we treat 

[jira] [Commented] (CALCITE-4256) RexSimplify should not simplify P AND P to P, if it contains a call to RAND or RAND_INTEGER

2020-09-14 Thread Danny Chen (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17195816#comment-17195816 ] Danny Chen commented on CALCITE-4256: - It might be wrong that {{SqlRandFunction.isDeterministic}}

[jira] [Created] (CALCITE-4257) Allow CachingRelMetadataProvider.cache to be parameterized in the constructor

2020-09-14 Thread James Starr (Jira)
James Starr created CALCITE-4257: Summary: Allow CachingRelMetadataProvider.cache to be parameterized in the constructor Key: CALCITE-4257 URL: https://issues.apache.org/jira/browse/CALCITE-4257

[jira] [Commented] (CALCITE-4256) RexSimplify should not simplify P AND P to P, if it contains a call to RAND or RAND_INTEGER

2020-09-14 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17195664#comment-17195664 ] Julian Hyde commented on CALCITE-4256: -- Let's frame this in terms of whether the operator is

[jira] [Commented] (CALCITE-2082) Do not store types or type factories inside operators

2020-09-14 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-2082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17195656#comment-17195656 ] Julian Hyde commented on CALCITE-2082: -- bq. was there a PR for this patch? Yes, it was part of

[jira] [Commented] (CALCITE-4253) RelOptUtil#findAllTables should probably use RelMetadataQuery#getTableReferences

2020-09-14 Thread Jesus Camacho Rodriguez (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17195654#comment-17195654 ] Jesus Camacho Rodriguez commented on CALCITE-4253: -- Thanks for pinging me

[jira] [Created] (CALCITE-4256) RexSimplify should not simplify P AND P to P, if it contains a call to RAND or RAND_INTEGER

2020-09-14 Thread Thomas Rebele (Jira)
Thomas Rebele created CALCITE-4256: -- Summary: RexSimplify should not simplify P AND P to P, if it contains a call to RAND or RAND_INTEGER Key: CALCITE-4256 URL: https://issues.apache.org/jira/browse/CALCITE-4256

[jira] [Comment Edited] (CALCITE-4254) ImmutableBeans should make an immutable copy of property values of type List, Set, or Map

2020-09-14 Thread Vladimir Sitnikov (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17195637#comment-17195637 ] Vladimir Sitnikov edited comment on CALCITE-4254 at 9/14/20, 5:32 PM:

[jira] [Comment Edited] (CALCITE-4254) ImmutableBeans should make an immutable copy of property values of type List, Set, or Map

2020-09-14 Thread Vladimir Sitnikov (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17195637#comment-17195637 ] Vladimir Sitnikov edited comment on CALCITE-4254 at 9/14/20, 5:27 PM:

[jira] [Commented] (CALCITE-4254) ImmutableBeans should make an immutable copy of property values of type List, Set, or Map

2020-09-14 Thread Vladimir Sitnikov (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17195637#comment-17195637 ] Vladimir Sitnikov commented on CALCITE-4254: Julian, what do you think ofrenaming

[jira] [Commented] (CALCITE-4249) Assertion error for NOT operator in join condition in Rel2SqlConverter

2020-09-14 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17195630#comment-17195630 ] Julian Hyde commented on CALCITE-4249: -- I don't think it's a duplicate. There is a proposed fix in 

[jira] [Commented] (CALCITE-4253) RelOptUtil#findAllTables should probably use RelMetadataQuery#getTableReferences

2020-09-14 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17195626#comment-17195626 ] Julian Hyde commented on CALCITE-4253: -- Yeah, it's not great. If you read the comments on

[jira] [Commented] (CALCITE-4254) ImmutableBeans should make an immutable copy of property values of type List, Set, or Map

2020-09-14 Thread Vladimir Sitnikov (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17195608#comment-17195608 ] Vladimir Sitnikov commented on CALCITE-4254: Oh, I just re-read the issue description, and

[jira] [Commented] (CALCITE-4254) ImmutableBeans should make an immutable copy of property values of type List, Set, or Map

2020-09-14 Thread Vladimir Sitnikov (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17195607#comment-17195607 ] Vladimir Sitnikov commented on CALCITE-4254: Well, there's one more option: use immutable

[jira] [Commented] (CALCITE-4254) ImmutableBeans should make an immutable copy of property values of type List, Set, or Map

2020-09-14 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17195601#comment-17195601 ] Julian Hyde commented on CALCITE-4254: -- [~vlsi], Ideally we'd allow both ways. In your scheme, the

[jira] [Commented] (CALCITE-4251) Overload RelMetadataQuery#getColumnOrigin method

2020-09-14 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17195593#comment-17195593 ] Julian Hyde commented on CALCITE-4251: -- I see. With today's implementation, I don't it's possible

[jira] [Commented] (CALCITE-4251) Overload RelMetadataQuery#getColumnOrigin method

2020-09-14 Thread xzh_dz (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17195434#comment-17195434 ] xzh_dz commented on CALCITE-4251: - Should we indicate that a parameter `derived` for table columns may