[jira] [Commented] (CALCITE-5881) Support to get foreign keys metadata in RelMetadataQuery

2023-08-03 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17750925#comment-17750925 ] Chunwei Lei commented on CALCITE-5881: -- Sounds reasonable. > Support to get foreign keys metadata

[jira] [Comment Edited] (CALCITE-5861) Optimization rules do not constant-fold expressions in window bounds

2023-07-19 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17744849#comment-17744849 ] Chunwei Lei edited comment on CALCITE-5861 at 7/20/23 2:52 AM: --- I tried

[jira] [Commented] (CALCITE-5861) Optimization rules do not constant-fold expressions in window bounds

2023-07-19 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17744849#comment-17744849 ] Chunwei Lei commented on CALCITE-5861: -- I tried the query mentioned in PostgreSQL and it works:

[jira] [Commented] (CALCITE-5837) After RexUtil.pullFactors method,sometimes the condition order of RexNode is not the same as before

2023-07-12 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17742626#comment-17742626 ] Chunwei Lei commented on CALCITE-5837: -- +1. > After RexUtil.pullFactors method,sometimes the

[jira] [Commented] (CALCITE-5842) LogicalProject deepHashCode creates same value with different RowType

2023-07-12 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17742622#comment-17742622 ] Chunwei Lei commented on CALCITE-5842: -- bq. The 2 logicalProjects from the 2 LogicalTableScans

[jira] [Commented] (CALCITE-5639) RexSimplify should remove IS NOT NULL check when LIKE comparison is present

2023-04-11 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17711168#comment-17711168 ] Chunwei Lei commented on CALCITE-5639: -- I can't agree more. It would be great if we can find a

[jira] [Comment Edited] (CALCITE-5267) Remove useless variable 'newCasts' in AggregateCaseToFilterRule

2022-09-06 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17600690#comment-17600690 ] Chunwei Lei edited comment on CALCITE-5267 at 9/6/22 9:27 AM: -- I checked

[jira] [Comment Edited] (CALCITE-5267) Remove useless variable 'newCasts' in AggregateCaseToFilterRule

2022-09-06 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17600690#comment-17600690 ] Chunwei Lei edited comment on CALCITE-5267 at 9/6/22 9:26 AM: -- I checked

[jira] [Comment Edited] (CALCITE-5267) Remove useless variable 'newCasts' in AggregateCaseToFilterRule

2022-09-06 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17600690#comment-17600690 ] Chunwei Lei edited comment on CALCITE-5267 at 9/6/22 9:26 AM: -- I checked

[jira] [Commented] (CALCITE-5267) Remove useless variable 'newCasts' in AggregateCaseToFilterRule

2022-09-06 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17600690#comment-17600690 ] Chunwei Lei commented on CALCITE-5267: -- Makes sense. > Remove useless variable 'newCasts' in

[jira] [Commented] (CALCITE-5231) Unable to create Oracle JDBC connection in DBeaver

2022-08-09 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17577257#comment-17577257 ] Chunwei Lei commented on CALCITE-5231: -- Hi, [~kartik.kud...@exate.com]. It's better to send an

[jira] [Resolved] (CALCITE-4223) Introducing column statistics to RelOptTable

2022-08-09 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4223?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chunwei Lei resolved CALCITE-4223. -- Fix Version/s: 1.32.0 Resolution: Fixed Fixed in

[jira] [Commented] (CALCITE-3890) Derive IS NOT NULL filter for the inputs of inner join

2022-07-26 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17571209#comment-17571209 ] Chunwei Lei commented on CALCITE-3890: -- Thank you for your attention, [~zabetak]. IMHO, the most

[jira] [Commented] (CALCITE-4223) Introducing column statistics to RelOptTable

2022-07-17 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17567773#comment-17567773 ] Chunwei Lei commented on CALCITE-4223: -- I would like to merge the PR in the next 48hours if no

[jira] [Comment Edited] (CALCITE-4223) Introducing column statistics to RelOptTable

2022-07-17 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17567773#comment-17567773 ] Chunwei Lei edited comment on CALCITE-4223 at 7/18/22 2:08 AM: --- I would

[jira] [Commented] (CALCITE-4223) Introducing column statistics to RelOptTable

2022-07-05 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17562492#comment-17562492 ] Chunwei Lei commented on CALCITE-4223: -- Could you please review the PR, [~julianhyde]? >

[jira] [Commented] (CALCITE-4223) Introducing column statistics to RelOptTable

2022-07-03 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17562018#comment-17562018 ] Chunwei Lei commented on CALCITE-4223: -- Thank you for your reply, [~asolimando]. I would like to

[jira] [Commented] (CALCITE-4223) Introducing column statistics to RelOptTable

2022-06-28 Thread Chunwei Lei (Jira)
Title: Message Title Chunwei Lei

[jira] [Resolved] (CALCITE-5195) ArrayIndexOutOfBoundsException when inferring more equal conditions from join condition for semi join

2022-06-26 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chunwei Lei resolved CALCITE-5195. -- Resolution: Fixed Fixed in

[jira] [Commented] (CALCITE-5195) ArrayIndexOutOfBoundsException when inferring more equal conditions from join condition for semi join

2022-06-26 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17558951#comment-17558951 ] Chunwei Lei commented on CALCITE-5195: -- Go ahead, [~libenchao]! You can open another JIRA for it.

[jira] [Comment Edited] (CALCITE-5195) ArrayIndexOutOfBoundsException when inferring more equal conditions from join condition for semi join

2022-06-26 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17558283#comment-17558283 ] Chunwei Lei edited comment on CALCITE-5195 at 6/27/22 2:25 AM: --- Thanks

[jira] [Commented] (CALCITE-5195) ArrayIndexOutOfBoundsException when inferring more equal conditions from join condition for semi join

2022-06-23 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17558283#comment-17558283 ] Chunwei Lei commented on CALCITE-5195: -- Thanks for your reply,[~libenchao]. I tried the following

[jira] [Comment Edited] (CALCITE-5195) ArrayIndexOutOfBoundsException when inferring more equal conditions from join condition for semi join

2022-06-22 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17557766#comment-17557766 ] Chunwei Lei edited comment on CALCITE-5195 at 6/23/22 2:08 AM: --- The

[jira] [Commented] (CALCITE-5195) ArrayIndexOutOfBoundsException when inferring more equal conditions from join condition for semi join

2022-06-22 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17557766#comment-17557766 ] Chunwei Lei commented on CALCITE-5195: -- The following sql also can reproduce the bug. {code:sql}

[jira] [Commented] (CALCITE-5195) ArrayIndexOutOfBoundsException when inferring more equal conditions from join condition for semi join

2022-06-21 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17557222#comment-17557222 ] Chunwei Lei commented on CALCITE-5195: -- PR: https://github.com/apache/calcite/pull/2837. Could you

[jira] [Commented] (CALCITE-5195) ArrayIndexOutOfBoundsException when inferring more equal conditions from join condition for semi join

2022-06-21 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17557218#comment-17557218 ] Chunwei Lei commented on CALCITE-5195: -- I plan to open a PR today so that it can be included in

[jira] [Updated] (CALCITE-5195) ArrayIndexOutOfBoundsException when inferring more equal conditions from join condition for semi join

2022-06-21 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chunwei Lei updated CALCITE-5195: - Fix Version/s: 1.31.0 > ArrayIndexOutOfBoundsException when inferring more equal conditions

[jira] [Created] (CALCITE-5195) ArrayIndexOutOfBoundsException when inferring more equal conditions from join condition for semi join

2022-06-21 Thread Chunwei Lei (Jira)
Chunwei Lei created CALCITE-5195: Summary: ArrayIndexOutOfBoundsException when inferring more equal conditions from join condition for semi join Key: CALCITE-5195 URL:

[jira] [Comment Edited] (CALCITE-5191) Allow sort by alias in BigQuery

2022-06-19 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17556160#comment-17556160 ] Chunwei Lei edited comment on CALCITE-5191 at 6/20/22 2:23 AM: --- Fixed in

[jira] [Resolved] (CALCITE-5191) Allow sort by alias in BigQuery

2022-06-19 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5191?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chunwei Lei resolved CALCITE-5191. -- Resolution: Fixed Fixed in

[jira] [Comment Edited] (CALCITE-5193) Push filter whose conditions include join keys and are composed by OR into inputs of full join

2022-06-16 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17554917#comment-17554917 ] Chunwei Lei edited comment on CALCITE-5193 at 6/16/22 6:53 AM: ---

[jira] [Updated] (CALCITE-5193) Push filter whose conditions include join keys and are composed by OR into inputs of full join

2022-06-16 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chunwei Lei updated CALCITE-5193: - Description: For example, {code:sql} select * from a full join b on a.id=b.id where a.id=1 or

[jira] [Commented] (CALCITE-5193) Push filter whose conditions include join keys and are composed by OR into inputs of full join

2022-06-16 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17554917#comment-17554917 ] Chunwei Lei commented on CALCITE-5193: -- [~libenchao]yes, you're right. I changed the description.

[jira] [Updated] (CALCITE-5193) Push filter whose conditions include join keys and are composed by OR into inputs of full join

2022-06-16 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chunwei Lei updated CALCITE-5193: - Description: For example, {code:sql} select * from a full join b on a.id=b.id where a.id=1 or

[jira] [Updated] (CALCITE-5193) Push filter whose conditions include join keys and are composed by OR into inputs of full join

2022-06-15 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chunwei Lei updated CALCITE-5193: - Description: For example, {code:java} select * from a full join b on a.id=b.id where a.id=1

[jira] [Created] (CALCITE-5193) Push filter whose conditions include join keys and are composed by OR into inputs of full join

2022-06-15 Thread Chunwei Lei (Jira)
Chunwei Lei created CALCITE-5193: Summary: Push filter whose conditions include join keys and are composed by OR into inputs of full join Key: CALCITE-5193 URL: https://issues.apache.org/jira/browse/CALCITE-5193

[jira] [Commented] (CALCITE-5191) Allow sort by alias in BigQuery

2022-06-14 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17554341#comment-17554341 ] Chunwei Lei commented on CALCITE-5191: -- The doc[1] has said that BigQuery supports alias in the

[jira] [Comment Edited] (CALCITE-5191) Allow sort by alias in BigQuery

2022-06-14 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17554341#comment-17554341 ] Chunwei Lei edited comment on CALCITE-5191 at 6/15/22 1:51 AM: --- The

[jira] [Comment Edited] (CALCITE-5169) 'xx < 1 OR xx > 1' cannot be simplified to 'xx <> 1'

2022-06-14 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17554339#comment-17554339 ] Chunwei Lei edited comment on CALCITE-5169 at 6/15/22 1:44 AM: --- Fixed in

[jira] [Comment Edited] (CALCITE-5169) 'xx < 1 OR xx > 1' cannot be simplified to 'xx <> 1'

2022-06-14 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17554339#comment-17554339 ] Chunwei Lei edited comment on CALCITE-5169 at 6/15/22 1:44 AM: --- Fixed in

[jira] [Comment Edited] (CALCITE-5169) 'xx < 1 OR xx > 1' cannot be simplified to 'xx <> 1'

2022-06-14 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17554339#comment-17554339 ] Chunwei Lei edited comment on CALCITE-5169 at 6/15/22 1:43 AM: --- Fixed in

[jira] [Resolved] (CALCITE-5169) 'xx < 1 OR xx > 1' cannot be simplified to 'xx <> 1'

2022-06-14 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5169?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chunwei Lei resolved CALCITE-5169. -- Resolution: Fixed Fixed in

[jira] [Comment Edited] (CALCITE-5169) 'xx < 1 OR xx > 1' cannot be simplified to 'xx <> 1'

2022-06-14 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17554339#comment-17554339 ] Chunwei Lei edited comment on CALCITE-5169 at 6/15/22 1:42 AM: --- Fixed in

[jira] [Commented] (CALCITE-5191) Allow sort by alias in BigQuery

2022-06-14 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17554337#comment-17554337 ] Chunwei Lei commented on CALCITE-5191: -- Good catch. The PR looks good to me. > Allow sort by

[jira] [Commented] (CALCITE-5169) 'xx < 1 OR xx > 1' cannot be simplified to 'xx <> 1'

2022-06-12 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17553366#comment-17553366 ] Chunwei Lei commented on CALCITE-5169: -- The PR looks good. I will merge the PR shortly. > 'xx < 1

[jira] [Comment Edited] (CALCITE-5169) 'xx < 1 OR xx > 1' cannot be simplified to 'xx <> 1'

2022-06-07 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17551352#comment-17551352 ] Chunwei Lei edited comment on CALCITE-5169 at 6/8/22 2:18 AM: --

[jira] [Commented] (CALCITE-5169) 'xx < 1 OR xx > 1' cannot be simplified to 'xx <> 1'

2022-06-07 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17551352#comment-17551352 ] Chunwei Lei commented on CALCITE-5169: -- Could you please double confirm the PR is the right way to

[jira] [Commented] (CALCITE-5179) In RelToSqlConverter, AssertionError for values with more than two items when SqlDialect#supportsAliasedValues is false

2022-06-07 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17551350#comment-17551350 ] Chunwei Lei commented on CALCITE-5179: -- I have put the label "LGTM-will-merge-soon". I will merge

[jira] [Resolved] (CALCITE-5150) Parser should parse subquery with order by inside array constructor

2022-06-05 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chunwei Lei resolved CALCITE-5150. -- Resolution: Fixed Fixed in

[jira] [Comment Edited] (CALCITE-5179) AssertionError in values with more than two items when SqlDialect#supportsAliasedValues is false

2022-06-05 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17550261#comment-17550261 ] Chunwei Lei edited comment on CALCITE-5179 at 6/6/22 2:11 AM: -- IMOP, it

[jira] [Comment Edited] (CALCITE-5179) AssertionError in values with more than two items when SqlDialect#supportsAliasedValues is false

2022-06-05 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17550261#comment-17550261 ] Chunwei Lei edited comment on CALCITE-5179 at 6/6/22 2:09 AM: -- IMOP, it

[jira] [Comment Edited] (CALCITE-5179) AssertionError in values with more than two items when SqlDialect#supportsAliasedValues is false

2022-06-05 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17550261#comment-17550261 ] Chunwei Lei edited comment on CALCITE-5179 at 6/6/22 2:07 AM: -- IMOP, it

[jira] [Commented] (CALCITE-5179) AssertionError in values with more than two items when SqlDialect#supportsAliasedValues is false

2022-06-05 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17550261#comment-17550261 ] Chunwei Lei commented on CALCITE-5179: -- IMOP, it would be great if the error appears when

[jira] [Resolved] (CALCITE-5170) Assertion error on range distribution creation

2022-05-31 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chunwei Lei resolved CALCITE-5170. -- Resolution: Fixed Fixed in

[jira] [Commented] (CALCITE-5157) ClassCastException in checkRollUp with DOT operator

2022-05-30 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17544091#comment-17544091 ] Chunwei Lei commented on CALCITE-5157: -- I am not sure whether the proposed fix is the best way.

[jira] [Commented] (CALCITE-5150) Parser should parse subquery with order by inside array constructor

2022-05-30 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17544092#comment-17544092 ] Chunwei Lei commented on CALCITE-5150: -- Get it! The PR looks good to me. > Parser should parse

[jira] [Commented] (CALCITE-5170) Assertion error on range distribution creation

2022-05-29 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17543741#comment-17543741 ] Chunwei Lei commented on CALCITE-5170: -- Good catch! The PR looks good. > Assertion error on range

[jira] [Resolved] (CALCITE-5162) RelMdUniqueKeys can return more precise unique keys for Aggregate

2022-05-29 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chunwei Lei resolved CALCITE-5162. -- Fix Version/s: 1.31.0 Resolution: Fixed Fixed in

[jira] [Resolved] (CALCITE-5073) JoinConditionPushRule cannot infer 'LHS.C1 = LHS.C2' from 'LHS.C1 = RHS.C1 AND LHS.C2 = RHS.C1'

2022-05-26 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5073?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chunwei Lei resolved CALCITE-5073. -- Resolution: Fixed Fixed in

[jira] [Resolved] (CALCITE-5163) MysqlSqlDialect unparse LISTAGG aggregate function error

2022-05-26 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5163?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chunwei Lei resolved CALCITE-5163. -- Fix Version/s: 1.31.0 Resolution: Fixed Fixed in

[jira] [Resolved] (CALCITE-5166) Method accept(RelShuttle) is not overridden in LogicalCalc and LogicalTableModify

2022-05-25 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5166?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chunwei Lei resolved CALCITE-5166. -- Resolution: Fixed Fixed in

[jira] [Commented] (CALCITE-5163) MysqlSqlDialect unparse LISTAGG aggregate function error

2022-05-23 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17541238#comment-17541238 ] Chunwei Lei commented on CALCITE-5163: -- Looks basically good. I left some minor comments. >

[jira] [Commented] (CALCITE-5166) Method accept(RelShuttle) is not overridden in LogicalCalc and LogicalTableModify

2022-05-22 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17540725#comment-17540725 ] Chunwei Lei commented on CALCITE-5166: -- Makes sense. There're some operators that have the same

[jira] [Resolved] (CALCITE-3890) Derive IS NOT NULL filter for the inputs of inner join

2022-05-20 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chunwei Lei resolved CALCITE-3890. -- Resolution: Fixed Fixed in

[jira] [Created] (CALCITE-5162) RelMdUniqueKeys can return more precise unique keys for Aggregate

2022-05-19 Thread Chunwei Lei (Jira)
Chunwei Lei created CALCITE-5162: Summary: RelMdUniqueKeys can return more precise unique keys for Aggregate Key: CALCITE-5162 URL: https://issues.apache.org/jira/browse/CALCITE-5162 Project: Calcite

[jira] [Commented] (CALCITE-5073) JoinConditionPushRule cannot infer 'LHS.C1 = LHS.C2' from 'LHS.C1 = RHS.C1 AND LHS.C2 = RHS.C1'

2022-05-18 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17539190#comment-17539190 ] Chunwei Lei commented on CALCITE-5073: -- I am +1 for this positive change. I will find some time to

[jira] [Comment Edited] (CALCITE-5157) ClassCastException in checkRollUp with DOT operator

2022-05-18 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17539174#comment-17539174 ] Chunwei Lei edited comment on CALCITE-5157 at 5/19/22 2:51 AM: --- I did

[jira] [Comment Edited] (CALCITE-5157) ClassCastException in checkRollUp with DOT operator

2022-05-18 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17539174#comment-17539174 ] Chunwei Lei edited comment on CALCITE-5157 at 5/19/22 2:49 AM: --- I did

[jira] [Comment Edited] (CALCITE-5157) ClassCastException in checkRollUp with DOT operator

2022-05-18 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17539174#comment-17539174 ] Chunwei Lei edited comment on CALCITE-5157 at 5/19/22 2:49 AM: --- I did

[jira] [Commented] (CALCITE-5157) ClassCastException in checkRollUp with DOT operator

2022-05-18 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17539174#comment-17539174 ] Chunwei Lei commented on CALCITE-5157: -- I did some investigation on this. It seems

[jira] [Comment Edited] (CALCITE-5157) ClassCastException in checkRollUp with DOT operator

2022-05-18 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17539168#comment-17539168 ] Chunwei Lei edited comment on CALCITE-5157 at 5/19/22 2:34 AM: --- FYI: I

[jira] [Commented] (CALCITE-5157) ClassCastException in checkRollUp with DOT operator

2022-05-18 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17539168#comment-17539168 ] Chunwei Lei commented on CALCITE-5157: -- FYI: I tried the following SQL in PostgreSQL and it works

[jira] [Updated] (CALCITE-3890) Derive IS NOT NULL filter for the inputs of inner join

2022-05-18 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chunwei Lei updated CALCITE-3890: - Fix Version/s: 1.31.0 > Derive IS NOT NULL filter for the inputs of inner join >

[jira] [Resolved] (CALCITE-5149) Refine RelMdColumnUniqueness for Aggregate by considering intersect keys between target keys and group keys

2022-05-17 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5149?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chunwei Lei resolved CALCITE-5149. -- Fix Version/s: 1.31.0 Resolution: Fixed Fixed in

[jira] [Comment Edited] (CALCITE-5073) JoinConditionPushRule cannot infer 'LHS.C1 = LHS.C2' from 'LHS.C1 = RHS.C1 AND LHS.C2 = RHS.C1'

2022-05-16 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17537896#comment-17537896 ] Chunwei Lei edited comment on CALCITE-5073 at 5/17/22 3:37 AM: --- FYI:

[jira] [Commented] (CALCITE-5073) JoinConditionPushRule cannot infer 'LHS.C1 = LHS.C2' from 'LHS.C1 = RHS.C1 AND LHS.C2 = RHS.C1'

2022-05-16 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17537896#comment-17537896 ] Chunwei Lei commented on CALCITE-5073: -- FYI: Flink has a rule named

[jira] [Resolved] (CALCITE-5137) EnumerableUncollect throws NPE if input has ((List) null)

2022-05-16 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5137?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chunwei Lei resolved CALCITE-5137. -- Fix Version/s: 1.31.0 Resolution: Fixed Fixed in

[jira] [Resolved] (CALCITE-5142) Upgrade Calcite to Avatica 1.21.0

2022-05-16 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5142?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chunwei Lei resolved CALCITE-5142. -- Resolution: Fixed Fixed in

[jira] [Commented] (CALCITE-5137) EnumerableUncollect throws NPE if input has ((List) null)

2022-05-15 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17537305#comment-17537305 ] Chunwei Lei commented on CALCITE-5137: -- The PR looks good to me. I will merge the PR if no other

[jira] [Commented] (CALCITE-5150) Parser should parse subquery with order by inside array constructor

2022-05-15 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17537303#comment-17537303 ] Chunwei Lei commented on CALCITE-5150: -- Thank you for reporting this, [~dmsysolyatin] . Honestly,

[jira] [Updated] (CALCITE-5149) Refine RelMdColumnUniqueness for Aggregate by considering intersect keys between target keys and group keys

2022-05-15 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5149?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chunwei Lei updated CALCITE-5149: - Summary: Refine RelMdColumnUniqueness for Aggregate by considering intersect keys between

[jira] [Resolved] (CALCITE-5081) Group keys of Aggregate are wrongly changed during decorrelation

2022-05-15 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5081?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chunwei Lei resolved CALCITE-5081. -- Fix Version/s: 1.31.0 Resolution: Fixed Fixed in

[jira] [Updated] (CALCITE-5149) Refine RelMdColumnUniqueness for Aggregate by considering intersect keys

2022-05-12 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5149?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chunwei Lei updated CALCITE-5149: - Description: For instance, columns: [0, 1] group keys: [0, 2] If [0] is unique, then [0, 1]

[jira] [Updated] (CALCITE-5149) Refine RelMdColumnUniqueness for Aggregate by considering intersect keys

2022-05-12 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5149?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chunwei Lei updated CALCITE-5149: - Description: For instance, columns: [0, 1] group by [0, 2] If [0] is unique, then [0, 1]

[jira] [Updated] (CALCITE-5149) Refine RelMdColumnUniqueness for Aggregate by considering intersect keys

2022-05-12 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5149?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chunwei Lei updated CALCITE-5149: - Summary: Refine RelMdColumnUniqueness for Aggregate by considering intersect keys (was:

[jira] [Created] (CALCITE-5149) Refine RelMdColumnUniqueness for Window by considering partition keys

2022-05-12 Thread Chunwei Lei (Jira)
Chunwei Lei created CALCITE-5149: Summary: Refine RelMdColumnUniqueness for Window by considering partition keys Key: CALCITE-5149 URL: https://issues.apache.org/jira/browse/CALCITE-5149 Project:

[jira] [Resolved] (CALCITE-5125) Extend "||" operator to work with arrays

2022-05-11 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chunwei Lei resolved CALCITE-5125. -- Fix Version/s: 1.31.0 Resolution: Fixed Fixed in

[jira] [Commented] (CALCITE-3890) Derive IS NOT NULL filter for the inputs of inner join

2022-05-11 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17535815#comment-17535815 ] Chunwei Lei commented on CALCITE-3890: -- Exactly. I think {{Strong}} can handle it well. > Derive

[jira] [Commented] (CALCITE-3890) Derive IS NOT NULL filter for the inputs of inner join

2022-05-10 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17534652#comment-17534652 ] Chunwei Lei commented on CALCITE-3890: -- I am trying to use {{Strong}} to analyze the join

[jira] [Commented] (CALCITE-5125) Extend "||" operator to work with arrays

2022-05-10 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17534640#comment-17534640 ] Chunwei Lei commented on CALCITE-5125: -- The PR looks good to me. I will merge the PR if there're

[jira] [Resolved] (CALCITE-5131) Remove redundant type cast

2022-05-10 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5131?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chunwei Lei resolved CALCITE-5131. -- Fix Version/s: 1.31.0 Resolution: Fixed Fixed in

[jira] [Commented] (CALCITE-3890) Derive IS NOT NULL filter for the inputs of inner join

2022-05-10 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17534637#comment-17534637 ] Chunwei Lei commented on CALCITE-3890: -- {quote}The description does not say that the filter is a

[jira] [Updated] (CALCITE-3890) Derive IS NOT NULL filter for the inputs of inner join

2022-05-10 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chunwei Lei updated CALCITE-3890: - Description: We can infer IS NOT NULL predicate from join which implies some columns may not

[jira] [Updated] (CALCITE-3890) Derive IS NOT NULL filter for the inputs of inner join

2022-05-10 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chunwei Lei updated CALCITE-3890: - Description: We can infer IS NOT NULL predicate from join which implies some columns may not

[jira] [Commented] (CALCITE-3890) Derive IS NOT NULL filter for the inputs of inner join

2022-05-10 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17534632#comment-17534632 ] Chunwei Lei commented on CALCITE-3890: -- {quote}Emp e LEFT JOIN Dept d USING (deptno) becomes

[jira] [Updated] (CALCITE-3890) Derive IS NOT NULL filter for the inputs of inner join

2022-05-10 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chunwei Lei updated CALCITE-3890: - Summary: Derive IS NOT NULL filter for the inputs of inner join (was: Derive IS NOT NULL

[jira] [Updated] (CALCITE-3890) Derive IS NOT NULL filter from inner join

2022-05-09 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chunwei Lei updated CALCITE-3890: - Summary: Derive IS NOT NULL filter from inner join (was: Infer IS NOT NULL predicate from

[jira] [Commented] (CALCITE-3890) Infer IS NOT NULL predicate from join

2022-05-09 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17534097#comment-17534097 ] Chunwei Lei commented on CALCITE-3890: -- I opened a PR for this feature:

[jira] [Assigned] (CALCITE-3890) Infer IS NOT NULL predicate from join

2022-05-09 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chunwei Lei reassigned CALCITE-3890: Assignee: Chunwei Lei (was: Vineet Garg) > Infer IS NOT NULL predicate from join >

[jira] [Commented] (CALCITE-5131) Remove redundant type cast

2022-05-09 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17534078#comment-17534078 ] Chunwei Lei commented on CALCITE-5131: -- Thank you for your trust. I will merge the PR if no other

  1   2   3   4   5   6   7   8   9   >