[jira] [Resolved] (CALCITE-5703) Reduce amount of generated runtime code

2023-05-30 Thread Feng Zhu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Feng Zhu resolved CALCITE-5703. --- Resolution: Fixed > Reduce amount of generated runtime code >

[jira] [Commented] (CALCITE-5703) Reduce amount of generated runtime code

2023-05-30 Thread Feng Zhu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17727489#comment-17727489 ] Feng Zhu commented on CALCITE-5703: --- Fixed in

[jira] [Resolved] (CALCITE-3627) Incorrect null semantic for ROW function

2022-01-04 Thread Feng Zhu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3627?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Feng Zhu resolved CALCITE-3627. --- Resolution: Fixed Fixed in

[jira] [Commented] (CALCITE-4777) Casting from DECIMAL to BOOLEAN throws an exception

2021-09-30 Thread Feng Zhu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17422616#comment-17422616 ] Feng Zhu commented on CALCITE-4777: --- [~xuyangzhong] Can we create an umbrella ticket to put these

[jira] [Commented] (CALCITE-4812) RelBuilder.join should error multiple correlate ids

2021-09-30 Thread Feng Zhu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17422591#comment-17422591 ] Feng Zhu commented on CALCITE-4812: --- Could you provide a test case? > RelBuilder.join should error

[jira] [Commented] (CALCITE-4810) Failed to cast a double field (which isn't a literal) to boolean in the test case.

2021-09-30 Thread Feng Zhu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17422545#comment-17422545 ] Feng Zhu commented on CALCITE-4810: --- Any standards can be inferred to help us review the cast

[jira] [Commented] (CALCITE-4805) The IN sub-query can't be converted to OR when value list contains Null.

2021-09-26 Thread Feng Zhu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17420435#comment-17420435 ] Feng Zhu commented on CALCITE-4805: --- Did you ever checked

[jira] [Resolved] (CALCITE-4532) Rex simplification fails with an exception on nested CASTs with ANY

2021-09-25 Thread Feng Zhu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Feng Zhu resolved CALCITE-4532. --- Resolution: Fixed Fixed in

[jira] [Closed] (CALCITE-3775) Implicit lookup methods in SimpleCalciteSchema ignore case sensitivity parameter

2021-07-07 Thread Feng Zhu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3775?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Feng Zhu closed CALCITE-3775. - Resolution: Fixed > Implicit lookup methods in SimpleCalciteSchema ignore case sensitivity >

[jira] [Commented] (CALCITE-3775) Implicit lookup methods in SimpleCalciteSchema ignore case sensitivity parameter

2021-07-07 Thread Feng Zhu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17376977#comment-17376977 ] Feng Zhu commented on CALCITE-3775: --- Fixed in

[jira] [Commented] (CALCITE-3775) Implicit lookup methods in SimpleCalciteSchema ignore case sensitivity parameter

2021-07-02 Thread Feng Zhu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17373278#comment-17373278 ] Feng Zhu commented on CALCITE-3775: --- I also prefer option 1, which has already applied in our product

[jira] [Resolved] (CALCITE-2854) Codegen compile error when implementing unary minus function with data type BigDecimal

2020-07-26 Thread Feng Zhu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-2854?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Feng Zhu resolved CALCITE-2854. --- Resolution: Fixed Fixed in

[jira] [Updated] (CALCITE-2854) Codegen compile error when implementing unary minus function with data type BigDecimal

2020-07-26 Thread Feng Zhu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-2854?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Feng Zhu updated CALCITE-2854: -- Summary: Codegen compile error when implementing unary minus function with data type BigDecimal

[jira] [Commented] (CALCITE-4133) Shouldn't trim fields when it's under Union

2020-07-20 Thread Feng Zhu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17161212#comment-17161212 ] Feng Zhu commented on CALCITE-4133: --- It seems to be duplicate with CALCITE-3399. > Shouldn't trim

[jira] [Updated] (CALCITE-2854) Codegen compile error for decimal nagate

2020-07-19 Thread Feng Zhu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-2854?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Feng Zhu updated CALCITE-2854: -- Summary: Codegen compile error for decimal nagate (was: Code generation error for UNARY_MINUS

[jira] [Resolved] (CALCITE-4000) Support OFFSET parameter in TUMBLE/HOP table functions

2020-07-16 Thread Feng Zhu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4000?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Feng Zhu resolved CALCITE-4000. --- Resolution: Fixed Fixed in

[jira] [Resolved] (CALCITE-2861) Exception occurs when do arithmetic between decimal and other numeric types

2020-07-13 Thread Feng Zhu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-2861?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Feng Zhu resolved CALCITE-2861. --- Resolution: Duplicate > Exception occurs when do arithmetic between decimal and other numeric

[jira] [Commented] (CALCITE-2861) Exception occurs when do arithmetic between decimal and other numeric types

2020-07-13 Thread Feng Zhu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-2861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17157111#comment-17157111 ] Feng Zhu commented on CALCITE-2861: --- This issue has already been addressed in CALCITE-3245. >

[jira] [Resolved] (CALCITE-4112) Planner should decorrelate when CalciteConnectionConfig is null

2020-07-13 Thread Feng Zhu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Feng Zhu resolved CALCITE-4112. --- Resolution: Fixed > Planner should decorrelate when CalciteConnectionConfig is null >

[jira] [Updated] (CALCITE-4112) Planner should decorrelate when CalciteConnectionConfig is null

2020-07-13 Thread Feng Zhu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Feng Zhu updated CALCITE-4112: -- Fix Version/s: 1.24.0 > Planner should decorrelate when CalciteConnectionConfig is null >

[jira] [Commented] (CALCITE-4112) Planner should decorrelate when CalciteConnectionConfig is null

2020-07-13 Thread Feng Zhu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17157096#comment-17157096 ] Feng Zhu commented on CALCITE-4112: --- Fixed in

[jira] [Commented] (CALCITE-4116) Remove unused code for tracking RexNode's nullable state in codegen

2020-07-13 Thread Feng Zhu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17157095#comment-17157095 ] Feng Zhu commented on CALCITE-4116: --- Fixed in

[jira] [Updated] (CALCITE-4116) Remove unused code for tracking RexNode's nullable state in codegen

2020-07-13 Thread Feng Zhu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Feng Zhu updated CALCITE-4116: -- Fix Version/s: 1.24.0 > Remove unused code for tracking RexNode's nullable state in codegen >

[jira] [Resolved] (CALCITE-4116) Remove unused code for tracking RexNode's nullable state in codegen

2020-07-13 Thread Feng Zhu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Feng Zhu resolved CALCITE-4116. --- Resolution: Fixed > Remove unused code for tracking RexNode's nullable state in codegen >

[jira] [Commented] (CALCITE-4108) ClassCastException: java.lang.Float cannot be cast to java.lang.Double

2020-07-09 Thread Feng Zhu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17154481#comment-17154481 ] Feng Zhu commented on CALCITE-4108: --- [~rr111], I have tested both branch-1.23 and master branch.

[jira] [Commented] (CALCITE-4108) ClassCastException: java.lang.Float cannot be cast to java.lang.Double

2020-07-09 Thread Feng Zhu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17154477#comment-17154477 ] Feng Zhu commented on CALCITE-4108: --- I still cannot reproduce it. Test case1: both *tp* and *o* in

[jira] [Created] (CALCITE-4116) Remove unused code for tracking RexNode's nullable state in codegen

2020-07-09 Thread Feng Zhu (Jira)
Feng Zhu created CALCITE-4116: - Summary: Remove unused code for tracking RexNode's nullable state in codegen Key: CALCITE-4116 URL: https://issues.apache.org/jira/browse/CALCITE-4116 Project: Calcite

[jira] [Commented] (CALCITE-4108) ClassCastException: java.lang.Float cannot be cast to java.lang.Double

2020-07-09 Thread Feng Zhu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17154372#comment-17154372 ] Feng Zhu commented on CALCITE-4108: --- [~rr111], thanks for your feedback, I will make another try.

[jira] [Commented] (CALCITE-4108) ClassCastException: java.lang.Float cannot be cast to java.lang.Double

2020-07-08 Thread Feng Zhu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17154150#comment-17154150 ] Feng Zhu commented on CALCITE-4108: --- How about *tp.o*'s type? I failed to reproduce it in my local

[jira] [Assigned] (CALCITE-4108) ClassCastException: java.lang.Float cannot be cast to java.lang.Double

2020-07-08 Thread Feng Zhu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4108?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Feng Zhu reassigned CALCITE-4108: - Assignee: Feng Zhu > ClassCastException: java.lang.Float cannot be cast to java.lang.Double >

[jira] [Commented] (CALCITE-4108) ClassCastException: java.lang.Float cannot be cast to java.lang.Double

2020-07-07 Thread Feng Zhu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17153185#comment-17153185 ] Feng Zhu commented on CALCITE-4108: --- Hi, [~rr111], could you provide more schema information?

[jira] [Commented] (CALCITE-4045) ReduceExpressionsRule$JoinReduceExpressionsRule(java.lang.IndexOutOfBoundsException: Index: 0, Size: 0)

2020-06-05 Thread Feng Zhu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17126644#comment-17126644 ] Feng Zhu commented on CALCITE-4045: --- Hi, [~jamie12221] thanks for reporting this issue. Could you

[jira] [Updated] (CALCITE-4047) at org.apache.calcite.rel.rules.PushProjector.getAdjustments(java.lang.ArrayIndexOutOfBoundsException: 0)

2020-06-05 Thread Feng Zhu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4047?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Feng Zhu updated CALCITE-4047: -- Description:     {code:java} 28:LogicalUnion(all=[true]) 21:LogicalProject

[jira] [Commented] (CALCITE-4040) Nonstandard SqlAggFunction rollup NPE Exception

2020-06-04 Thread Feng Zhu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17125641#comment-17125641 ] Feng Zhu commented on CALCITE-4040: --- [~xzh_dz], thanks for clarification. Current Jira title message

[jira] [Commented] (CALCITE-4040) Nonstandard SqlAggFunction rollup NPE Exception

2020-06-03 Thread Feng Zhu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17125489#comment-17125489 ] Feng Zhu commented on CALCITE-4040: --- Is this Exception only thrown in non-standard aggregation

[jira] [Commented] (CALCITE-4035) Adapter for REST interface with query or path parameters

2020-05-31 Thread Feng Zhu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17120709#comment-17120709 ] Feng Zhu commented on CALCITE-4035: --- Great! We also have some similar plans on REST APIs, thrift

[jira] [Commented] (CALCITE-4010) Revise codegen for EnumerableMergeJoin to accept any sort order

2020-05-18 Thread Feng Zhu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17110785#comment-17110785 ] Feng Zhu commented on CALCITE-4010: --- I'd like to take it. > Revise codegen for EnumerableMergeJoin

[jira] [Assigned] (CALCITE-4010) Revise codegen for EnumerableMergeJoin to accept any sort order

2020-05-18 Thread Feng Zhu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4010?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Feng Zhu reassigned CALCITE-4010: - Assignee: Feng Zhu > Revise codegen for EnumerableMergeJoin to accept any sort order >

[jira] [Commented] (CALCITE-3998) Bad datatype for sum(n), it should be BIGINT but it is sometimes INTEGER

2020-05-13 Thread Feng Zhu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17106848#comment-17106848 ] Feng Zhu commented on CALCITE-3998: --- {quote}I also noted that sometimes the type of sum(N) where N is

[jira] [Resolved] (CALCITE-3780) SESSION Table-valued Function

2020-05-09 Thread Feng Zhu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3780?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Feng Zhu resolved CALCITE-3780. --- Fix Version/s: 1.23.0 Resolution: Fixed Fixed in

[jira] [Comment Edited] (CALCITE-3737) HOP Table-valued Function

2020-05-09 Thread Feng Zhu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17103283#comment-17103283 ] Feng Zhu edited comment on CALCITE-3737 at 5/9/20, 12:26 PM: - Fixed via

[jira] [Resolved] (CALCITE-3737) HOP Table-valued Function

2020-05-09 Thread Feng Zhu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Feng Zhu resolved CALCITE-3737. --- Resolution: Fixed Fixed via

[jira] [Resolved] (CALCITE-3866) "numeric field overflow" when running the generated SQL in PostgreSQL

2020-05-09 Thread Feng Zhu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3866?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Feng Zhu resolved CALCITE-3866. --- Resolution: Fixed Fixed via

[jira] [Updated] (CALCITE-3866) "numeric field overflow" when running the generated SQL in PostgreSQL

2020-05-09 Thread Feng Zhu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3866?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Feng Zhu updated CALCITE-3866: -- Summary: "numeric field overflow" when running the generated SQL in PostgreSQL (was:

[jira] [Resolved] (CALCITE-3447) Fix equivalents in method SubstitutionVisitor#go

2020-04-20 Thread Feng Zhu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Feng Zhu resolved CALCITE-3447. --- Fix Version/s: 1.23.0 Resolution: Fixed > Fix equivalents in method SubstitutionVisitor#go

[jira] [Commented] (CALCITE-3447) Fix equivalents in method SubstitutionVisitor#go

2020-04-20 Thread Feng Zhu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17087667#comment-17087667 ] Feng Zhu commented on CALCITE-3447: --- Fixed in

[jira] [Resolved] (CALCITE-3079) Successive dependent windows cannot be implemented in same expression level

2020-04-16 Thread Feng Zhu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3079?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Feng Zhu resolved CALCITE-3079. --- Resolution: Duplicate > Successive dependent windows cannot be implemented in same expression

[jira] [Reopened] (CALCITE-3079) Successive dependent windows cannot be implemented in same expression level

2020-04-16 Thread Feng Zhu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3079?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Feng Zhu reopened CALCITE-3079: --- > Successive dependent windows cannot be implemented in same expression level >

[jira] [Resolved] (CALCITE-3079) Successive dependent windows cannot be implemented in same expression level

2020-04-16 Thread Feng Zhu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3079?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Feng Zhu resolved CALCITE-3079. --- Resolution: Duplicate > Successive dependent windows cannot be implemented in same expression

[jira] [Commented] (CALCITE-3079) Successive dependent windows cannot be implemented in same expression level

2020-04-16 Thread Feng Zhu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17084725#comment-17084725 ] Feng Zhu commented on CALCITE-3079: --- [~danny0405] Thanks for reminder. It turns out Julian fixed this

[jira] [Reopened] (CALCITE-3079) Successive dependent windows cannot be implemented in same expression level

2020-04-16 Thread Feng Zhu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3079?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Feng Zhu reopened CALCITE-3079: --- > Successive dependent windows cannot be implemented in same expression level >

[jira] [Commented] (CALCITE-3079) Successive dependent windows cannot be implemented in same expression level

2020-04-16 Thread Feng Zhu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17084668#comment-17084668 ] Feng Zhu commented on CALCITE-3079: --- [~danny0405] CALCITE-3876 only addresses the problem in

[jira] [Resolved] (CALCITE-3895) When the group sets of Aggregate is not null, union of its members should contain group key

2020-04-15 Thread Feng Zhu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3895?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Feng Zhu resolved CALCITE-3895. --- Resolution: Not A Problem > When the group sets of Aggregate is not null, union of its members

[jira] [Resolved] (CALCITE-3893) SQL with GROUP_ID may generate wrong plan

2020-04-15 Thread Feng Zhu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3893?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Feng Zhu resolved CALCITE-3893. --- Resolution: Not A Problem > SQL with GROUP_ID may generate wrong plan >

[jira] [Created] (CALCITE-3930) When converting Aggregate to SQL, add Having clause if a group key is not in group sets

2020-04-15 Thread Feng Zhu (Jira)
Feng Zhu created CALCITE-3930: - Summary: When converting Aggregate to SQL, add Having clause if a group key is not in group sets Key: CALCITE-3930 URL: https://issues.apache.org/jira/browse/CALCITE-3930

[jira] [Updated] (CALCITE-3737) HOP Table-valued Function

2020-04-13 Thread Feng Zhu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Feng Zhu updated CALCITE-3737: -- Fix Version/s: 1.23.0 > HOP Table-valued Function > - > >

[jira] [Resolved] (CALCITE-3733) In JDBC adapter, when generating SQL for MYSQL, generate TIMESTAMP type as DATETIME for CAST

2020-04-13 Thread Feng Zhu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3733?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Feng Zhu resolved CALCITE-3733. --- Fix Version/s: 1.23.0 Resolution: Fixed > In JDBC adapter, when generating SQL for MYSQL,

[jira] [Commented] (CALCITE-3733) In JDBC adapter, when generating SQL for MYSQL, generate TIMESTAMP type as DATETIME for CAST

2020-04-13 Thread Feng Zhu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17082792#comment-17082792 ] Feng Zhu commented on CALCITE-3733: --- Fixed in

[jira] [Commented] (CALCITE-3893) SQL with GROUP_ID may generate wrong plan

2020-04-12 Thread Feng Zhu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17081981#comment-17081981 ] Feng Zhu commented on CALCITE-3893: --- Ok, thanks for your feedback. I'd like to make a final

[jira] [Commented] (CALCITE-3893) SQL with GROUP_ID may generate wrong plan

2020-04-09 Thread Feng Zhu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17080233#comment-17080233 ] Feng Zhu commented on CALCITE-3893: --- {quote}If someone can back up the "a bit hard to implement", I

[jira] [Comment Edited] (CALCITE-3899) cast( string as date ) throw exception in dynamic parameter

2020-04-07 Thread Feng Zhu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17077762#comment-17077762 ] Feng Zhu edited comment on CALCITE-3899 at 4/8/20, 2:51 AM: It is a legal

[jira] [Commented] (CALCITE-3899) cast( string as date ) throw exception in dynamic parameter

2020-04-07 Thread Feng Zhu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17077762#comment-17077762 ] Feng Zhu commented on CALCITE-3899: --- It is a legal PrepareStatement. It may be difficult to solve

[jira] [Commented] (CALCITE-3895) When the group sets of Aggregate is not null, union of its members should contain group key

2020-04-07 Thread Feng Zhu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17077748#comment-17077748 ] Feng Zhu commented on CALCITE-3895: --- {{groupSet}} == {{union(groupSets) is not a new requirement. It

[jira] [Comment Edited] (CALCITE-3895) When the group sets of Aggregate is not null, union of its members should contain group key

2020-04-06 Thread Feng Zhu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17076824#comment-17076824 ] Feng Zhu edited comment on CALCITE-3895 at 4/7/20, 2:03 AM: {quote}And

[jira] [Commented] (CALCITE-3895) When the group sets of Aggregate is not null, union of its members should contain group key

2020-04-06 Thread Feng Zhu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17076824#comment-17076824 ] Feng Zhu commented on CALCITE-3895: --- {quote}And equivalently, every element of {{groupSets}} should

[jira] [Created] (CALCITE-3895) When the group sets of Aggregate is not null, union of its members should contain group key

2020-04-03 Thread Feng Zhu (Jira)
Feng Zhu created CALCITE-3895: - Summary: When the group sets of Aggregate is not null, union of its members should contain group key Key: CALCITE-3895 URL: https://issues.apache.org/jira/browse/CALCITE-3895

[jira] [Commented] (CALCITE-3893) SQL with GROUP_ID may generate wrong plan

2020-04-02 Thread Feng Zhu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17074213#comment-17074213 ] Feng Zhu commented on CALCITE-3893: --- The result is correct. It seems that the rutime can process the

[jira] [Assigned] (CALCITE-3893) SQL with GROUP_ID may generate wrong plan

2020-04-02 Thread Feng Zhu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3893?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Feng Zhu reassigned CALCITE-3893: - Assignee: Feng Zhu > SQL with GROUP_ID may generate wrong plan >

[jira] [Updated] (CALCITE-3893) SQL with GROUP_ID may generate wrong plan

2020-04-02 Thread Feng Zhu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3893?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Feng Zhu updated CALCITE-3893: -- Fix Version/s: 1.23.0 > SQL with GROUP_ID may generate wrong plan >

[jira] [Commented] (CALCITE-3893) SQL with GROUP_ID may generate wrong plan

2020-04-02 Thread Feng Zhu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17073656#comment-17073656 ] Feng Zhu commented on CALCITE-3893: --- [~icshuo], according to the discussion, we will rewrite the

[jira] [Commented] (CALCITE-3893) SQL with GROUP_ID may generate wrong plan

2020-04-02 Thread Feng Zhu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17073547#comment-17073547 ] Feng Zhu commented on CALCITE-3893: --- Hi, [~icshuo], thanks for reporting the problem, you are right.

[jira] [Commented] (CALCITE-3866) ReturnTypes.AGG_SUM may cause "numeric field overflow" on PostgreSQL when generate the sql after using the rule AggregateJoinTransposeRule.EXTENDED.

2020-03-29 Thread Feng Zhu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17070639#comment-17070639 ] Feng Zhu commented on CALCITE-3866: --- So, the issue is the incorrect type inference of

[jira] [Resolved] (CALCITE-3864) Supports CONCAT for variable arguments

2020-03-27 Thread Feng Zhu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Feng Zhu resolved CALCITE-3864. --- Resolution: Fixed > Supports CONCAT for variable arguments >

[jira] [Closed] (CALCITE-3864) Supports CONCAT for variable arguments

2020-03-27 Thread Feng Zhu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Feng Zhu closed CALCITE-3864. - Resolution: Fixed > Supports CONCAT for variable arguments > -- >

[jira] [Reopened] (CALCITE-3864) Supports CONCAT for variable arguments

2020-03-27 Thread Feng Zhu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Feng Zhu reopened CALCITE-3864: --- > Supports CONCAT for variable arguments > -- > >

[jira] [Reopened] (CALCITE-3864) Supports CONCAT for variable arguments

2020-03-27 Thread Feng Zhu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Feng Zhu reopened CALCITE-3864: --- > Supports CONCAT for variable arguments > -- > >

[jira] [Resolved] (CALCITE-3864) Supports CONCAT for variable arguments

2020-03-27 Thread Feng Zhu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Feng Zhu resolved CALCITE-3864. --- Fix Version/s: 1.23.0 Resolution: Resolved Fixed in

[jira] [Commented] (CALCITE-3878) Make ArrayList creation with initial capacity when size is fixed

2020-03-27 Thread Feng Zhu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17068397#comment-17068397 ] Feng Zhu commented on CALCITE-3878: --- Certainly, changes made by this PR can help to improve the

[jira] [Commented] (CALCITE-3876) Should not combine projects when top project contains window function referencing window function from bottom project

2020-03-25 Thread Feng Zhu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17067289#comment-17067289 ] Feng Zhu commented on CALCITE-3876: --- It duplicates with CALCITE-3079, in which the proposed approach

[jira] [Commented] (CALCITE-3872) Simplify expressions with unary minus

2020-03-25 Thread Feng Zhu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17066472#comment-17066472 ] Feng Zhu commented on CALCITE-3872: --- Just of curious, will this simplification bury some exception?

[jira] [Commented] (CALCITE-3864) Add Implementation for SqlLibraryOperators.CONCAT_FUNCTION in SqlFunctions and correct the return type inference of SqlLibraryOperators.CONCAT_FUNCTION

2020-03-24 Thread Feng Zhu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17066323#comment-17066323 ] Feng Zhu commented on CALCITE-3864: --- When we converting a function _*f1*_ to another one *_f2_*,

[jira] [Commented] (CALCITE-3864) Add Implementation for SqlLibraryOperators.CONCAT_FUNCTION in SqlFunctions and correct the return type inference of SqlLibraryOperators.CONCAT_FUNCTION

2020-03-24 Thread Feng Zhu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17065554#comment-17065554 ] Feng Zhu commented on CALCITE-3864: --- Hi, [~winipanda], thanks for your investigation. CONCAT_FUNCTION

[jira] [Commented] (CALCITE-3864) Add Implementation for SqlLibraryOperators.CONCAT_FUNCTION in SqlFunctions and correct the return type inference of SqlLibraryOperators.CONCAT_FUNCTION

2020-03-19 Thread Feng Zhu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17063039#comment-17063039 ] Feng Zhu commented on CALCITE-3864: --- I remember that the concat function differs in many products.

[jira] [Resolved] (CALCITE-3815) Add missing SQL standard aggregate functions: EVERY, SOME, INTERSECTION

2020-03-14 Thread Feng Zhu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3815?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Feng Zhu resolved CALCITE-3815. --- Resolution: Resolved Fixed via

[jira] [Updated] (CALCITE-3815) Add missing SQL standard aggregate functions: EVERY, SOME, INTERSECTION

2020-03-14 Thread Feng Zhu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3815?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Feng Zhu updated CALCITE-3815: -- Fix Version/s: 1.23.0 > Add missing SQL standard aggregate functions: EVERY, SOME, INTERSECTION >

[jira] [Commented] (CALCITE-3724) Presto dialect implementation

2020-03-12 Thread Feng Zhu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17058342#comment-17058342 ] Feng Zhu commented on CALCITE-3724: --- Hi [~x1q1j1], could please add some material (e.g., presto's

[jira] [Commented] (CALCITE-3815) Add missing SQL standard aggregate functions: EVERY, SOME, INTERSECTION

2020-03-11 Thread Feng Zhu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17057616#comment-17057616 ] Feng Zhu commented on CALCITE-3815: --- {quote}_New classes and new SqlKind to be added for these

[jira] [Comment Edited] (CALCITE-3815) Add missing SQL standard aggregate functions: EVERY, SOME, INTERSECTION

2020-03-11 Thread Feng Zhu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17057517#comment-17057517 ] Feng Zhu edited comment on CALCITE-3815 at 3/12/20, 2:42 AM: -

[jira] [Comment Edited] (CALCITE-3815) Add missing SQL standard aggregate functions: EVERY, SOME, INTERSECTION

2020-03-11 Thread Feng Zhu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17057517#comment-17057517 ] Feng Zhu edited comment on CALCITE-3815 at 3/12/20, 2:42 AM: -

[jira] [Commented] (CALCITE-3815) Add missing SQL standard aggregate functions: EVERY, SOME, INTERSECTION

2020-03-11 Thread Feng Zhu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17057517#comment-17057517 ] Feng Zhu commented on CALCITE-3815: --- [~julianhyde], [~hanu.ncr], yes, you are right. I made something

[jira] [Commented] (CALCITE-3815) Add missing SQL standard aggregate functions: EVERY, SOME, INTERSECTION

2020-03-11 Thread Feng Zhu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17056677#comment-17056677 ] Feng Zhu commented on CALCITE-3815: --- It seems that we cannot completely reuse _min/max_'s

[jira] [Commented] (CALCITE-3840) Re-aliasing of VALUES that has column aliases produces wrong SQL in the JDBC adapter

2020-03-05 Thread Feng Zhu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17053057#comment-17053057 ] Feng Zhu commented on CALCITE-3840: --- Hey, [~christian.beikov], could you provide a test case? >

[jira] [Commented] (CALCITE-3815) Add missing SQL standard aggregate functions: EVERY, SOME, INTERSECTION

2020-03-01 Thread Feng Zhu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17048717#comment-17048717 ] Feng Zhu commented on CALCITE-3815: --- [~hanu.ncr], sure! Thanks. But I found I failed to assigned it

[jira] [Closed] (CALCITE-3832) NPE when decimal cast double

2020-02-27 Thread Feng Zhu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3832?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Feng Zhu closed CALCITE-3832. - Resolution: Duplicate The root cause: failing to inline unsafe code. It duplicates with CALCITE-3142.

[jira] [Commented] (CALCITE-3832) NPE when decimal cast double

2020-02-27 Thread Feng Zhu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17046594#comment-17046594 ] Feng Zhu commented on CALCITE-3832: --- Yeah, it's a known problem. That PR can cover this ticket. >

[jira] [Comment Edited] (CALCITE-3815) Add missing SQL standard aggregate functions: EVERY, SOME, INTERSECTION

2020-02-23 Thread Feng Zhu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17043166#comment-17043166 ] Feng Zhu edited comment on CALCITE-3815 at 2/24/20 6:01 AM: It seems like

[jira] [Commented] (CALCITE-3815) Add missing SQL standard aggregate functions: EVERY, SOME, INTERSECTION

2020-02-23 Thread Feng Zhu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17043166#comment-17043166 ] Feng Zhu commented on CALCITE-3815: --- It seems like Except/Fusion (including codegen) has already been

[jira] [Commented] (CALCITE-3224) New RexNode-to-Expression CodeGen Implementation

2020-02-19 Thread Feng Zhu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17040658#comment-17040658 ] Feng Zhu commented on CALCITE-3224: --- The codegen component is not intuitive, and it seems that

[jira] [Commented] (CALCITE-3772) Query returning bad results

2020-02-19 Thread Feng Zhu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17040230#comment-17040230 ] Feng Zhu commented on CALCITE-3772: --- I think there are two general ways to fix this issue: (1)

[jira] [Commented] (CALCITE-3772) Query returning bad results

2020-02-19 Thread Feng Zhu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17040212#comment-17040212 ] Feng Zhu commented on CALCITE-3772: --- It's not safe to trim fields [1] when the Plan contains

  1   2   3   4   >