[jira] [Commented] (CALCITE-5763) Discontinue support for Guava < 20.0

[ https://issues.apache.org/jira/browse/CALCITE-5763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17775821#comment-17775821 ] Gian Merlino commented on CALCITE-5763: --- [~julianhyde] yes, please go ahead. Druid is on Calcite

[jira] [Commented] (CALCITE-5865) ClassCastException with FLOOR and CEIL on conformances that are not builtin

[ https://issues.apache.org/jira/browse/CALCITE-5865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17745688#comment-17745688 ] Gian Merlino commented on CALCITE-5865: --- Sorry about that! Strangely, the original PR didn't have

[jira] [Resolved] (CALCITE-5865) ClassCastException with FLOOR and CEIL on conformances that are not builtin

[ https://issues.apache.org/jira/browse/CALCITE-5865?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gian Merlino resolved CALCITE-5865. --- Resolution: Fixed > ClassCastException with FLOOR and CEIL on conformances that are not

[jira] [Commented] (CALCITE-5865) ClassCastException with FLOOR and CEIL on conformances that are not builtin

[ https://issues.apache.org/jira/browse/CALCITE-5865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17745179#comment-17745179 ] Gian Merlino commented on CALCITE-5865: --- I committed the small fix to {{main}}, so I'll mark this

[jira] [Updated] (CALCITE-5865) ClassCastException with FLOOR and CEIL on conformances that are not builtin

[ https://issues.apache.org/jira/browse/CALCITE-5865?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gian Merlino updated CALCITE-5865: -- Fix Version/s: 1.35.0 > ClassCastException with FLOOR and CEIL on conformances that are not

[jira] [Commented] (CALCITE-5865) ClassCastException with FLOOR and CEIL on conformances that are not builtin

[ https://issues.apache.org/jira/browse/CALCITE-5865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17744846#comment-17744846 ] Gian Merlino commented on CALCITE-5865: --- Thank you! > ClassCastException with FLOOR and CEIL on

[jira] [Commented] (CALCITE-5865) ClassCastException with FLOOR and CEIL on conformances that are not builtin

[ https://issues.apache.org/jira/browse/CALCITE-5865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17744817#comment-17744817 ] Gian Merlino commented on CALCITE-5865: --- PR in https://github.com/apache/calcite/pull/3327. Btw,

[jira] [Created] (CALCITE-5865) ClassCastException with FLOOR and CEIL on conformances that are not builtin

Gian Merlino created CALCITE-5865: - Summary: ClassCastException with FLOOR and CEIL on conformances that are not builtin Key: CALCITE-5865 URL: https://issues.apache.org/jira/browse/CALCITE-5865

[jira] [Commented] (CALCITE-5479) FamilyOperandTypeChecker is not readily composable in sequences

[ https://issues.apache.org/jira/browse/CALCITE-5479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741833#comment-17741833 ] Gian Merlino commented on CALCITE-5479: --- Thank you! > FamilyOperandTypeChecker is not readily

[jira] [Commented] (CALCITE-5479) FamilyOperandTypeChecker is not readily composable in sequences

[ https://issues.apache.org/jira/browse/CALCITE-5479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741810#comment-17741810 ] Gian Merlino commented on CALCITE-5479: --- [~julianhyde], do you think you'll have a chance to look

[jira] [Commented] (CALCITE-5708) SUBSTRING validation error if any parameter is a NULL literal

[ https://issues.apache.org/jira/browse/CALCITE-5708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17740235#comment-17740235 ] Gian Merlino commented on CALCITE-5708: --- Committed in

[jira] [Resolved] (CALCITE-5708) SUBSTRING validation error if any parameter is a NULL literal

[ https://issues.apache.org/jira/browse/CALCITE-5708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gian Merlino resolved CALCITE-5708. --- Resolution: Fixed > SUBSTRING validation error if any parameter is a NULL literal >

[jira] [Updated] (CALCITE-5708) SUBSTRING validation error if any parameter is a NULL literal

[ https://issues.apache.org/jira/browse/CALCITE-5708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gian Merlino updated CALCITE-5708: -- Summary: SUBSTRING validation error if any parameter is a NULL literal (was: Change

[jira] [Resolved] (CALCITE-5727) RelOptFixture#checkUnchanged should assert planAfter is not present

[ https://issues.apache.org/jira/browse/CALCITE-5727?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gian Merlino resolved CALCITE-5727. --- Resolution: Fixed > RelOptFixture#checkUnchanged should assert planAfter is not present >

[jira] [Commented] (CALCITE-5708) Change SUBSTRING result if either of parameters is NULL literal

[ https://issues.apache.org/jira/browse/CALCITE-5708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17739231#comment-17739231 ] Gian Merlino commented on CALCITE-5708: --- I wrote a review as well. Hope this helps. There is a

[jira] [Commented] (CALCITE-5479) FamilyOperandTypeChecker is not readily composable in sequences

[ https://issues.apache.org/jira/browse/CALCITE-5479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17736296#comment-17736296 ] Gian Merlino commented on CALCITE-5479: --- I believe so. The main changes are these two: -

[jira] [Resolved] (CALCITE-5477) Compatibility with Guava < 20.0

[ https://issues.apache.org/jira/browse/CALCITE-5477?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gian Merlino resolved CALCITE-5477. --- Resolution: Fixed Committed the patch. Per CALCITE-5763 this is expected to be reverted by

[jira] [Commented] (CALCITE-5477) Compatibility with Guava < 20.0

[ https://issues.apache.org/jira/browse/CALCITE-5477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17730283#comment-17730283 ] Gian Merlino commented on CALCITE-5477: --- OK, I'll proceed with the plan to build with Guava 19,

[jira] [Commented] (CALCITE-5477) Compatibility with Guava < 20.0

[ https://issues.apache.org/jira/browse/CALCITE-5477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17730224#comment-17730224 ] Gian Merlino commented on CALCITE-5477: --- Speaking as a Druid committer, my preference is that we

[jira] [Updated] (CALCITE-5477) Compatibility with Guava < 20.0

[ https://issues.apache.org/jira/browse/CALCITE-5477?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gian Merlino updated CALCITE-5477: -- Fix Version/s: 1.35.0 > Compatibility with Guava < 20.0 > --- >

[jira] [Updated] (CALCITE-5479) FamilyOperandTypeChecker is not readily composable in sequences

[ https://issues.apache.org/jira/browse/CALCITE-5479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gian Merlino updated CALCITE-5479: -- Fix Version/s: 1.35.0 > FamilyOperandTypeChecker is not readily composable in sequences >

[jira] [Commented] (CALCITE-5477) Compatibility with Guava < 20.0

[ https://issues.apache.org/jira/browse/CALCITE-5477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17729990#comment-17729990 ] Gian Merlino commented on CALCITE-5477: --- New PR: https://github.com/apache/calcite/pull/3249 >

[jira] [Commented] (CALCITE-3877) In RexWindow, make fields upperBound and lowerBound not-nullable

[ https://issues.apache.org/jira/browse/CALCITE-3877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17695424#comment-17695424 ] Gian Merlino commented on CALCITE-3877: --- I wanted to inquire about this block added in

[jira] [Commented] (CALCITE-5477) Compatibility with Guava < 20.0

[ https://issues.apache.org/jira/browse/CALCITE-5477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17691732#comment-17691732 ] Gian Merlino commented on CALCITE-5477: --- That sounds fair enough. I will try this approach out,

[jira] [Updated] (CALCITE-5477) Compatibility with Guava < 20.0

[ https://issues.apache.org/jira/browse/CALCITE-5477?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gian Merlino updated CALCITE-5477: -- Summary: Compatibility with Guava < 20.0 (was: Prefer Util.checkArgument over

[jira] [Commented] (CALCITE-5477) Prefer Util.checkArgument over Preconditions.checkArgument

[ https://issues.apache.org/jira/browse/CALCITE-5477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17690664#comment-17690664 ] Gian Merlino commented on CALCITE-5477: --- Sorry for the delay in responding. I was out of office

[jira] [Commented] (CALCITE-5479) FamilyOperandTypeChecker is not readily composable in sequences

[ https://issues.apache.org/jira/browse/CALCITE-5479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17690605#comment-17690605 ] Gian Merlino commented on CALCITE-5479: --- I see. I've updated the linked PR with what I think is a

[jira] [Updated] (CALCITE-5479) FamilyOperandTypeChecker is not readily composable in sequences

[ https://issues.apache.org/jira/browse/CALCITE-5479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gian Merlino updated CALCITE-5479: -- Summary: FamilyOperandTypeChecker is not readily composable in sequences (was: Restore

[jira] [Commented] (CALCITE-5478) Use highest input precision for datetimes in SqlTypeFactoryImpl.leastRestrictive

[ https://issues.apache.org/jira/browse/CALCITE-5478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17690553#comment-17690553 ] Gian Merlino commented on CALCITE-5478: --- Thanks for your comment. Sorry for the delay in

[jira] [Comment Edited] (CALCITE-5477) Prefer Util.checkArgument over Preconditions.checkArgument

[ https://issues.apache.org/jira/browse/CALCITE-5477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17677581#comment-17677581 ] Gian Merlino edited comment on CALCITE-5477 at 1/17/23 8:34 PM: The

[jira] [Commented] (CALCITE-5477) Prefer Util.checkArgument over Preconditions.checkArgument

[ https://issues.apache.org/jira/browse/CALCITE-5477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17677581#comment-17677581 ] Gian Merlino commented on CALCITE-5477: --- The situation is a little awkward due to the new

[jira] [Updated] (CALCITE-5477) Prefer Util.checkArgument over Preconditions.checkArgument

[ https://issues.apache.org/jira/browse/CALCITE-5477?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gian Merlino updated CALCITE-5477: -- Description: Related to CALCITE-5428. Preconditions.checkArgument gained new overloads in

[jira] [Commented] (CALCITE-5479) Restore consistent handling of iFormalOperand in sequence checkers

[ https://issues.apache.org/jira/browse/CALCITE-5479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17676980#comment-17676980 ] Gian Merlino commented on CALCITE-5479: --- Ah. Would you mind explaining what the behavior is

[jira] [Created] (CALCITE-5479) Restore consistent handling of iFormalOperand in sequence checkers

Gian Merlino created CALCITE-5479: - Summary: Restore consistent handling of iFormalOperand in sequence checkers Key: CALCITE-5479 URL: https://issues.apache.org/jira/browse/CALCITE-5479 Project:

[jira] [Commented] (CALCITE-5478) Use highest input precision for datetimes in SqlTypeFactoryImpl.leastRestrictive

[ https://issues.apache.org/jira/browse/CALCITE-5478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17676868#comment-17676868 ] Gian Merlino commented on CALCITE-5478: --- https://github.com/apache/calcite/pull/3029 makes this

[jira] [Created] (CALCITE-5478) Use highest input precision for datetimes in SqlTypeFactoryImpl.leastRestrictive

Gian Merlino created CALCITE-5478: - Summary: Use highest input precision for datetimes in SqlTypeFactoryImpl.leastRestrictive Key: CALCITE-5478 URL: https://issues.apache.org/jira/browse/CALCITE-5478

[jira] [Commented] (CALCITE-5477) Prefer Util.checkArgument over Preconditions.checkArgument

[ https://issues.apache.org/jira/browse/CALCITE-5477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17676866#comment-17676866 ] Gian Merlino commented on CALCITE-5477: --- https://github.com/apache/calcite/pull/3028 adds

[jira] [Created] (CALCITE-5477) Prefer Util.checkArgument over Preconditions.checkArgument

Gian Merlino created CALCITE-5477: - Summary: Prefer Util.checkArgument over Preconditions.checkArgument Key: CALCITE-5477 URL: https://issues.apache.org/jira/browse/CALCITE-5477 Project: Calcite

[jira] [Created] (CALCITE-5428) Reduce minimum Guava version to 16.0.1.

Gian Merlino created CALCITE-5428: - Summary: Reduce minimum Guava version to 16.0.1. Key: CALCITE-5428 URL: https://issues.apache.org/jira/browse/CALCITE-5428 Project: Calcite Issue Type:

[jira] [Updated] (CALCITE-5428) Reduce minimum Guava version to 16.0.1

[ https://issues.apache.org/jira/browse/CALCITE-5428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gian Merlino updated CALCITE-5428: -- Summary: Reduce minimum Guava version to 16.0.1 (was: Reduce minimum Guava version to

[jira] [Created] (CALCITE-4121) Avatica misplaces properties from URL while connecting

Gian Merlino created CALCITE-4121: - Summary: Avatica misplaces properties from URL while connecting Key: CALCITE-4121 URL: https://issues.apache.org/jira/browse/CALCITE-4121 Project: Calcite

[jira] [Commented] (CALCITE-3178) RexSimplify.simplifyOrTerms slow with large OR filters

[ https://issues.apache.org/jira/browse/CALCITE-3178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16879907#comment-16879907 ] Gian Merlino commented on CALCITE-3178: --- What's the best way to add a test case for a performance

[jira] [Commented] (CALCITE-3178) RexSimplify.simplifyOrTerms slow with large OR filters

[ https://issues.apache.org/jira/browse/CALCITE-3178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16879895#comment-16879895 ] Gian Merlino commented on CALCITE-3178: --- [~vladimirsitnikov] No, I hadn't seen it. Do you think

[jira] [Commented] (CALCITE-3178) RexSimplify.simplifyOrTerms slow with large OR filters

[ https://issues.apache.org/jira/browse/CALCITE-3178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16879894#comment-16879894 ] Gian Merlino commented on CALCITE-3178: --- This patch that does the "quick fix" of limiting OR

[jira] [Created] (CALCITE-3178) RexSimplify.simplifyOrTerms slow with large OR filters

Gian Merlino created CALCITE-3178: - Summary: RexSimplify.simplifyOrTerms slow with large OR filters Key: CALCITE-3178 URL: https://issues.apache.org/jira/browse/CALCITE-3178 Project: Calcite

[jira] [Commented] (CALCITE-3144) Add rule, CaseFilteredAggregatorRule, that converts "SUM(CASE WHEN b THEN x END)" to "SUM(x) FILTER (WHERE b)"

[ https://issues.apache.org/jira/browse/CALCITE-3144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16879527#comment-16879527 ] Gian Merlino commented on CALCITE-3144: --- On [line 234 of

[jira] [Commented] (CALCITE-3144) Add rule, CaseFilteredAggregatorRule, that converts "SUM(CASE WHEN b THEN x END)" to "SUM(x) FILTER (WHERE b)"

[ https://issues.apache.org/jira/browse/CALCITE-3144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16876495#comment-16876495 ] Gian Merlino commented on CALCITE-3144: --- > Gian Merlino, Do you recall the reason for this line?

[jira] [Commented] (CALCITE-2635) getMonotonocity is slow on wide tables

[ https://issues.apache.org/jira/browse/CALCITE-2635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16658057#comment-16658057 ] Gian Merlino commented on CALCITE-2635: --- Any suggestions on what file is appropriate for that

[jira] [Updated] (CALCITE-2635) getMonotonocity is slow on wide tables

[ https://issues.apache.org/jira/browse/CALCITE-2635?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gian Merlino updated CALCITE-2635: -- External issue ID: https://github.com/apache/calcite/pull/891 > getMonotonocity is slow on

[jira] [Created] (CALCITE-2635) getMonotonocity is slow on wide tables

Gian Merlino created CALCITE-2635: - Summary: getMonotonocity is slow on wide tables Key: CALCITE-2635 URL: https://issues.apache.org/jira/browse/CALCITE-2635 Project: Calcite Issue Type:

[jira] [Commented] (CALCITE-1910) NPE on filtered aggregators using "IN"

[ https://issues.apache.org/jira/browse/CALCITE-1910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16207796#comment-16207796 ] Gian Merlino commented on CALCITE-1910: --- Thanks for the review [~michaelmior]! Fixed in

[jira] [Resolved] (CALCITE-1910) NPE on filtered aggregators using "IN"

[ https://issues.apache.org/jira/browse/CALCITE-1910?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gian Merlino resolved CALCITE-1910. --- Resolution: Fixed Assignee: Gian Merlino (was: Julian Hyde) > NPE on filtered

[jira] [Commented] (CALCITE-1910) NPE on filtered aggregators using "IN"

[ https://issues.apache.org/jira/browse/CALCITE-1910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16206822#comment-16206822 ] Gian Merlino commented on CALCITE-1910: --- I wrote a patch and test case in

[jira] [Commented] (CALCITE-2007) RexSimplify incorrectly simplifies AND bounds

[ https://issues.apache.org/jira/browse/CALCITE-2007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16202387#comment-16202387 ] Gian Merlino commented on CALCITE-2007: --- Got it, thanks for the tips. > RexSimplify incorrectly

[jira] [Commented] (CALCITE-2008) Fix braces in TRIM signature

[ https://issues.apache.org/jira/browse/CALCITE-2008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16202050#comment-16202050 ] Gian Merlino commented on CALCITE-2008: --- Fixed in

[jira] [Commented] (CALCITE-2007) RexSimplify incorrectly simplifies AND bounds

[ https://issues.apache.org/jira/browse/CALCITE-2007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16201254#comment-16201254 ] Gian Merlino commented on CALCITE-2007: --- [~julianhyde] last time I raised a PR you asked me if I

[jira] [Created] (CALCITE-2007) RexSimplify incorrectly simplifies AND bounds

Gian Merlino created CALCITE-2007: - Summary: RexSimplify incorrectly simplifies AND bounds Key: CALCITE-2007 URL: https://issues.apache.org/jira/browse/CALCITE-2007 Project: Calcite Issue

[jira] [Updated] (CALCITE-2007) RexSimplify incorrectly simplifies AND bounds

[ https://issues.apache.org/jira/browse/CALCITE-2007?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gian Merlino updated CALCITE-2007: -- Description: For example, RexSimplify incorrectly simplifies {{1 < x AND x < 3}} to {{x <

[jira] [Commented] (CALCITE-1588) Add SQL syntax to allow approximate LIMIT and distinct-COUNT

[ https://issues.apache.org/jira/browse/CALCITE-1588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16107560#comment-16107560 ] Gian Merlino commented on CALCITE-1588: --- In Druid at least, you don't get to specify the accuracy

[jira] [Created] (CALCITE-1910) NPE on filtered aggregators using "IN"

Gian Merlino created CALCITE-1910: - Summary: NPE on filtered aggregators using "IN" Key: CALCITE-1910 URL: https://issues.apache.org/jira/browse/CALCITE-1910 Project: Calcite Issue Type: Bug

[jira] [Resolved] (CALCITE-1799) OR IN Subquery conversion wrong

[ https://issues.apache.org/jira/browse/CALCITE-1799?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gian Merlino resolved CALCITE-1799. --- Resolution: Won't Fix Marked "won't fix" (for the old subquery expander) based on prior

[jira] [Commented] (CALCITE-1799) OR IN Subquery conversion wrong

[ https://issues.apache.org/jira/browse/CALCITE-1799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16075595#comment-16075595 ] Gian Merlino commented on CALCITE-1799: --- > Let's mark it as fixed by the other bug (do you recall

[jira] [Updated] (CALCITE-1874) Configurable SqlToRelConverter.Config in Frameworks

[ https://issues.apache.org/jira/browse/CALCITE-1874?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gian Merlino updated CALCITE-1874: -- Issue Type: Improvement (was: Bug) > Configurable SqlToRelConverter.Config in Frameworks >

[jira] [Commented] (CALCITE-1799) OR IN Subquery conversion wrong

[ https://issues.apache.org/jira/browse/CALCITE-1799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16075537#comment-16075537 ] Gian Merlino commented on CALCITE-1799: --- [~julianhyde] do you think it makes sense to keep this

[jira] [Commented] (CALCITE-1874) Configurable SqlToRelConverter.Config in Frameworks

[ https://issues.apache.org/jira/browse/CALCITE-1874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16075538#comment-16075538 ] Gian Merlino commented on CALCITE-1874: --- Patch in https://github.com/apache/calcite/pull/492. >

[jira] [Created] (CALCITE-1874) Configurable SqlToRelConverter.Config in Frameworks

Gian Merlino created CALCITE-1874: - Summary: Configurable SqlToRelConverter.Config in Frameworks Key: CALCITE-1874 URL: https://issues.apache.org/jira/browse/CALCITE-1874 Project: Calcite

[jira] [Commented] (CALCITE-1799) OR IN Subquery conversion wrong

[ https://issues.apache.org/jira/browse/CALCITE-1799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16075533#comment-16075533 ] Gian Merlino commented on CALCITE-1799: --- [~julianhyde], I finally got around to testing this, and

[jira] [Commented] (CALCITE-1873) Validator errors when grouping by ordinals that refer to aliases

[ https://issues.apache.org/jira/browse/CALCITE-1873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16075263#comment-16075263 ] Gian Merlino commented on CALCITE-1873: --- More details & patch in the linked PR. For some reason,

[jira] [Created] (CALCITE-1873) Validator errors when grouping by ordinals that refer to aliases

Gian Merlino created CALCITE-1873: - Summary: Validator errors when grouping by ordinals that refer to aliases Key: CALCITE-1873 URL: https://issues.apache.org/jira/browse/CALCITE-1873 Project:

[jira] [Updated] (CALCITE-1873) Validator errors when grouping by ordinals that refer to aliases

[ https://issues.apache.org/jira/browse/CALCITE-1873?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gian Merlino updated CALCITE-1873: -- Description: Patch in https://github.com/apache/calcite/pull/490. > Validator errors when

[jira] [Created] (CALCITE-1799) OR IN Subquery conversion wrong

Gian Merlino created CALCITE-1799: - Summary: OR IN Subquery conversion wrong Key: CALCITE-1799 URL: https://issues.apache.org/jira/browse/CALCITE-1799 Project: Calcite Issue Type: Bug

[jira] [Commented] (CALCITE-1719) Collapse nested limits

[ https://issues.apache.org/jira/browse/CALCITE-1719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15982376#comment-15982376 ] Gian Merlino commented on CALCITE-1719: --- I just re-titled and updated the description -- hope it's

[jira] [Updated] (CALCITE-1719) Collapse nested limits

[ https://issues.apache.org/jira/browse/CALCITE-1719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gian Merlino updated CALCITE-1719: -- Description: Useful for subqueries like {{SELECT * FROM (...) LIMIT X}}, where the inner

[jira] [Updated] (CALCITE-1719) Collapse nested limits

[ https://issues.apache.org/jira/browse/CALCITE-1719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gian Merlino updated CALCITE-1719: -- Summary: Collapse nested limits (was: SortCollapseRule for collapsing nested sorts) >

[jira] [Updated] (CALCITE-1719) Collapse nested limits

[ https://issues.apache.org/jira/browse/CALCITE-1719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gian Merlino updated CALCITE-1719: -- Description: Useful for subqueries like {{SELECT * FROM (...) LIMIT X}}, where the inner

[jira] [Commented] (CALCITE-1719) SortCollapseRule for collapsing nested sorts

[ https://issues.apache.org/jira/browse/CALCITE-1719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15982268#comment-15982268 ] Gian Merlino commented on CALCITE-1719: --- [~julianhyde], it sounds like the approach here is a

[jira] [Comment Edited] (CALCITE-1719) SortCollapseRule for collapsing nested sorts

[ https://issues.apache.org/jira/browse/CALCITE-1719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15962348#comment-15962348 ] Gian Merlino edited comment on CALCITE-1719 at 4/10/17 2:54 AM:

[jira] [Commented] (CALCITE-1719) SortCollapseRule for collapsing nested sorts

[ https://issues.apache.org/jira/browse/CALCITE-1719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15962348#comment-15962348 ] Gian Merlino commented on CALCITE-1719: --- [~julianhyde], the motivation for this rule is to make it

[jira] [Commented] (CALCITE-1719) SortCollapseRule for collapsing nested sorts

[ https://issues.apache.org/jira/browse/CALCITE-1719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15937124#comment-15937124 ] Gian Merlino commented on CALCITE-1719: --- Got it, that makes sense. This rule should be fine then,

[jira] [Commented] (CALCITE-1719) SortCollapseRule for collapsing nested sorts

[ https://issues.apache.org/jira/browse/CALCITE-1719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15937072#comment-15937072 ] Gian Merlino commented on CALCITE-1719: --- The rule shouldn't care about the inner sort order at

[jira] [Commented] (CALCITE-1718) Incorrect data type for context in Druid adapter

[ https://issues.apache.org/jira/browse/CALCITE-1718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15937016#comment-15937016 ] Gian Merlino commented on CALCITE-1718: --- There isn't really a preferred form, either is supposed

[jira] [Created] (CALCITE-1719) SortCollapseRule for collapsing nested sorts

Gian Merlino created CALCITE-1719: - Summary: SortCollapseRule for collapsing nested sorts Key: CALCITE-1719 URL: https://issues.apache.org/jira/browse/CALCITE-1719 Project: Calcite Issue

[jira] [Commented] (CALCITE-1718) Incorrect data type for context in Druid adapter

[ https://issues.apache.org/jira/browse/CALCITE-1718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15935764#comment-15935764 ] Gian Merlino commented on CALCITE-1718: --- [~michaelmior], what error do you get? Druid 0.9.1.1+

[jira] [Commented] (CALCITE-1714) Do not push group by on druid metrics fields

[ https://issues.apache.org/jira/browse/CALCITE-1714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15934102#comment-15934102 ] Gian Merlino commented on CALCITE-1714: --- (master already does) > Do not push group by on druid

[jira] [Commented] (CALCITE-1714) Do not push group by on druid metrics fields

[ https://issues.apache.org/jira/browse/CALCITE-1714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15934101#comment-15934101 ] Gian Merlino commented on CALCITE-1714: --- Druid 0.10.0 will support grouping by numeric columns,

[jira] [Commented] (CALCITE-1601) DateRangeRules loses OR filters

[ https://issues.apache.org/jira/browse/CALCITE-1601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15883222#comment-15883222 ] Gian Merlino commented on CALCITE-1601: --- I collected the failing tests in CALCITE-1658. >

[jira] [Commented] (CALCITE-1601) DateRangeRules loses OR filters

[ https://issues.apache.org/jira/browse/CALCITE-1601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15881472#comment-15881472 ] Gian Merlino commented on CALCITE-1601: --- Sure thing Julian. I'll poke at it a bit more and write

[jira] [Commented] (CALCITE-1601) DateRangeRules loses OR filters

[ https://issues.apache.org/jira/browse/CALCITE-1601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15880897#comment-15880897 ] Gian Merlino commented on CALCITE-1601: --- Btw, the way to read that test case is 1. SQL 2.

[jira] [Comment Edited] (CALCITE-1601) DateRangeRules loses OR filters

[ https://issues.apache.org/jira/browse/CALCITE-1601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15880888#comment-15880888 ] Gian Merlino edited comment on CALCITE-1601 at 2/23/17 5:34 PM: Hey

[jira] [Comment Edited] (CALCITE-1601) DateRangeRules loses OR filters

[ https://issues.apache.org/jira/browse/CALCITE-1601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15880888#comment-15880888 ] Gian Merlino edited comment on CALCITE-1601 at 2/23/17 5:33 PM: Hey

[jira] [Commented] (CALCITE-1601) DateRangeRules loses OR filters

[ https://issues.apache.org/jira/browse/CALCITE-1601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15880888#comment-15880888 ] Gian Merlino commented on CALCITE-1601: --- Hey Julian, I haven't reviewed the patch (I still

[jira] [Commented] (CALCITE-1617) Druid adapter: Send timestamp literals to Druid as local time, not UTC

[ https://issues.apache.org/jira/browse/CALCITE-1617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15851625#comment-15851625 ] Gian Merlino commented on CALCITE-1617: --- [~bslim], https://github.com/druid-io/druid/pull/3850 is

[jira] [Commented] (CALCITE-1589) Druid adapter: timeseries query shows all days, even if no data

[ https://issues.apache.org/jira/browse/CALCITE-1589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15828691#comment-15828691 ] Gian Merlino commented on CALCITE-1589: --- You want "skipEmptyBuckets" : true in your query context.

[jira] [Issue Comment Deleted] (CALCITE-1587) Druid adapter: topN returns approximate results

[ https://issues.apache.org/jira/browse/CALCITE-1587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gian Merlino updated CALCITE-1587: -- Comment: was deleted (was: In Druid's SQL dialect, for distinct-count, even if you disable

[jira] [Commented] (CALCITE-1588) Add SQL syntax to allow approximate LIMIT and distinct-COUNT

[ https://issues.apache.org/jira/browse/CALCITE-1588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15828664#comment-15828664 ] Gian Merlino commented on CALCITE-1588: --- In Druid's SQL dialect, for distinct-count, even if you

[jira] [Commented] (CALCITE-1587) Druid adapter: topN returns approximate results

[ https://issues.apache.org/jira/browse/CALCITE-1587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15828660#comment-15828660 ] Gian Merlino commented on CALCITE-1587: --- In Druid's SQL dialect, for distinct-count, even if you

[jira] [Commented] (CALCITE-1587) Druid adapter: topN returns approximate results

[ https://issues.apache.org/jira/browse/CALCITE-1587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15828662#comment-15828662 ] Gian Merlino commented on CALCITE-1587: --- Oops I commented on the wrong issue. Meant that for

[jira] [Commented] (CALCITE-1587) Druid adapter: topN returns approximate results

[ https://issues.apache.org/jira/browse/CALCITE-1587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15828547#comment-15828547 ] Gian Merlino commented on CALCITE-1587: --- In Druid's built-in SQL we make this an option,

[jira] [Commented] (CALCITE-1579) Druid adapter: wrong semantics of groupBy query limit with granularity

[ https://issues.apache.org/jira/browse/CALCITE-1579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15826835#comment-15826835 ] Gian Merlino commented on CALCITE-1579: --- See also https://github.com/druid-io/druid/issues/1926.

[jira] [Commented] (CALCITE-1525) Use "Planner" to handle query preparation process in CalcitePrepareImpl

[ https://issues.apache.org/jira/browse/CALCITE-1525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15719031#comment-15719031 ] Gian Merlino commented on CALCITE-1525: --- A couple of differences I noticed: 1) The Planner

  1   2   >