[jira] [Resolved] (CALCITE-4105) Replace Pair with Flat2List in RelDigestWriter to improve hash code distribution

2020-07-13 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan resolved CALCITE-4105. Fix Version/s: 1.24.0 Resolution: Fixed Fixed in https://github.com/apache/calcit

[jira] [Resolved] (CALCITE-4096) Change Pair.hashCode() not to use XOR

2020-07-09 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4096?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan resolved CALCITE-4096. Resolution: Not A Problem Opened a new JIRA to use FlatList instead of Pair: CALCITE-4105

[jira] [Commented] (CALCITE-4096) Change Pair.hashCode() not to use XOR

2020-07-06 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17152482#comment-17152482 ] Haisheng Yuan commented on CALCITE-4096: I think I was not making myself clear.

[jira] [Resolved] (CALCITE-4103) SetOp and Union should accept RelNode subclasses in the constructor

2020-07-03 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan resolved CALCITE-4103. Resolution: Not A Problem It is not worthwhile doing. > SetOp and Union should accept Re

[jira] [Commented] (CALCITE-4105) Replace Pair with Flat2List in RelDigestWriter to improve hash code distribution

2020-07-03 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17151114#comment-17151114 ] Haisheng Yuan commented on CALCITE-4105: There is a discussion about changing P

[jira] [Created] (CALCITE-4105) Replace Pair with Flat2List in RelDigestWriter to improve hash code distribution

2020-07-03 Thread Haisheng Yuan (Jira)
Haisheng Yuan created CALCITE-4105: -- Summary: Replace Pair with Flat2List in RelDigestWriter to improve hash code distribution Key: CALCITE-4105 URL: https://issues.apache.org/jira/browse/CALCITE-4105

[jira] [Created] (CALCITE-4103) SetOp and Union should accept RelNode subclasses in the constructor

2020-07-02 Thread Haisheng Yuan (Jira)
Haisheng Yuan created CALCITE-4103: -- Summary: SetOp and Union should accept RelNode subclasses in the constructor Key: CALCITE-4103 URL: https://issues.apache.org/jira/browse/CALCITE-4103 Project: Ca

[jira] [Commented] (CALCITE-4096) Change Pair.hashCode() not to use XOR

2020-07-02 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17150461#comment-17150461 ] Haisheng Yuan commented on CALCITE-4096: Flat2List is a good alternative. Howe

[jira] [Resolved] (CALCITE-4097) Avoid requesting unnecessary trait request when deriving traits from child inputs

2020-07-01 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan resolved CALCITE-4097. Fix Version/s: 1.24.0 Resolution: Fixed Fixed in  [https://github.com/apache/calci

[jira] [Commented] (CALCITE-4097) Avoid requesting unnecessary trait request when deriving traits from child inputs

2020-06-30 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17149058#comment-17149058 ] Haisheng Yuan commented on CALCITE-4097: I copied from code comment. > Avoid r

[jira] [Commented] (CALCITE-4097) Avoid requesting unnecessary trait request when deriving traits from child inputs

2020-06-30 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17149057#comment-17149057 ] Haisheng Yuan commented on CALCITE-4097: LOL. :) Thanks! > Avoid requesting u

[jira] [Created] (CALCITE-4097) Avoid requesting unnecessary trait request when deriving traits from child inputs

2020-06-30 Thread Haisheng Yuan (Jira)
Haisheng Yuan created CALCITE-4097: -- Summary: Avoid requesting unnecessary trait request when deriving traits from child inputs Key: CALCITE-4097 URL: https://issues.apache.org/jira/browse/CALCITE-4097

[jira] [Created] (CALCITE-4096) Change Pair.hashCode() not to use XOR

2020-06-29 Thread Haisheng Yuan (Jira)
Haisheng Yuan created CALCITE-4096: -- Summary: Change Pair.hashCode() not to use XOR Key: CALCITE-4096 URL: https://issues.apache.org/jira/browse/CALCITE-4096 Project: Calcite Issue Type: Imp

[jira] [Resolved] (CALCITE-4056) Remove Digest from RelNode and RexNode

2020-06-24 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan resolved CALCITE-4056. Resolution: Fixed Fixed in - https://github.com/apache/calcite/commit/173624261263435916

[jira] [Resolved] (CALCITE-3786) Add Digest interface to enable efficient hashCode(equals) for RexNode and RelNode

2020-06-24 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3786?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan resolved CALCITE-3786. Resolution: Fixed Dude, next time would you please refrain from reverting other member's

[jira] [Commented] (CALCITE-3786) Add Digest interface to enable efficient hashCode(equals) for RexNode and RelNode

2020-06-23 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17143173#comment-17143173 ] Haisheng Yuan commented on CALCITE-3786: OK, since you desire it so much, let m

[jira] [Updated] (CALCITE-3786) Add Digest interface to enable efficient hashCode(equals) for RexNode and RelNode

2020-06-23 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3786?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan updated CALCITE-3786: --- Attachment: image-2020-06-23-12-47-25-599.png > Add Digest interface to enable efficient ha

[jira] [Updated] (CALCITE-3786) Add Digest interface to enable efficient hashCode(equals) for RexNode and RelNode

2020-06-23 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3786?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan updated CALCITE-3786: --- Attachment: screenshot-6.png > Add Digest interface to enable efficient hashCode(equals) fo

[jira] [Updated] (CALCITE-3786) Add Digest interface to enable efficient hashCode(equals) for RexNode and RelNode

2020-06-23 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3786?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan updated CALCITE-3786: --- Attachment: screenshot-5.png > Add Digest interface to enable efficient hashCode(equals) fo

[jira] [Updated] (CALCITE-3786) Add Digest interface to enable efficient hashCode(equals) for RexNode and RelNode

2020-06-23 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3786?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan updated CALCITE-3786: --- Attachment: screenshot-3.png > Add Digest interface to enable efficient hashCode(equals) fo

[jira] [Updated] (CALCITE-3786) Add Digest interface to enable efficient hashCode(equals) for RexNode and RelNode

2020-06-23 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3786?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan updated CALCITE-3786: --- Attachment: screenshot-4.png > Add Digest interface to enable efficient hashCode(equals) fo

[jira] [Updated] (CALCITE-3786) Add Digest interface to enable efficient hashCode(equals) for RexNode and RelNode

2020-06-23 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3786?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan updated CALCITE-3786: --- Attachment: screenshot-2.png > Add Digest interface to enable efficient hashCode(equals) fo

[jira] [Updated] (CALCITE-3786) Add Digest interface to enable efficient hashCode(equals) for RexNode and RelNode

2020-06-23 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3786?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan updated CALCITE-3786: --- Attachment: screenshot-1.png > Add Digest interface to enable efficient hashCode(equals) fo

[jira] [Resolved] (CALCITE-4083) RelTraitSet failed to canonize traits

2020-06-23 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4083?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan resolved CALCITE-4083. Fix Version/s: 1.24.0 Resolution: Fixed Fixed in  [https://github.com/apache/calci

[jira] [Created] (CALCITE-4083) RelTraitSet failed to canonize traits

2020-06-22 Thread Haisheng Yuan (Jira)
Haisheng Yuan created CALCITE-4083: -- Summary: RelTraitSet failed to canonize traits Key: CALCITE-4083 URL: https://issues.apache.org/jira/browse/CALCITE-4083 Project: Calcite Issue Type: Bug

[jira] [Commented] (CALCITE-3786) Add Digest interface to enable efficient hashCode(equals) for RexNode and RelNode

2020-06-22 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17142199#comment-17142199 ] Haisheng Yuan commented on CALCITE-3786: {quote}My example code just illustrate

[jira] [Comment Edited] (CALCITE-3786) Add Digest interface to enable efficient hashCode(equals) for RexNode and RelNode

2020-06-22 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17142038#comment-17142038 ] Haisheng Yuan edited comment on CALCITE-3786 at 6/22/20, 1:32 PM: ---

[jira] [Commented] (CALCITE-3786) Add Digest interface to enable efficient hashCode(equals) for RexNode and RelNode

2020-06-22 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17142038#comment-17142038 ] Haisheng Yuan commented on CALCITE-3786: [~danny0405] Thank you for replying an

[jira] [Commented] (CALCITE-3786) Add Digest interface to enable efficient hashCode(equals) for RexNode and RelNode

2020-06-21 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17141718#comment-17141718 ] Haisheng Yuan commented on CALCITE-3786: {quote} Make the Digest an inner class

[jira] [Commented] (CALCITE-3786) Add Digest interface to enable efficient hashCode(equals) for RexNode and RelNode

2020-06-21 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17141648#comment-17141648 ] Haisheng Yuan commented on CALCITE-3786: {quote} I don't think having an interf

[jira] [Commented] (CALCITE-3786) Add Digest interface to enable efficient hashCode(equals) for RexNode and RelNode

2020-06-21 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17141516#comment-17141516 ] Haisheng Yuan commented on CALCITE-3786: {quote} Just implement the #explainTer

[jira] [Commented] (CALCITE-3786) Add Digest interface to enable efficient hashCode(equals) for RexNode and RelNode

2020-06-20 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17141240#comment-17141240 ] Haisheng Yuan commented on CALCITE-3786: {quote} We should be cautious for #equ

[jira] [Commented] (CALCITE-3786) Add Digest interface to enable efficient hashCode(equals) for RexNode and RelNode

2020-06-19 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17140958#comment-17140958 ] Haisheng Yuan commented on CALCITE-3786: OK, let me put it in another way. What

[jira] [Commented] (CALCITE-4073) Add a new component RexNormalize for more effect rex nodes normalization

2020-06-19 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17140810#comment-17140810 ] Haisheng Yuan commented on CALCITE-4073: I would refrain from adding new config

[jira] [Commented] (CALCITE-4071) Make RelNode Immutable

2020-06-19 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17140751#comment-17140751 ] Haisheng Yuan commented on CALCITE-4071: lol. HepPlanner is indeed a tricky one

[jira] [Commented] (CALCITE-3786) Add Digest interface to enable efficient hashCode(equals) for RexNode and RelNode

2020-06-18 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17140202#comment-17140202 ] Haisheng Yuan commented on CALCITE-3786: [~danny0405] Thank you for your feedba

[jira] [Commented] (CALCITE-4071) Make RelNode Immutable

2020-06-18 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17140023#comment-17140023 ] Haisheng Yuan commented on CALCITE-4071: [~julianhyde] Let's completely remove

[jira] [Commented] (CALCITE-3786) Add Digest interface to enable efficient hashCode(equals) for RexNode and RelNode

2020-06-18 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17140010#comment-17140010 ] Haisheng Yuan commented on CALCITE-3786: I think my objection on this proposal

[jira] [Commented] (CALCITE-4071) Make RelNode Immutable

2020-06-18 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17139912#comment-17139912 ] Haisheng Yuan commented on CALCITE-4071: No, the old one will be garbage collec

[jira] [Commented] (CALCITE-4071) Make RelNode Immutable

2020-06-18 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17139899#comment-17139899 ] Haisheng Yuan commented on CALCITE-4071: For backward compatibility. I would re

[jira] [Created] (CALCITE-4071) Make RelNode Immutable

2020-06-18 Thread Haisheng Yuan (Jira)
Haisheng Yuan created CALCITE-4071: -- Summary: Make RelNode Immutable Key: CALCITE-4071 URL: https://issues.apache.org/jira/browse/CALCITE-4071 Project: Calcite Issue Type: Improvement

[jira] [Commented] (CALCITE-4056) Remove Digest from RelNode and RexNode

2020-06-17 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17139075#comment-17139075 ] Haisheng Yuan commented on CALCITE-4056: [~danny0405] I pushed it again. Now yo

[jira] [Commented] (CALCITE-4056) Remove Digest from RelNode and RexNode

2020-06-17 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17139067#comment-17139067 ] Haisheng Yuan commented on CALCITE-4056: [~danny0405] I don't mind the code is

[jira] [Commented] (CALCITE-4056) Remove Digest from RelNode and RexNode

2020-06-17 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17139059#comment-17139059 ] Haisheng Yuan commented on CALCITE-4056: Thank you for reviewing the code, Dann

[jira] [Commented] (CALCITE-4056) Remove Digest from RelNode and RexNode

2020-06-17 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17139029#comment-17139029 ] Haisheng Yuan commented on CALCITE-4056: You told Laurent: It seems that you h

[jira] [Commented] (CALCITE-4056) Remove Digest from RelNode and RexNode

2020-06-17 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17139019#comment-17139019 ] Haisheng Yuan commented on CALCITE-4056: [~danny0405], thank you for your comme

[jira] [Resolved] (CALCITE-4056) Remove Digest from RelNode and RexNode

2020-06-17 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan resolved CALCITE-4056. Fix Version/s: 1.24.0 Resolution: Fixed Fixed in  [https://github.com/apache/calci

[jira] [Commented] (CALCITE-4058) Add Limit and LogicalLimit operator and deprecate limit in Sort

2020-06-15 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17136184#comment-17136184 ] Haisheng Yuan commented on CALCITE-4058: Hi [~julianhyde], thanks for commentin

[jira] [Commented] (CALCITE-4058) Add Limit and LogicalLimit operator and deprecate limit in Sort

2020-06-15 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17135874#comment-17135874 ] Haisheng Yuan commented on CALCITE-4058: [~rubenql] I totally understand you co

[jira] [Commented] (CALCITE-4033) SqlNode.toSqlString generates wrong query for syntax "literal(select * from unnest(...))"

2020-06-14 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17135415#comment-17135415 ] Haisheng Yuan commented on CALCITE-4033: {{Unnest}} is a table function, Postgr

[jira] [Commented] (CALCITE-4027) Add -Doverwrite option to SqlToRelTestBase

2020-06-13 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17135002#comment-17135002 ] Haisheng Yuan commented on CALCITE-4027: You don't need to manually update the

[jira] [Commented] (CALCITE-4027) Add -Doverwrite option to SqlToRelTestBase

2020-06-13 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17134997#comment-17134997 ] Haisheng Yuan commented on CALCITE-4027: [~xzh_dz] Thanks for working on this.

[jira] [Resolved] (CALCITE-4057) Implement trait propagation for EnumerableBatchNestedLoopJoin

2020-06-13 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4057?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan resolved CALCITE-4057. Fix Version/s: 1.24.0 Resolution: Fixed Fixed in  [https://github.com/apache/calci

[jira] [Commented] (CALCITE-4023) Remove or deprecate ProjectSortTransposeRule

2020-06-13 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17134926#comment-17134926 ] Haisheng Yuan commented on CALCITE-4023: Exactly, on the other hand, it implies

[jira] [Commented] (CALCITE-4013) Remove traitset derivation when creating logical operators

2020-06-12 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17134228#comment-17134228 ] Haisheng Yuan commented on CALCITE-4013: LogicalFilter takes more: !image-2020

[jira] [Updated] (CALCITE-4013) Remove traitset derivation when creating logical operators

2020-06-12 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4013?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan updated CALCITE-4013: --- Attachment: image-2020-06-12-08-46-26-846.png > Remove traitset derivation when creating lo

[jira] [Commented] (CALCITE-3786) Add Digest interface to enable efficient hashCode(equals) for RexNode and RelNode

2020-06-11 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17133799#comment-17133799 ] Haisheng Yuan commented on CALCITE-3786: {quote} Even we are with these additi

[jira] [Commented] (CALCITE-4058) Add Limit and LogicalLimit operator and deprecate limit in Sort

2020-06-11 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17133249#comment-17133249 ] Haisheng Yuan commented on CALCITE-4058: You mean objections? I would love to h

[jira] [Commented] (CALCITE-3786) Add Digest interface to enable efficient hashCode(equals) for RexNode and RelNode

2020-06-10 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17132916#comment-17132916 ] Haisheng Yuan commented on CALCITE-3786: {quote} That's not true, for RelNode w

[jira] [Created] (CALCITE-4058) Add Limit and LogicalLimit operator and deprecate limit in Sort

2020-06-10 Thread Haisheng Yuan (Jira)
Haisheng Yuan created CALCITE-4058: -- Summary: Add Limit and LogicalLimit operator and deprecate limit in Sort Key: CALCITE-4058 URL: https://issues.apache.org/jira/browse/CALCITE-4058 Project: Calcit

[jira] [Commented] (CALCITE-4008) Implement Code generation for EnumerableSortedAggregate

2020-06-10 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17132752#comment-17132752 ] Haisheng Yuan commented on CALCITE-4008: Sorry to replying late. Let's focus on

[jira] [Commented] (CALCITE-3786) Add Digest interface to enable efficient hashCode(equals) for RexNode and RelNode

2020-06-10 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17132573#comment-17132573 ] Haisheng Yuan commented on CALCITE-3786: The digest of RelNode in the patch doe

[jira] [Resolved] (CALCITE-4018) EnumerableValues should provide requested traits

2020-06-10 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4018?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan resolved CALCITE-4018. Resolution: Fixed Fixed in https://github.com/apache/calcite/commit/7c5c7e3b77b6a7606e12

[jira] [Resolved] (CALCITE-4002) Add security check to make sure TransformationRule doesn't generate PhysicalNode

2020-06-10 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4002?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan resolved CALCITE-4002. Fix Version/s: 1.24.0 Resolution: Fixed Fixed in https://github.com/apache/calcit

[jira] [Resolved] (CALCITE-4003) In MaterializationTest, FilterProjectTransposeRule matches with logical and physical convention

2020-06-10 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4003?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan resolved CALCITE-4003. Fix Version/s: 1.24.0 Resolution: Fixed Fixed in https://github.com/apache/calcit

[jira] [Commented] (CALCITE-2648) Output collation of EnumerableWindow is not consistent with its implementation

2020-06-09 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-2648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17130133#comment-17130133 ] Haisheng Yuan commented on CALCITE-2648: Pull request: https://github.com/apach

[jira] [Commented] (CALCITE-3786) Add Digest interface to enable efficient hashCode(equals) for RexNode and RelNode

2020-06-09 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17130096#comment-17130096 ] Haisheng Yuan commented on CALCITE-3786: I am sorry for disappointing you, I sh

[jira] [Commented] (CALCITE-4018) EnumerableValues should provide requested traits

2020-06-09 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17129902#comment-17129902 ] Haisheng Yuan commented on CALCITE-4018: Pull request: [https://github.com/apac

[jira] [Commented] (CALCITE-3786) Add Digest interface to enable efficient hashCode(equals) for RexNode and RelNode

2020-06-09 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17129415#comment-17129415 ] Haisheng Yuan commented on CALCITE-3786: I noticed Danny opened a pull request,

[jira] [Created] (CALCITE-4056) Remove Digest from RelNode and RexNode

2020-06-09 Thread Haisheng Yuan (Jira)
Haisheng Yuan created CALCITE-4056: -- Summary: Remove Digest from RelNode and RexNode Key: CALCITE-4056 URL: https://issues.apache.org/jira/browse/CALCITE-4056 Project: Calcite Issue Type: Im

[jira] [Commented] (CALCITE-4052) Enable Top-down Optimization

2020-06-08 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17128824#comment-17128824 ] Haisheng Yuan commented on CALCITE-4052: +1, thanks! > Enable Top-down Optimiz

[jira] [Resolved] (CALCITE-4041) Implement trait propagation for EnumerableCorrelate

2020-06-08 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4041?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan resolved CALCITE-4041. Resolution: Fixed Fixed in  [https://github.com/apache/calcite/commit/61cf2bf30d0496cf795

[jira] [Commented] (CALCITE-4050) Traits Propagation for EnumerableMergeJoin Produces Incorrect Result

2020-06-08 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17128722#comment-17128722 ] Haisheng Yuan commented on CALCITE-4050: The 1-1 mapping is OK, the problem is

[jira] [Resolved] (CALCITE-4007) MergeJoin collation check should not be limited to join key's order

2020-06-08 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4007?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan resolved CALCITE-4007. Fix Version/s: 1.24.0 Resolution: Fixed Fixed in  [https://github.com/apache/calci

[jira] [Resolved] (CALCITE-4050) Traits Propagation for EnumerableMergeJoin Produces Incorrect Result

2020-06-08 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4050?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan resolved CALCITE-4050. Fix Version/s: 1.24.0 Resolution: Fixed Fixed in  [https://github.com/apache/calci

[jira] [Resolved] (CALCITE-4012) Implement trait propagation for EnumerableHashJoin and EnumerableNestedLoopJoin

2020-06-08 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4012?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan resolved CALCITE-4012. Resolution: Fixed Fixed in  [https://github.com/apache/calcite/commit/eedd40bea825e0a00f5

[jira] [Updated] (CALCITE-4015) Pass through parent collation request on subset or superset of join keys for EnumerableMergeJoin

2020-06-06 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4015?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan updated CALCITE-4015: --- Summary: Pass through parent collation request on subset or superset of join keys for Enume

[jira] [Resolved] (CALCITE-4030) Assert error during top-down optimization with Project/Filter Traits passdown and derivation

2020-06-04 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4030?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan resolved CALCITE-4030. Fix Version/s: 1.24.0 Resolution: Fixed Fixed in  [https://github.com/apache/calci

[jira] [Commented] (CALCITE-4041) Implement trait propagation for EnumerableCorrelate

2020-06-04 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17125895#comment-17125895 ] Haisheng Yuan commented on CALCITE-4041: Thanks, looks great. > Implement trai

[jira] [Commented] (CALCITE-4042) JoinCommuteRule must not match SEMI / ANTI join

2020-06-04 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17125889#comment-17125889 ] Haisheng Yuan commented on CALCITE-4042: No problem, will do. > JoinCommuteRul

[jira] [Commented] (CALCITE-3911) JoinCommuteRule may generate wrong plan for SEMI/ANTI join

2020-06-04 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17125881#comment-17125881 ] Haisheng Yuan commented on CALCITE-3911: See CALCITE-4042. > JoinCommuteRule m

[jira] [Commented] (CALCITE-4042) JoinCommuteRule must not match SEMI / ANTI join

2020-06-04 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17125879#comment-17125879 ] Haisheng Yuan commented on CALCITE-4042: Never mind, I will close CALCITE-3911.

[jira] [Resolved] (CALCITE-3911) JoinCommuteRule may generate wrong plan for SEMI/ANTI join

2020-06-04 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3911?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan resolved CALCITE-3911. Resolution: Duplicate > JoinCommuteRule may generate wrong plan for SEMI/ANTI join >

[jira] [Commented] (CALCITE-4042) JoinCommuteRule must not match SEMI / ANTI join

2020-06-04 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17125868#comment-17125868 ] Haisheng Yuan commented on CALCITE-4042: Is it same issue? CALCITE-3911 > Join

[jira] [Commented] (CALCITE-4030) Assert error during top-down optimization with Project/Filter Traits passdown and derivation

2020-06-03 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17125423#comment-17125423 ] Haisheng Yuan commented on CALCITE-4030: MaterializedViewRelOptRulesTest. testJ

[jira] [Commented] (CALCITE-4030) Assert error during top-down optimization with Project/Filter Traits passdown and derivation

2020-06-03 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17125418#comment-17125418 ] Haisheng Yuan commented on CALCITE-4030: The assertion error has been fixed in 

[jira] [Resolved] (CALCITE-3991) The required boolean should always be provided in RelSet.getOrCreateSubset()

2020-06-03 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3991?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan resolved CALCITE-3991. Fix Version/s: 1.24.0 Resolution: Fixed Fixed in  [https://github.com/apache/calci

[jira] [Resolved] (CALCITE-3981) Volcano.register should not return stale/merged subset

2020-06-03 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan resolved CALCITE-3981. Resolution: Fixed Fixed in  [https://github.com/apache/calcite/commit/df5f4470e4257e8e705

[jira] [Commented] (CALCITE-4036) Allow applying SemiJoinRule to join without aggregate below

2020-06-03 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17125227#comment-17125227 ] Haisheng Yuan commented on CALCITE-4036: More importantly, AggregateRemoveRule

[jira] [Commented] (CALCITE-4032) Mark CalcMergeRule as TransformationRule

2020-06-03 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17125013#comment-17125013 ] Haisheng Yuan commented on CALCITE-4032: Cool, thanks for the update, [~rubenql

[jira] [Resolved] (CALCITE-4032) Mark CalcMergeRule as TransformationRule

2020-06-02 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4032?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan resolved CALCITE-4032. Fix Version/s: 1.24.0 Resolution: Fixed Fixed in  [https://github.com/apache/calci

[jira] [Resolved] (CALCITE-4029) ProjectRemoveRule auto pruning may prevent rules from running if mixed conventions are used in a logical plan

2020-06-02 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4029?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan resolved CALCITE-4029. Resolution: Not A Problem Thanks all for the discussion. Since there is a consensus, I am

[jira] [Commented] (CALCITE-4036) Allow applying SemiJoinRule to join without aggregate below

2020-06-01 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17121236#comment-17121236 ] Haisheng Yuan commented on CALCITE-4036: Even AggregateRemoveRule is applied be

[jira] [Commented] (CALCITE-4036) Allow applying SemiJoinRule to join without aggregate below

2020-06-01 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17121036#comment-17121036 ] Haisheng Yuan commented on CALCITE-4036: Hmm.. Because AggregateRemoveRule was

[jira] [Commented] (CALCITE-4032) Mark CalcMergeRule as TransformationRule

2020-05-31 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17120597#comment-17120597 ] Haisheng Yuan commented on CALCITE-4032: [~rubenql] Do you mind making your own

[jira] [Resolved] (CALCITE-4023) Remove or deprecate ProjectSortTransposeRule

2020-05-31 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4023?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan resolved CALCITE-4023. Fix Version/s: 1.24.0 Resolution: Fixed Fixed in  [https://github.com/apache/calci

[jira] [Commented] (CALCITE-3963) Maintain logical properties at RelSet (equivalent group) instead of RelNode

2020-05-30 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17120385#comment-17120385 ] Haisheng Yuan commented on CALCITE-3963: 4 values in confidence level is indeed

[jira] [Resolved] (CALCITE-3993) Add isDefault(), keys(), keyBits() to RelTrait interface

2020-05-29 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3993?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan resolved CALCITE-3993. Fix Version/s: 1.24.0 Resolution: Fixed Fixed in  [https://github.com/apache/calci

[jira] [Created] (CALCITE-4032) Mark CalcMergeRule as TransformationRule

2020-05-29 Thread Haisheng Yuan (Jira)
Haisheng Yuan created CALCITE-4032: -- Summary: Mark CalcMergeRule as TransformationRule Key: CALCITE-4032 URL: https://issues.apache.org/jira/browse/CALCITE-4032 Project: Calcite Issue Type:

[jira] [Commented] (CALCITE-4012) Implement trait propagation for EnumerableHashJoin and EnumerableNestedLoopJoin

2020-05-29 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17119884#comment-17119884 ] Haisheng Yuan commented on CALCITE-4012: Cool. > Implement trait propagation f

<    1   2   3   4   5   6   7   8   9   10   >