[
https://issues.apache.org/jira/browse/CALCITE-1953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16144302#comment-16144302
]
MinJi Kim commented on CALCITE-1953:
[~julianhyde] I made changes to the PR according to your
[
https://issues.apache.org/jira/browse/CALCITE-1953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16144302#comment-16144302
]
MinJi Kim edited comment on CALCITE-1953 at 8/28/17 8:31 PM:
-
[~julianhyde]
[
https://issues.apache.org/jira/browse/CALCITE-1953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16143330#comment-16143330
]
MinJi Kim commented on CALCITE-1953:
[~julianhyde] I think your suggestion for IS_NOT_TRUE makes
[
https://issues.apache.org/jira/browse/CALCITE-1945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16143253#comment-16143253
]
MinJi Kim commented on CALCITE-1945:
Thank you for the review, [~julianhyde]! I am sorry for the
[
https://issues.apache.org/jira/browse/CALCITE-1956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16131673#comment-16131673
]
MinJi Kim commented on CALCITE-1956:
I am actually curious if this was intentionally disallowed
MinJi Kim created CALCITE-1956:
--
Summary: Allow MultiJoin to contain multiple FULL joins
Key: CALCITE-1956
URL: https://issues.apache.org/jira/browse/CALCITE-1956
Project: Calcite
Issue Type:
[
https://issues.apache.org/jira/browse/CALCITE-1954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16131439#comment-16131439
]
MinJi Kim commented on CALCITE-1954:
A small patch, but would appreciate another set of eyes to
MinJi Kim created CALCITE-1954:
--
Summary: SqlValidator need to maintain forceNullable across joins
and renaming
Key: CALCITE-1954
URL: https://issues.apache.org/jira/browse/CALCITE-1954
Project: Calcite
[
https://issues.apache.org/jira/browse/CALCITE-1953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16131306#comment-16131306
]
MinJi Kim commented on CALCITE-1953:
Here is my initial PR. Thanks!
MinJi Kim created CALCITE-1953:
--
Summary: Reducing NOT() should not collaose NOT(IS_TRUE) to
IS_FALSE for nullable inputs
Key: CALCITE-1953
URL: https://issues.apache.org/jira/browse/CALCITE-1953
[
https://issues.apache.org/jira/browse/CALCITE-1945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16128197#comment-16128197
]
MinJi Kim commented on CALCITE-1945:
I have a first draft of this patch here. I would like to make
[
https://issues.apache.org/jira/browse/CALCITE-1936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16122810#comment-16122810
]
MinJi Kim commented on CALCITE-1936:
I updated the PR. Thanks!
[
https://issues.apache.org/jira/browse/CALCITE-1936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16122767#comment-16122767
]
MinJi Kim commented on CALCITE-1936:
Yes, I meant TRUNCATE. I updated the title. I will also
[
https://issues.apache.org/jira/browse/CALCITE-1936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
MinJi Kim updated CALCITE-1936:
---
Summary: Allow ROUND() and TRUNCATE() to take only one operand (was: Allow
ROUND() and TRUNC() to
[
https://issues.apache.org/jira/browse/CALCITE-1936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16122424#comment-16122424
]
MinJi Kim commented on CALCITE-1936:
Here is a small patch for this jira. Please let me know what
MinJi Kim created CALCITE-1936:
--
Summary: Allow ROUND() and TRUNC() to take only one operand
Key: CALCITE-1936
URL: https://issues.apache.org/jira/browse/CALCITE-1936
Project: Calcite
Issue
[
https://issues.apache.org/jira/browse/CALCITE-1930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16122332#comment-16122332
]
MinJi Kim edited comment on CALCITE-1930 at 8/10/17 9:14 PM:
-
Here is the
[
https://issues.apache.org/jira/browse/CALCITE-1930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16122332#comment-16122332
]
MinJi Kim commented on CALCITE-1930:
Here is the updated PR:
[
https://issues.apache.org/jira/browse/CALCITE-1931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16120073#comment-16120073
]
MinJi Kim commented on CALCITE-1931:
I have updated the pull request with some additional changes
[
https://issues.apache.org/jira/browse/CALCITE-1930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16118728#comment-16118728
]
MinJi Kim commented on CALCITE-1930:
The assumption that the "distinct aggregate call" have only one
[
https://issues.apache.org/jira/browse/CALCITE-1931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16118693#comment-16118693
]
MinJi Kim commented on CALCITE-1931:
I think CUME_DIST() and PERCENT_RANK() for example, should
[
https://issues.apache.org/jira/browse/CALCITE-1932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16117384#comment-16117384
]
MinJi Kim commented on CALCITE-1932:
Thank you for reviewing this PR! Thanks! -Minji
MinJi Kim created CALCITE-1932:
--
Summary: Project.getPermutation() should return null if a column
is repeated
Key: CALCITE-1932
URL: https://issues.apache.org/jira/browse/CALCITE-1932
Project: Calcite
[
https://issues.apache.org/jira/browse/CALCITE-1931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16117196#comment-16117196
]
MinJi Kim commented on CALCITE-1931:
Thanks again for reviewing this!
MinJi Kim created CALCITE-1931:
--
Summary: rank/ntile/etc. functions should not always return INTEGER
Key: CALCITE-1931
URL: https://issues.apache.org/jira/browse/CALCITE-1931
Project: Calcite
[
https://issues.apache.org/jira/browse/CALCITE-1930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16117052#comment-16117052
]
MinJi Kim commented on CALCITE-1930:
Here is an initial fix for this issue that I noticed for
[
https://issues.apache.org/jira/browse/CALCITE-1930?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
MinJi Kim updated CALCITE-1930:
---
Description:
A query with two aggregate calls, sum(comm) and min(comm), it produces an
incorrect
MinJi Kim created CALCITE-1930:
--
Summary: AggregateExpandDistinctAggregatesRule does not expand
aggregates properly
Key: CALCITE-1930
URL: https://issues.apache.org/jira/browse/CALCITE-1930
Project:
[
https://issues.apache.org/jira/browse/CALCITE-1829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16037931#comment-16037931
]
MinJi Kim commented on CALCITE-1829:
I updated the PR. Please take a look, thanks again!
[
https://issues.apache.org/jira/browse/CALCITE-1829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16037926#comment-16037926
]
MinJi Kim commented on CALCITE-1829:
No, not really. I was worried that there might be cases that
[
https://issues.apache.org/jira/browse/CALCITE-1829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16037872#comment-16037872
]
MinJi Kim commented on CALCITE-1829:
[~julianhyde] I updated the PR with the changes. If you can
[
https://issues.apache.org/jira/browse/CALCITE-1829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16037536#comment-16037536
]
MinJi Kim edited comment on CALCITE-1829 at 6/5/17 8:44 PM:
Thanks for the
[
https://issues.apache.org/jira/browse/CALCITE-1829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16037536#comment-16037536
]
MinJi Kim commented on CALCITE-1829:
Thanks for the review, [~julianhyde]. I will fix the
[
https://issues.apache.org/jira/browse/CALCITE-1829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16035880#comment-16035880
]
MinJi Kim commented on CALCITE-1829:
[~julianhyde] Let me know if this looks okay. Thanks!
[
https://issues.apache.org/jira/browse/CALCITE-1829?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
MinJi Kim updated CALCITE-1829:
---
Description:
In RexImplicationChecker, we support a lot of operators and types, but it looks
like
[
https://issues.apache.org/jira/browse/CALCITE-1829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16035698#comment-16035698
]
MinJi Kim commented on CALCITE-1829:
Okay, let me go find an example and update the description to
[
https://issues.apache.org/jira/browse/CALCITE-1829?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
MinJi Kim updated CALCITE-1829:
---
Description:
In RexImplicationChecker, we support a lot of operators and types, but it looks
like
MinJi Kim created CALCITE-1829:
--
Summary: Add TIME/TIMESTAMP/DATE datatype handling to
RexImplicationChecker
Key: CALCITE-1829
URL: https://issues.apache.org/jira/browse/CALCITE-1829
Project: Calcite
[
https://issues.apache.org/jira/browse/CALCITE-1800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16021492#comment-16021492
]
MinJi Kim edited comment on CALCITE-1800 at 5/23/17 5:11 PM:
-
+1 Looks good
[
https://issues.apache.org/jira/browse/CALCITE-1800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16021492#comment-16021492
]
MinJi Kim commented on CALCITE-1800:
+1 Looks good to me. Thanks, [~victor.ba...@gmail.com]
> JDBC
[
https://issues.apache.org/jira/browse/CALCITE-1800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16020677#comment-16020677
]
MinJi Kim commented on CALCITE-1800:
It looks like my previous suggestion is not going to work. In
[
https://issues.apache.org/jira/browse/CALCITE-1800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16020643#comment-16020643
]
MinJi Kim edited comment on CALCITE-1800 at 5/23/17 4:24 AM:
-
It looks like
[
https://issues.apache.org/jira/browse/CALCITE-1800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16020643#comment-16020643
]
MinJi Kim commented on CALCITE-1800:
It looks like the problem is whether we should create a new
[
https://issues.apache.org/jira/browse/CALCITE-1800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16020504#comment-16020504
]
MinJi Kim commented on CALCITE-1800:
Sure thing! I will take a look it soon.
> JDBC adapter fails
[
https://issues.apache.org/jira/browse/CALCITE-1800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16020504#comment-16020504
]
MinJi Kim edited comment on CALCITE-1800 at 5/23/17 1:06 AM:
-
Sure thing! I
[
https://issues.apache.org/jira/browse/CALCITE-1753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15975646#comment-15975646
]
MinJi Kim commented on CALCITE-1753:
It looks like I spoke too soon. I tried enabling
[
https://issues.apache.org/jira/browse/CALCITE-1753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15975607#comment-15975607
]
MinJi Kim commented on CALCITE-1753:
[~julianhyde] and [~jni] I updated the pull request. Please
[
https://issues.apache.org/jira/browse/CALCITE-1753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15971874#comment-15971874
]
MinJi Kim edited comment on CALCITE-1753 at 4/18/17 12:15 AM:
--
[
https://issues.apache.org/jira/browse/CALCITE-1753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15971874#comment-15971874
]
MinJi Kim commented on CALCITE-1753:
[~julianhyde] Sure thing. Will make the changes. I can test
[
https://issues.apache.org/jira/browse/CALCITE-1753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15969827#comment-15969827
]
MinJi Kim commented on CALCITE-1753:
I updated the PR with some changes. Please take a look at let
[
https://issues.apache.org/jira/browse/CALCITE-1753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15965420#comment-15965420
]
MinJi Kim commented on CALCITE-1753:
I debated between adding another preserveExprCondition to
MinJi Kim created CALCITE-1753:
--
Summary: ProjectJoinTransposeRule with preserveExprCondition
pushes projects below outer-joins
Key: CALCITE-1753
URL: https://issues.apache.org/jira/browse/CALCITE-1753
[
https://issues.apache.org/jira/browse/CALCITE-1747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15963682#comment-15963682
]
MinJi Kim commented on CALCITE-1747:
I wanted to make sure that this isn't going to cause some
MinJi Kim created CALCITE-1747:
--
Summary: RelMdColumnUniqueness for HepRelVertex
Key: CALCITE-1747
URL: https://issues.apache.org/jira/browse/CALCITE-1747
Project: Calcite
Issue Type: Bug
[
https://issues.apache.org/jira/browse/CALCITE-1453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15584271#comment-15584271
]
MinJi Kim commented on CALCITE-1453:
[~julianhyde] I will take a look at the patch.
> Support ANY
[
https://issues.apache.org/jira/browse/CALCITE-1453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15584271#comment-15584271
]
MinJi Kim edited comment on CALCITE-1453 at 10/18/16 3:08 AM:
--
MinJi Kim created CALCITE-1380:
--
Summary: Redshift jdbc driver returns "POSTGRES" for its database
product name
Key: CALCITE-1380
URL: https://issues.apache.org/jira/browse/CALCITE-1380
Project: Calcite
[
https://issues.apache.org/jira/browse/CALCITE-1372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15491849#comment-15491849
]
MinJi Kim commented on CALCITE-1372:
+1. It looks good to me. I am debugging something related,
[
https://issues.apache.org/jira/browse/CALCITE-1342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15471264#comment-15471264
]
MinJi Kim commented on CALCITE-1342:
Okay, will remember from now on!
Fixed in
[
https://issues.apache.org/jira/browse/CALCITE-1342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
MinJi Kim resolved CALCITE-1342.
Resolution: Fixed
Fix Version/s: 1.9.0
> ProjectPusher should use rel factories when
[
https://issues.apache.org/jira/browse/CALCITE-1342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15468909#comment-15468909
]
MinJi Kim commented on CALCITE-1342:
Okay, sure. I will make the changes. I will give it a try at
[
https://issues.apache.org/jira/browse/CALCITE-1110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15468739#comment-15468739
]
MinJi Kim commented on CALCITE-1110:
I am curious about what is being considered to resolve this
[
https://issues.apache.org/jira/browse/CALCITE-1342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15454350#comment-15454350
]
MinJi Kim commented on CALCITE-1342:
[~julianhyde] I uploaded an updated patch. Please let me know
[
https://issues.apache.org/jira/browse/CALCITE-1342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15451045#comment-15451045
]
MinJi Kim commented on CALCITE-1342:
Will do! I am sorry for the delay. I got caught in something,
[
https://issues.apache.org/jira/browse/CALCITE-1342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
MinJi Kim updated CALCITE-1342:
---
Description: I was playing around with some new ideas in drill, and wanted
to use ProjectPusher,
MinJi Kim created CALCITE-1342:
--
Summary: ProjectPusher should use rel factories when creating new
rels, e.g. project/filter
Key: CALCITE-1342
URL: https://issues.apache.org/jira/browse/CALCITE-1342
[
https://issues.apache.org/jira/browse/CALCITE-1333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15398292#comment-15398292
]
MinJi Kim commented on CALCITE-1333:
I will take a look at CALCITE-1043. From my initial glance, I
[
https://issues.apache.org/jira/browse/CALCITE-1333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15398280#comment-15398280
]
MinJi Kim commented on CALCITE-1333:
Here is my initial patch. Please let me know if there are any
[
https://issues.apache.org/jira/browse/CALCITE-1332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
MinJi Kim updated CALCITE-1332:
---
Description:
I tried joining tables in DB2 and it looks like DB2 dialect requires the fully
[
https://issues.apache.org/jira/browse/CALCITE-1332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
MinJi Kim updated CALCITE-1332:
---
Description:
I tried joining tables in DB2 and it looks like DB2 dialect requires the fully
[
https://issues.apache.org/jira/browse/CALCITE-1332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15396134#comment-15396134
]
MinJi Kim commented on CALCITE-1332:
[~julianhyde] I am sure if this is the best way to solve this
[
https://issues.apache.org/jira/browse/CALCITE-1330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15392885#comment-15392885
]
MinJi Kim commented on CALCITE-1330:
https://github.com/apache/calcite/pull/260
> DB2 does not
MinJi Kim created CALCITE-1330:
--
Summary: DB2 does not support character sets in data type
Key: CALCITE-1330
URL: https://issues.apache.org/jira/browse/CALCITE-1330
Project: Calcite
Issue Type:
[
https://issues.apache.org/jira/browse/CALCITE-1312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15373441#comment-15373441
]
MinJi Kim edited comment on CALCITE-1312 at 7/12/16 6:48 PM:
-
Thanks for the
[
https://issues.apache.org/jira/browse/CALCITE-1312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15373441#comment-15373441
]
MinJi Kim commented on CALCITE-1312:
Thanks for the review. I made the changes you suggested.
[
https://issues.apache.org/jira/browse/CALCITE-1312?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
MinJi Kim updated CALCITE-1312:
---
Description:
timestamp_add("MINUTE", 1, date '2016-06-15') returns 2016-06-15 since it
returns a
[
https://issues.apache.org/jira/browse/CALCITE-1312?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
MinJi Kim updated CALCITE-1312:
---
Summary: timestamp_add(UNIT, DATE) should return timestamp if the unit
added is less than a date,
[
https://issues.apache.org/jira/browse/CALCITE-1313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15371949#comment-15371949
]
MinJi Kim commented on CALCITE-1313:
Thanks for the review! I moved the test case to
MinJi Kim created CALCITE-1313:
--
Summary: expandOrderExpr() does not validate node type and
properly set it
Key: CALCITE-1313
URL: https://issues.apache.org/jira/browse/CALCITE-1313
Project: Calcite
[
https://issues.apache.org/jira/browse/CALCITE-1312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15371677#comment-15371677
]
MinJi Kim commented on CALCITE-1312:
https://github.com/apache/calcite/pull/253
>
MinJi Kim created CALCITE-1312:
--
Summary: timestamp_add(UNIT, DATE) should return timestamp if the
unit added is less than a date
Key: CALCITE-1312
URL: https://issues.apache.org/jira/browse/CALCITE-1312
[
https://issues.apache.org/jira/browse/CALCITE-1289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
MinJi Kim updated CALCITE-1289:
---
Description: RexUtil.simplify() returns incorrect type information if the
RexNode is a
MinJi Kim created CALCITE-1283:
--
Summary: Nullability incorrectly assigned in
SqlTypeFactory.leastRestrictiveSqlType()
Key: CALCITE-1283
URL: https://issues.apache.org/jira/browse/CALCITE-1283
Project:
[
https://issues.apache.org/jira/browse/CALCITE-1151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15315199#comment-15315199
]
MinJi Kim commented on CALCITE-1151:
https://github.com/apache/calcite/pull/244
> Fix SQLSetOption
[
https://issues.apache.org/jira/browse/CALCITE-1107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15314496#comment-15314496
]
MinJi Kim commented on CALCITE-1107:
https://github.com/apache/calcite/pull/242
> Expose
[
https://issues.apache.org/jira/browse/CALCITE-1106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15314495#comment-15314495
]
MinJi Kim commented on CALCITE-1106:
https://github.com/apache/calcite/pull/242
> Change
MinJi Kim created CALCITE-1148:
--
Summary: Trait conversion broken for RelTraits other than
Convention
Key: CALCITE-1148
URL: https://issues.apache.org/jira/browse/CALCITE-1148
Project: Calcite
87 matches
Mail list logo