[jira] [Commented] (CALCITE-1569) Date condition can generates Integer == Integer, which is always false

2017-01-22 Thread Kaige Liu (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15833926#comment-15833926 ] Kaige Liu commented on CALCITE-1569: - The compare condition between Dates works now. But still not

[jira] [Commented] (CALCITE-1569) Date condition can generates Integer == Integer, which is always false

2017-01-20 Thread liyang (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15832182#comment-15832182 ] liyang commented on CALCITE-1569: - I've asked help from Kaige to verify the patch. > Date condition can

[jira] [Commented] (CALCITE-1569) Date condition can generates Integer == Integer, which is always false

2017-01-20 Thread zhen wang (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15831621#comment-15831621 ] zhen wang commented on CALCITE-1569: https://github.com/apache/calcite/pull/356 tests fixed with

[jira] [Commented] (CALCITE-1569) Date condition can generates Integer == Integer, which is always false

2017-01-19 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15830694#comment-15830694 ] Julian Hyde commented on CALCITE-1569: -- [~zhenw], I get test failures in

[jira] [Commented] (CALCITE-1569) Date condition can generates Integer == Integer, which is always false

2017-01-19 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15830579#comment-15830579 ] Julian Hyde commented on CALCITE-1569: -- The fix isn't ideal. I'd rather that we convert

[jira] [Commented] (CALCITE-1569) Date condition can generates Integer == Integer, which is always false

2017-01-19 Thread liyang (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15829980#comment-15829980 ] liyang commented on CALCITE-1569: - Thanks guys for making the progress. Let me know if the original full

[jira] [Commented] (CALCITE-1569) Date condition can generates Integer == Integer, which is always false

2017-01-17 Thread zhen wang (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15825683#comment-15825683 ] zhen wang commented on CALCITE-1569: wrote another fix:

[jira] [Commented] (CALCITE-1569) Date condition can generates Integer == Integer, which is always false

2017-01-16 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15824720#comment-15824720 ] Julian Hyde commented on CALCITE-1569: -- It appears that {{toInt(Date)}} will throw if the date is

[jira] [Commented] (CALCITE-1569) Date condition can generates Integer == Integer, which is always false

2017-01-14 Thread zhen wang (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15823028#comment-15823028 ] zhen wang commented on CALCITE-1569: hmm, what will this line look like in your mind `/* 115 */

[jira] [Commented] (CALCITE-1569) Date condition can generates Integer == Integer, which is always false

2017-01-14 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15822868#comment-15822868 ] Julian Hyde commented on CALCITE-1569: -- I don't like the direction you're going in that fix. We

[jira] [Commented] (CALCITE-1569) Date condition can generates Integer == Integer, which is always false

2017-01-14 Thread zhen wang (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15822847#comment-15822847 ] zhen wang commented on CALCITE-1569: thanks [~vladimirsitnikov] for the test case. it seems if the

[jira] [Commented] (CALCITE-1569) Date condition can generates Integer == Integer, which is always false

2017-01-09 Thread Vladimir Sitnikov (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15813034#comment-15813034 ] Vladimir Sitnikov commented on CALCITE-1569: [~liyang.g...@gmail.com], can you please