[
https://issues.apache.org/jira/browse/CALCITE-1792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16021917#comment-16021917
]
Julian Hyde commented on CALCITE-1792:
--
Separation of concerns. It's not the JDBC adapter's job to
[
https://issues.apache.org/jira/browse/CALCITE-1792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16020938#comment-16020938
]
Muhammad Gelbana commented on CALCITE-1792:
---
I agree. However, don't you agree that for
[
https://issues.apache.org/jira/browse/CALCITE-1792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16019391#comment-16019391
]
Muhammad Gelbana commented on CALCITE-1792:
---
[~julianhyde], why would you support the FALSE
[
https://issues.apache.org/jira/browse/CALCITE-1792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16018918#comment-16018918
]
Julian Hyde commented on CALCITE-1792:
--
Thanks for being flexible. To be honest I'm only 55/45 on
[
https://issues.apache.org/jira/browse/CALCITE-1792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16018632#comment-16018632
]
Sergiy Simonov commented on CALCITE-1792:
-
That's why I fixed my PR despite I'm not agree with
[
https://issues.apache.org/jira/browse/CALCITE-1792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16018629#comment-16018629
]
Julian Hyde commented on CALCITE-1792:
--
The so-called "SQL-92 join syntax" is standard. And it is
[
https://issues.apache.org/jira/browse/CALCITE-1792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16018623#comment-16018623
]
Sergiy Simonov commented on CALCITE-1792:
-
Updated PR to preserve comma syntax
>
[
https://issues.apache.org/jira/browse/CALCITE-1792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16018535#comment-16018535
]
Julian Hyde commented on CALCITE-1792:
--
There seem to be 2 changes here: 1 handle TRUE; 2 move away
[
https://issues.apache.org/jira/browse/CALCITE-1792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16013750#comment-16013750
]
Sergiy Simonov commented on CALCITE-1792:
-
Applied comments to PR.
> RelToSqlConverter doesn't
[
https://issues.apache.org/jira/browse/CALCITE-1792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16013207#comment-16013207
]
Jess Balint commented on CALCITE-1792:
--
Looks good. Was a small oversight in the original fix.
[
https://issues.apache.org/jira/browse/CALCITE-1792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16012355#comment-16012355
]
Sergiy Simonov commented on CALCITE-1792:
-
Raised PR with the fix:
11 matches
Mail list logo