[jira] [Commented] (CALCITE-1792) RelToSqlConverter doesn't handle cartesian join (join cond as TRUE)

2017-05-23 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16021917#comment-16021917 ] Julian Hyde commented on CALCITE-1792: -- Separation of concerns. It's not the JDBC adapter's job to

[jira] [Commented] (CALCITE-1792) RelToSqlConverter doesn't handle cartesian join (join cond as TRUE)

2017-05-23 Thread Muhammad Gelbana (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16020938#comment-16020938 ] Muhammad Gelbana commented on CALCITE-1792: --- I agree. However, don't you agree that for

[jira] [Commented] (CALCITE-1792) RelToSqlConverter doesn't handle cartesian join (join cond as TRUE)

2017-05-22 Thread Muhammad Gelbana (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16019391#comment-16019391 ] Muhammad Gelbana commented on CALCITE-1792: --- [~julianhyde], why would you support the FALSE

[jira] [Commented] (CALCITE-1792) RelToSqlConverter doesn't handle cartesian join (join cond as TRUE)

2017-05-21 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16018918#comment-16018918 ] Julian Hyde commented on CALCITE-1792: -- Thanks for being flexible. To be honest I'm only 55/45 on

[jira] [Commented] (CALCITE-1792) RelToSqlConverter doesn't handle cartesian join (join cond as TRUE)

2017-05-20 Thread Sergiy Simonov (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16018632#comment-16018632 ] Sergiy Simonov commented on CALCITE-1792: - That's why I fixed my PR despite I'm not agree with

[jira] [Commented] (CALCITE-1792) RelToSqlConverter doesn't handle cartesian join (join cond as TRUE)

2017-05-20 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16018629#comment-16018629 ] Julian Hyde commented on CALCITE-1792: -- The so-called "SQL-92 join syntax" is standard. And it is

[jira] [Commented] (CALCITE-1792) RelToSqlConverter doesn't handle cartesian join (join cond as TRUE)

2017-05-20 Thread Sergiy Simonov (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16018623#comment-16018623 ] Sergiy Simonov commented on CALCITE-1792: - Updated PR to preserve comma syntax >

[jira] [Commented] (CALCITE-1792) RelToSqlConverter doesn't handle cartesian join (join cond as TRUE)

2017-05-20 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16018535#comment-16018535 ] Julian Hyde commented on CALCITE-1792: -- There seem to be 2 changes here: 1 handle TRUE; 2 move away

[jira] [Commented] (CALCITE-1792) RelToSqlConverter doesn't handle cartesian join (join cond as TRUE)

2017-05-17 Thread Sergiy Simonov (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16013750#comment-16013750 ] Sergiy Simonov commented on CALCITE-1792: - Applied comments to PR. > RelToSqlConverter doesn't

[jira] [Commented] (CALCITE-1792) RelToSqlConverter doesn't handle cartesian join (join cond as TRUE)

2017-05-16 Thread Jess Balint (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16013207#comment-16013207 ] Jess Balint commented on CALCITE-1792: -- Looks good. Was a small oversight in the original fix.

[jira] [Commented] (CALCITE-1792) RelToSqlConverter doesn't handle cartesian join (join cond as TRUE)

2017-05-16 Thread Sergiy Simonov (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16012355#comment-16012355 ] Sergiy Simonov commented on CALCITE-1792: - Raised PR with the fix: