[jira] [Commented] (CALCITE-1935) Reference implementation for MATCH_RECOGNIZE

2019-08-13 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16906393#comment-16906393 ] Julian Hyde commented on CALCITE-1935: -- I use ‘git rebase -i’ over many iterations, and sometimes

[jira] [Commented] (CALCITE-1935) Reference implementation for MATCH_RECOGNIZE

2019-08-13 Thread zhen wang (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16906175#comment-16906175 ] zhen wang commented on CALCITE-1935: [~julianhyde] you still managed to squeeze it into 3 big

[jira] [Commented] (CALCITE-1935) Reference implementation for MATCH_RECOGNIZE

2019-08-12 Thread Julian Feinauer (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16905847#comment-16905847 ] Julian Feinauer commented on CALCITE-1935: -- Thank you very much [~danny0405]! > Reference

[jira] [Commented] (CALCITE-1935) Reference implementation for MATCH_RECOGNIZE

2019-08-12 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16905746#comment-16905746 ] Danny Chan commented on CALCITE-1935: - Nice job, [~julian.feinauer] ! Thanks for your contribution

[jira] [Commented] (CALCITE-1935) Reference implementation for MATCH_RECOGNIZE

2019-08-12 Thread Julian Feinauer (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16905538#comment-16905538 ] Julian Feinauer commented on CALCITE-1935: -- Thank you so much [~julianhyde] for your support

[jira] [Commented] (CALCITE-1935) Reference implementation for MATCH_RECOGNIZE

2019-08-10 Thread Julian Feinauer (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16904354#comment-16904354 ] Julian Feinauer commented on CALCITE-1935: -- The commit is

[jira] [Commented] (CALCITE-1935) Reference implementation for MATCH_RECOGNIZE

2019-08-09 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16904236#comment-16904236 ] Julian Hyde commented on CALCITE-1935: -- Just a note regarding {{class CircularArrayList}}. As I

[jira] [Commented] (CALCITE-1935) Reference implementation for MATCH_RECOGNIZE

2019-08-09 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16904230#comment-16904230 ] Julian Hyde commented on CALCITE-1935: -- Can you point me to the commit with the test? (Don't need

[jira] [Commented] (CALCITE-1935) Reference implementation for MATCH_RECOGNIZE

2019-08-09 Thread Julian Feinauer (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16903819#comment-16903819 ] Julian Feinauer commented on CALCITE-1935: -- I just created a PR where I added a Test to

[jira] [Commented] (CALCITE-1935) Reference implementation for MATCH_RECOGNIZE

2019-08-09 Thread Julian Feinauer (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16903794#comment-16903794 ] Julian Feinauer commented on CALCITE-1935: -- Hey [~julianhyde] thank for your detailed

[jira] [Commented] (CALCITE-1935) Reference implementation for MATCH_RECOGNIZE

2019-08-08 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16903462#comment-16903462 ] Julian Hyde commented on CALCITE-1935: -- * RelBuilder: I made the those changes. They look fine. *

[jira] [Commented] (CALCITE-1935) Reference implementation for MATCH_RECOGNIZE

2019-08-08 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16903435#comment-16903435 ] Julian Hyde commented on CALCITE-1935: -- In [an

[jira] [Commented] (CALCITE-1935) Reference implementation for MATCH_RECOGNIZE

2019-08-08 Thread Julian Feinauer (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16902823#comment-16902823 ] Julian Feinauer commented on CALCITE-1935: -- Hey [~julianhyde], I just checked your branch and

[jira] [Commented] (CALCITE-1935) Reference implementation for MATCH_RECOGNIZE

2019-08-08 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16902775#comment-16902775 ] Julian Hyde commented on CALCITE-1935: -- I've reviewed and done a little cleanup. Very little was

[jira] [Commented] (CALCITE-1935) Reference implementation for MATCH_RECOGNIZE

2019-08-07 Thread Julian Feinauer (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16902397#comment-16902397 ] Julian Feinauer commented on CALCITE-1935: -- Hey [~julianhyde], you assigned the issue back to

[jira] [Commented] (CALCITE-1935) Reference implementation for MATCH_RECOGNIZE

2019-07-31 Thread Julian Feinauer (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16897535#comment-16897535 ] Julian Feinauer commented on CALCITE-1935: -- Hey, I think this is a good way and definitely

[jira] [Commented] (CALCITE-1935) Reference implementation for MATCH_RECOGNIZE

2019-07-31 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16897445#comment-16897445 ] Julian Hyde commented on CALCITE-1935: -- The way I tend to deal with large PRs like this is to

[jira] [Commented] (CALCITE-1935) Reference implementation for MATCH_RECOGNIZE

2019-07-31 Thread Julian Feinauer (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16897031#comment-16897031 ] Julian Feinauer commented on CALCITE-1935: -- [~julianhyde] I will do and thank you for your

[jira] [Commented] (CALCITE-1935) Reference implementation for MATCH_RECOGNIZE

2019-07-30 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16896325#comment-16896325 ] Julian Hyde commented on CALCITE-1935: -- OK, I will look at it today or tomorrow. (Please nag me

[jira] [Commented] (CALCITE-1935) Reference implementation for MATCH_RECOGNIZE

2019-07-30 Thread Julian Feinauer (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16896198#comment-16896198 ] Julian Feinauer commented on CALCITE-1935: -- Hey [~julianhyde], I submitted a PR which needs a

[jira] [Commented] (CALCITE-1935) Reference implementation for MATCH_RECOGNIZE

2019-07-28 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16894761#comment-16894761 ] Julian Hyde commented on CALCITE-1935: -- [~julian.feinauer], I've assigned to you since you say you

[jira] [Commented] (CALCITE-1935) Reference implementation for MATCH_RECOGNIZE

2019-07-01 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16876391#comment-16876391 ] Julian Hyde commented on CALCITE-1935: -- It's not very important that you squash; it's more

[jira] [Commented] (CALCITE-1935) Reference implementation for MATCH_RECOGNIZE

2019-06-30 Thread zhen wang (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16875736#comment-16875736 ] zhen wang commented on CALCITE-1935: [~julian.feinauer] , I spent some time on rebasing your work

[jira] [Commented] (CALCITE-1935) Reference implementation for MATCH_RECOGNIZE

2019-04-12 Thread Julian Feinauer (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16816658#comment-16816658 ] Julian Feinauer commented on CALCITE-1935: -- Hi [~julianhyde] thanks for your offer. And I

[jira] [Commented] (CALCITE-1935) Reference implementation for MATCH_RECOGNIZE

2019-04-12 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16816573#comment-16816573 ] Julian Hyde commented on CALCITE-1935: -- [~julian.feinauer] That's great. If there's something you

[jira] [Commented] (CALCITE-1935) Reference implementation for MATCH_RECOGNIZE

2018-11-29 Thread zhen wang (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16703125#comment-16703125 ] zhen wang commented on CALCITE-1935: okay, I will put it here first, adding it gradually:

[jira] [Commented] (CALCITE-1935) Reference implementation for MATCH_RECOGNIZE

2018-11-28 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16702646#comment-16702646 ] Julian Hyde commented on CALCITE-1935: -- Thanks for starting on this. A couple of things, though: *

[jira] [Commented] (CALCITE-1935) Reference implementation for MATCH_RECOGNIZE

2018-11-28 Thread zhen wang (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16702572#comment-16702572 ] zhen wang commented on CALCITE-1935: yep, I will play with it and add queries to `match.iq`. let

[jira] [Commented] (CALCITE-1935) Reference implementation for MATCH_RECOGNIZE

2018-11-28 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16702568#comment-16702568 ] Julian Hyde commented on CALCITE-1935: -- [~zhenw] A better option is [Oracle's

[jira] [Commented] (CALCITE-1935) Reference implementation for MATCH_RECOGNIZE

2018-11-27 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16701402#comment-16701402 ] Julian Hyde commented on CALCITE-1935: -- [~zhenw] If you have time to write some tests in the next

[jira] [Commented] (CALCITE-1935) Reference implementation for MATCH_RECOGNIZE

2018-11-27 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16701073#comment-16701073 ] Julian Hyde commented on CALCITE-1935: -- Oracle 18c XE might be the answer. (XE, Express Edition is

[jira] [Commented] (CALCITE-1935) Reference implementation for MATCH_RECOGNIZE

2018-11-27 Thread zhen wang (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16700454#comment-16700454 ] zhen wang commented on CALCITE-1935: some of the 'oracle queries' I am looking at

[jira] [Commented] (CALCITE-1935) Reference implementation for MATCH_RECOGNIZE

2018-11-26 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16699512#comment-16699512 ] Julian Hyde commented on CALCITE-1935: -- Over Thanksgiving, I started working on

[jira] [Commented] (CALCITE-1935) Reference implementation for MATCH_RECOGNIZE

2018-01-03 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310237#comment-16310237 ] Julian Hyde commented on CALCITE-1935: -- [~ransom], I noticed your dev branch

[jira] [Commented] (CALCITE-1935) Reference implementation for MATCH_RECOGNIZE

2017-09-07 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16157391#comment-16157391 ] Julian Hyde commented on CALCITE-1935: -- There is an old result that a regexp is equivalent to an

[jira] [Commented] (CALCITE-1935) Reference implementation for MATCH_RECOGNIZE

2017-09-06 Thread Zhiqiang He (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16156329#comment-16156329 ] Zhiqiang He commented on CALCITE-1935: -- I'm very sorry to replay so late. I still thinks that we

[jira] [Commented] (CALCITE-1935) Reference implementation for MATCH_RECOGNIZE

2017-09-06 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16156103#comment-16156103 ] Julian Hyde commented on CALCITE-1935: -- Here is a dev branch with match.iq:

[jira] [Commented] (CALCITE-1935) Reference implementation for MATCH_RECOGNIZE

2017-08-22 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16137463#comment-16137463 ] Julian Hyde commented on CALCITE-1935: -- The important point is that we need to start executing

[jira] [Commented] (CALCITE-1935) Reference implementation for MATCH_RECOGNIZE

2017-08-15 Thread Zhiqiang He (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16127129#comment-16127129 ] Zhiqiang He commented on CALCITE-1935: -- But regular expression can not conver all functions in

[jira] [Commented] (CALCITE-1935) Reference implementation for MATCH_RECOGNIZE

2017-08-15 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16127022#comment-16127022 ] Julian Hyde commented on CALCITE-1935: -- As you have said, building an NFA is expensive. It might be

[jira] [Commented] (CALCITE-1935) Reference implementation for MATCH_RECOGNIZE

2017-08-14 Thread Zhiqiang He (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16126696#comment-16126696 ] Zhiqiang He commented on CALCITE-1935: -- But this simple reference implementation can not be used in

[jira] [Commented] (CALCITE-1935) Reference implementation for MATCH_RECOGNIZE

2017-08-14 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16125839#comment-16125839 ] Julian Hyde commented on CALCITE-1935: -- Maybe regexp cannot handle everything. But we've been

[jira] [Commented] (CALCITE-1935) Reference implementation for MATCH_RECOGNIZE

2017-08-13 Thread Zhiqiang He (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16125140#comment-16125140 ] Zhiqiang He commented on CALCITE-1935: -- I do not think we can use regular expression support. It is

[jira] [Commented] (CALCITE-1935) Reference implementation for MATCH_RECOGNIZE

2017-08-11 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16123478#comment-16123478 ] Julian Hyde commented on CALCITE-1935: -- Remember, it doesn't have to be efficient. Could you use

[jira] [Commented] (CALCITE-1935) Reference implementation for MATCH_RECOGNIZE

2017-08-11 Thread Dian Fu (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16123288#comment-16123288 ] Dian Fu commented on CALCITE-1935: -- [~julianhyde], sorry for late response. IMO, it's not easy to add

[jira] [Commented] (CALCITE-1935) Reference implementation for MATCH_RECOGNIZE

2017-08-09 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16120768#comment-16120768 ] Julian Hyde commented on CALCITE-1935: -- [~ransom] or [~dian.fu], could one of you take on this