[jira] [Commented] (CALCITE-1998) Hive - Version specific handling for NULLS FIRST/ NULLS LAST

2017-11-13 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16250347#comment-16250347 ] Julian Hyde commented on CALCITE-1998: -- I was initially worried that we needed to generate "order

[jira] [Commented] (CALCITE-1998) Hive - Version specific handling for NULLS FIRST/ NULLS LAST

2017-11-06 Thread Abbas Gadhia (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16241626#comment-16241626 ] Abbas Gadhia commented on CALCITE-1998: --- Hi [~julianhyde], I just noticed that the MysqlDialect

[jira] [Commented] (CALCITE-1998) Hive - Version specific handling for NULLS FIRST/ NULLS LAST

2017-10-23 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16216032#comment-16216032 ] Julian Hyde commented on CALCITE-1998: -- Reviewing

[jira] [Commented] (CALCITE-1998) Hive - Version specific handling for NULLS FIRST/ NULLS LAST

2017-10-19 Thread Abbas Gadhia (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16211348#comment-16211348 ] Abbas Gadhia commented on CALCITE-1998: --- [~julianhyde] Yes. Will send across the recommended

[jira] [Commented] (CALCITE-1998) Hive - Version specific handling for NULLS FIRST/ NULLS LAST

2017-10-11 Thread Christian Beikov (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16200047#comment-16200047 ] Christian Beikov commented on CALCITE-1998: --- Looks nice, I added some comments to the PR. When

[jira] [Commented] (CALCITE-1998) Hive - Version specific handling for NULLS FIRST/ NULLS LAST

2017-10-11 Thread Abbas Gadhia (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16200023#comment-16200023 ] Abbas Gadhia commented on CALCITE-1998: --- I've made the optimization Julian recommended i.e the one

[jira] [Commented] (CALCITE-1998) Hive - Version specific handling for NULLS FIRST/ NULLS LAST

2017-10-06 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16194892#comment-16194892 ] Julian Hyde commented on CALCITE-1998: -- An observation about the emulateNullDirection (not this

[jira] [Commented] (CALCITE-1998) Hive - Version specific handling for NULLS FIRST/ NULLS LAST

2017-10-06 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16194855#comment-16194855 ] Julian Hyde commented on CALCITE-1998: -- You don't need to parse version strings. JDBC makes major

[jira] [Commented] (CALCITE-1998) Hive - Version specific handling for NULLS FIRST/ NULLS LAST

2017-10-06 Thread Abbas Gadhia (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16194502#comment-16194502 ] Abbas Gadhia commented on CALCITE-1998: --- {noformat} I don't think it's a good idea to put the

[jira] [Commented] (CALCITE-1998) Hive - Version specific handling for NULLS FIRST/ NULLS LAST

2017-10-06 Thread Christian Beikov (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16194276#comment-16194276 ] Christian Beikov commented on CALCITE-1998: --- I don't think it's a good idea to put the product