[
https://issues.apache.org/jira/browse/CALCITE-2302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16919078#comment-16919078
]
Julian Hyde commented on CALCITE-2302:
--
Thanks for your patience in getting this to completion,
[
https://issues.apache.org/jira/browse/CALCITE-2302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16918405#comment-16918405
]
Danny Chan commented on CALCITE-2302:
-
[~julianhyde] Thanks.
There seems to be 2 style type
[
https://issues.apache.org/jira/browse/CALCITE-2302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16917951#comment-16917951
]
Julian Hyde commented on CALCITE-2302:
--
[~danny0405] Do I understand correctly that after this
[
https://issues.apache.org/jira/browse/CALCITE-2302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16917850#comment-16917850
]
Stamatis Zampetakis commented on CALCITE-2302:
--
Hey Danny, this issue is going to have a
[
https://issues.apache.org/jira/browse/CALCITE-2302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16915414#comment-16915414
]
Danny Chan commented on CALCITE-2302:
-
[~julianhyde] Does the latest commit solve your review
[
https://issues.apache.org/jira/browse/CALCITE-2302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16914070#comment-16914070
]
Danny Chan commented on CALCITE-2302:
-
I have made the latest change in commit
[
https://issues.apache.org/jira/browse/CALCITE-2302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16913843#comment-16913843
]
Danny Chan commented on CALCITE-2302:
-
Thanks, [~julianhyde] I kind of agree with your point that
[
https://issues.apache.org/jira/browse/CALCITE-2302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16913576#comment-16913576
]
Julian Hyde commented on CALCITE-2302:
--
I just noticed that we have
[
https://issues.apache.org/jira/browse/CALCITE-2302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16912840#comment-16912840
]
Danny Chan commented on CALCITE-2302:
-
[~julianhyde] Does my reply answer your questions ? I'm
[
https://issues.apache.org/jira/browse/CALCITE-2302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16912839#comment-16912839
]
Danny Chan commented on CALCITE-2302:
-
For "9/2 returns 4.5", we indeed do the type coercion
[
https://issues.apache.org/jira/browse/CALCITE-2302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16911967#comment-16911967
]
Julian Hyde commented on CALCITE-2302:
--
[~danny0405] Not sure that the policy for deriving the
[
https://issues.apache.org/jira/browse/CALCITE-2302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16911987#comment-16911987
]
Danny Chan commented on CALCITE-2302:
-
[~julianhyde] Personally i propose to add this policy to
[
https://issues.apache.org/jira/browse/CALCITE-2302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16911921#comment-16911921
]
Haisheng Yuan commented on CALCITE-2302:
+1 on the patch, overall. Given the default behavior
[
https://issues.apache.org/jira/browse/CALCITE-2302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16910144#comment-16910144
]
Danny Chan commented on CALCITE-2302:
-
Thanks [~zabetak], most of the sql contexts that need
[
https://issues.apache.org/jira/browse/CALCITE-2302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16909601#comment-16909601
]
Stamatis Zampetakis commented on CALCITE-2302:
--
I think we agreed that it should be
[
https://issues.apache.org/jira/browse/CALCITE-2302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16908903#comment-16908903
]
Danny Chan commented on CALCITE-2302:
-
Thanks so much for your review [~hyuan] !
I have add a new
[
https://issues.apache.org/jira/browse/CALCITE-2302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16908576#comment-16908576
]
Haisheng Yuan commented on CALCITE-2302:
Let me repeat my comment here. My only concern is that
[
https://issues.apache.org/jira/browse/CALCITE-2302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16907122#comment-16907122
]
Stamatis Zampetakis commented on CALCITE-2302:
--
Hey [~hyuan], it seems that you reviewed
[
https://issues.apache.org/jira/browse/CALCITE-2302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16896156#comment-16896156
]
Danny Chan commented on CALCITE-2302:
-
Thanks, [~julianhyde], i have rebase the code again ~
>
[
https://issues.apache.org/jira/browse/CALCITE-2302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16895534#comment-16895534
]
Julian Hyde commented on CALCITE-2302:
--
Let's get this reviewed and into 1.21. It's a useful
[
https://issues.apache.org/jira/browse/CALCITE-2302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16497520#comment-16497520
]
Yuzhao Chen commented on CALCITE-2302:
--
Hi, committers, can you give me some suggestions? Our
[
https://issues.apache.org/jira/browse/CALCITE-2302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16495975#comment-16495975
]
Yuzhao Chen commented on CALCITE-2302:
--
Hi, [~julianhyde]
Can you give me some suggestions? I'm
[
https://issues.apache.org/jira/browse/CALCITE-2302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16494723#comment-16494723
]
Yuzhao Chen commented on CALCITE-2302:
--
hi, [~julianhyde]
I have made a PR here
[
https://issues.apache.org/jira/browse/CALCITE-2302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16466732#comment-16466732
]
Yuzhao Chen commented on CALCITE-2302:
--
Most common cases are:
# 1='1' comparison
# UDF/UDAF which
[
https://issues.apache.org/jira/browse/CALCITE-2302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16466270#comment-16466270
]
Julian Hyde commented on CALCITE-2302:
--
Calcite already does some implicit conversions. I agree we
25 matches
Mail list logo
