[jira] [Commented] (CALCITE-2712) Add rule to remove null-generating side of a Join

[ https://issues.apache.org/jira/browse/CALCITE-2712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16842299#comment-16842299 ] Chunwei Lei commented on CALCITE-2712: -- Fixed in  [https://github.com/apache/calci

[jira] [Commented] (CALCITE-2712) Add rule to remove null-generating side of a Join

[ https://issues.apache.org/jira/browse/CALCITE-2712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16841439#comment-16841439 ] Chunwei Lei commented on CALCITE-2712: -- Thank you very much for your review [~juli

[jira] [Commented] (CALCITE-2712) Add rule to remove null-generating side of a Join

[ https://issues.apache.org/jira/browse/CALCITE-2712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16832602#comment-16832602 ] Chunwei Lei commented on CALCITE-2712: -- [~julianhyde], [~hyuan] any other comments

[jira] [Commented] (CALCITE-2712) Add rule to remove null-generating side of a Join

[ https://issues.apache.org/jira/browse/CALCITE-2712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16822645#comment-16822645 ] Chunwei Lei commented on CALCITE-2712: -- [~julianhyde], thanks for your helpful com

[jira] [Commented] (CALCITE-2712) Add rule to remove null-generating side of a Join

[ https://issues.apache.org/jira/browse/CALCITE-2712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16822511#comment-16822511 ] Julian Hyde commented on CALCITE-2712: -- Thanks for the refactorings, and for addin

[jira] [Commented] (CALCITE-2712) Add rule to remove null-generating side of a Join

[ https://issues.apache.org/jira/browse/CALCITE-2712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16820900#comment-16820900 ] Julian Hyde commented on CALCITE-2712: -- Out of office today and tomorrow. I'll try

[jira] [Commented] (CALCITE-2712) Add rule to remove null-generating side of a Join

[ https://issues.apache.org/jira/browse/CALCITE-2712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16818852#comment-16818852 ] Chunwei Lei commented on CALCITE-2712: -- Thanks [~swtalbot]. [~julianhyde], do you

[jira] [Commented] (CALCITE-2712) Add rule to remove null-generating side of a Join

[ https://issues.apache.org/jira/browse/CALCITE-2712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16818076#comment-16818076 ] Steven Talbot commented on CALCITE-2712: Given [~julianhyde]'s correction of my

[jira] [Commented] (CALCITE-2712) Add rule to remove null-generating side of a Join

[ https://issues.apache.org/jira/browse/CALCITE-2712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16817576#comment-16817576 ] Chunwei Lei commented on CALCITE-2712: -- I updated the PR including: * Rename the

[jira] [Commented] (CALCITE-2712) Add rule to remove null-generating side of a Join

[ https://issues.apache.org/jira/browse/CALCITE-2712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16817507#comment-16817507 ] Chunwei Lei commented on CALCITE-2712: -- [~julianhyde], [~swtalbot] Many thanks for

[jira] [Commented] (CALCITE-2712) Add rule to remove null-generating side of a Join

[ https://issues.apache.org/jira/browse/CALCITE-2712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16816751#comment-16816751 ] Julian Hyde commented on CALCITE-2712: -- Tree-walks are not possible because in Vol

[jira] [Commented] (CALCITE-2712) Add rule to remove null-generating side of a Join

[ https://issues.apache.org/jira/browse/CALCITE-2712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16816646#comment-16816646 ] Steven Talbot commented on CALCITE-2712: Do we not also need a `ProjectJoinElim

[jira] [Commented] (CALCITE-2712) Add rule to remove null-generating side of a Join

[ https://issues.apache.org/jira/browse/CALCITE-2712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16816540#comment-16816540 ] Julian Hyde commented on CALCITE-2712: -- [~swtalbot], Can you please review. > Add

[jira] [Commented] (CALCITE-2712) Add rule to remove null-generating side of a Join

[ https://issues.apache.org/jira/browse/CALCITE-2712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16816538#comment-16816538 ] Julian Hyde commented on CALCITE-2712: -- Based on a quick review, looks good. I don

[jira] [Commented] (CALCITE-2712) Add rule to remove null-generating side of a Join

[ https://issues.apache.org/jira/browse/CALCITE-2712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16816369#comment-16816369 ] Chunwei Lei commented on CALCITE-2712: -- I opened a pull request: [https://github.c

[jira] [Commented] (CALCITE-2712) Add rule to remove null-generating side of a Join

[ https://issues.apache.org/jira/browse/CALCITE-2712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16800193#comment-16800193 ] Julian Hyde commented on CALCITE-2712: -- [~Chunwei Lei], Sure! > Add rule to remov

[jira] [Commented] (CALCITE-2712) Add rule to remove null-generating side of a Join

[ https://issues.apache.org/jira/browse/CALCITE-2712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16798660#comment-16798660 ] Chunwei Lei commented on CALCITE-2712: -- [~julianhyde] Can I take this one? > Add

[jira] [Commented] (CALCITE-2712) Add rule to remove null-generating side of a Join

[ https://issues.apache.org/jira/browse/CALCITE-2712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16701177#comment-16701177 ] Julian Hyde commented on CALCITE-2712: -- cc [~swtalbot] > Add rule to remove null-