[jira] [Commented] (CALCITE-2948) Complicated logical plan generated for in subquery with non-equi condition

2019-04-29 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16828945#comment-16828945 ] Danny Chan commented on CALCITE-2948: - {quote}We are not going to rewrite the rule and change the

[jira] [Commented] (CALCITE-2948) Complicated logical plan generated for in subquery with non-equi condition

2019-04-28 Thread Haisheng Yuan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1682#comment-1682 ] Haisheng Yuan commented on CALCITE-2948: My mistake, the plan is not incorrect. We are not

[jira] [Commented] (CALCITE-2948) Complicated logical plan generated for in subquery with non-equi condition

2019-04-28 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16828880#comment-16828880 ] Danny Chan commented on CALCITE-2948: - [~hyuan] {quote}Because the filter should comparing column

[jira] [Commented] (CALCITE-2948) Complicated logical plan generated for in subquery with non-equi condition

2019-04-28 Thread Haisheng Yuan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16828874#comment-16828874 ] Haisheng Yuan commented on CALCITE-2948: SubqueryRemoveRule transform correlated subquery to

[jira] [Commented] (CALCITE-2948) Complicated logical plan generated for in subquery with non-equi condition

2019-04-28 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16828872#comment-16828872 ] Danny Chan commented on CALCITE-2948: - [~hyuan] Thx for your review SubqueryRemoveRule and

[jira] [Commented] (CALCITE-2948) Complicated logical plan generated for in subquery with non-equi condition

2019-04-28 Thread Haisheng Yuan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16828858#comment-16828858 ] Haisheng Yuan commented on CALCITE-2948: The problem is that we always generate inner

[jira] [Commented] (CALCITE-2948) Complicated logical plan generated for in subquery with non-equi condition

2019-04-28 Thread Haisheng Yuan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16828857#comment-16828857 ] Haisheng Yuan commented on CALCITE-2948: Well, I found that the plan described in issue can

[jira] [Commented] (CALCITE-2948) Complicated logical plan generated for in subquery with non-equi condition

2019-04-28 Thread Haisheng Yuan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16828850#comment-16828850 ] Haisheng Yuan commented on CALCITE-2948: I think you have missed our last conversation that

[jira] [Commented] (CALCITE-2948) Complicated logical plan generated for in subquery with non-equi condition

2019-04-28 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16827891#comment-16827891 ] Danny Chan commented on CALCITE-2948: - [~hyuan], [~julianhyde] Instead of making a rule, i extend

[jira] [Commented] (CALCITE-2948) Complicated logical plan generated for in subquery with non-equi condition

2019-04-26 Thread Haisheng Yuan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16827429#comment-16827429 ] Haisheng Yuan commented on CALCITE-2948: I see your points. But I think we should not aim at

[jira] [Commented] (CALCITE-2948) Complicated logical plan generated for in subquery with non-equi condition

2019-04-26 Thread Haisheng Yuan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16827376#comment-16827376 ] Haisheng Yuan commented on CALCITE-2948: {quote} what kinds of 2 RelNodes are equavelent

[jira] [Commented] (CALCITE-2948) Complicated logical plan generated for in subquery with non-equi condition

2019-04-26 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16827371#comment-16827371 ] Danny Chan commented on CALCITE-2948: - [~hyuan] [~julianhyde] I also think a rule match is more

[jira] [Commented] (CALCITE-2948) Complicated logical plan generated for in subquery with non-equi condition

2019-04-26 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16827099#comment-16827099 ] Julian Hyde commented on CALCITE-2948: -- I agree with [~hyuan]. Transforming “x = y + 1” to “x - 1

[jira] [Commented] (CALCITE-2948) Complicated logical plan generated for in subquery with non-equi condition

2019-04-26 Thread Haisheng Yuan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16827084#comment-16827084 ] Haisheng Yuan commented on CALCITE-2948: [~danny0405] Let's first just focus on