[
https://issues.apache.org/jira/browse/CALCITE-3118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16861715#comment-16861715
]
Danny Chan commented on CALCITE-3118:
-
Okey, finally i believe this is a bug
For this case, it
[
https://issues.apache.org/jira/browse/CALCITE-3118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16859312#comment-16859312
]
Botong Huang commented on CALCITE-3118:
---
{quote}
Firstly you construct a RelNode tree like what
[
https://issues.apache.org/jira/browse/CALCITE-3118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16859078#comment-16859078
]
Danny Chan commented on CALCITE-3118:
-
I'm -1 on this fix.
Just like you said,
[
https://issues.apache.org/jira/browse/CALCITE-3118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16858702#comment-16858702
]
Vladimir Sitnikov commented on CALCITE-3118:
{quote}At least I hope you agree with the one
[
https://issues.apache.org/jira/browse/CALCITE-3118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16858699#comment-16858699
]
Botong Huang commented on CALCITE-3118:
---
bq. Or it might happen you could rewrite the test-case
[
https://issues.apache.org/jira/browse/CALCITE-3118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16858696#comment-16858696
]
Vladimir Sitnikov commented on CALCITE-3118:
I'm sorry I have no much time left here.
[
https://issues.apache.org/jira/browse/CALCITE-3118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16858693#comment-16858693
]
Botong Huang commented on CALCITE-3118:
---
bq. It is not wrong provided the children are identical
[
https://issues.apache.org/jira/browse/CALCITE-3118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16858683#comment-16858683
]
Vladimir Sitnikov commented on CALCITE-3118:
{quote}it is wrong to return a match with a
[
https://issues.apache.org/jira/browse/CALCITE-3118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16858653#comment-16858653
]
Botong Huang commented on CALCITE-3118:
---
Thanks [~danny0405] for reviewing! Having two relNodes
[
https://issues.apache.org/jira/browse/CALCITE-3118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16858325#comment-16858325
]
Danny Chan commented on CALCITE-3118:
-
I don't know why you make {{leftPhy}} and {{rightPhy}}
[
https://issues.apache.org/jira/browse/CALCITE-3118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16858178#comment-16858178
]
Botong Huang commented on CALCITE-3118:
---
Agree in general. But in this test case, the rule
[
https://issues.apache.org/jira/browse/CALCITE-3118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16858067#comment-16858067
]
Vladimir Sitnikov commented on CALCITE-3118:
[~botong], as far as I understand, there's
[
https://issues.apache.org/jira/browse/CALCITE-3118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16858053#comment-16858053
]
Botong Huang commented on CALCITE-3118:
---
Sure, supposedly this rule should only match once, with
[
https://issues.apache.org/jira/browse/CALCITE-3118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16858043#comment-16858043
]
Vladimir Sitnikov commented on CALCITE-3118:
[~botong],
I reverted the fix, and the test
[
https://issues.apache.org/jira/browse/CALCITE-3118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16858038#comment-16858038
]
Botong Huang commented on CALCITE-3118:
---
New version pushed, can you take another look and see if
[
https://issues.apache.org/jira/browse/CALCITE-3118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16858027#comment-16858027
]
Vladimir Sitnikov commented on CALCITE-3118:
{quote} is unit test required for this kind of
[
https://issues.apache.org/jira/browse/CALCITE-3118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16858020#comment-16858020
]
Botong Huang commented on CALCITE-3118:
---
Sure, let me try make the unit test more readable. On a
[
https://issues.apache.org/jira/browse/CALCITE-3118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16858005#comment-16858005
]
Vladimir Sitnikov commented on CALCITE-3118:
{quote} Without the one line fix, this assert
[
https://issues.apache.org/jira/browse/CALCITE-3118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16857997#comment-16857997
]
Botong Huang commented on CALCITE-3118:
---
Thanks [~vladimirsitnikov] for reviewing. The real check
[
https://issues.apache.org/jira/browse/CALCITE-3118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16857994#comment-16857994
]
Vladimir Sitnikov commented on CALCITE-3118:
Frankly speaking, I have scanned through the
20 matches
Mail list logo
