[jira] [Commented] (CALCITE-4559) Create 'interface RexRule', a modular rewrite for row-expressions

[ https://issues.apache.org/jira/browse/CALCITE-4559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17338811#comment-17338811 ] Vladimir Ozerov commented on CALCITE-4559: -- Makes sense, thank you for the clarification. >

[jira] [Commented] (CALCITE-4559) Create 'interface RexRule', a modular rewrite for row-expressions

[ https://issues.apache.org/jira/browse/CALCITE-4559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17325311#comment-17325311 ] Julian Hyde commented on CALCITE-4559: -- {quote}I would suggest defining a public pattern interface

[jira] [Commented] (CALCITE-4559) Create 'interface RexRule', a modular rewrite for row-expressions

[ https://issues.apache.org/jira/browse/CALCITE-4559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17324840#comment-17324840 ] Vladimir Ozerov commented on CALCITE-4559: -- [~julianhyde] [~hyuan], I propose to treat my

[jira] [Commented] (CALCITE-4559) Create 'interface RexRule', a modular rewrite for row-expressions

[ https://issues.apache.org/jira/browse/CALCITE-4559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17324758#comment-17324758 ] Julian Hyde commented on CALCITE-4559: -- [~vozerov], Expanding on [~hyuan]'s question: Can you give

[jira] [Commented] (CALCITE-4559) Create 'interface RexRule', a modular rewrite for row-expressions

[ https://issues.apache.org/jira/browse/CALCITE-4559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17324726#comment-17324726 ] Haisheng Yuan commented on CALCITE-4559: I agree with [~vozerov] that this is a great change,

[jira] [Commented] (CALCITE-4559) Create 'interface RexRule', a modular rewrite for row-expressions

[ https://issues.apache.org/jira/browse/CALCITE-4559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17324605#comment-17324605 ] Vladimir Ozerov commented on CALCITE-4559: -- The design looks great to me in general. I would

[jira] [Commented] (CALCITE-4559) Create 'interface RexRule', a modular rewrite for row-expressions

[ https://issues.apache.org/jira/browse/CALCITE-4559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17324379#comment-17324379 ] Danny Chen commented on CALCITE-4559: - > should it include NullAs NullAs simplification is a big

[jira] [Commented] (CALCITE-4559) Create 'interface RexRule', a modular rewrite for row-expressions

[ https://issues.apache.org/jira/browse/CALCITE-4559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17324339#comment-17324339 ] Julian Hyde commented on CALCITE-4559: -- I am not set on the interfaces of {{RelRule}} which build

[jira] [Commented] (CALCITE-4559) Create 'interface RexRule', a modular rewrite for row-expressions

[ https://issues.apache.org/jira/browse/CALCITE-4559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17324151#comment-17324151 ] Danny Chen commented on CALCITE-4559: - Thanks [~julianhyde] for this fantastic feature, i believe

[jira] [Commented] (CALCITE-4559) Create 'interface RexRule', a modular rewrite for row-expressions

[ https://issues.apache.org/jira/browse/CALCITE-4559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17324123#comment-17324123 ] Haisheng Yuan commented on CALCITE-4559: Thanks Julian for the proposal, I will take a look. >

[jira] [Commented] (CALCITE-4559) Create 'interface RexRule', a modular rewrite for row-expressions

[ https://issues.apache.org/jira/browse/CALCITE-4559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17323811#comment-17323811 ] Vladimir Ozerov commented on CALCITE-4559: -- I'll take a look on the weekend, thanks. > Create

[jira] [Commented] (CALCITE-4559) Create 'interface RexRule', a modular rewrite for row-expressions

[ https://issues.apache.org/jira/browse/CALCITE-4559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17322390#comment-17322390 ] Julian Hyde commented on CALCITE-4559: -- [~danny0405], [~zabetak], [~hyuan], [~vlsi], since you

[jira] [Commented] (CALCITE-4559) Create 'interface RexRule', a modular rewrite for row-expressions

[ https://issues.apache.org/jira/browse/CALCITE-4559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17317345#comment-17317345 ] Marieke Gueye commented on CALCITE-4559: [~julianhyde] definitely that makes sense > Create

[jira] [Commented] (CALCITE-4559) Create 'interface RexRule', a modular rewrite for row-expressions

[ https://issues.apache.org/jira/browse/CALCITE-4559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17317322#comment-17317322 ] Julian Hyde commented on CALCITE-4559: -- [~mkou], Thank you for adding those examples. They make

[jira] [Commented] (CALCITE-4559) Create 'interface RexRule', a modular rewrite for row-expressions

[ https://issues.apache.org/jira/browse/CALCITE-4559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17315881#comment-17315881 ] Marieke Gueye commented on CALCITE-4559: Hey Julian,  Here are some examples of rules I had in

[jira] [Commented] (CALCITE-4559) Create 'interface RexRule', a modular rewrite for row-expressions

[ https://issues.apache.org/jira/browse/CALCITE-4559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17311102#comment-17311102 ] James Starr commented on CALCITE-4559: -- Are these rex rules going to be able to handle rewriting

[jira] [Commented] (CALCITE-4559) Create 'interface RexRule', a modular rewrite for row-expressions

[ https://issues.apache.org/jira/browse/CALCITE-4559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17311080#comment-17311080 ] Julian Hyde commented on CALCITE-4559: -- In