[jira] [Commented] (CALCITE-5035) Define a rule of SortProjectPullUpConstantsRule to pull up constant's project under Sort

2022-03-10 Thread Xurenhe (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17504240#comment-17504240 ] Xurenhe commented on CALCITE-5035: -- I've been thinking this over and over recently Some sort elements

[jira] [Commented] (CALCITE-5035) Define a rule of SortProjectPullUpConstantsRule to pull up constant's project under Sort

2022-03-09 Thread Xurenhe (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17503424#comment-17503424 ] Xurenhe commented on CALCITE-5035: -- [~asolimando]  Thanks your reply. The related

[jira] [Commented] (CALCITE-5035) Define a rule of SortProjectPullUpConstantsRule to pull up constant's project under Sort

2022-03-09 Thread Alessandro Solimando (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17503417#comment-17503417 ] Alessandro Solimando commented on CALCITE-5035: --- I think that adding missing tests is

[jira] [Commented] (CALCITE-5035) Define a rule of SortProjectPullUpConstantsRule to pull up constant's project under Sort

2022-03-08 Thread Xurenhe (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17503285#comment-17503285 ] Xurenhe commented on CALCITE-5035: -- [~julianhyde]  Thanks for your reply. I try to rename this rule,

[jira] [Commented] (CALCITE-5035) Define a rule of SortProjectPullUpConstantsRule to pull up constant's project under Sort

2022-03-08 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17503132#comment-17503132 ] Julian Hyde commented on CALCITE-5035: -- Reviewing the PR: * Nice, clean, well-commented code. Well

[jira] [Commented] (CALCITE-5035) Define a rule of SortProjectPullUpConstantsRule to pull up constant's project under Sort

2022-03-08 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17503125#comment-17503125 ] Julian Hyde commented on CALCITE-5035: -- I'll repeat the comments I made on dev@ (which [~wojustme]