[ 
https://issues.apache.org/jira/browse/CALCITE-6098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17808152#comment-17808152
 ] 

Stamatis Zampetakis commented on CALCITE-6098:
----------------------------------------------

I compared the content of calcite, orc, and jekyll git repositories at those 
revisions that introduced the website content discussed here using the script 
in  [^fdupes_cross_repo.sh]. Given that I was not sure from which revision 
exactly was the copy made from the jekyll repository, I configured the script 
to check all those spanning ~2 months before the ORC website was first created 
(May 9, 2015). The results of the script are shown below:

{noformat}
    307 ./calcite/site/css/screen.scss ./orc/site/css/screen.scss 
./jekyll/site/css/screen.scss 
    307 ./calcite/site/fonts/fontawesome-webfont.eot 
./orc/site/fonts/fontawesome-webfont.eot 
./jekyll/site/fonts/fontawesome-webfont.eot 
    307 ./calcite/site/fonts/fontawesome-webfont.svg 
./orc/site/fonts/fontawesome-webfont.svg 
./jekyll/site/fonts/fontawesome-webfont.svg 
    307 ./calcite/site/fonts/fontawesome-webfont.ttf 
./orc/site/fonts/fontawesome-webfont.ttf 
./jekyll/site/fonts/fontawesome-webfont.ttf 
    307 ./calcite/site/fonts/fontawesome-webfont.woff 
./orc/site/fonts/fontawesome-webfont.woff 
./jekyll/site/fonts/fontawesome-webfont.woff 
    307 ./calcite/site/Gemfile ./orc/site/Gemfile 
    307 ./calcite/site/.gitignore ./orc/site/.gitignore 
    307 ./calcite/site/_includes/anchor_links.html 
./orc/site/_includes/anchor_links.html 
./jekyll/site/_includes/anchor_links.html 
    307 ./calcite/site/_includes/docs_contents.html 
./orc/site/_includes/docs_contents.html 
./jekyll/site/_includes/docs_contents.html 
    307 ./calcite/site/_includes/docs_contents_mobile.html 
./orc/site/_includes/docs_contents_mobile.html 
./jekyll/site/_includes/docs_contents_mobile.html 
    307 ./calcite/site/_includes/docs_ul.html ./orc/site/_includes/docs_ul.html 
    307 ./calcite/site/_includes/news_contents_mobile.html 
./orc/site/_includes/news_contents_mobile.html 
./jekyll/site/_includes/news_contents_mobile.html 
    307 ./calcite/site/_includes/primary-nav-items.html 
./orc/site/_includes/primary-nav-items.html 
    307 ./calcite/site/_includes/top.html ./orc/site/_includes/top.html 
    307 ./calcite/site/js/html5shiv.min.js ./orc/site/js/html5shiv.min.js 
./jekyll/site/js/html5shiv.min.js 
    307 ./calcite/site/js/respond.min.js ./orc/site/js/respond.min.js 
./jekyll/site/js/respond.min.js 
    307 ./calcite/site/_layouts/default.html ./orc/site/_layouts/default.html 
    305 ./calcite/site/_layouts/docs.html ./orc/site/_layouts/docs.html 
      2 ./calcite/site/_layouts/docs.html ./orc/site/_layouts/docs.html 
./jekyll/site/_layouts/docs.html 
    307 ./calcite/site/_layouts/news.html ./orc/site/_layouts/news.html 
./jekyll/site/_layouts/news.html 
    307 ./calcite/site/_layouts/page.html ./orc/site/_layouts/page.html 
./jekyll/site/_layouts/page.html 
    307 ./calcite/site/news/releases/index.html 
./orc/site/news/releases/index.html ./jekyll/site/news/releases/index.html 
      2 ./calcite/site/_sass/_font-awesome.scss 
./orc/site/_sass/_font-awesome.scss 
    305 ./calcite/site/_sass/_font-awesome.scss 
./orc/site/_sass/_font-awesome.scss ./jekyll/site/_sass/_font-awesome.scss 
    307 ./calcite/site/_sass/_gridism.scss ./orc/site/_sass/_gridism.scss 
./jekyll/site/_sass/_gridism.scss 
    307 ./calcite/site/_sass/_mixins.scss ./orc/site/_sass/_mixins.scss 
./jekyll/site/_sass/_mixins.scss 
    307 ./calcite/site/_sass/_normalize.scss ./orc/site/_sass/_normalize.scss 
./jekyll/site/_sass/_normalize.scss 
    307 ./calcite/site/_sass/_pygments.scss ./orc/site/_sass/_pygments.scss 
./jekyll/site/_sass/_pygments.scss 
    307 ./jekyll/test/source/_slides/octojekyll.png 
./jekyll/site/img/octojekyll.png 
    307 ./orc/site/_includes/docs_option.html 
./jekyll/site/_includes/docs_option.html 
    307 ./orc/site/_includes/news_item.html 
./jekyll/site/_includes/news_item.html
{noformat}
Observe that many files under _includes, _layouts, _sass, etc., are exact 
duplicates. Some files (e.g., such as header.html and footer.html) do not 
appear as duplicates because essentially the content was modified before 
committing to make sense for the Apache project.

My take from the above is that the Jekyll template was used for both ORC, and 
Calcite website so the files under the respective directories should be under 
MIT and this should be mentioned in the main LICENSE file.
I updated the current PR essentially attributing all template based files to 
Jekyll. There have been some extensions to the initial template but to avoid 
over-complicating the LICENSE and confusing our end-users I attributed 
everything under site/_includes, site/_layouts, site/_sass, and site/css to 
Jekyll.

I will leave the PR open for 72h in case someone wants to have a look and merge 
it afterwards.

[~omalley] since you created the ORC website you may find this discussion 
interesting. If you have any feedback please let us know.

> Update LICENSE and NOTICE for Jekyll website template
> -----------------------------------------------------
>
>                 Key: CALCITE-6098
>                 URL: https://issues.apache.org/jira/browse/CALCITE-6098
>             Project: Calcite
>          Issue Type: Task
>    Affects Versions: 1.36.0
>            Reporter: Stamatis Zampetakis
>            Assignee: Stamatis Zampetakis
>            Priority: Major
>              Labels: pull-request-available
>         Attachments: fdupes_cross_repo.sh
>
>
> The NOTICE file contains the following statement:
> {noformat}
> The web site includes files generated by Jekyll.{noformat}
>  
> However, there is nothing in the [LICENSE of Jekyll 
> |https://github.com/jekyll/jekyll/blob/3f3a283018a976da11a0bfcc13a20d43d37ee29f/LICENSE]
>  that requires such attribution. 
> According to the instructions of composing the [NOTICE 
> file|https://infra.apache.org/licensing-howto.html#mod-notice] for ASF 
> projects we shouldn't add anything in there that is not *legally* required.
> Moreover the generated files are not necessary licensed under the same 
> LICENSE with the generator. 
> JavaCC, ANTLR, and lots of other source generators use a variety of licenses 
> but the generated output is not licensed under the same terms. For instance, 
> Calcite uses JavaCC, which is licensed under 
> [BSD-3|https://github.com/javacc/javacc/blob/master/LICENSE]  but both the 
> grammar as well as the generated .java files are AL2.
> As long as we are not packaging bits of Jekyll in Calcite there is no need to 
> add explicit mentions in LICENSE or NOTICE files.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to