[jira] [Commented] (CALCITE-6193) If a query has more than one subexpression that matches a materialized view, only the first is substituted

2024-05-29 Thread Mou Wu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17850306#comment-17850306 ] Mou Wu commented on CALCITE-6193: - [~jduong] I have followed your review advices, can you review my PR

[jira] [Commented] (CALCITE-6193) If a query has more than one subexpression that matches a materialized view, only the first is substituted

2024-03-13 Thread Mou Wu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17825926#comment-17825926 ] Mou Wu commented on CALCITE-6193: - [~jiajunbernoulli] OK, can you review my PR again? we can check in

[jira] [Commented] (CALCITE-6193) If a query has more than one subexpression that matches a materialized view, only the first is substituted

2024-03-06 Thread Jiajun Xie (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17824257#comment-17824257 ] Jiajun Xie commented on CALCITE-6193: - I was worried about side effects that from your PR, so I

[jira] [Commented] (CALCITE-6193) If a query has more than one subexpression that matches a materialized view, only the first is substituted

2024-02-29 Thread Mou Wu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17822429#comment-17822429 ] Mou Wu commented on CALCITE-6193: - [~jiajunbernoulli] The reason of issue 1 is issue 2. It's still

[jira] [Commented] (CALCITE-6193) If a query has more than one subexpression that matches a materialized view, only the first is substituted

2024-02-29 Thread Jiajun Xie (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17822079#comment-17822079 ] Jiajun Xie commented on CALCITE-6193: - [~4wei] Your thinking is too one-sided.   There are two

[jira] [Commented] (CALCITE-6193) If a query has more than one subexpression that matches a materialized view, only the first is substituted

2024-02-28 Thread Mou Wu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821924#comment-17821924 ] Mou Wu commented on CALCITE-6193: - [~jiajunbernoulli] I don't think so, actually, the root cause of

[jira] [Commented] (CALCITE-6193) If a query has more than one subexpression that matches a materialized view, only the first is substituted

2024-02-28 Thread Jiajun Xie (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821912#comment-17821912 ] Jiajun Xie commented on CALCITE-6193: - [~4wei] , `undo` is another issue. Please create a new Jira

[jira] [Commented] (CALCITE-6193) If a query has more than one subexpression that matches a materialized view, only the first is substituted

2024-02-27 Thread Mou Wu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821502#comment-17821502 ] Mou Wu commented on CALCITE-6193: - [~jiajunbernoulli] I answered your question in your PR, and I

[jira] [Commented] (CALCITE-6193) If a query has more than one subexpression that matches a materialized view, only the first is substituted

2024-02-26 Thread Jiajun Xie (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17820966#comment-17820966 ] Jiajun Xie commented on CALCITE-6193: - [~4wei] , Can you answer my question in PR?

[jira] [Commented] (CALCITE-6193) If a query has more than one subexpression that matches a materialized view, only the first is substituted

2024-02-01 Thread Mou Wu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17813494#comment-17813494 ] Mou Wu commented on CALCITE-6193: - [~jiajunbernoulli] OK, I wonder whether there are any examples that

[jira] [Commented] (CALCITE-6193) If a query has more than one subexpression that matches a materialized view, only the first is substituted

2024-02-01 Thread Jiajun Xie (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17813203#comment-17813203 ] Jiajun Xie commented on CALCITE-6193: - BTW, [~4wei] Do you have benchmark for you PR? I would like

[jira] [Commented] (CALCITE-6193) If a query has more than one subexpression that matches a materialized view, only the first is substituted

2024-02-01 Thread Jiajun Xie (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17813202#comment-17813202 ] Jiajun Xie commented on CALCITE-6193: - [~4wei] Sorry, I don't have enough time to read your code.

[jira] [Commented] (CALCITE-6193) If a query has more than one subexpression that matches a materialized view, only the first is substituted

2024-01-31 Thread Mou Wu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17813016#comment-17813016 ] Mou Wu commented on CALCITE-6193: - [~jiajunbernoulli] Did you review my comments in your commit? > If

[jira] [Commented] (CALCITE-6193) If a query has more than one subexpression that matches a materialized view, only the first is substituted

2024-01-14 Thread Mou Wu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17806606#comment-17806606 ] Mou Wu commented on CALCITE-6193: - [~jiajunbernoulli] I reviewed your