[jira] [Commented] (CALCITE-3349) Add Function DDL into SqlKind DDL enum

2019-09-19 Thread Danny Chan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16933197#comment-16933197 ] Danny Chan commented on CALCITE-3349: - [~walterddr], there is no reason, it is just

[jira] [Commented] (CALCITE-1178) Allow SqlBetweenOperator to compare DATE and TIMESTAMP

2019-09-19 Thread Danny Chan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-1178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16933207#comment-16933207 ] Danny Chan commented on CALCITE-1178: - [~jacobroldan], yeah, you are right, 1.21 su

[jira] [Commented] (CALCITE-3354) RelToSqlConverter does not support LogicalTableFunctionScan

2019-09-19 Thread Danny Chan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16933211#comment-16933211 ] Danny Chan commented on CALCITE-3354: - Thanks for reporting [~anha], and welcome to

[jira] [Commented] (CALCITE-3349) Add Function DDL into SqlKind DDL enum

2019-09-19 Thread Danny Chan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16933213#comment-16933213 ] Danny Chan commented on CALCITE-3349: - Personally, i'm okey with this change, but i

[jira] [Commented] (CALCITE-3329) Implement osquery for OS adapter

2019-09-19 Thread Forward Xu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16933287#comment-16933287 ] Forward Xu commented on CALCITE-3329: - hi [~julianhyde]  thank you very much, is th

[jira] [Commented] (CALCITE-3224) New RexNode-to-Expression CodeGen Implementation

2019-09-19 Thread jin xing (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1691#comment-1691 ] jin xing commented on CALCITE-3224: --- When you san – – "For each RexNode, the visitor

[jira] [Commented] (CALCITE-3355) Deduce whether CASE and COALESCE may produce NULL values

2019-09-19 Thread Kirill Kozlov (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16933589#comment-16933589 ] Kirill Kozlov commented on CALCITE-3355: [~Chunwei Lei], thanks for volunteerin

[jira] [Updated] (CALCITE-3323) Handle arbitrary/unknown functions that have ordinary syntax

2019-09-19 Thread Ryan Fu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ryan Fu updated CALCITE-3323: - Description: Add a strategy where if a function has ordinary function syntax and we don't recognize it

[jira] [Commented] (CALCITE-3340) Make TUMBLE be accepted as an operand for "FROM TABLE()" in validator

2019-09-19 Thread Rui Wang (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16933642#comment-16933642 ] Rui Wang commented on CALCITE-3340: --- [~julianhyde] Regarding to one point you mentio

[jira] [Commented] (CALCITE-3353) ProjectJoinTransposeRule caused AssertionError when creating a new Join

2019-09-19 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16933854#comment-16933854 ] Haisheng Yuan commented on CALCITE-3353: [~jinxing6...@126.com] I agree with yo

[jira] [Comment Edited] (CALCITE-3352) ProjectToWindowRule sets wrong collation on generated Window

2019-09-19 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16933863#comment-16933863 ] Haisheng Yuan edited comment on CALCITE-3352 at 9/19/19 11:55 PM: ---

[jira] [Commented] (CALCITE-3352) ProjectToWindowRule sets wrong collation on generated Window

2019-09-19 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16933863#comment-16933863 ] Haisheng Yuan commented on CALCITE-3352: You mixing physical properties with lo

[jira] [Commented] (CALCITE-3350) Keep origin type for RexLiteral when deserialized from json string

2019-09-19 Thread Danny Chan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16933948#comment-16933948 ] Danny Chan commented on CALCITE-3350: - Personally i'm curious about why the origina

[jira] [Comment Edited] (CALCITE-3350) Keep origin type for RexLiteral when deserialized from json string

2019-09-19 Thread Danny Chan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16933948#comment-16933948 ] Danny Chan edited comment on CALCITE-3350 at 9/20/19 2:16 AM: ---

[jira] [Comment Edited] (CALCITE-3350) Keep origin type for RexLiteral when deserialized from json string

2019-09-19 Thread Danny Chan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16933948#comment-16933948 ] Danny Chan edited comment on CALCITE-3350 at 9/20/19 2:16 AM: ---

[jira] [Comment Edited] (CALCITE-3350) Keep origin type for RexLiteral when deserialized from json string

2019-09-19 Thread Danny Chan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16933948#comment-16933948 ] Danny Chan edited comment on CALCITE-3350 at 9/20/19 2:16 AM: ---

[jira] [Resolved] (CALCITE-3360) SqlValidator throws NEP for unregistered function without implicit type coercion

2019-09-19 Thread Danny Chan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan resolved CALCITE-3360. - Resolution: Fixed Fixed in [df3dc81|https://github.com/apache/calcite/commit/df3dc81f23166c15e

[jira] [Assigned] (CALCITE-3355) Deduce whether CASE and COALESCE may produce NULL values

2019-09-19 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chunwei Lei reassigned CALCITE-3355: Assignee: Chunwei Lei > Deduce whether CASE and COALESCE may produce NULL values > -

[jira] [Commented] (CALCITE-3360) SqlValidator throws NEP for unregistered function without implicit type coercion

2019-09-19 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16933971#comment-16933971 ] Chunwei Lei commented on CALCITE-3360: -- Just a little confused. What does {{NEP}} 

[jira] [Commented] (CALCITE-3355) Deduce whether CASE and COALESCE may produce NULL values

2019-09-19 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16933972#comment-16933972 ] Chunwei Lei commented on CALCITE-3355: -- Thanks, [~kirillkozlov]. I can assign this

[jira] [Updated] (CALCITE-3360) SqlValidator throws NPE for unregistered function without implicit type coercion

2019-09-19 Thread Danny Chan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan updated CALCITE-3360: Summary: SqlValidator throws NPE for unregistered function without implicit type coercion (was:

[jira] [Commented] (CALCITE-3360) SqlValidator throws NPE for unregistered function without implicit type coercion

2019-09-19 Thread Danny Chan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16934033#comment-16934033 ] Danny Chan commented on CALCITE-3360: - Oh, thanks for correct, [~Chunwei Lei] ! >

[jira] [Comment Edited] (CALCITE-3360) SqlValidator throws NPE for unregistered function without implicit type coercion

2019-09-19 Thread Danny Chan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16933953#comment-16933953 ] Danny Chan edited comment on CALCITE-3360 at 9/20/19 4:18 AM: ---

[jira] [Commented] (CALCITE-3224) New RexNode-to-Expression CodeGen Implementation

2019-09-19 Thread Feng Zhu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16934044#comment-16934044 ] Feng Zhu commented on CALCITE-3224: --- [~jinxing6...@126.com]Yeah, it is used to mark w

[jira] [Commented] (CALCITE-3353) ProjectJoinTransposeRule caused AssertionError when creating a new Join

2019-09-19 Thread Danny Chan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16934061#comment-16934061 ] Danny Chan commented on CALCITE-3353: - Maybe we should give out a list of the rules

[jira] [Commented] (CALCITE-3352) ProjectToWindowRule sets wrong collation on generated Window

2019-09-19 Thread Danny Chan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16934067#comment-16934067 ] Danny Chan commented on CALCITE-3352: - Indeed, but the ProjectToWindowRule can mat

[jira] [Commented] (CALCITE-3353) ProjectJoinTransposeRule caused AssertionError when creating a new Join

2019-09-19 Thread Stamatis Zampetakis (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16934110#comment-16934110 ] Stamatis Zampetakis commented on CALCITE-3353: -- I agree that some rules do

[jira] [Commented] (CALCITE-3353) ProjectJoinTransposeRule caused AssertionError when creating a new Join

2019-09-19 Thread Danny Chan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16934134#comment-16934134 ] Danny Chan commented on CALCITE-3353: - Thanks [~zabetak], i kind of disagree with y