[jira] [Commented] (CALCITE-4352) RelBuilder/RexSimplify/Sarg incorrectly transforms complex expressions with IS NULL/IS NOT NULL

2020-10-27 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17221679#comment-17221679 ] Julian Hyde commented on CALCITE-4352: -- Thanks for checking, [~aigor]. >

[jira] [Commented] (CALCITE-4360) Apply SubstitutionRule first in top-down driven rule apply

2020-10-27 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17221667#comment-17221667 ] Julian Hyde commented on CALCITE-4360: -- Do you have a test case that justifies your assertion? >

[jira] [Commented] (CALCITE-4354) ITEM operator does not support synthetic struct type

2020-10-27 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17221692#comment-17221692 ] Julian Hyde commented on CALCITE-4354: -- Makes sense: * Please update reference.md. * Is the index

[jira] [Commented] (CALCITE-4352) RelBuilder/RexSimplify/Sarg incorrectly transforms complex expressions with IS NULL/IS NOT NULL

2020-10-27 Thread Igor Lozynskyi (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17221661#comment-17221661 ] Igor Lozynskyi commented on CALCITE-4352: - [~julianhyde], I executed our test suites over your

[jira] [Commented] (CALCITE-4345) SUM CASE WHEN xxx THEN 1 without "ELSE" throws NPE in AggregateCaseToFilterRule

2020-10-27 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17221671#comment-17221671 ] Julian Hyde commented on CALCITE-4345: -- We have been going round and round discussing whether a

[jira] [Commented] (CALCITE-4354) ITEM operator does not support synthetic struct type

2020-10-27 Thread Danny Chen (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17221917#comment-17221917 ] Danny Chen commented on CALCITE-4354: - I tried this SQL in PostgreSQL 9.6 {code:sql} create table

[jira] [Comment Edited] (CALCITE-4354) ITEM operator does not support synthetic struct type

2020-10-27 Thread Danny Chen (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17221917#comment-17221917 ] Danny Chen edited comment on CALCITE-4354 at 10/28/20, 2:42 AM: I tried

[jira] [Commented] (CALCITE-4345) SUM CASE WHEN xxx THEN 1 without "ELSE" throws NPE in AggregateCaseToFilterRule

2020-10-27 Thread Jiatao Tao (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17221911#comment-17221911 ] Jiatao Tao commented on CALCITE-4345: - Sure~ > SUM CASE WHEN xxx THEN 1 without "ELSE" throws NPE

[jira] [Commented] (CALCITE-4360) Apply SubstitutionRule first in top-down driven rule apply

2020-10-27 Thread Jinpeng Wu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17221928#comment-17221928 ] Jinpeng Wu commented on CALCITE-4360: - Yes. This should be a typo of previous commit. Thanks for

[jira] [Commented] (CALCITE-4358) Potential memory leak in VolcanoPlanner#materializations due to circular reference

2020-10-27 Thread Jiatao Tao (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17221909#comment-17221909 ] Jiatao Tao commented on CALCITE-4358: - [~zabetak] In fact, no, the RelOptMaterialization is only

[jira] [Comment Edited] (CALCITE-4345) SUM CASE WHEN xxx THEN 1 without "ELSE" throws NPE in AggregateCaseToFilterRule

2020-10-27 Thread Jiatao Tao (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17221362#comment-17221362 ] Jiatao Tao edited comment on CALCITE-4345 at 10/27/20, 12:12 PM: -

[jira] [Commented] (CALCITE-4345) SUM CASE WHEN xxx THEN 1 without "ELSE" throws NPE in AggregateCaseToFilterRule

2020-10-27 Thread Jiatao Tao (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17221362#comment-17221362 ] Jiatao Tao commented on CALCITE-4345: - As I said in PR: If we think "null" is not a reasonable

[jira] [Commented] (CALCITE-4358) Potential memory leak in VolcanoPlanner#materializations due to circular reference

2020-10-27 Thread Stamatis Zampetakis (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17221377#comment-17221377 ] Stamatis Zampetakis commented on CALCITE-4358: -- One question is do you keep

[jira] [Created] (CALCITE-4358) Potential memory leak in VolcanoPlanner#materializations due to circular reference

2020-10-27 Thread Jiatao Tao (Jira)
Jiatao Tao created CALCITE-4358: --- Summary: Potential memory leak in VolcanoPlanner#materializations due to circular reference Key: CALCITE-4358 URL: https://issues.apache.org/jira/browse/CALCITE-4358

[jira] [Commented] (CALCITE-4354) ITEM operator does not support synthetic struct type

2020-10-27 Thread Stamatis Zampetakis (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17221365#comment-17221365 ] Stamatis Zampetakis commented on CALCITE-4354: -- I think the change makes sense. I left

[jira] [Commented] (CALCITE-4354) ITEM operator does not support synthetic struct type

2020-10-27 Thread Danny Chen (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17221216#comment-17221216 ] Danny Chen commented on CALCITE-4354: - I'm fine with the change. What do you think [~zabetak] and

[jira] [Updated] (CALCITE-4360) Should apply SubstituteRule first in top-down driven rule apply

2020-10-27 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chunwei Lei updated CALCITE-4360: - Description: In the current implementation, TopDownRuleQueue adds substitute rules in the end

[jira] [Created] (CALCITE-4359) EnumerableProject.create didn't consider input's traitSet

2020-10-27 Thread Jiatao Tao (Jira)
Jiatao Tao created CALCITE-4359: --- Summary: EnumerableProject.create didn't consider input's traitSet Key: CALCITE-4359 URL: https://issues.apache.org/jira/browse/CALCITE-4359 Project: Calcite

[jira] [Commented] (CALCITE-4359) EnumerableProject.create didn't consider input's traitSet

2020-10-27 Thread Jiatao Tao (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17221421#comment-17221421 ] Jiatao Tao commented on CALCITE-4359: - Seems not an issue, close this one. >

[jira] [Closed] (CALCITE-4359) EnumerableProject.create didn't consider input's traitSet

2020-10-27 Thread Jiatao Tao (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiatao Tao closed CALCITE-4359. --- Resolution: Not A Problem > EnumerableProject.create didn't consider input's traitSet >

[jira] [Created] (CALCITE-4360) Should apply SubstituteRule first in top-down driven rule apply

2020-10-27 Thread Chunwei Lei (Jira)
Chunwei Lei created CALCITE-4360: Summary: Should apply SubstituteRule first in top-down driven rule apply Key: CALCITE-4360 URL: https://issues.apache.org/jira/browse/CALCITE-4360 Project: Calcite

[jira] [Updated] (CALCITE-4360) Should apply SubstitutionRule first in top-down driven rule apply

2020-10-27 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chunwei Lei updated CALCITE-4360: - Summary: Should apply SubstitutionRule first in top-down driven rule apply (was: Should apply

[jira] [Updated] (CALCITE-4360) Should apply SubstitutionRule first in top-down driven rule apply

2020-10-27 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chunwei Lei updated CALCITE-4360: - Description: In the current implementation, TopDownRuleQueue adds substitute rules in the end

[jira] [Updated] (CALCITE-4360) Apply SubstitutionRule first in top-down driven rule apply

2020-10-27 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chunwei Lei updated CALCITE-4360: - Summary: Apply SubstitutionRule first in top-down driven rule apply (was: Should apply

[jira] [Updated] (CALCITE-4360) Apply SubstitutionRule first in top-down driven rule apply

2020-10-27 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated CALCITE-4360: Labels: pull-request-available (was: ) > Apply SubstitutionRule first in top-down