[jira] [Commented] (CALCITE-994) Calcite development under Eclipse IDE
[
https://issues.apache.org/jira/browse/CALCITE-994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15041472#comment-15041472
]
Alexander Reshetov commented on CALCITE-994:
When I try "mvn checkstyle:checkstyle" in console, I got Checkstyle errors too.
{code}
mvn checkstyle:checkstyle
[INFO] Scanning for projects...
[INFO]
[INFO] Reactor Build Order:
[INFO]
[INFO] Calcite
[INFO] Calcite Avatica
[INFO] Calcite Avatica Server
[INFO] Calcite Linq4j
[INFO] Calcite Core
[INFO] Calcite Examples
[INFO] Calcite Example CSV
[INFO] Calcite Example Function
[INFO] Calcite MongoDB
[INFO] Calcite Piglet
[INFO] Calcite Plus
[INFO] Calcite Spark
[INFO] Calcite Splunk
[INFO] Calcite Ubenchmark
[INFO]
[INFO]
[INFO] Building Calcite 1.6.0-SNAPSHOT
[INFO]
[INFO]
[INFO] --- maven-checkstyle-plugin:2.12.1:checkstyle (default-cli) @ calcite ---
[INFO]
[INFO]
[INFO] Building Calcite Avatica 1.6.0-SNAPSHOT
[INFO]
[INFO]
[INFO] --- maven-checkstyle-plugin:2.12.1:checkstyle (default-cli) @
calcite-avatica ---
[INFO]
[INFO] There are 24113 checkstyle errors.
[WARNING] Unable to locate Source XRef to link to - DISABLED
[INFO]
[INFO]
[INFO] Building Calcite Avatica Server 1.6.0-SNAPSHOT
[INFO]
[INFO]
[INFO] --- maven-checkstyle-plugin:2.12.1:checkstyle (default-cli) @
calcite-avatica-server ---
[INFO]
[INFO] There are 620 checkstyle errors.
[WARNING] Unable to locate Source XRef to link to - DISABLED
[INFO]
[INFO]
[INFO] Building Calcite Linq4j 1.6.0-SNAPSHOT
[INFO]
[INFO]
[INFO] --- maven-checkstyle-plugin:2.12.1:checkstyle (default-cli) @
calcite-linq4j ---
[INFO]
[INFO] There are 8547 checkstyle errors.
[WARNING] Unable to locate Source XRef to link to - DISABLED
[INFO]
[INFO]
[INFO] Building Calcite Core 1.6.0-SNAPSHOT
[INFO]
[INFO]
[INFO] --- maven-checkstyle-plugin:2.12.1:checkstyle (default-cli) @
calcite-core ---
[INFO]
[INFO] There are 35183 checkstyle errors.
[WARNING] Unable to locate Source XRef to link to - DISABLED
[INFO]
[INFO]
[INFO] Building Calcite Examples 1.6.0-SNAPSHOT
[INFO]
[INFO]
[INFO] --- maven-checkstyle-plugin:2.12.1:checkstyle (default-cli) @
calcite-example ---
[INFO]
[INFO]
[INFO] Building Calcite Example CSV 1.6.0-SNAPSHOT
[INFO]
[INFO]
[INFO] --- maven-checkstyle-plugin:2.12.1:checkstyle (default-cli) @
calcite-example-csv ---
[INFO]
[INFO] There are 241 checkstyle errors.
[WARNING] Unable to locate Source XRef to link to - DISABLED
[INFO]
[INFO]
[INFO] Building Calcite Example Function 1.6.0-SNAPSHOT
[INFO]
[INFO]
[INFO] --- maven-checkstyle-plugin:2.12.1:checkstyle (default-cli) @
calcite-example-function ---
[INFO]
[INFO] There are 92 checkstyle errors.
[WARNING] Unable to locate Source XRef to link to - DISABLED
[INFO]
[INFO]
[INFO] Building Calcite MongoDB 1.6.0-SNAPSHOT
[INFO]
[INFO]
[INFO] --- maven-checkstyle-plugin:2.12.1:checkstyle (default-cli) @
calcite-mongodb ---
[INFO]
[INFO] There
[jira] [Commented] (CALCITE-994) Calcite development under Eclipse IDE
[ https://issues.apache.org/jira/browse/CALCITE-994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15041826#comment-15041826 ] Josh Elser commented on CALCITE-994: [~areshetov], that is curious. I wonder why that isn't getting picked up. We might need to lift the configuration for the maven-checkstyle-plugin from the execution to the plugin itself for manual invocation of the goal to work as expected. Does that make sense? > Calcite development under Eclipse IDE > - > > Key: CALCITE-994 > URL: https://issues.apache.org/jira/browse/CALCITE-994 > Project: Calcite > Issue Type: Improvement > Components: site >Reporter: Alexander Reshetov >Assignee: Julian Hyde >Priority: Minor > Attachments: lifecycle-mapping-metadata.xml > > > After "git clone" project could not be imported in Eclipse as existing Maven > project. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CALCITE-1005) NullPointerException in RelMdMaxRowCount
[ https://issues.apache.org/jira/browse/CALCITE-1005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15041703#comment-15041703 ] Mike Hinchey commented on CALCITE-1005: --- I have a fix, though I couldn't reproduce within a calcite test: https://github.com/apache/calcite/pull/173 > NullPointerException in RelMdMaxRowCount > > > Key: CALCITE-1005 > URL: https://issues.apache.org/jira/browse/CALCITE-1005 > Project: Calcite > Issue Type: Bug > Components: core >Affects Versions: 1.6.0 >Reporter: Mike Hinchey >Assignee: Julian Hyde > > After commit 24b0747 for CALCITE-987, I get an error from a test in my own > project, but the test is all copied from calcite. > The query is this: > with > t1(x) as (select * from (values 1,2, case when 1 = 1 then null else 3 end)), > t2(x) as (select * from (values 1,case when 1 = 1 then null else 3 end)) > select * > from t1 > where t1.x not in (select t2.x from t2); > I took that from core/src/test/resources/sql/subquery.oq, and I'm running > with the CsvSchemaFactory and TRANSLATABLE. > Abbreviated stacktrace (most of it is reflection noise): > ... > at > org.apache.calcite.rel.metadata.RelMetadataQuery.getRowCount(RelMetadataQuery.java:86) > at org.apache.calcite.plan.hep.HepPlanner.dumpGraph(HepPlanner.java:958) > at > org.apache.calcite.plan.hep.HepPlanner.applyTransformationResults(HepPlanner.java:723) > at org.apache.calcite.plan.hep.HepPlanner.applyRule(HepPlanner.java:518) > at > org.apache.calcite.plan.hep.HepPlanner.applyRules(HepPlanner.java:392) > at > org.apache.calcite.plan.hep.HepPlanner.executeInstruction(HepPlanner.java:255) > at > org.apache.calcite.plan.hep.HepInstruction$RuleInstance.execute(HepInstruction.java:125) > at > org.apache.calcite.plan.hep.HepPlanner.executeProgram(HepPlanner.java:207) > at > org.apache.calcite.plan.hep.HepPlanner.findBestExp(HepPlanner.java:194) > ... more > at > org.apache.calcite.rel.metadata.RelMetadataQuery.getRowCount(RelMetadataQuery.java:86) > at > org.apache.calcite.rel.core.Filter.estimateFilteredRows(Filter.java:156) > at > org.apache.calcite.rel.core.Filter.estimateFilteredRows(Filter.java:150) > at org.apache.calcite.rel.core.Calc.getRows(Calc.java:135) > at > org.apache.calcite.rel.metadata.RelMdRowCount.getRowCount(RelMdRowCount.java:144) > ... 50 more > at > org.apache.calcite.rel.metadata.RelMetadataQuery.getMaxRowCount(RelMetadataQuery.java:101) > at > org.apache.calcite.rel.metadata.RelMdUtil.getJoinRowCount(RelMdUtil.java:705) > at org.apache.calcite.rel.core.Join.getRows(Join.java:175) > at > org.apache.calcite.rel.metadata.RelMdRowCount.getRowCount(RelMdRowCount.java:144) > ... 90 more > at > org.apache.calcite.rel.metadata.RelMetadataQuery.getMaxRowCount(RelMetadataQuery.java:101) > at > org.apache.calcite.rel.metadata.RelMdMaxRowCount.getMaxRowCount(RelMdMaxRowCount.java:108) > ... 105 more > Caused by: java.lang.NullPointerException > at > org.apache.calcite.rel.metadata.RelMdMaxRowCount.getMaxRowCount(RelMdMaxRowCount.java:102) > ... 125 more -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (CALCITE-1007) Transitive Inference on Join Condition is not type safe
Laljo John Pullokkaran created CALCITE-1007: --- Summary: Transitive Inference on Join Condition is not type safe Key: CALCITE-1007 URL: https://issues.apache.org/jira/browse/CALCITE-1007 Project: Calcite Issue Type: Bug Components: core Affects Versions: 1.5.0 Reporter: Laljo John Pullokkaran Assignee: Laljo John Pullokkaran select * from (select 1 as x from t1) t1 join (select stroll as x from t2)t2 join t1.x=t2.x; While transferring x=1 from t1 to t2, we don't use the correct type for 'x' on t2. This could result in data correctness. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (CALCITE-1005) NullPointerException in getMaxRowCount for Aggregate
[ https://issues.apache.org/jira/browse/CALCITE-1005?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Hyde resolved CALCITE-1005. -- Resolution: Fixed Fix Version/s: 1.6.0 Fixed in http://git-wip-us.apache.org/repos/asf/calcite/commit/b0fa9f37. Thanks for the PR, [~mikehinchey]! > NullPointerException in getMaxRowCount for Aggregate > > > Key: CALCITE-1005 > URL: https://issues.apache.org/jira/browse/CALCITE-1005 > Project: Calcite > Issue Type: Bug > Components: core >Affects Versions: 1.6.0 >Reporter: Mike Hinchey >Assignee: Julian Hyde > Fix For: 1.6.0 > > > After commit 24b0747 for CALCITE-987, I get an error from a test in my own > project, but the test is all copied from calcite. > The query is this: > with > t1(x) as (select * from (values 1,2, case when 1 = 1 then null else 3 end)), > t2(x) as (select * from (values 1,case when 1 = 1 then null else 3 end)) > select * > from t1 > where t1.x not in (select t2.x from t2); > I took that from core/src/test/resources/sql/subquery.oq, and I'm running > with the CsvSchemaFactory and TRANSLATABLE. > Abbreviated stacktrace (most of it is reflection noise): > ... > at > org.apache.calcite.rel.metadata.RelMetadataQuery.getRowCount(RelMetadataQuery.java:86) > at org.apache.calcite.plan.hep.HepPlanner.dumpGraph(HepPlanner.java:958) > at > org.apache.calcite.plan.hep.HepPlanner.applyTransformationResults(HepPlanner.java:723) > at org.apache.calcite.plan.hep.HepPlanner.applyRule(HepPlanner.java:518) > at > org.apache.calcite.plan.hep.HepPlanner.applyRules(HepPlanner.java:392) > at > org.apache.calcite.plan.hep.HepPlanner.executeInstruction(HepPlanner.java:255) > at > org.apache.calcite.plan.hep.HepInstruction$RuleInstance.execute(HepInstruction.java:125) > at > org.apache.calcite.plan.hep.HepPlanner.executeProgram(HepPlanner.java:207) > at > org.apache.calcite.plan.hep.HepPlanner.findBestExp(HepPlanner.java:194) > ... more > at > org.apache.calcite.rel.metadata.RelMetadataQuery.getRowCount(RelMetadataQuery.java:86) > at > org.apache.calcite.rel.core.Filter.estimateFilteredRows(Filter.java:156) > at > org.apache.calcite.rel.core.Filter.estimateFilteredRows(Filter.java:150) > at org.apache.calcite.rel.core.Calc.getRows(Calc.java:135) > at > org.apache.calcite.rel.metadata.RelMdRowCount.getRowCount(RelMdRowCount.java:144) > ... 50 more > at > org.apache.calcite.rel.metadata.RelMetadataQuery.getMaxRowCount(RelMetadataQuery.java:101) > at > org.apache.calcite.rel.metadata.RelMdUtil.getJoinRowCount(RelMdUtil.java:705) > at org.apache.calcite.rel.core.Join.getRows(Join.java:175) > at > org.apache.calcite.rel.metadata.RelMdRowCount.getRowCount(RelMdRowCount.java:144) > ... 90 more > at > org.apache.calcite.rel.metadata.RelMetadataQuery.getMaxRowCount(RelMetadataQuery.java:101) > at > org.apache.calcite.rel.metadata.RelMdMaxRowCount.getMaxRowCount(RelMdMaxRowCount.java:108) > ... 105 more > Caused by: java.lang.NullPointerException > at > org.apache.calcite.rel.metadata.RelMdMaxRowCount.getMaxRowCount(RelMdMaxRowCount.java:102) > ... 125 more -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CALCITE-992) Validate and resolve sequence reference as a Table object
[ https://issues.apache.org/jira/browse/CALCITE-992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15042632#comment-15042632 ] Maryann Xue commented on CALCITE-992: - Thank you, [~julianhyde], for making the changes! Yes, the THREAD_LOCAL object does exactly what is needed, with the help of the "to string" and "from string" for qualified names. I have some minor questions, which I have posted on the pull request. > Validate and resolve sequence reference as a Table object > - > > Key: CALCITE-992 > URL: https://issues.apache.org/jira/browse/CALCITE-992 > Project: Calcite > Issue Type: Sub-task >Reporter: Maryann Xue >Assignee: Maryann Xue > Fix For: 1.6.0 > > Attachments: CALCITE-992.suggested.diff > > > Currently the validator does not validate if the sequence exists or if the > corresponding table is of the required type, etc. Also, in NEXT_VALUE and > CURRENT_VALUE function, we need the sequence Table object instead of the > sequence name string. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (CALCITE-993) Predicate Pull up above Project enhancement
[
https://issues.apache.org/jira/browse/CALCITE-993?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julian Hyde resolved CALCITE-993.
-
Resolution: Fixed
Fix Version/s: 1.6.0
Fixed in http://git-wip-us.apache.org/repos/asf/calcite/commit/9be2bdb9, with
some clean up in http://git-wip-us.apache.org/repos/asf/calcite/commit/8281668f.
> Predicate Pull up above Project enhancement
> ---
>
> Key: CALCITE-993
> URL: https://issues.apache.org/jira/browse/CALCITE-993
> Project: Calcite
> Issue Type: Bug
> Components: core
>Affects Versions: 1.5.0
>Reporter: Laljo John Pullokkaran
>Assignee: Laljo John Pullokkaran
> Fix For: 1.6.0
>
>
> Predicate Pull up on Project can also pull up deterministic functions whose
> arguments are all literals.
> Ex: select r1.x from (select cast('10' as int) as x, y from r1 where y<10)r1
> join r2 on r1.x=r2.x;
> Currently deterministic functions involving constants are ignored which
> results in missed transitive inference.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (CALCITE-1005) NullPointerException in getMaxRowCount for Aggregate
[ https://issues.apache.org/jira/browse/CALCITE-1005?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Hyde updated CALCITE-1005: - Summary: NullPointerException in getMaxRowCount for Aggregate (was: NullPointerException in RelMdMaxRowCount) > NullPointerException in getMaxRowCount for Aggregate > > > Key: CALCITE-1005 > URL: https://issues.apache.org/jira/browse/CALCITE-1005 > Project: Calcite > Issue Type: Bug > Components: core >Affects Versions: 1.6.0 >Reporter: Mike Hinchey >Assignee: Julian Hyde > > After commit 24b0747 for CALCITE-987, I get an error from a test in my own > project, but the test is all copied from calcite. > The query is this: > with > t1(x) as (select * from (values 1,2, case when 1 = 1 then null else 3 end)), > t2(x) as (select * from (values 1,case when 1 = 1 then null else 3 end)) > select * > from t1 > where t1.x not in (select t2.x from t2); > I took that from core/src/test/resources/sql/subquery.oq, and I'm running > with the CsvSchemaFactory and TRANSLATABLE. > Abbreviated stacktrace (most of it is reflection noise): > ... > at > org.apache.calcite.rel.metadata.RelMetadataQuery.getRowCount(RelMetadataQuery.java:86) > at org.apache.calcite.plan.hep.HepPlanner.dumpGraph(HepPlanner.java:958) > at > org.apache.calcite.plan.hep.HepPlanner.applyTransformationResults(HepPlanner.java:723) > at org.apache.calcite.plan.hep.HepPlanner.applyRule(HepPlanner.java:518) > at > org.apache.calcite.plan.hep.HepPlanner.applyRules(HepPlanner.java:392) > at > org.apache.calcite.plan.hep.HepPlanner.executeInstruction(HepPlanner.java:255) > at > org.apache.calcite.plan.hep.HepInstruction$RuleInstance.execute(HepInstruction.java:125) > at > org.apache.calcite.plan.hep.HepPlanner.executeProgram(HepPlanner.java:207) > at > org.apache.calcite.plan.hep.HepPlanner.findBestExp(HepPlanner.java:194) > ... more > at > org.apache.calcite.rel.metadata.RelMetadataQuery.getRowCount(RelMetadataQuery.java:86) > at > org.apache.calcite.rel.core.Filter.estimateFilteredRows(Filter.java:156) > at > org.apache.calcite.rel.core.Filter.estimateFilteredRows(Filter.java:150) > at org.apache.calcite.rel.core.Calc.getRows(Calc.java:135) > at > org.apache.calcite.rel.metadata.RelMdRowCount.getRowCount(RelMdRowCount.java:144) > ... 50 more > at > org.apache.calcite.rel.metadata.RelMetadataQuery.getMaxRowCount(RelMetadataQuery.java:101) > at > org.apache.calcite.rel.metadata.RelMdUtil.getJoinRowCount(RelMdUtil.java:705) > at org.apache.calcite.rel.core.Join.getRows(Join.java:175) > at > org.apache.calcite.rel.metadata.RelMdRowCount.getRowCount(RelMdRowCount.java:144) > ... 90 more > at > org.apache.calcite.rel.metadata.RelMetadataQuery.getMaxRowCount(RelMetadataQuery.java:101) > at > org.apache.calcite.rel.metadata.RelMdMaxRowCount.getMaxRowCount(RelMdMaxRowCount.java:108) > ... 105 more > Caused by: java.lang.NullPointerException > at > org.apache.calcite.rel.metadata.RelMdMaxRowCount.getMaxRowCount(RelMdMaxRowCount.java:102) > ... 125 more -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CALCITE-1005) NullPointerException in RelMdMaxRowCount
[ https://issues.apache.org/jira/browse/CALCITE-1005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15042010#comment-15042010 ] Julian Hyde commented on CALCITE-1005: -- We're OK without a test case for this one. Your change is clearly an improvement. Will commit after tests pass. > NullPointerException in RelMdMaxRowCount > > > Key: CALCITE-1005 > URL: https://issues.apache.org/jira/browse/CALCITE-1005 > Project: Calcite > Issue Type: Bug > Components: core >Affects Versions: 1.6.0 >Reporter: Mike Hinchey >Assignee: Julian Hyde > > After commit 24b0747 for CALCITE-987, I get an error from a test in my own > project, but the test is all copied from calcite. > The query is this: > with > t1(x) as (select * from (values 1,2, case when 1 = 1 then null else 3 end)), > t2(x) as (select * from (values 1,case when 1 = 1 then null else 3 end)) > select * > from t1 > where t1.x not in (select t2.x from t2); > I took that from core/src/test/resources/sql/subquery.oq, and I'm running > with the CsvSchemaFactory and TRANSLATABLE. > Abbreviated stacktrace (most of it is reflection noise): > ... > at > org.apache.calcite.rel.metadata.RelMetadataQuery.getRowCount(RelMetadataQuery.java:86) > at org.apache.calcite.plan.hep.HepPlanner.dumpGraph(HepPlanner.java:958) > at > org.apache.calcite.plan.hep.HepPlanner.applyTransformationResults(HepPlanner.java:723) > at org.apache.calcite.plan.hep.HepPlanner.applyRule(HepPlanner.java:518) > at > org.apache.calcite.plan.hep.HepPlanner.applyRules(HepPlanner.java:392) > at > org.apache.calcite.plan.hep.HepPlanner.executeInstruction(HepPlanner.java:255) > at > org.apache.calcite.plan.hep.HepInstruction$RuleInstance.execute(HepInstruction.java:125) > at > org.apache.calcite.plan.hep.HepPlanner.executeProgram(HepPlanner.java:207) > at > org.apache.calcite.plan.hep.HepPlanner.findBestExp(HepPlanner.java:194) > ... more > at > org.apache.calcite.rel.metadata.RelMetadataQuery.getRowCount(RelMetadataQuery.java:86) > at > org.apache.calcite.rel.core.Filter.estimateFilteredRows(Filter.java:156) > at > org.apache.calcite.rel.core.Filter.estimateFilteredRows(Filter.java:150) > at org.apache.calcite.rel.core.Calc.getRows(Calc.java:135) > at > org.apache.calcite.rel.metadata.RelMdRowCount.getRowCount(RelMdRowCount.java:144) > ... 50 more > at > org.apache.calcite.rel.metadata.RelMetadataQuery.getMaxRowCount(RelMetadataQuery.java:101) > at > org.apache.calcite.rel.metadata.RelMdUtil.getJoinRowCount(RelMdUtil.java:705) > at org.apache.calcite.rel.core.Join.getRows(Join.java:175) > at > org.apache.calcite.rel.metadata.RelMdRowCount.getRowCount(RelMdRowCount.java:144) > ... 90 more > at > org.apache.calcite.rel.metadata.RelMetadataQuery.getMaxRowCount(RelMetadataQuery.java:101) > at > org.apache.calcite.rel.metadata.RelMdMaxRowCount.getMaxRowCount(RelMdMaxRowCount.java:108) > ... 105 more > Caused by: java.lang.NullPointerException > at > org.apache.calcite.rel.metadata.RelMdMaxRowCount.getMaxRowCount(RelMdMaxRowCount.java:102) > ... 125 more -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (CALCITE-1006) Enable maven-findbugs-plugin
Josh Elser created CALCITE-1006: --- Summary: Enable maven-findbugs-plugin Key: CALCITE-1006 URL: https://issues.apache.org/jira/browse/CALCITE-1006 Project: Calcite Issue Type: Task Components: build Reporter: Josh Elser Assignee: Josh Elser We can fairly trivially wire up the maven-findbugs-plugin to get some static-analysis at build time. This is my tool of choice for the matter -- I'll make sure we have some sane configuration and try to knock out any issues that it reports. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
