[jira] [Commented] (CALCITE-1028) Move populate materializations after sql-to-rel conversion
[ https://issues.apache.org/jira/browse/CALCITE-1028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15066890#comment-15066890 ] Julian Hyde commented on CALCITE-1028: -- * getMaterializations and getLattices could use some javadoc * I generally don't use Override if I am implementing, not overriding, a method; and if I do use Override, I usually put it on the same line as the rest of the declaration * is there a test case for the bug that was fixed by passing viewSchemaPath? > Move populate materializations after sql-to-rel conversion > -- > > Key: CALCITE-1028 > URL: https://issues.apache.org/jira/browse/CALCITE-1028 > Project: Calcite > Issue Type: Improvement >Reporter: Maryann Xue >Assignee: Maryann Xue >Priority: Minor > Labels: phoenix > Fix For: 1.6.0 > > Attachments: CALCITE-1028.patch > > > This is to allow Phoenix to figure out which materializations are concerned > with the query and thus have a chance to define them right before > materializations are populated. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (CALCITE-1033) Create Avatica message documentation for protobufs
Josh Elser created CALCITE-1033: --- Summary: Create Avatica message documentation for protobufs Key: CALCITE-1033 URL: https://issues.apache.org/jira/browse/CALCITE-1033 Project: Calcite Issue Type: Improvement Components: site Reporter: Josh Elser Assignee: Josh Elser Fix For: 1.6.0 Need to make documentation for the protocol buffer wire message format for Avatica. While it's "similar" in spirit to the JSON docs, probably not sufficiently similar for people other than me (who wrote it). These docs should help write implementations for Avatica in other languages and help us define the "specification". -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (CALCITE-1033) Create Avatica message documentation for protobufs
[ https://issues.apache.org/jira/browse/CALCITE-1033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh Elser resolved CALCITE-1033. - Resolution: Fixed Fixed in https://git1-us-west.apache.org/repos/asf?p=calcite.git;a=commit;h=60b2825c8a49c62ea3caf2212521809ebc545bd8 > Create Avatica message documentation for protobufs > -- > > Key: CALCITE-1033 > URL: https://issues.apache.org/jira/browse/CALCITE-1033 > Project: Calcite > Issue Type: Improvement > Components: site >Reporter: Josh Elser >Assignee: Josh Elser > Fix For: 1.6.0 > > > Need to make documentation for the protocol buffer wire message format for > Avatica. > While it's "similar" in spirit to the JSON docs, probably not sufficiently > similar for people other than me (who wrote it). > These docs should help write implementations for Avatica in other languages > and help us define the "specification". -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (CALCITE-984) Missing Avatica RPC docs: ExecuteRequest, SyncResultsRequest, OpenConnectionRequest
[
https://issues.apache.org/jira/browse/CALCITE-984?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Josh Elser resolved CALCITE-984.
Resolution: Fixed
Fix Version/s: (was: next)
1.6.0
Ok, prod site should be updated now. I only copied in {{docs/}} as my changes
were limited there (to the best of my knowledge)
> Missing Avatica RPC docs: ExecuteRequest, SyncResultsRequest,
> OpenConnectionRequest
> ---
>
> Key: CALCITE-984
> URL: https://issues.apache.org/jira/browse/CALCITE-984
> Project: Calcite
> Issue Type: Improvement
> Components: avatica
>Reporter: Josh Elser
>Assignee: Josh Elser
> Fix For: 1.6.0
>
>
> Went to point someone to the RPC docs for the equivalent call for execute on
> a prepared statement and realized the docs were missing.
> Giving a glance comparing the current docs to Service.java, I noticed we were
> missing ExecuteRequest, SyncResultsRequest, OpenConnectionRequest. Let me add
> some docs here.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Resolved] (CALCITE-1032) Verify javadoc of private methods
[ https://issues.apache.org/jira/browse/CALCITE-1032?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Hyde resolved CALCITE-1032. -- Resolution: Fixed Fix Version/s: 1.6.0 Fixed in http://git-wip-us.apache.org/repos/asf/calcite/commit/eaa35a41. > Verify javadoc of private methods > - > > Key: CALCITE-1032 > URL: https://issues.apache.org/jira/browse/CALCITE-1032 > Project: Calcite > Issue Type: Bug >Reporter: Julian Hyde >Assignee: Julian Hyde > Fix For: 1.6.0 > > > Currently we only verify javadoc links for methods and classes that will > occur in the site javadoc, so we skip private and package-protected methods. > We should verify (and fix) all javadoc references, because we use javadoc > references for code-level documentation. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (CALCITE-1029) Add "purpose" explanations to Avatica JSON docs
[ https://issues.apache.org/jira/browse/CALCITE-1029?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh Elser resolved CALCITE-1029. - Resolution: Fixed Fix Version/s: (was: next) 1.6.0 Fixed in https://git1-us-west.apache.org/repos/asf?p=calcite.git;a=commit;h=e7bbcec8f451dbc2b02434eba6d17138e1d44e6e > Add "purpose" explanations to Avatica JSON docs > --- > > Key: CALCITE-1029 > URL: https://issues.apache.org/jira/browse/CALCITE-1029 > Project: Calcite > Issue Type: Improvement > Components: site >Reporter: Josh Elser >Assignee: Josh Elser > Fix For: 1.6.0 > > > Looking at the JSON docs again, they serve as a easily viewable/readable > source for what objects (requests, responses, and "other") might be used with > the JSON API. An area in which it is lacking is how each of these objects is > actually used. > Add a brief explanation to each object that describe how (and why, if > necessary to give adequate explanation to "how") each are used, similar to a > class-level Javadoc comment feel. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CALCITE-1028) Move populate materializations after sql-to-rel conversion
[ https://issues.apache.org/jira/browse/CALCITE-1028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15067165#comment-15067165 ] Julian Hyde commented on CALCITE-1028: -- The extended test suite passed; go ahead and check in whenever you like. > Move populate materializations after sql-to-rel conversion > -- > > Key: CALCITE-1028 > URL: https://issues.apache.org/jira/browse/CALCITE-1028 > Project: Calcite > Issue Type: Improvement >Reporter: Maryann Xue >Assignee: Maryann Xue >Priority: Minor > Labels: phoenix > Fix For: 1.6.0 > > Attachments: CALCITE-1028.patch > > > This is to allow Phoenix to figure out which materializations are concerned > with the query and thus have a chance to define them right before > materializations are populated. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (CALCITE-1034) Use a custom checker for code style rules that Checkstyle cannot express
Julian Hyde created CALCITE-1034: Summary: Use a custom checker for code style rules that Checkstyle cannot express Key: CALCITE-1034 URL: https://issues.apache.org/jira/browse/CALCITE-1034 Project: Calcite Issue Type: Bug Reporter: Julian Hyde Assignee: Julian Hyde Use a custom checker for code style rules that Checkstyle cannot express. The checker class needs to be available before Calcite is compiled, so put it in an external project, net.hydromatic.toolbox. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
