[jira] [Commented] (CALCITE-2994) Least restrictive type among structs does not consider nullability

[ https://issues.apache.org/jira/browse/CALCITE-2994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16816837#comment-16816837 ] Danny Chan commented on CALCITE-2994: - The current code already consider structured

[jira] [Commented] (CALCITE-2974) Timestamp conversion performance can be improved

[ https://issues.apache.org/jira/browse/CALCITE-2974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16816836#comment-16816836 ] Danny Chan commented on CALCITE-2974: - Well, i also think the code consistent is ve

[jira] [Commented] (CALCITE-2966) Problem with Code Generation

[ https://issues.apache.org/jira/browse/CALCITE-2966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16816827#comment-16816827 ] Danny Chan commented on CALCITE-2966: - Sorry, i don't think there is any bug for th

[jira] [Comment Edited] (CALCITE-2966) Problem with Code Generation

[ https://issues.apache.org/jira/browse/CALCITE-2966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16816827#comment-16816827 ] Danny Chan edited comment on CALCITE-2966 at 4/13/19 4:16 AM: ---

[jira] [Commented] (CALCITE-2969) Improve design of join-like relational expressions

[ https://issues.apache.org/jira/browse/CALCITE-2969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16816820#comment-16816820 ] Danny Chan commented on CALCITE-2969: - [~hyuan] I also think so, so for the first P

[jira] [Comment Edited] (CALCITE-2986) Wrong results with =ANY subquery

[ https://issues.apache.org/jira/browse/CALCITE-2986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16816817#comment-16816817 ] Danny Chan edited comment on CALCITE-2986 at 4/13/19 3:34 AM: ---

[jira] [Comment Edited] (CALCITE-2986) Wrong results with =ANY subquery

[ https://issues.apache.org/jira/browse/CALCITE-2986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16816817#comment-16816817 ] Danny Chan edited comment on CALCITE-2986 at 4/13/19 3:34 AM: ---

[jira] [Commented] (CALCITE-2986) Wrong results with =ANY subquery

[ https://issues.apache.org/jira/browse/CALCITE-2986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16816817#comment-16816817 ] Danny Chan commented on CALCITE-2986: - >  IN corresponds to = and is rewritten usin

[jira] [Commented] (CALCITE-2992) Make implicit conversions when generating hash join keys for an equiCondition

[ https://issues.apache.org/jira/browse/CALCITE-2992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16816784#comment-16816784 ] Chunwei Lei commented on CALCITE-2992: -- Agree with [~danny0405]. Maybe we should c

[jira] [Updated] (CALCITE-2986) Wrong results with =ANY subquery

[ https://issues.apache.org/jira/browse/CALCITE-2986?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated CALCITE-2986: Labels: pull-request-available sub-query (was: sub-query) > Wrong results with =ANY subq

[jira] [Updated] (CALCITE-2986) Wrong results with =ANY subquery

[ https://issues.apache.org/jira/browse/CALCITE-2986?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated CALCITE-2986: Labels: pull-request-available sub-query (was: sub-query) > Wrong results with =ANY subq

[jira] [Commented] (CALCITE-2974) Timestamp conversion performance can be improved

[ https://issues.apache.org/jira/browse/CALCITE-2974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16816756#comment-16816756 ] Julian Hyde commented on CALCITE-2974: -- That seems pretty compelling. Now, if we

[jira] [Commented] (CALCITE-2712) Add rule to remove null-generating side of a Join

[ https://issues.apache.org/jira/browse/CALCITE-2712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16816751#comment-16816751 ] Julian Hyde commented on CALCITE-2712: -- Tree-walks are not possible because in Vol

[jira] [Commented] (CALCITE-2991) getMaxRowCount should return rowcount 1 for an aggregate with constant keys

[ https://issues.apache.org/jira/browse/CALCITE-2991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16816744#comment-16816744 ] Haisheng Yuan commented on CALCITE-2991: OK, thanks! > getMaxRowCount should r

[jira] [Commented] (CALCITE-2991) getMaxRowCount should return rowcount 1 for an aggregate with constant keys

[ https://issues.apache.org/jira/browse/CALCITE-2991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16816743#comment-16816743 ] Julian Hyde commented on CALCITE-2991: -- I'm reviewing again. [~hyuan] I'll make su

[jira] [Commented] (CALCITE-2977) Exception is not thrown out when there are ambiguous field in select list

[ https://issues.apache.org/jira/browse/CALCITE-2977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16816732#comment-16816732 ] Haisheng Yuan commented on CALCITE-2977: Pushed to master https://github.com/a

[jira] [Resolved] (CALCITE-2977) Exception is not thrown out when there are ambiguous field in select list

[ https://issues.apache.org/jira/browse/CALCITE-2977?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan resolved CALCITE-2977. Resolution: Fixed > Exception is not thrown out when there are ambiguous field in select

[jira] [Comment Edited] (CALCITE-2986) Wrong results with =ANY subquery

[ https://issues.apache.org/jira/browse/CALCITE-2986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16816716#comment-16816716 ] Vineet Garg edited comment on CALCITE-2986 at 4/12/19 10:38 PM: -

[jira] [Commented] (CALCITE-2986) Wrong results with =ANY subquery

[ https://issues.apache.org/jira/browse/CALCITE-2986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16816716#comment-16816716 ] Vineet Garg commented on CALCITE-2986: -- bq  <>ANY should probably be transformed i

[jira] [Commented] (CALCITE-2986) Wrong results with =ANY subquery

[ https://issues.apache.org/jira/browse/CALCITE-2986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16816715#comment-16816715 ] Vineet Garg commented on CALCITE-2986: -- I have opened a pull request for {{=ANY}}

[jira] [Resolved] (CALCITE-2739) NPE will thrown if the DEFINE statement contains IN in MATCH_RECOGNIZE

[ https://issues.apache.org/jira/browse/CALCITE-2739?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan resolved CALCITE-2739. Resolution: Fixed Fix Version/s: 1.20.0 Pushed to master https://github.com/apach

[jira] [Commented] (CALCITE-2969) Improve design of join-like relational expressions

[ https://issues.apache.org/jira/browse/CALCITE-2969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16816681#comment-16816681 ] Haisheng Yuan commented on CALCITE-2969: I was assuming this is just an umbrell

[jira] [Resolved] (CALCITE-896) Remove Aggregate if grouping columns are unique and all functions are splittable

[ https://issues.apache.org/jira/browse/CALCITE-896?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haisheng Yuan resolved CALCITE-896. --- Resolution: Fixed Assignee: Haisheng Yuan Fix Version/s: 1.20.0 Pushed to ma

[jira] [Commented] (CALCITE-1935) Reference implementation for MATCH_RECOGNIZE

[ https://issues.apache.org/jira/browse/CALCITE-1935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16816658#comment-16816658 ] Julian Feinauer commented on CALCITE-1935: -- Hi [~julianhyde] thanks for your o

[jira] [Comment Edited] (CALCITE-2712) Add rule to remove null-generating side of a Join

[ https://issues.apache.org/jira/browse/CALCITE-2712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16816646#comment-16816646 ] Steven Talbot edited comment on CALCITE-2712 at 4/12/19 8:58 PM:

[jira] [Comment Edited] (CALCITE-2712) Add rule to remove null-generating side of a Join

[ https://issues.apache.org/jira/browse/CALCITE-2712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16816646#comment-16816646 ] Steven Talbot edited comment on CALCITE-2712 at 4/12/19 8:57 PM:

[jira] [Commented] (CALCITE-2712) Add rule to remove null-generating side of a Join

[ https://issues.apache.org/jira/browse/CALCITE-2712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16816646#comment-16816646 ] Steven Talbot commented on CALCITE-2712: Do we not also need a `ProjectJoinElim

[jira] [Commented] (CALCITE-2966) Problem with Code Generation

[ https://issues.apache.org/jira/browse/CALCITE-2966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16816643#comment-16816643 ] Julian Feinauer commented on CALCITE-2966: -- Hey [~danny0405] a short update on

[jira] [Commented] (CALCITE-1935) Reference implementation for MATCH_RECOGNIZE

[ https://issues.apache.org/jira/browse/CALCITE-1935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16816573#comment-16816573 ] Julian Hyde commented on CALCITE-1935: -- [~julian.feinauer] That's great. If there'

[jira] [Commented] (CALCITE-896) Remove Aggregate if grouping columns are unique and all functions are splittable

[ https://issues.apache.org/jira/browse/CALCITE-896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16816565#comment-16816565 ] Julian Hyde commented on CALCITE-896: - Reviewing now; looks like I'll need to fix 3

[jira] [Comment Edited] (CALCITE-2991) getMaxRowCount should return rowcount 1 for an aggregate with constant keys

[ https://issues.apache.org/jira/browse/CALCITE-2991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16816556#comment-16816556 ] Julian Hyde edited comment on CALCITE-2991 at 4/12/19 6:19 PM: --

[jira] [Commented] (CALCITE-2991) getMaxRowCount should return rowcount 1 for an aggregate with constant keys

[ https://issues.apache.org/jira/browse/CALCITE-2991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16816556#comment-16816556 ] Julian Hyde commented on CALCITE-2991: -- Regarding a rule to eliminate constant key

[jira] [Commented] (CALCITE-2712) Add rule to remove null-generating side of a Join

[ https://issues.apache.org/jira/browse/CALCITE-2712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16816540#comment-16816540 ] Julian Hyde commented on CALCITE-2712: -- [~swtalbot], Can you please review. > Add

[jira] [Commented] (CALCITE-2712) Add rule to remove null-generating side of a Join

[ https://issues.apache.org/jira/browse/CALCITE-2712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16816538#comment-16816538 ] Julian Hyde commented on CALCITE-2712: -- Based on a quick review, looks good. I don

[jira] [Commented] (CALCITE-2974) Timestamp conversion performance can be improved

[ https://issues.apache.org/jira/browse/CALCITE-2974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16816500#comment-16816500 ] Valeriy Trofimov commented on CALCITE-2974: --- simplifyCast is called 6 tmes fo

[jira] [Created] (CALCITE-2994) Least restrictive type among structs does not consider nullability

Stamatis Zampetakis created CALCITE-2994: Summary: Least restrictive type among structs does not consider nullability Key: CALCITE-2994 URL: https://issues.apache.org/jira/browse/CALCITE-2994

[jira] [Closed] (CALCITE-1152) Fix small issues with ANY type including ensureType and determining least restrictive type

[ https://issues.apache.org/jira/browse/CALCITE-1152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stamatis Zampetakis closed CALCITE-1152. Resolution: Fixed Fix Version/s: 1.8.0 > Fix small issues with ANY type in

[jira] [Commented] (CALCITE-2712) Add rule to remove null-generating side of a Join

[ https://issues.apache.org/jira/browse/CALCITE-2712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16816369#comment-16816369 ] Chunwei Lei commented on CALCITE-2712: -- I opened a pull request: [https://github.c

[jira] [Updated] (CALCITE-2712) Add rule to remove null-generating side of a Join

[ https://issues.apache.org/jira/browse/CALCITE-2712?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated CALCITE-2712: Labels: pull-request-available (was: ) > Add rule to remove null-generating side of a Jo

[jira] [Commented] (CALCITE-2966) Problem with Code Generation

[ https://issues.apache.org/jira/browse/CALCITE-2966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16816305#comment-16816305 ] Julian Feinauer commented on CALCITE-2966: -- Hi [~danny0405] all good! I tell y

[jira] [Updated] (CALCITE-2993) ParseException may be thrown for legal SQL queries due to incorrect "LOOKAHEAD(1)" hints

[ https://issues.apache.org/jira/browse/CALCITE-2993?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated CALCITE-2993: Labels: pull-request-available (was: ) > ParseException may be thrown for legal SQL quer

[jira] [Commented] (CALCITE-2966) Problem with Code Generation

[ https://issues.apache.org/jira/browse/CALCITE-2966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16816213#comment-16816213 ] Danny Chan commented on CALCITE-2966: - [~julian.feinauer] I would check this soon,

[jira] [Updated] (CALCITE-2993) ParseException may be thrown for legal SQL queries due to incorrect "LOOKAHEAD(1)" hints

[ https://issues.apache.org/jira/browse/CALCITE-2993?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hongze Zhang updated CALCITE-2993: -- Description: In some cases, ParseException is thrown incorrectly: Case 1 {code:sql} select l

[jira] [Updated] (CALCITE-2993) ParseException may be thrown for legal SQL queries due to incorrect "LOOKAHEAD(1)" hints

[ https://issues.apache.org/jira/browse/CALCITE-2993?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hongze Zhang updated CALCITE-2993: -- Description: In some cases, ParseException is thrown incorrectly: Case 1 {code:sql} select l

[jira] [Created] (CALCITE-2993) ParseException may be thrown for legal SQL queries due to incorrect "LOOKAHEAD(1)" hints

Hongze Zhang created CALCITE-2993: - Summary: ParseException may be thrown for legal SQL queries due to incorrect "LOOKAHEAD(1)" hints Key: CALCITE-2993 URL: https://issues.apache.org/jira/browse/CALCITE-2993

[jira] [Commented] (CALCITE-2986) Wrong results with =ANY subquery

[ https://issues.apache.org/jira/browse/CALCITE-2986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16816096#comment-16816096 ] Danny Chan commented on CALCITE-2986: - [~vgarg] Agree with you that the semi join s

[jira] [Commented] (CALCITE-2992) Make implicit conversions when generating hash join keys for an equiCondition

[ https://issues.apache.org/jira/browse/CALCITE-2992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16816077#comment-16816077 ] Danny Chan commented on CALCITE-2992: - I don't think it's a good idea to coerce typ

[jira] [Commented] (CALCITE-2992) Make implicit conversions when generating hash join keys for an equiCondition

[ https://issues.apache.org/jira/browse/CALCITE-2992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16816075#comment-16816075 ] Julian Hyde commented on CALCITE-2992: -- Converting keys to strings is a waste of b

[jira] [Commented] (CALCITE-2973) Allow theta joins that have equi conditions to be executed using a hash join algorithm

[ https://issues.apache.org/jira/browse/CALCITE-2973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16816069#comment-16816069 ] Danny Chan commented on CALCITE-2973: - Hi, [~hhlai1990], i think this issue has str

[jira] [Updated] (CALCITE-2992) Make implicit conversions when generating hash join keys for an equiCondition

[ https://issues.apache.org/jira/browse/CALCITE-2992?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated CALCITE-2992: Labels: pull-request-available (was: ) > Make implicit conversions when generating hash

[jira] [Created] (CALCITE-2992) Make implicit conversions when generating hash join keys for an equiCondition

Lai Zhou created CALCITE-2992: - Summary: Make implicit conversions when generating hash join keys for an equiCondition Key: CALCITE-2992 URL: https://issues.apache.org/jira/browse/CALCITE-2992 Project: Ca

[jira] [Updated] (CALCITE-2696) Make it easier to configure SqlToRelConverter.Config.getInSubQueryThreshold()

[ https://issues.apache.org/jira/browse/CALCITE-2696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated CALCITE-2696: Labels: pull-request-available (was: ) > Make it easier to configure SqlToRelConverter.C