[jira] [Updated] (CALCITE-4368) TopDownOptTest fails if applying non-substitution rule first

2020-10-30 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4368?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chunwei Lei updated CALCITE-4368: - Description: If we apply non-substitution rules first, some tests in TopDownOptTest would

[jira] [Updated] (CALCITE-4368) TopDownOptTest fails if applying non-substitution rule first

2020-10-30 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4368?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chunwei Lei updated CALCITE-4368: - Description: If we apply non-substitution rules first, some tests in TopDownOptTest would

[jira] [Updated] (CALCITE-4368) TopDownOptTest fails if applying non-substitution rule first

2020-10-30 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4368?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chunwei Lei updated CALCITE-4368: - Description: If we apply non-substitution rules first, some tests in TopDownOptTest would

[jira] [Created] (CALCITE-4368) TopDownOptTest fails if applying non-substitution rule first

2020-10-30 Thread Chunwei Lei (Jira)
Chunwei Lei created CALCITE-4368: Summary: TopDownOptTest fails if applying non-substitution rule first Key: CALCITE-4368 URL: https://issues.apache.org/jira/browse/CALCITE-4368 Project: Calcite

[jira] [Comment Edited] (CALCITE-4360) Apply SubstitutionRule first in top-down driven rule apply

2020-10-29 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17222756#comment-17222756 ] Chunwei Lei edited comment on CALCITE-4360 at 10/29/20, 7:51 AM: - BTW,

[jira] [Commented] (CALCITE-4360) Apply SubstitutionRule first in top-down driven rule apply

2020-10-29 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17222756#comment-17222756 ] Chunwei Lei commented on CALCITE-4360: -- BTW, I found all the test cases in TopDownOptTest failed

[jira] [Commented] (CALCITE-4360) Apply SubstitutionRule first in top-down driven rule apply

2020-10-29 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17222749#comment-17222749 ] Chunwei Lei commented on CALCITE-4360: -- [~fan_li_ya] Makes sense.  > Apply SubstitutionRule first

[jira] [Resolved] (CALCITE-4360) Apply SubstitutionRule first in top-down driven rule apply

2020-10-29 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chunwei Lei resolved CALCITE-4360. -- Resolution: Invalid > Apply SubstitutionRule first in top-down driven rule apply >

[jira] [Commented] (CALCITE-4360) Apply SubstitutionRule first in top-down driven rule apply

2020-10-29 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17222730#comment-17222730 ] Chunwei Lei commented on CALCITE-4360: -- I am sorry that I misunderstood the codes. Currently, the

[jira] [Updated] (CALCITE-4360) Apply SubstitutionRule first in top-down driven rule apply

2020-10-27 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chunwei Lei updated CALCITE-4360: - Summary: Apply SubstitutionRule first in top-down driven rule apply (was: Should apply

[jira] [Updated] (CALCITE-4360) Should apply SubstitutionRule first in top-down driven rule apply

2020-10-27 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chunwei Lei updated CALCITE-4360: - Description: In the current implementation, TopDownRuleQueue adds substitute rules in the end

[jira] [Updated] (CALCITE-4360) Should apply SubstitutionRule first in top-down driven rule apply

2020-10-27 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chunwei Lei updated CALCITE-4360: - Summary: Should apply SubstitutionRule first in top-down driven rule apply (was: Should apply

[jira] [Updated] (CALCITE-4360) Should apply SubstituteRule first in top-down driven rule apply

2020-10-27 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chunwei Lei updated CALCITE-4360: - Description: In the current implementation, TopDownRuleQueue adds substitute rules in the end

[jira] [Created] (CALCITE-4360) Should apply SubstituteRule first in top-down driven rule apply

2020-10-27 Thread Chunwei Lei (Jira)
Chunwei Lei created CALCITE-4360: Summary: Should apply SubstituteRule first in top-down driven rule apply Key: CALCITE-4360 URL: https://issues.apache.org/jira/browse/CALCITE-4360 Project: Calcite

[jira] [Commented] (CALCITE-947) Allow optional parameters to have default values other than NULL

2020-10-26 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17221113#comment-17221113 ] Chunwei Lei commented on CALCITE-947: - I am sorry that I cannot find time to finish it. Removed the

[jira] [Assigned] (CALCITE-947) Allow optional parameters to have default values other than NULL

2020-10-26 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-947?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chunwei Lei reassigned CALCITE-947: --- Assignee: (was: Chunwei Lei) > Allow optional parameters to have default values other

[jira] [Resolved] (CALCITE-3746) RexSimplify changes the order of IS NOT NULL in And RexNode

2020-10-26 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3746?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chunwei Lei resolved CALCITE-3746. -- Resolution: Invalid > RexSimplify changes the order of IS NOT NULL in And RexNode >

[jira] [Commented] (CALCITE-3746) RexSimplify changes the order of IS NOT NULL in And RexNode

2020-10-26 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17221110#comment-17221110 ] Chunwei Lei commented on CALCITE-3746: -- Since we cannot reach a consensus, close it now. >

[jira] [Assigned] (CALCITE-907) Add AggregateExchangeTransposeRule

2020-10-26 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-907?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chunwei Lei reassigned CALCITE-907: --- Assignee: (was: Chunwei Lei) > Add AggregateExchangeTransposeRule >

[jira] [Resolved] (CALCITE-4332) Improve error when planning rule produces a relational expression with wrong row type

2020-10-26 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chunwei Lei resolved CALCITE-4332. -- Fix Version/s: 1.27.0 Resolution: Fixed Fixed in 

[jira] [Commented] (CALCITE-4277) skip rule match when rel's relset is obsolete

2020-10-18 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17216421#comment-17216421 ] Chunwei Lei commented on CALCITE-4277: -- Sounds fine. > skip rule match when rel's relset is

[jira] [Commented] (CALCITE-4338) Support MERGE INTO Clause

2020-10-16 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17215214#comment-17215214 ] Chunwei Lei commented on CALCITE-4338: -- Just out of curiosity, do other systems support this

[jira] [Comment Edited] (CALCITE-4338) Support MERGE INTO Clause

2020-10-16 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17215214#comment-17215214 ] Chunwei Lei edited comment on CALCITE-4338 at 10/16/20, 6:29 AM: - Just

[jira] [Updated] (CALCITE-4341) Support double/float mod

2020-10-15 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4341?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chunwei Lei updated CALCITE-4341: - Summary: Support double/float mod (was: Calcite support double/float mod) > Support

[jira] [Commented] (CALCITE-4332) Improve error when planning rule produces a relational expression with wrong row type

2020-10-15 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17215201#comment-17215201 ] Chunwei Lei commented on CALCITE-4332: -- I am working on it. > Improve error when planning rule

[jira] [Assigned] (CALCITE-4332) Improve error when planning rule produces a relational expression with wrong row type

2020-10-15 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chunwei Lei reassigned CALCITE-4332: Assignee: Chunwei Lei > Improve error when planning rule produces a relational

[jira] [Resolved] (CALCITE-4260) Support plan explain with dot format

2020-10-14 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chunwei Lei resolved CALCITE-4260. -- Fix Version/s: 1.27.0 Resolution: Fixed Fixed in

[jira] [Commented] (CALCITE-4332) Improve error when planning rule produces a relational expression with wrong row type

2020-10-13 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17213554#comment-17213554 ] Chunwei Lei commented on CALCITE-4332: -- [~vladimirsitnikov] if you don'mind, I would like to take

[jira] [Commented] (CALCITE-4332) Improve error when planning rule produces a relation with a wrong rowtype

2020-10-12 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17212228#comment-17212228 ] Chunwei Lei commented on CALCITE-4332: -- That would be great. I met the same confusing error

[jira] [Comment Edited] (CALCITE-4223) Introducing column statistics to RelOptTable

2020-10-12 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17212173#comment-17212173 ] Chunwei Lei edited comment on CALCITE-4223 at 10/12/20, 7:13 AM: - I

[jira] [Commented] (CALCITE-4223) Introducing column statistics to RelOptTable

2020-10-12 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17212173#comment-17212173 ] Chunwei Lei commented on CALCITE-4223: -- I would check it. Thank you for your reply(:DJust back

[jira] [Commented] (CALCITE-4310) Add API backward compatibility verification

2020-10-12 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17212165#comment-17212165 ] Chunwei Lei commented on CALCITE-4310: -- Interesting tools(y) > Add API backward compatibility

[jira] [Commented] (CALCITE-4223) Introducing column statistics to RelOptTable

2020-09-28 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17203237#comment-17203237 ] Chunwei Lei commented on CALCITE-4223: -- {quote}I don't know why Flink and Drill have not

[jira] [Commented] (CALCITE-4223) Introducing column statistics to RelOptTable

2020-09-26 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17202725#comment-17202725 ] Chunwei Lei commented on CALCITE-4223: -- Let's think about it in another way. A good interface is

[jira] [Commented] (CALCITE-4241) Some improvements to metadata query

2020-09-22 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17200474#comment-17200474 ] Chunwei Lei commented on CALCITE-4241: -- Fixed in

[jira] [Resolved] (CALCITE-4192) RelMdColumnOrigins gets the wrong index of group by columns after RelNode was optimized by AggregateProjectMergeRule rule

2020-09-20 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chunwei Lei resolved CALCITE-4192. -- Fix Version/s: (was: next) 1.26.0 Resolution: Fixed Fixed in

[jira] [Updated] (CALCITE-4192) RelMdColumnOrigins gets the wrong index of group by columns after RelNode was optimized by AggregateProjectMergeRule rule

2020-09-20 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chunwei Lei updated CALCITE-4192: - Summary: RelMdColumnOrigins gets the wrong index of group by columns after RelNode was

[jira] [Updated] (CALCITE-4192) RelMdColumnOrigins get the wrong index of group by columns after RelNode was optimized by AggregateProjectMergeRule rule

2020-09-20 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chunwei Lei updated CALCITE-4192: - Summary: RelMdColumnOrigins get the wrong index of group by columns after RelNode was

[jira] [Commented] (CALCITE-4223) Introducing column statistics to RelOptTable

2020-09-20 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17199143#comment-17199143 ] Chunwei Lei commented on CALCITE-4223: -- Do you mean that we don't need to do any changes since we

[jira] [Commented] (CALCITE-4223) Introducing column statistics to RelOptTable

2020-09-18 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17198161#comment-17198161 ] Chunwei Lei commented on CALCITE-4223: -- {quote}That doesn't work, because your {{ColStatistics}} 

[jira] [Commented] (CALCITE-4223) Introducing column statistics to RelOptTable

2020-09-17 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17198105#comment-17198105 ] Chunwei Lei commented on CALCITE-4223: -- Thank you for your review, Julian. {quote}it does not

[jira] [Comment Edited] (CALCITE-4197) Provide utility to visualize RelNode plans

2020-09-16 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17197336#comment-17197336 ] Chunwei Lei edited comment on CALCITE-4197 at 9/17/20, 3:06 AM:

[jira] [Commented] (CALCITE-4197) Provide utility to visualize RelNode plans

2020-09-16 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17197336#comment-17197336 ] Chunwei Lei commented on CALCITE-4197: -- [~julianhyde], I did not notice that there're some

[jira] [Commented] (CALCITE-4256) RexSimplify should not simplify P AND P to P, if it contains a call to RAND or RAND_INTEGER

2020-09-14 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17195833#comment-17195833 ] Chunwei Lei commented on CALCITE-4256: -- Agree with [~danny0405]. In our system, we treat 

[jira] [Commented] (CALCITE-4250) Failed to get original column of aggregate operator

2020-09-13 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17195153#comment-17195153 ] Chunwei Lei commented on CALCITE-4250: -- It seems duplicate with CALCITE-4192. > Failed to get

[jira] [Resolved] (CALCITE-4239) RelMdUniqueKeys returns wrong unique keys for Aggregate with grouping sets

2020-09-13 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chunwei Lei resolved CALCITE-4239. -- Fix Version/s: 1.26.0 Resolution: Fixed Fixed in 

[jira] [Resolved] (CALCITE-4197) Provide utility to visualize RelNode plans

2020-09-13 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chunwei Lei resolved CALCITE-4197. -- Fix Version/s: 1.26.0 Resolution: Fixed Fixed in

[jira] [Commented] (CALCITE-4223) Introducing column statistics to RelOptTable

2020-09-10 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17193391#comment-17193391 ] Chunwei Lei commented on CALCITE-4223: -- Thank you for your helpful insight, [~julianhyde]. I will

[jira] [Assigned] (CALCITE-4239) RelMdUniqueKeys returns wrong unique keys for Aggregate with grouping sets

2020-09-09 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chunwei Lei reassigned CALCITE-4239: Assignee: Chunwei Lei > RelMdUniqueKeys returns wrong unique keys for Aggregate with

[jira] [Created] (CALCITE-4239) RelMdUniqueKeys returns wrong unique keys for Aggregate with grouping sets

2020-09-09 Thread Chunwei Lei (Jira)
Chunwei Lei created CALCITE-4239: Summary: RelMdUniqueKeys returns wrong unique keys for Aggregate with grouping sets Key: CALCITE-4239 URL: https://issues.apache.org/jira/browse/CALCITE-4239

[jira] [Commented] (CALCITE-4223) Introducing column statistics to RelOptTable

2020-09-08 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17192601#comment-17192601 ] Chunwei Lei commented on CALCITE-4223: -- There is always an alternative due to the flexible

[jira] [Comment Edited] (CALCITE-4223) Introducing column statistics to RelOptTable

2020-09-08 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17192601#comment-17192601 ] Chunwei Lei edited comment on CALCITE-4223 at 9/9/20, 3:50 AM: --- There is

[jira] [Commented] (CALCITE-4223) Introducing column statistics to RelOptTable

2020-09-07 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17191916#comment-17191916 ] Chunwei Lei commented on CALCITE-4223: -- Thanks for sharing, [~danny0405]. IMO, one of the

[jira] [Commented] (CALCITE-4224) Add an method for RelNode to output its tree digest like RelOptUtil.toString

2020-09-07 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17191913#comment-17191913 ] Chunwei Lei commented on CALCITE-4224: -- You can add a method in a class that is already loaded

[jira] [Commented] (CALCITE-4224) Add an method for RelNode to output its tree digest like RelOptUtil.toString

2020-09-06 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17191419#comment-17191419 ] Chunwei Lei commented on CALCITE-4224: -- Considering we can get it via RelOptUtil.toString()(get

[jira] [Comment Edited] (CALCITE-4223) Introducing column statistics to RelOptTable

2020-09-06 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17191409#comment-17191409 ] Chunwei Lei edited comment on CALCITE-4223 at 9/7/20, 2:35 AM: --- Let me

[jira] [Commented] (CALCITE-4223) Introducing column statistics to RelOptTable

2020-09-06 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17191409#comment-17191409 ] Chunwei Lei commented on CALCITE-4223: -- Let me make myself clear. What in my mind is that there is

[jira] [Commented] (CALCITE-4224) Add an method for RelNode to output its tree digest like RelOptUtil.toString

2020-09-03 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17190508#comment-17190508 ] Chunwei Lei commented on CALCITE-4224: -- I don't understand much about your proposal. Could you

[jira] [Comment Edited] (CALCITE-4223) Introducing column statistics to RelOptTable

2020-09-03 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17190504#comment-17190504 ] Chunwei Lei edited comment on CALCITE-4223 at 9/4/20, 2:58 AM: ---

[jira] [Comment Edited] (CALCITE-4223) Introducing column statistics to RelOptTable

2020-09-03 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17190504#comment-17190504 ] Chunwei Lei edited comment on CALCITE-4223 at 9/4/20, 2:58 AM: ---

[jira] [Comment Edited] (CALCITE-4223) Introducing column statistics to RelOptTable

2020-09-03 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17190504#comment-17190504 ] Chunwei Lei edited comment on CALCITE-4223 at 9/4/20, 2:58 AM: ---

[jira] [Commented] (CALCITE-4223) Introducing column statistics to RelOptTable

2020-09-03 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17190504#comment-17190504 ] Chunwei Lei commented on CALCITE-4223: -- [~julianhyde], column statistics might include NDV,

[jira] [Commented] (CALCITE-4223) Introducing column statistics to RelOptTable

2020-09-03 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17190493#comment-17190493 ] Chunwei Lei commented on CALCITE-4223: -- [~amaliujia] , column stats are used in Hive[1], Flink[2],

[jira] [Assigned] (CALCITE-4223) Introducing column statistics to RelOptTable

2020-09-03 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4223?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chunwei Lei reassigned CALCITE-4223: Assignee: Chunwei Lei > Introducing column statistics to RelOptTable >

[jira] [Created] (CALCITE-4223) Introducing column statistics to RelOptTable

2020-09-03 Thread Chunwei Lei (Jira)
Chunwei Lei created CALCITE-4223: Summary: Introducing column statistics to RelOptTable Key: CALCITE-4223 URL: https://issues.apache.org/jira/browse/CALCITE-4223 Project: Calcite Issue Type:

[jira] [Resolved] (CALCITE-4203) RelMdUniqueKeys should not return empty when meeting Intersect and Minus if its input has unique keys

2020-09-03 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4203?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chunwei Lei resolved CALCITE-4203. -- Fix Version/s: 1.26.0 Resolution: Fixed Fixed in 

[jira] [Commented] (CALCITE-4180) Support for Elasticsearch basic authentication

2020-09-01 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17188940#comment-17188940 ] Chunwei Lei commented on CALCITE-4180: -- Updated the title to make it clearer. > Support for

[jira] [Updated] (CALCITE-4180) Support for Elasticsearch basic authentication

2020-09-01 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4180?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chunwei Lei updated CALCITE-4180: - Summary: Support for Elasticsearch basic authentication (was: Where to set elasticsearch

[jira] [Commented] (CALCITE-4209) RelBuilder: ability to avoid generating empty() on limit 0

2020-09-01 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17188939#comment-17188939 ] Chunwei Lei commented on CALCITE-4209: -- {{relBuilder.filter(false)}} can generate empty() too.

[jira] [Commented] (CALCITE-4203) RelMdUniqueKeys should not return empty when meeting Intersect and Minus if its input has unique keys

2020-09-01 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17188937#comment-17188937 ] Chunwei Lei commented on CALCITE-4203: -- I have no problem with that. I would update the PR. >

[jira] [Commented] (CALCITE-4197) Provide utility to visualize RelNode plans

2020-09-01 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17188932#comment-17188932 ] Chunwei Lei commented on CALCITE-4197: -- I like this feature. It is really helpful. > Provide

[jira] [Commented] (CALCITE-4208) Improve metadata row count for Join

2020-09-01 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17188931#comment-17188931 ] Chunwei Lei commented on CALCITE-4208: -- AFAIK, the row count of Join is related to the NDV. Should

[jira] [Commented] (CALCITE-4203) RelMdUniqueKeys should not return empty when meeting Intersect and Minus if its input has unique keys

2020-09-01 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17188173#comment-17188173 ] Chunwei Lei commented on CALCITE-4203: -- Thanks for your review, Julian. > Is there any benefit in

[jira] [Created] (CALCITE-4203) RelMdUniqueKeys should not return empty when meeting Intersect and Minus if its input has unique keys

2020-08-31 Thread Chunwei Lei (Jira)
Chunwei Lei created CALCITE-4203: Summary: RelMdUniqueKeys should not return empty when meeting Intersect and Minus if its input has unique keys Key: CALCITE-4203 URL:

[jira] [Commented] (CALCITE-4199) Add nullability annotations to the methods and fields, ensure consistency with checkerframework

2020-08-31 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187590#comment-17187590 ] Chunwei Lei commented on CALCITE-4199: -- If it is enforced, does it take a lot of effort to change

[jira] [Commented] (CALCITE-4199) Add nullability annotations to the methods and fields, ensure consistency with checkerframework

2020-08-30 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17187373#comment-17187373 ] Chunwei Lei commented on CALCITE-4199: -- Does it mean the annotation is enforced? > Add

[jira] [Commented] (CALCITE-4191) Improve the logic of creating aggregate calls

2020-08-25 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17184884#comment-17184884 ] Chunwei Lei commented on CALCITE-4191: -- Personally I would like to have such a way to create

[jira] [Commented] (CALCITE-1581) UDTF like in hive

2020-08-12 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-1581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17176737#comment-17176737 ] Chunwei Lei commented on CALCITE-1581: -- I am not sure whether  it should use {{LogicalCorrelate

[jira] [Updated] (CALCITE-3351) SQLException when executing SQL containing Chinese

2020-08-12 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chunwei Lei updated CALCITE-3351: - Summary: SQLException when executing SQL containing Chinese (was: calcite mysql utf8 throws

[jira] [Commented] (CALCITE-3409) Add an interface in MaterializedViewSubstitutionVisitor to allow registering UnifyRule

2020-08-11 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17175946#comment-17175946 ] Chunwei Lei commented on CALCITE-3409: -- I left some comments on PR#2094. > Add an interface in

[jira] [Resolved] (CALCITE-4081) Round-tripping a DECIMAL literal through Planner -> RelToSqlConverter -> Planner throws validation error

2020-08-06 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4081?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chunwei Lei resolved CALCITE-4081. -- Fix Version/s: 1.25.0 Resolution: Fixed Fixed in 

[jira] [Commented] (CALCITE-4156) ReflectiveRelMetadataProvider constructor should throw an exception (instead of assertion) when called with an empty map

2020-08-05 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17171433#comment-17171433 ] Chunwei Lei commented on CALCITE-4156: -- Makes sense. > ReflectiveRelMetadataProvider constructor

[jira] [Commented] (CALCITE-4155) Simplify in expression of discreet values

2020-08-05 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17171429#comment-17171429 ] Chunwei Lei commented on CALCITE-4155: -- If any of those numbers is lack, it can not be reduced. I

[jira] [Assigned] (CALCITE-1581) UDTF like in hive

2020-07-31 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-1581?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chunwei Lei reassigned CALCITE-1581: Assignee: Chunwei Lei (was: pengzhiwei) > UDTF like in hive > - > >

[jira] [Commented] (CALCITE-1581) UDTF like in hive

2020-07-31 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-1581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17168550#comment-17168550 ] Chunwei Lei commented on CALCITE-1581: -- Opened a new PR[1] with some fix-ups.

[jira] [Updated] (CALCITE-1581) UDTF like in hive

2020-07-31 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-1581?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chunwei Lei updated CALCITE-1581: - Fix Version/s: 1.25.0 > UDTF like in hive > - > > Key:

[jira] [Comment Edited] (CALCITE-4081) Round-tripping a DECIMAL literal through Planner -> RelToSqlConverter -> Planner throws validation error

2020-07-31 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17168497#comment-17168497 ] Chunwei Lei edited comment on CALCITE-4081 at 7/31/20, 7:29 AM: > 

[jira] [Comment Edited] (CALCITE-4081) Round-tripping a DECIMAL literal through Planner -> RelToSqlConverter -> Planner throws validation error

2020-07-31 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17168494#comment-17168494 ] Chunwei Lei edited comment on CALCITE-4081 at 7/31/20, 7:29 AM: > 

[jira] [Commented] (CALCITE-4081) Round-tripping a DECIMAL literal through Planner -> RelToSqlConverter -> Planner throws validation error

2020-07-31 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17168497#comment-17168497 ] Chunwei Lei commented on CALCITE-4081: -- > Should we remove the valid check for decimal literal ?

[jira] [Commented] (CALCITE-4081) Round-tripping a DECIMAL literal through Planner -> RelToSqlConverter -> Planner throws validation error

2020-07-31 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17168494#comment-17168494 ] Chunwei Lei commented on CALCITE-4081: -- > Shouldn't RexExecutor have thrown?

[jira] [Resolved] (CALCITE-4118) RexSimplify might remove CAST from RexNode incorrectly

2020-07-30 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4118?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chunwei Lei resolved CALCITE-4118. -- Fix Version/s: 1.25.0 Resolution: Fixed Fixed in 

[jira] [Updated] (CALCITE-4118) RexSimplify might remove CAST from RexNode incorrectly

2020-07-30 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4118?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chunwei Lei updated CALCITE-4118: - Affects Version/s: 1.24.0 > RexSimplify might remove CAST from RexNode incorrectly >

[jira] [Commented] (CALCITE-2772) Support varargs for user-defined functions (UDFs)

2020-07-30 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-2772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17168346#comment-17168346 ] Chunwei Lei commented on CALCITE-2772: -- Appreciate it, [~pzw2018]. > Support varargs for

[jira] [Assigned] (CALCITE-2772) Support varargs for user-defined functions (UDFs)

2020-07-30 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-2772?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chunwei Lei reassigned CALCITE-2772: Assignee: Chunwei Lei (was: pengzhiwei) > Support varargs for user-defined functions

[jira] [Comment Edited] (CALCITE-4147) Rename "master" branch to "main"

2020-07-30 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17167712#comment-17167712 ] Chunwei Lei edited comment on CALCITE-4147 at 7/30/20, 8:37 AM: >From

[jira] [Commented] (CALCITE-4147) Rename "master" branch to "main"

2020-07-30 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17167712#comment-17167712 ] Chunwei Lei commented on CALCITE-4147: -- So I think the master branch is open for commits. Right?

[jira] [Commented] (CALCITE-2772) Support varargs for user-defined functions (UDFs)

2020-07-29 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-2772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17167622#comment-17167622 ] Chunwei Lei commented on CALCITE-2772: -- [~pzw2018], are you making any progress? I would like to

[jira] [Commented] (CALCITE-3923) Refactor how planner rules are parameterized

2020-07-29 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17167045#comment-17167045 ] Chunwei Lei commented on CALCITE-3923: -- A minor fix of Site: 

[jira] [Assigned] (CALCITE-4081) Round-tripping a DECIMAL literal through Planner -> RelToSqlConverter -> Planner throws validation error

2020-07-28 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4081?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chunwei Lei reassigned CALCITE-4081: Assignee: Chunwei Lei > Round-tripping a DECIMAL literal through Planner ->

[jira] [Assigned] (CALCITE-4118) RexSimplify might remove CAST from RexNode incorrectly

2020-07-28 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4118?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chunwei Lei reassigned CALCITE-4118: Assignee: Chunwei Lei > RexSimplify might remove CAST from RexNode incorrectly >

<    1   2   3   4   5   6   7   8   9   >