[jira] [Commented] (CALCITE-4118) RexSimplify might remove CAST from RexNode incorrectly

[ https://issues.apache.org/jira/browse/CALCITE-4118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17166099#comment-17166099 ] Chunwei Lei commented on CALCITE-4118: -- I opened a PR: 

[jira] [Commented] (CALCITE-4080) Allow character literals as column aliases, if SqlConformance.allowCharLiteralAlias()

[ https://issues.apache.org/jira/browse/CALCITE-4080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17166092#comment-17166092 ] Chunwei Lei commented on CALCITE-4080: -- I thought it's an individual issue. Opening a PR can let

[jira] [Commented] (CALCITE-4080) Allow character literals as column aliases, if SqlConformance.allowCharLiteralAlias()

[ https://issues.apache.org/jira/browse/CALCITE-4080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17165685#comment-17165685 ] Chunwei Lei commented on CALCITE-4080: -- Julian, could you please open a pull request? > Allow

[jira] [Resolved] (CALCITE-4117) Release Calcite 1.24.0

[ https://issues.apache.org/jira/browse/CALCITE-4117?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chunwei Lei resolved CALCITE-4117. -- Resolution: Fixed Fixed in 

[jira] [Commented] (CALCITE-4022) Support unparse special syntax when operator is INSERT

[ https://issues.apache.org/jira/browse/CALCITE-4022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17164805#comment-17164805 ] Chunwei Lei commented on CALCITE-4022: -- [~yanlin-Lynn] I force-pushed the master. Please re-do the

[jira] [Commented] (CALCITE-4115) Improve the prompt of using SQL keywords for sql parser

[ https://issues.apache.org/jira/browse/CALCITE-4115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17164804#comment-17164804 ] Chunwei Lei commented on CALCITE-4115: -- [~danny0405], I force-pushed the master. Could you please

[jira] [Commented] (CALCITE-4118) RexSimplify might remove CAST from RexNode incorrectly

[ https://issues.apache.org/jira/browse/CALCITE-4118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17160870#comment-17160870 ] Chunwei Lei commented on CALCITE-4118: -- I could not find enough time to figure out a perfect fix.

[jira] [Updated] (CALCITE-4118) RexSimplify might remove CAST from RexNode incorrectly

[ https://issues.apache.org/jira/browse/CALCITE-4118?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chunwei Lei updated CALCITE-4118: - Fix Version/s: (was: 1.24.0) > RexSimplify might remove CAST from RexNode incorrectly >

[jira] [Commented] (CALCITE-4081) Round-tripping a DECIMAL literal through Planner -> RelToSqlConverter -> Planner throws validation error

[ https://issues.apache.org/jira/browse/CALCITE-4081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17159817#comment-17159817 ] Chunwei Lei commented on CALCITE-4081: -- I spent some time on it. From what I can see, CAST was

[jira] [Commented] (CALCITE-4118) RexSimplify might remove CAST from RexNode incorrectly

[ https://issues.apache.org/jira/browse/CALCITE-4118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17157913#comment-17157913 ] Chunwei Lei commented on CALCITE-4118: -- I think we'd better get the fix in 1.24. But I could not

[jira] [Resolved] (CALCITE-4094) Allow SqlOperator of SqlKind#OTHER_FUNCTION to define a Strong.Policy

[ https://issues.apache.org/jira/browse/CALCITE-4094?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chunwei Lei resolved CALCITE-4094. -- Resolution: Fixed Fixed in 

[jira] [Commented] (CALCITE-4000) Support OFFSET parameter in TUMBLE/HOP table functions

[ https://issues.apache.org/jira/browse/CALCITE-4000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17157909#comment-17157909 ] Chunwei Lei commented on CALCITE-4000: -- [~amaliujia] , is the PR good enough to be merged? >

[jira] [Updated] (CALCITE-3782) Bitwise operator Bit_And, Bit_OR and Bit_XOR support binary and varbinary type

[ https://issues.apache.org/jira/browse/CALCITE-3782?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chunwei Lei updated CALCITE-3782: - Fix Version/s: (was: 1.24.0) > Bitwise operator Bit_And, Bit_OR and Bit_XOR support binary

[jira] [Updated] (CALCITE-3366) RelDecorrelator supports Union

[ https://issues.apache.org/jira/browse/CALCITE-3366?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chunwei Lei updated CALCITE-3366: - Fix Version/s: (was: 1.24.0) > RelDecorrelator supports Union >

[jira] [Updated] (CALCITE-3517) DiffRepository spends too much time writing XML, makes some tests 5x slower

[ https://issues.apache.org/jira/browse/CALCITE-3517?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chunwei Lei updated CALCITE-3517: - Fix Version/s: (was: 1.24.0) > DiffRepository spends too much time writing XML, makes some

[jira] [Commented] (CALCITE-3517) DiffRepository spends too much time writing XML, makes some tests 5x slower

[ https://issues.apache.org/jira/browse/CALCITE-3517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17157847#comment-17157847 ] Chunwei Lei commented on CALCITE-3517: -- Let us get it into 1.25 since it is not urgent. >

[jira] [Commented] (CALCITE-3936) RelToSqlConverter changes target of ambiguous HAVING clause with a Project on Filter on Aggregate

[ https://issues.apache.org/jira/browse/CALCITE-3936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17157119#comment-17157119 ] Chunwei Lei commented on CALCITE-3936: -- I saw the PR was approved. Could you please squash commits

[jira] [Commented] (CALCITE-3916) Support cascades style top-down driven rule apply

[ https://issues.apache.org/jira/browse/CALCITE-3916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17157106#comment-17157106 ] Chunwei Lei commented on CALCITE-3916: -- Hi, [~FatLittle] and [~hyuan], do you think the PR is good

[jira] [Commented] (CALCITE-3841) Change downloads page to use downloads.apache.org

[ https://issues.apache.org/jira/browse/CALCITE-3841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17157103#comment-17157103 ] Chunwei Lei commented on CALCITE-3841: -- Hi, [~hyuan], Are you making some progress？ > Change

[jira] [Comment Edited] (CALCITE-3517) DiffRepository spends too much time writing XML, makes some tests 5x slower

[ https://issues.apache.org/jira/browse/CALCITE-3517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17157102#comment-17157102 ] Chunwei Lei edited comment on CALCITE-3517 at 7/14/20, 2:57 AM: Hi,

[jira] [Commented] (CALCITE-3517) DiffRepository spends too much time writing XML, makes some tests 5x slower

[ https://issues.apache.org/jira/browse/CALCITE-3517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17157102#comment-17157102 ] Chunwei Lei commented on CALCITE-3517: -- Hi, [~laurent], do you think we can get it into 1.24? >

[jira] [Updated] (CALCITE-4070) Add benchmark test for new Digest interface

[ https://issues.apache.org/jira/browse/CALCITE-4070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chunwei Lei updated CALCITE-4070: - Fix Version/s: (was: 1.24.0) > Add benchmark test for new Digest interface >

[jira] [Comment Edited] (CALCITE-4104) Add automatically link to GitHub PR and 'pull-request-available' label to issues

[ https://issues.apache.org/jira/browse/CALCITE-4104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17151808#comment-17151808 ] Chunwei Lei edited comment on CALCITE-4104 at 7/6/20, 6:58 AM: --- Good

[jira] [Commented] (CALCITE-4104) Add automatically link to GitHub PR and 'pull-request-available' label to issues

[ https://issues.apache.org/jira/browse/CALCITE-4104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17151808#comment-17151808 ] Chunwei Lei commented on CALCITE-4104: -- Nice job(y) > Add automatically link to GitHub PR and

[jira] [Commented] (CALCITE-4098) Remove redundant code in "RelJson.toJson(RelDistribution)"

[ https://issues.apache.org/jira/browse/CALCITE-4098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17149062#comment-17149062 ] Chunwei Lei commented on CALCITE-4098: -- Makes sense. > Remove redundant code in

[jira] [Commented] (CALCITE-4098) Remove redundant code in "RelJson.toJson(RelDistribution)"

[ https://issues.apache.org/jira/browse/CALCITE-4098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17149061#comment-17149061 ] Chunwei Lei commented on CALCITE-4098: -- Attached the PR. > Remove redundant code in

[jira] [Updated] (CALCITE-4098) Remove redundant code in "RelJson.toJson(RelDistribution)"

[ https://issues.apache.org/jira/browse/CALCITE-4098?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chunwei Lei updated CALCITE-4098: - Summary: Remove redundant code in "RelJson.toJson(RelDistribution)" (was: remove redundant

[jira] [Commented] (CALCITE-4097) Avoid requesting unnecessary trait request when deriving traits from child inputs

[ https://issues.apache.org/jira/browse/CALCITE-4097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17149056#comment-17149056 ] Chunwei Lei commented on CALCITE-4097: -- Haha, the format of description is rarely seen. Attached

[jira] [Resolved] (CALCITE-3941) Add the default strict mode to the path in the Json functions

[ https://issues.apache.org/jira/browse/CALCITE-3941?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chunwei Lei resolved CALCITE-3941. -- Fix Version/s: 1.24.0 Resolution: Fixed Fixed in 

[jira] [Commented] (CALCITE-3786) Add Digest interface to enable efficient hashCode(equals) for RexNode and RelNode

[ https://issues.apache.org/jira/browse/CALCITE-3786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17142172#comment-17142172 ] Chunwei Lei commented on CALCITE-3786: -- > Your patch collects the digest items every time we do

[jira] [Commented] (CALCITE-3786) Add Digest interface to enable efficient hashCode(equals) for RexNode and RelNode

[ https://issues.apache.org/jira/browse/CALCITE-3786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17142132#comment-17142132 ] Chunwei Lei commented on CALCITE-3786: -- IMHO, the latest change proposed by [~hyuan] is

[jira] [Commented] (CALCITE-3923) Refactor how planner rules are parameterized

[ https://issues.apache.org/jira/browse/CALCITE-3923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17140190#comment-17140190 ] Chunwei Lei commented on CALCITE-3923: -- Comparing the new approach, the older one seems simpler

[jira] [Commented] (CALCITE-4071) Make RelNode Immutable

[ https://issues.apache.org/jira/browse/CALCITE-4071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17140186#comment-17140186 ] Chunwei Lei commented on CALCITE-4071: -- I recommend deprecating it first since there are some

[jira] [Commented] (CALCITE-4073) Add a new component RexNormalize for more effect rex nodes normalization

[ https://issues.apache.org/jira/browse/CALCITE-4073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17140168#comment-17140168 ] Chunwei Lei commented on CALCITE-4073: -- For complex queries, the normalization would be

[jira] [Resolved] (CALCITE-4060) TypeCoercionImpl#inOperationCoercion doesn't consider NOT_IN.

[ https://issues.apache.org/jira/browse/CALCITE-4060?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chunwei Lei resolved CALCITE-4060. -- Resolution: Fixed Fixed in 

[jira] [Resolved] (CALCITE-4020) Support Calc operator in RelFieldTrimmer

[ https://issues.apache.org/jira/browse/CALCITE-4020?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chunwei Lei resolved CALCITE-4020. -- Fix Version/s: 1.24.0 Resolution: Fixed Fixed in

[jira] [Commented] (CALCITE-3923) Refactor how planner rules are parameterized

[ https://issues.apache.org/jira/browse/CALCITE-3923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17139174#comment-17139174 ] Chunwei Lei commented on CALCITE-3923: -- Thanks for working on this, [~julianhyde]. Would it lead

[jira] [Comment Edited] (CALCITE-3786) Add Digest interface to enable efficient hashCode(equals) for RexNode and RelNode

[ https://issues.apache.org/jira/browse/CALCITE-3786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17139099#comment-17139099 ] Chunwei Lei edited comment on CALCITE-3786 at 6/18/20, 5:16 AM:

[jira] [Commented] (CALCITE-3786) Add Digest interface to enable efficient hashCode(equals) for RexNode and RelNode

[ https://issues.apache.org/jira/browse/CALCITE-3786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17139099#comment-17139099 ] Chunwei Lei commented on CALCITE-3786: -- [~julianhyde], I don't agree with you. The owner should

[jira] [Commented] (CALCITE-4047) at org.apache.calcite.rel.rules.PushProjector.getAdjustments(java.lang.ArrayIndexOutOfBoundsException: 0)

[ https://issues.apache.org/jira/browse/CALCITE-4047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17135383#comment-17135383 ] Chunwei Lei commented on CALCITE-4047: -- Thank you for reporting this, [~jamie12221]. Could you

[jira] [Commented] (CALCITE-4046) Check the number of input nodes(org.apache.calcite.interpreter.SetOpNode)

[ https://issues.apache.org/jira/browse/CALCITE-4046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17135382#comment-17135382 ] Chunwei Lei commented on CALCITE-4046: -- Thank you for reporting this, [~jamie12221]. Could you

[jira] [Commented] (CALCITE-4056) Remove Digest from RelNode and RexNode

[ https://issues.apache.org/jira/browse/CALCITE-4056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17135379#comment-17135379 ] Chunwei Lei commented on CALCITE-4056: -- The digest of RexNode seems useless, while the digest of

[jira] [Commented] (CALCITE-4058) Add Limit and LogicalLimit operator and deprecate limit in Sort

[ https://issues.apache.org/jira/browse/CALCITE-4058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17135375#comment-17135375 ] Chunwei Lei commented on CALCITE-4058: -- I could not agree more(y). > Add Limit and LogicalLimit

[jira] [Resolved] (CALCITE-4016) Implement trait propagation for EnumerableCalc

[ https://issues.apache.org/jira/browse/CALCITE-4016?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chunwei Lei resolved CALCITE-4016. -- Resolution: Fixed Fixed in 

[jira] [Commented] (CALCITE-4016) Implement trait propagation for EnumerableCalc

[ https://issues.apache.org/jira/browse/CALCITE-4016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17113694#comment-17113694 ] Chunwei Lei commented on CALCITE-4016: -- OK. Thanks for your kindly reminder, [~amaliujia] . >

[jira] [Comment Edited] (CALCITE-2997) Avoid pushing down join condition in SqlToRelConverter

[ https://issues.apache.org/jira/browse/CALCITE-2997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17112733#comment-17112733 ] Chunwei Lei edited comment on CALCITE-2997 at 5/21/20, 2:29 AM: Should

[jira] [Commented] (CALCITE-2997) Avoid pushing down join condition in SqlToRelConverter

[ https://issues.apache.org/jira/browse/CALCITE-2997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17112733#comment-17112733 ] Chunwei Lei commented on CALCITE-2997: -- I think It may be less overhead if such optimizations are

[jira] [Commented] (CALCITE-4016) Implement trait propagation for EnumerableCalc

[ https://issues.apache.org/jira/browse/CALCITE-4016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17112729#comment-17112729 ] Chunwei Lei commented on CALCITE-4016: -- [~hyuan] , I would like to take it. > Implement trait

[jira] [Assigned] (CALCITE-4016) Implement trait propagation for EnumerableCalc

[ https://issues.apache.org/jira/browse/CALCITE-4016?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chunwei Lei reassigned CALCITE-4016: Assignee: Chunwei Lei > Implement trait propagation for EnumerableCalc >

[jira] [Commented] (CALCITE-3987) Allow addition and subtraction operations between DATE and NUMERIC types.

[ https://issues.apache.org/jira/browse/CALCITE-3987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17104540#comment-17104540 ] Chunwei Lei commented on CALCITE-3987: -- Just for curious, What products support this syntax? >

[jira] [Commented] (CALCITE-3988) Intersect in RelMdRowCount doesn't take into account 'intersect all'

[ https://issues.apache.org/jira/browse/CALCITE-3988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17104538#comment-17104538 ] Chunwei Lei commented on CALCITE-3988: -- [~xzh_dz] , thanks for the pr. I left some comments. >

[jira] [Comment Edited] (CALCITE-3972) Allow RelBuilder to create RelNode with convention and use it for trait convert

[ https://issues.apache.org/jira/browse/CALCITE-3972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17100394#comment-17100394 ] Chunwei Lei edited comment on CALCITE-3972 at 5/6/20, 5:19 AM: --- Add the

[jira] [Comment Edited] (CALCITE-3972) Allow RelBuilder to create RelNode with convention and use it for trait convert

[ https://issues.apache.org/jira/browse/CALCITE-3972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17100394#comment-17100394 ] Chunwei Lei edited comment on CALCITE-3972 at 5/6/20, 5:19 AM: --- Add the

[jira] [Commented] (CALCITE-3972) Allow RelBuilder to create RelNode with convention and use it for trait convert

[ https://issues.apache.org/jira/browse/CALCITE-3972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17100394#comment-17100394 ] Chunwei Lei commented on CALCITE-3972: -- Add the PR link:

[jira] [Resolved] (CALCITE-3938) Support LogicalCalc in RelShuttle

[ https://issues.apache.org/jira/browse/CALCITE-3938?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chunwei Lei resolved CALCITE-3938. -- Fix Version/s: 1.23.0 Assignee: Chunwei Lei Resolution: Fixed Fixed in 

[jira] [Commented] (CALCITE-3948) Improve operand's RelSubset matching handling in VolcanoRuleCall

[ https://issues.apache.org/jira/browse/CALCITE-3948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17089519#comment-17089519 ] Chunwei Lei commented on CALCITE-3948: -- I saw [~botong] had opened a pr: 

[jira] [Commented] (CALCITE-3940) Hint item can not parse correctly if the name is right after token "/*+"

[ https://issues.apache.org/jira/browse/CALCITE-3940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17087377#comment-17087377 ] Chunwei Lei commented on CALCITE-3940: -- Hint item can not parse correctly -> Hint item can not be

[jira] [Commented] (CALCITE-3938) Support LogicalCalc in RelShuttle

[ https://issues.apache.org/jira/browse/CALCITE-3938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17087327#comment-17087327 ] Chunwei Lei commented on CALCITE-3938: -- Agree with [~jinxing6...@126.com]. > Support LogicalCalc

[jira] [Updated] (CALCITE-3938) Support LogicalCalc in RelShuttle

[ https://issues.apache.org/jira/browse/CALCITE-3938?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chunwei Lei updated CALCITE-3938: - Summary: Support LogicalCalc in RelShuttle (was: implement visit LogicalCalc in

[jira] [Resolved] (CALCITE-3909) RelMdMinRowCount doesn't take into account UNION DISTINCT

[ https://issues.apache.org/jira/browse/CALCITE-3909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chunwei Lei resolved CALCITE-3909. -- Fix Version/s: 1.23.0 Resolution: Fixed Fixed in 

[jira] [Comment Edited] (CALCITE-3919) Upgrade ProjectJoinTransposeRule to allow user choose whether to keep join condition

[ https://issues.apache.org/jira/browse/CALCITE-3919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17082069#comment-17082069 ] Chunwei Lei edited comment on CALCITE-3919 at 4/13/20, 5:19 AM: I don't

[jira] [Commented] (CALCITE-3919) Upgrade ProjectJoinTransposeRule to allow user choose whether to keep join condition

[ https://issues.apache.org/jira/browse/CALCITE-3919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17082069#comment-17082069 ] Chunwei Lei commented on CALCITE-3919: -- I don't think it is a bug. The condition seems useless if 

[jira] [Commented] (CALCITE-3910) Enhance ProjectJoinTransposeRule to support SemiJoin and AntiJoin

[ https://issues.apache.org/jira/browse/CALCITE-3910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17082017#comment-17082017 ] Chunwei Lei commented on CALCITE-3910: -- [~fan_li_ya] , go ahead. > Enhance

[jira] [Commented] (CALCITE-3910) Enhance ProjectJoinTransposeRule to support SemiJoin and AntiJoin

[ https://issues.apache.org/jira/browse/CALCITE-3910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17082011#comment-17082011 ] Chunwei Lei commented on CALCITE-3910: -- [~zabetak] , no, I am not working on this. > Enhance

[jira] [Commented] (CALCITE-3890) Infer IS NOT NULL predicate from join

[ https://issues.apache.org/jira/browse/CALCITE-3890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17081110#comment-17081110 ] Chunwei Lei commented on CALCITE-3890: -- [~vgarg], [~kgyrtkirk] Instead of using a rule to add

[jira] [Commented] (CALCITE-3915) Add rule listener to report rule attempts and time at DEBUG log level

[ https://issues.apache.org/jira/browse/CALCITE-3915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17081109#comment-17081109 ] Chunwei Lei commented on CALCITE-3915: -- +1 for adding such a listener. > Add rule listener to

[jira] [Commented] (CALCITE-3913) Test correctness using formal verification techniques

[ https://issues.apache.org/jira/browse/CALCITE-3913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17081108#comment-17081108 ] Chunwei Lei commented on CALCITE-3913: -- Interesting work! I think checking the rule correctness is

[jira] [Updated] (CALCITE-3910) Enhance ProjectJoinTransposeRule to support SemiJoin and AntiJoin

[ https://issues.apache.org/jira/browse/CALCITE-3910?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chunwei Lei updated CALCITE-3910: - Description: Currently, ProjectJoinTransposeRule does not support push project pass SemiJoin

[jira] [Created] (CALCITE-3910) Enhance ProjectJoinTransposeRule to support SemiJoin and AntiJoin

Chunwei Lei created CALCITE-3910: Summary: Enhance ProjectJoinTransposeRule to support SemiJoin and AntiJoin Key: CALCITE-3910 URL: https://issues.apache.org/jira/browse/CALCITE-3910 Project: Calcite

[jira] [Updated] (CALCITE-3909) RelMdMinRowCount doesn't take into account UNION DISTINCT

[ https://issues.apache.org/jira/browse/CALCITE-3909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chunwei Lei updated CALCITE-3909: - Description: When computing minRowCount for Union, it doesn't task into account UNION

[jira] [Created] (CALCITE-3909) RelMdMinRowCount doesn't take into account UNION DISTINCT

Chunwei Lei created CALCITE-3909: Summary: RelMdMinRowCount doesn't take into account UNION DISTINCT Key: CALCITE-3909 URL: https://issues.apache.org/jira/browse/CALCITE-3909 Project: Calcite

[jira] [Resolved] (CALCITE-3726) Allow declaring type objects

[ https://issues.apache.org/jira/browse/CALCITE-3726?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chunwei Lei resolved CALCITE-3726. -- Resolution: Fixed The document is added via 

[jira] [Resolved] (CALCITE-3835) Overloaded table functions fail with an assertion error if param types differ

[ https://issues.apache.org/jira/browse/CALCITE-3835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chunwei Lei resolved CALCITE-3835. -- Resolution: Fixed Fixed in 

[jira] [Resolved] (CALCITE-3851) Replace the node importance map with a set for pruned nodes

[ https://issues.apache.org/jira/browse/CALCITE-3851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chunwei Lei resolved CALCITE-3851. -- Fix Version/s: 1.23.0 Assignee: Chunwei Lei Resolution: Fixed Fixed in 

[jira] [Resolved] (CALCITE-3872) Simplify expressions with unary minus

[ https://issues.apache.org/jira/browse/CALCITE-3872?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chunwei Lei resolved CALCITE-3872. -- Fix Version/s: 1.23.0 Assignee: Chunwei Lei Resolution: Fixed Fixed in 

[jira] [Commented] (CALCITE-2970) Performance issue when enabling abstract converter for EnumerableConvention

[ https://issues.apache.org/jira/browse/CALCITE-2970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17076835#comment-17076835 ] Chunwei Lei commented on CALCITE-2970: -- Agree with [~hyuan] and [~danny0405]. > Performance issue

[jira] [Resolved] (CALCITE-3891) Remove use of Pair.zip in RelTraitSet.satisfies

[ https://issues.apache.org/jira/browse/CALCITE-3891?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chunwei Lei resolved CALCITE-3891. -- Fix Version/s: 1.23.0 Resolution: Fixed Fixed in 

[jira] [Commented] (CALCITE-3891) Remove use of Pair.zip in RelTraitSet.satisfies

[ https://issues.apache.org/jira/browse/CALCITE-3891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17073340#comment-17073340 ] Chunwei Lei commented on CALCITE-3891: -- [~hyuan],  I would like to take it if you don't mind. >

[jira] [Assigned] (CALCITE-3891) Remove use of Pair.zip in RelTraitSet.satisfies

[ https://issues.apache.org/jira/browse/CALCITE-3891?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chunwei Lei reassigned CALCITE-3891: Assignee: Chunwei Lei > Remove use of Pair.zip in RelTraitSet.satisfies >

[jira] [Commented] (CALCITE-3891) Remove use of Pair.zip in RelTraitSet.satisfies

[ https://issues.apache.org/jira/browse/CALCITE-3891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17073328#comment-17073328 ] Chunwei Lei commented on CALCITE-3891: -- It seems we can use a simpler way to implement it just as

[jira] [Assigned] (CALCITE-3890) Infer IS NOT NULL predicate from join

[ https://issues.apache.org/jira/browse/CALCITE-3890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chunwei Lei reassigned CALCITE-3890: Assignee: Vineet Garg (was: Chunwei Lei) > Infer IS NOT NULL predicate from join >

[jira] [Commented] (CALCITE-3890) Infer IS NOT NULL predicate from join

[ https://issues.apache.org/jira/browse/CALCITE-3890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17073323#comment-17073323 ] Chunwei Lei commented on CALCITE-3890: -- [~vgarg], welcome to contribute. I assigned the issue to

[jira] [Comment Edited] (CALCITE-3890) Infer IS NOT NULL predicate from join

[ https://issues.apache.org/jira/browse/CALCITE-3890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17073323#comment-17073323 ] Chunwei Lei edited comment on CALCITE-3890 at 4/2/20, 2:39 AM: --- [~vgarg],

[jira] [Assigned] (CALCITE-3890) Infer IS NOT NULL predicate from join

[ https://issues.apache.org/jira/browse/CALCITE-3890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chunwei Lei reassigned CALCITE-3890: Assignee: Chunwei Lei > Infer IS NOT NULL predicate from join >

[jira] [Created] (CALCITE-3890) Infer IS NOT NULL predicate from join

Chunwei Lei created CALCITE-3890: Summary: Infer IS NOT NULL predicate from join Key: CALCITE-3890 URL: https://issues.apache.org/jira/browse/CALCITE-3890 Project: Calcite Issue Type:

[jira] [Comment Edited] (CALCITE-3884) Return type for SIGN function is incorrect

[ https://issues.apache.org/jira/browse/CALCITE-3884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17072358#comment-17072358 ] Chunwei Lei edited comment on CALCITE-3884 at 4/1/20, 3:47 AM: --- Thanks

[jira] [Commented] (CALCITE-3884) Return type for SIGN function is incorrect

[ https://issues.apache.org/jira/browse/CALCITE-3884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17072358#comment-17072358 ] Chunwei Lei commented on CALCITE-3884: -- I checked the docs of PostgreSQL[1] and it says the return

[jira] [Commented] (CALCITE-3851) Replace the node importance map with a set for pruned nodes

[ https://issues.apache.org/jira/browse/CALCITE-3851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17072320#comment-17072320 ] Chunwei Lei commented on CALCITE-3851: -- I would like to merge this pr if there are no other

[jira] [Commented] (CALCITE-3889) Add apply(Mappings.Mapping) to RelTrait and RelTraitSet

[ https://issues.apache.org/jira/browse/CALCITE-3889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17072318#comment-17072318 ] Chunwei Lei commented on CALCITE-3889: -- +1 for adding such a method.  > Add

[jira] [Commented] (CALCITE-3873) Use global caching for ReflectiveVisitDispatcher implementation

[ https://issues.apache.org/jira/browse/CALCITE-3873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17068247#comment-17068247 ] Chunwei Lei commented on CALCITE-3873: -- Nice job~ > Use global caching for

[jira] [Resolved] (CALCITE-3852) RexSimplify doesn't simplify NOT EQUAL predicates

[ https://issues.apache.org/jira/browse/CALCITE-3852?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chunwei Lei resolved CALCITE-3852. -- Fix Version/s: 1.23.0 Resolution: Fixed > RexSimplify doesn't simplify NOT EQUAL

[jira] [Commented] (CALCITE-3852) RexSimplify doesn't simplify NOT EQUAL predicates

[ https://issues.apache.org/jira/browse/CALCITE-3852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17061360#comment-17061360 ] Chunwei Lei commented on CALCITE-3852: -- Fixed in 

[jira] [Comment Edited] (CALCITE-3851) Replace the node importance map with a set for pruned nodes

[ https://issues.apache.org/jira/browse/CALCITE-3851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17060609#comment-17060609 ] Chunwei Lei edited comment on CALCITE-3851 at 3/17/20, 3:47 AM: I agree

[jira] [Commented] (CALCITE-3851) Replace the node importance map with a set for pruned nodes

[ https://issues.apache.org/jira/browse/CALCITE-3851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17060609#comment-17060609 ] Chunwei Lei commented on CALCITE-3851: -- I agree with [~julianhyde] . Besides, the pr looks good to

[jira] [Resolved] (CALCITE-3694) Implement SINH function

[ https://issues.apache.org/jira/browse/CALCITE-3694?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chunwei Lei resolved CALCITE-3694. -- Fix Version/s: 1.23.0 Resolution: Fixed Fixed in 

[jira] [Resolved] (CALCITE-3704) Implement STRCMP function

[ https://issues.apache.org/jira/browse/CALCITE-3704?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chunwei Lei resolved CALCITE-3704. -- Fix Version/s: 1.23.0 Resolution: Fixed Fixed in 

[jira] [Commented] (CALCITE-3852) RexSimplify doesn't simplify NOT EQUAL predicates

[ https://issues.apache.org/jira/browse/CALCITE-3852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17057677#comment-17057677 ] Chunwei Lei commented on CALCITE-3852: -- Makes sense. I would update the pr. > RexSimplify doesn't

[jira] [Commented] (CALCITE-3852) RexSimplify doesn't simplify NOT EQUAL predicates

[ https://issues.apache.org/jira/browse/CALCITE-3852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17057584#comment-17057584 ] Chunwei Lei commented on CALCITE-3852: -- Thanks for your reply, [~kgyrtkirk]. I am wondering it

[jira] [Updated] (CALCITE-3842) RexSimplify doesn't simplify range predicates

[ https://issues.apache.org/jira/browse/CALCITE-3842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chunwei Lei updated CALCITE-3842: - Summary: RexSimplify doesn't simplify range predicates (was: RexSimplify doesn't simplify

[jira] [Commented] (CALCITE-3851) Replace the node importance map with a set for pruned nodes

[ https://issues.apache.org/jira/browse/CALCITE-3851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17057579#comment-17057579 ] Chunwei Lei commented on CALCITE-3851: -- IMHO, the api {{setImportance}} is a little confusing.

<    1   2   3   4   5   6   7   8   9   >