[jira] [Commented] (CALCITE-2948) Complicated logical plan generated for in subquery with non-equi condition

2019-04-26 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16827371#comment-16827371 ] Danny Chan commented on CALCITE-2948: - [~hyuan] [~julianhyde] I also think a rule match is more

[jira] [Commented] (CALCITE-2282) Allow OperatorTable to be pluggable in the parser

2019-04-25 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16826600#comment-16826600 ] Danny Chan commented on CALCITE-2282: - [~julianhyde] i'm planning to remove the sql operator table

[jira] [Commented] (CALCITE-3016) Reorganize the operator tables

2019-04-25 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16826592#comment-16826592 ] Danny Chan commented on CALCITE-3016: - [~julianhyde] Thx for the review I have updated the PR

[jira] [Comment Edited] (CALCITE-2282) Allow OperatorTable to be pluggable in the parser

2019-04-25 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16826033#comment-16826033 ] Danny Chan edited comment on CALCITE-2282 at 4/25/19 12:56 PM: ---

[jira] [Commented] (CALCITE-2282) Allow OperatorTable to be pluggable in the parser

2019-04-25 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16826033#comment-16826033 ] Danny Chan commented on CALCITE-2282: - [~julianhyde] I did more tests and i make sure we can

[jira] [Commented] (CALCITE-2846) Document Oracle-specific functions, such as NVL and LTRIM, in the SQL reference

2019-04-25 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16825896#comment-16825896 ] Danny Chan commented on CALCITE-2846: - Thx for your review, [~Chunwei Lei] ! > Document

[jira] [Commented] (CALCITE-2282) Allow OperatorTable to be pluggable in the parser

2019-04-24 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16825709#comment-16825709 ] Danny Chan commented on CALCITE-2282: - [~hhlai1990] Seems you really have much requests about

[jira] [Comment Edited] (CALCITE-2846) Document Oracle-specific functions, such as NVL and LTRIM, in the SQL reference

2019-04-24 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16825697#comment-16825697 ] Danny Chan edited comment on CALCITE-2846 at 4/25/19 4:06 AM: --

[jira] [Commented] (CALCITE-2846) Document Oracle-specific functions, such as NVL and LTRIM, in the SQL reference

2019-04-24 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16825697#comment-16825697 ] Danny Chan commented on CALCITE-2846: - [~julianhyde] I have fire a PR 

[jira] [Commented] (CALCITE-2846) Document Oracle-specific functions, such as NVL and LTRIM, in the SQL reference

2019-04-24 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16824887#comment-16824887 ] Danny Chan commented on CALCITE-2846: - link as a sub task > Document Oracle-specific functions,

[jira] [Created] (CALCITE-3016) Reorganize the operator tables

2019-04-24 Thread Danny Chan (JIRA)
Danny Chan created CALCITE-3016: --- Summary: Reorganize the operator tables Key: CALCITE-3016 URL: https://issues.apache.org/jira/browse/CALCITE-3016 Project: Calcite Issue Type: Improvement

[jira] [Commented] (CALCITE-2282) Allow OperatorTable to be pluggable in the parser

2019-04-24 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16824872#comment-16824872 ] Danny Chan commented on CALCITE-2282: - [~julianhyde] I'm a little confused about this:

[jira] [Comment Edited] (CALCITE-2282) Allow OperatorTable to be pluggable in the parser

2019-04-23 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16824786#comment-16824786 ] Danny Chan edited comment on CALCITE-2282 at 4/24/19 3:50 AM: --

[jira] [Commented] (CALCITE-2282) Allow OperatorTable to be pluggable in the parser

2019-04-23 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16824786#comment-16824786 ] Danny Chan commented on CALCITE-2282: - [~julianhyde] We did have an identifier in sql call[1], now

[jira] [Comment Edited] (CALCITE-2282) Allow OperatorTable to be pluggable in the parser

2019-04-23 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16823836#comment-16823836 ] Danny Chan edited comment on CALCITE-2282 at 4/23/19 8:43 AM: --

[jira] [Commented] (CALCITE-2282) Allow OperatorTable to be pluggable in the parser

2019-04-23 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16823836#comment-16823836 ] Danny Chan commented on CALCITE-2282: - [~julianhyde] After i remove the code snippet, the unparsed

[jira] [Commented] (CALCITE-2969) Improve design of join-like relational expressions

2019-04-22 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16823651#comment-16823651 ] Danny Chan commented on CALCITE-2969: - [~julianhyde] Thanks for your review, i have made the

[jira] [Commented] (CALCITE-2282) Allow OperatorTable to be pluggable in the parser

2019-04-22 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16823623#comment-16823623 ] Danny Chan commented on CALCITE-2282: - [~julianhyde] Seems that this code snippet is useless now, i

[jira] [Assigned] (CALCITE-2846) Document Oracle-specific functions, such as NVL and LTRIM, in the SQL reference

2019-04-22 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2846?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan reassigned CALCITE-2846: --- Assignee: Danny Chan > Document Oracle-specific functions, such as NVL and LTRIM, in the

[jira] [Closed] (CALCITE-1624) Inefficient plan for NOT IN correlated subqueries

2019-04-22 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1624?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan closed CALCITE-1624. --- Resolution: Fixed > Inefficient plan for NOT IN correlated subqueries >

[jira] [Commented] (CALCITE-1624) Inefficient plan for NOT IN correlated subqueries

2019-04-22 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16823047#comment-16823047 ] Danny Chan commented on CALCITE-1624: - [~vgarg] Yeah, you are right, i missed that it is a left

[jira] [Commented] (CALCITE-482) Implement sql and planner hints

2019-04-22 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16823027#comment-16823027 ] Danny Chan commented on CALCITE-482: [~julianhyde] may i take this issue ?:D > Implement sql and

[jira] [Commented] (CALCITE-2974) Timestamp conversion performance can be improved

2019-04-22 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16822946#comment-16822946 ] Danny Chan commented on CALCITE-2974: - [~ValTrofFuture] Thx for your perf data report, what

[jira] [Commented] (CALCITE-2948) SqlToRelConverter generates complicated logical plan for in subquery with non-equi condition

2019-04-19 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16822343#comment-16822343 ] Danny Chan commented on CALCITE-2948: - [~hyuan] yes, i add `testRemoveSemiJoin1()` and

[jira] [Commented] (CALCITE-1624) Inefficient plan for NOT IN correlated subqueries

2019-04-19 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16821775#comment-16821775 ] Danny Chan commented on CALCITE-1624: - Hei, [~vgarg], when i attach the test case to

[jira] [Assigned] (CALCITE-1624) Inefficient plan for NOT IN correlated subqueries

2019-04-18 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1624?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan reassigned CALCITE-1624: --- Assignee: Danny Chan > Inefficient plan for NOT IN correlated subqueries >

[jira] [Commented] (CALCITE-2282) Allow OperatorTable to be pluggable in the parser

2019-04-18 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16821049#comment-16821049 ] Danny Chan commented on CALCITE-2282: - [~zhztheplayer] The parser has a hard code SqlStdOperator

[jira] [Commented] (CALCITE-1624) Inefficient plan for NOT IN correlated subqueries

2019-04-18 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16820788#comment-16820788 ] Danny Chan commented on CALCITE-1624: - [~vgarg] may i take this issue ? i would take it if you

[jira] [Commented] (CALCITE-2948) SqlToRelConverter generates complicated logical plan for in subquery with non-equi condition

2019-04-17 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16820661#comment-16820661 ] Danny Chan commented on CALCITE-2948: - [~vvysotskyi] The aggregate group set keys are already added

[jira] [Commented] (CALCITE-1531) SqlValidatorException when boolean operators are used with NULL

2019-04-17 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16819945#comment-16819945 ] Danny Chan commented on CALCITE-1531: - This kind of in the scope of implicit type coercion. >

[jira] [Issue Comment Deleted] (CALCITE-2948) SqlToRelConverter generates complicated logical plan for in subquery with non-equi condition

2019-04-17 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2948?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan updated CALCITE-2948: Comment: was deleted (was: Hi [~hyuan] [~zabetak] [~julianhyde] [~vgarg]  I have applied a

[jira] [Commented] (CALCITE-2948) SqlToRelConverter generates complicated logical plan for in subquery with non-equi condition

2019-04-17 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16819927#comment-16819927 ] Danny Chan commented on CALCITE-2948: - Hi [~hyuan] [~zabetak] [~julianhyde] [~vgarg]  I have

[jira] [Commented] (CALCITE-2948) SqlToRelConverter generates complicated logical plan for in subquery with non-equi condition

2019-04-17 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16819916#comment-16819916 ] Danny Chan commented on CALCITE-2948: - Hi [~hyuan] [~zabetak] [~julianhyde] [~vgarg]  I have

[jira] [Assigned] (CALCITE-2166) Cumulative cost of RelSubset.best RelNode is increased after calling RelSubset.propagateCostImprovements() for input RelNodes

2019-04-16 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2166?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan reassigned CALCITE-2166: --- Assignee: Danny Chan > Cumulative cost of RelSubset.best RelNode is increased after

[jira] [Commented] (CALCITE-2018) Queries failed with AssertionError: rel has lower cost than best cost of subset

2019-04-16 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16818906#comment-16818906 ] Danny Chan commented on CALCITE-2018: - [~vvysotskyi] Ok, i will try to fix CALCITE-2166 and then

[jira] [Commented] (CALCITE-2933) In Druid adapter, expression like "cast(cast(\"timestamp\" as timestamp) as varchar)" returns as epoch millisecond

2019-04-16 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16818719#comment-16818719 ] Danny Chan commented on CALCITE-2933: - [~zhztheplayer] Do you think the patch is okey now ? Should

[jira] [Commented] (CALCITE-2999) Can't get the right column value in LogicalSort

2019-04-16 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16818714#comment-16818714 ] Danny Chan commented on CALCITE-2999: - [~zhztheplayer] Got your idea, the RelRoot is a little

[jira] [Commented] (CALCITE-2966) Problem with Code Generation

2019-04-16 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16818681#comment-16818681 ] Danny Chan commented on CALCITE-2966: - I think you can close it, thx for your work

[jira] [Assigned] (CALCITE-2018) Queries failed with AssertionError: rel has lower cost than best cost of subset

2019-04-16 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2018?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan reassigned CALCITE-2018: --- Assignee: Danny Chan > Queries failed with AssertionError: rel has lower cost than best

[jira] [Comment Edited] (CALCITE-2966) Problem with Code Generation

2019-04-16 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16818673#comment-16818673 ] Danny Chan edited comment on CALCITE-2966 at 4/16/19 6:08 AM: -- Instead of

[jira] [Commented] (CALCITE-2018) Queries failed with AssertionError: rel has lower cost than best cost of subset

2019-04-16 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16818668#comment-16818668 ] Danny Chan commented on CALCITE-2018: - [~vvysotskyi] [~julianhyde] Any progress on this issue? I

[jira] [Issue Comment Deleted] (CALCITE-3004) ProjectSetOpTransposeRule pushes RexOver down incorrectly

2019-04-15 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3004?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan updated CALCITE-3004: Comment: was deleted (was: [~zhztheplayer] i will take this issue if you agree.) >

[jira] [Commented] (CALCITE-3004) ProjectSetOpTransposeRule pushes RexOver down incorrectly

2019-04-15 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16818608#comment-16818608 ] Danny Chan commented on CALCITE-3004: - [~zhztheplayer] i will take this issue if you agree. >

[jira] [Commented] (CALCITE-3002) Case statement fails with: SqlValidatorException: Cannot apply '=' to arguments of type ' = '.

2019-04-15 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16818600#comment-16818600 ] Danny Chan commented on CALCITE-3002: - It's true that now Calcite does not support implicit type

[jira] [Commented] (CALCITE-2999) Can't get the right column value in LogicalSort

2019-04-15 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16817806#comment-16817806 ] Danny Chan commented on CALCITE-2999: - I'm not that sure until i'm fixing, but the plan is wrong

[jira] [Assigned] (CALCITE-2999) Can't get the right column value in LogicalSort

2019-04-15 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2999?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan reassigned CALCITE-2999: --- Assignee: Danny Chan > Can't get the right column value in LogicalSort >

[jira] [Commented] (CALCITE-2999) Can't get the right column value in LogicalSort

2019-04-15 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16817655#comment-16817655 ] Danny Chan commented on CALCITE-2999: - I checked sql-standard 2011 and the sort specification list

[jira] [Comment Edited] (CALCITE-2966) Problem with Code Generation

2019-04-14 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16817510#comment-16817510 ] Danny Chan edited comment on CALCITE-2966 at 4/15/19 2:48 AM: --

[jira] [Commented] (CALCITE-2966) Problem with Code Generation

2019-04-14 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16817510#comment-16817510 ] Danny Chan commented on CALCITE-2966: - [~julian.feinauer] I have got the reason, for PREV($UP.x,

[jira] [Commented] (CALCITE-2997) Avoid pushing down join condition in SqlToRelConverter

2019-04-14 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16817500#comment-16817500 ] Danny Chan commented on CALCITE-2997: - So in what scene you must rely on the logical plan exactly ?

[jira] [Commented] (CALCITE-2204) Volcano Planner may not choose the cheapest cost plan

2019-04-13 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16817167#comment-16817167 ] Danny Chan commented on CALCITE-2204: - There are many problems that are addressed in CALCITE-2018,

[jira] [Comment Edited] (CALCITE-2986) Wrong results with =ANY subquery

2019-04-13 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16817165#comment-16817165 ] Danny Chan edited comment on CALCITE-2986 at 4/14/19 2:22 AM: -- {quote}I am

[jira] [Commented] (CALCITE-2994) Least restrictive type among structs does not consider nullability

2019-04-12 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16816837#comment-16816837 ] Danny Chan commented on CALCITE-2994: - The current code already consider structured type [1], so

[jira] [Commented] (CALCITE-2974) Timestamp conversion performance can be improved

2019-04-12 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16816836#comment-16816836 ] Danny Chan commented on CALCITE-2974: - Well, i also think the code consistent is very important

[jira] [Commented] (CALCITE-2966) Problem with Code Generation

2019-04-12 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16816827#comment-16816827 ] Danny Chan commented on CALCITE-2966: - Sorry, i don't think there is any bug for the code snippet

[jira] [Comment Edited] (CALCITE-2966) Problem with Code Generation

2019-04-12 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16816827#comment-16816827 ] Danny Chan edited comment on CALCITE-2966 at 4/13/19 4:16 AM: -- Sorry, i

[jira] [Commented] (CALCITE-2969) Improve design of join-like relational expressions

2019-04-12 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16816820#comment-16816820 ] Danny Chan commented on CALCITE-2969: - [~hyuan] I also think so, so for the first PR, i almost

[jira] [Comment Edited] (CALCITE-2986) Wrong results with =ANY subquery

2019-04-12 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16816817#comment-16816817 ] Danny Chan edited comment on CALCITE-2986 at 4/13/19 3:34 AM: --   {quote}IN

[jira] [Commented] (CALCITE-2986) Wrong results with =ANY subquery

2019-04-12 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16816817#comment-16816817 ] Danny Chan commented on CALCITE-2986: - >  IN corresponds to = and is rewritten using LEFT OUTER

[jira] [Commented] (CALCITE-2966) Problem with Code Generation

2019-04-12 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16816213#comment-16816213 ] Danny Chan commented on CALCITE-2966: - [~julian.feinauer] I would check this soon, i'm so sorry

[jira] [Commented] (CALCITE-2986) Wrong results with =ANY subquery

2019-04-12 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16816096#comment-16816096 ] Danny Chan commented on CALCITE-2986: - [~vgarg] Agree with you that the semi join should not only

[jira] [Commented] (CALCITE-2992) Make implicit conversions when generating hash join keys for an equiCondition

2019-04-12 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16816077#comment-16816077 ] Danny Chan commented on CALCITE-2992: - I don't think it's a good idea to coerce type int (long) to

[jira] [Commented] (CALCITE-2973) Allow theta joins that have equi conditions to be executed using a hash join algorithm

2019-04-12 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16816069#comment-16816069 ] Danny Chan commented on CALCITE-2973: - Hi, [~hhlai1990], i think this issue has strong association

[jira] [Commented] (CALCITE-2981) Syntax error with simple nested select query

2019-04-08 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16812426#comment-16812426 ] Danny Chan commented on CALCITE-2981: - [~vamshi.v.kris...@gmail.com] Seems should not happen, i

[jira] [Assigned] (CALCITE-2981) Syntax error with simple nested select query

2019-04-08 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan reassigned CALCITE-2981: --- Assignee: Danny Chan > Syntax error with simple nested select query >

[jira] [Commented] (CALCITE-2980) Implement the FORMAT clause of the CAST operator (added in SQL:2016)

2019-04-04 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16810460#comment-16810460 ] Danny Chan commented on CALCITE-2980: - [~julianhyde] I would like to take this issue. > Implement

[jira] [Assigned] (CALCITE-2980) Implement the FORMAT clause of the CAST operator (added in SQL:2016)

2019-04-04 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2980?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan reassigned CALCITE-2980: --- Assignee: Danny Chan > Implement the FORMAT clause of the CAST operator (added in

[jira] [Assigned] (CALCITE-2978) sorting not applied in subqueries

2019-04-03 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2978?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan reassigned CALCITE-2978: --- Assignee: Danny Chan > sorting not applied in subqueries >

[jira] [Commented] (CALCITE-2966) Problem with Code Generation

2019-04-02 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16808289#comment-16808289 ] Danny Chan commented on CALCITE-2966: - The commit is not that complete, i only see 2 files changed

[jira] [Assigned] (CALCITE-2967) New rule to remove SemiJoin

2019-04-02 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2967?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan reassigned CALCITE-2967: --- Assignee: Ruben Quesada Lopez (was: Danny Chan) > New rule to remove SemiJoin >

[jira] [Assigned] (CALCITE-2967) New rule to remove SemiJoin

2019-04-02 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2967?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan reassigned CALCITE-2967: --- Assignee: Danny Chan (was: Ruben Quesada Lopez) > New rule to remove SemiJoin >

[jira] [Commented] (CALCITE-2967) New rule to remove SemiJoin

2019-04-02 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16807684#comment-16807684 ] Danny Chan commented on CALCITE-2967: - What i'm curious about is after decorrelation, an in clause

[jira] [Assigned] (CALCITE-2969) Improve design of join-like relational expressions

2019-04-01 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2969?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan reassigned CALCITE-2969: --- Assignee: Danny Chan > Improve design of join-like relational expressions >

[jira] [Created] (CALCITE-2966) Problem with Code Generation

2019-03-31 Thread Danny Chan (JIRA)
Danny Chan created CALCITE-2966: --- Summary: Problem with Code Generation Key: CALCITE-2966 URL: https://issues.apache.org/jira/browse/CALCITE-2966 Project: Calcite Issue Type: Bug

[jira] [Commented] (CALCITE-2914) Improve how LatticeSuggester deduces foreign keys

2019-03-31 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16806348#comment-16806348 ] Danny Chan commented on CALCITE-2914: - [~julianhyde] Reviewing now. > Improve how LatticeSuggester

[jira] [Commented] (CALCITE-2948) SqlToRelConverter generates complicated logical plan for subquery

2019-03-31 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16806335#comment-16806335 ] Danny Chan commented on CALCITE-2948: - [~julianhyde] [~hyuan] [~vgarg] The value generator for the

[jira] [Commented] (CALCITE-2960) CalciteCatalogReader use a hard-coding config to get functions

2019-03-28 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16804578#comment-16804578 ] Danny Chan commented on CALCITE-2960: - Got your idea, it's weird that Calcite itself never use 

[jira] [Closed] (CALCITE-2744) Throws RuntimeException in RelDecorrelator when optimizing a Semi-Join query with a multi-param aggregate function in subquery

2019-03-28 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2744?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan closed CALCITE-2744. --- Resolution: Won't Fix > Throws RuntimeException in RelDecorrelator when optimizing a Semi-Join

[jira] [Updated] (CALCITE-2744) Throws RuntimeException in RelDecorrelator when optimizing a Semi-Join query with a multi-param aggregate function in subquery

2019-03-28 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2744?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan updated CALCITE-2744: Fix Version/s: (was: 1.20.0) > Throws RuntimeException in RelDecorrelator when optimizing a

[jira] [Commented] (CALCITE-2744) Throws RuntimeException in RelDecorrelator when optimizing a Semi-Join query with a multi-param aggregate function in subquery

2019-03-28 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16804543#comment-16804543 ] Danny Chan commented on CALCITE-2744: - It seems that it is an edge case that an agg function can

[jira] [Updated] (CALCITE-2744) Throws RuntimeException in RelDecorrelator when optimizing a Semi-Join query with a multi-param aggregate function in subquery

2019-03-28 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2744?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan updated CALCITE-2744: Fix Version/s: 1.20.0 > Throws RuntimeException in RelDecorrelator when optimizing a Semi-Join

[jira] [Assigned] (CALCITE-2744) Throws RuntimeException in RelDecorrelator when optimizing a Semi-Join query with a multi-param aggregate function in subquery

2019-03-28 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2744?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan reassigned CALCITE-2744: --- Assignee: Danny Chan > Throws RuntimeException in RelDecorrelator when optimizing a

[jira] [Commented] (CALCITE-2960) CalciteCatalogReader use a hard-coding config to get functions

2019-03-28 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16803624#comment-16803624 ] Danny Chan commented on CALCITE-2960: - BTW, i never saw any case that Calcite use

[jira] [Commented] (CALCITE-2960) CalciteCatalogReader use a hard-coding config to get functions

2019-03-28 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16803618#comment-16803618 ] Danny Chan commented on CALCITE-2960: - I think it is part of issue 2928, and i have add link for

[jira] [Comment Edited] (CALCITE-2928) Make UDF lookup default to case insensitive

2019-03-28 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16803610#comment-16803610 ] Danny Chan edited comment on CALCITE-2928 at 3/28/19 6:09 AM: --

[jira] [Comment Edited] (CALCITE-2928) Make UDF lookup default to case insensitive

2019-03-28 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16803610#comment-16803610 ] Danny Chan edited comment on CALCITE-2928 at 3/28/19 6:08 AM: --

[jira] [Commented] (CALCITE-2928) Make UDF lookup default to case insensitive

2019-03-28 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16803610#comment-16803610 ] Danny Chan commented on CALCITE-2928: - [~julianhyde] i have fire a

[jira] [Commented] (CALCITE-481) Add "Spool" operator, to allow re-use of relational expressions

2019-03-26 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16801636#comment-16801636 ] Danny Chan commented on CALCITE-481: Cool topic, just found it first time, i would like to

[jira] [Commented] (CALCITE-2208) MaterializedViewTable.MATERIALIZATION_CONNECTION breaks lex and case sensitivity for end user

2019-03-26 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16801626#comment-16801626 ] Danny Chan commented on CALCITE-2208: - [~julianhyde] I have fixed this in

[jira] [Assigned] (CALCITE-2948) SqlToRelConverter generates complicated logical plan for subquery

2019-03-25 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2948?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan reassigned CALCITE-2948: --- Assignee: Danny Chan > SqlToRelConverter generates complicated logical plan for subquery

[jira] [Commented] (CALCITE-2948) SqlToRelConverter generates complicated logical plan for subquery

2019-03-25 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16801282#comment-16801282 ] Danny Chan commented on CALCITE-2948: - [~hyuan] Hi, may i take this issue, i will take it if you

[jira] [Commented] (CALCITE-2936) Simplify EXISTS or NOT EXISTS sub-query that has "GROUP BY ()"

2019-03-24 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16800380#comment-16800380 ] Danny Chan commented on CALCITE-2936: - So the MinRowCount and MaxRowCount are all estimated but

[jira] [Assigned] (CALCITE-2939) NPE Array Type serialToJdbc in TypedValue when executeBatch

2019-03-22 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2939?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Chan reassigned CALCITE-2939: --- Assignee: Danny Chan > NPE Array Type serialToJdbc in TypedValue when executeBatch >

[jira] [Commented] (CALCITE-2939) NPE Array Type serialToJdbc in TypedValue when executeBatch

2019-03-21 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16798176#comment-16798176 ] Danny Chan commented on CALCITE-2939: - [~shining] Hi, i would like to take this issue if you agree,

[jira] [Commented] (CALCITE-2928) Make UDF lookup default to case insensitive

2019-03-20 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16797760#comment-16797760 ] Danny Chan commented on CALCITE-2928: - [~julianhyde] Yes, thx for your rely. I think there are 2

[jira] [Commented] (CALCITE-2933) In Druid adapter, expression like "cast(cast(\"timestamp\" as timestamp) as varchar)" returns as epoch millisecond

2019-03-20 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16797138#comment-16797138 ] Danny Chan commented on CALCITE-2933: - [~zhztheplayer] I have found the reason, it is because in

[jira] [Created] (CALCITE-2938) Druid adapter do wrong behavior for casts from timestamp type to date type

2019-03-20 Thread Danny Chan (JIRA)
Danny Chan created CALCITE-2938: --- Summary: Druid adapter do wrong behavior for casts from timestamp type to date type Key: CALCITE-2938 URL: https://issues.apache.org/jira/browse/CALCITE-2938 Project:

[jira] [Commented] (CALCITE-2933) In Druid adapter, expression like "cast(cast(\"timestamp\" as timestamp) as varchar)" returns as epoch millisecond

2019-03-20 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16796923#comment-16796923 ] Danny Chan commented on CALCITE-2933: - [~zhztheplayer] Sorry, my fault, all my test cases throw

[jira] [Commented] (CALCITE-2933) In Druid adapter, expression like "cast(cast(\"timestamp\" as timestamp) as varchar)" returns as epoch millisecond

2019-03-20 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16796912#comment-16796912 ] Danny Chan commented on CALCITE-2933: - [~zhztheplayer] It seems that the error does not has any

[jira] [Commented] (CALCITE-2929) Simplification of IS NULL checks are incorrectly assuming that CAST-s are possible

2019-03-19 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16796059#comment-16796059 ] Danny Chan commented on CALCITE-2929: - [~kgyrtkirk] I definitely agree that {code:java} select

<    1   2   3   4   5   6   >