[jira] [Commented] (CALCITE-6409) Char types and Boolean types are comparable

2024-05-13 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17846030#comment-17846030 ] Julian Hyde commented on CALCITE-6409: -- Who said the types need to be comparable? Comparable means

[jira] [Comment Edited] (CALCITE-6400) MAP_ENTRIES allows null as a map key

2024-05-13 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845929#comment-17845929 ] Julian Hyde edited comment on CALCITE-6400 at 5/13/24 1:45 PM: --- How about

[jira] [Commented] (CALCITE-6400) MAP_ENTRIES allows null as a map key

2024-05-13 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845929#comment-17845929 ] Julian Hyde commented on CALCITE-6400: -- How about “MAP_ENTRIES should throw if a key value is

[jira] [Comment Edited] (CALCITE-6409) Char types and Boolean types are comparable

2024-05-12 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845744#comment-17845744 ] Julian Hyde edited comment on CALCITE-6409 at 5/12/24 8:42 PM: ---

[jira] [Commented] (CALCITE-6409) Char types and Boolean types are comparable

2024-05-12 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845744#comment-17845744 ] Julian Hyde commented on CALCITE-6409: -- [~caicancai], Please describe what research you have done,

[jira] [Commented] (CALCITE-6410) dateadd(MONTH, 3, date '2016-02-24') parsing failed

2024-05-12 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845743#comment-17845743 ] Julian Hyde commented on CALCITE-6410: -- Not a bug. That syntax is only supported in the Babel

[jira] [Updated] (CALCITE-6408) Not-null ThreadLocal

2024-05-11 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Hyde updated CALCITE-6408: - Fix Version/s: 1.38.0 > Not-null ThreadLocal > > > Key:

[jira] [Assigned] (CALCITE-6408) Not-null ThreadLocal

2024-05-10 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Hyde reassigned CALCITE-6408: Assignee: Julian Hyde > Not-null ThreadLocal > > >

[jira] [Created] (CALCITE-6408) Not-null ThreadLocal

2024-05-10 Thread Julian Hyde (Jira)
Julian Hyde created CALCITE-6408: Summary: Not-null ThreadLocal Key: CALCITE-6408 URL: https://issues.apache.org/jira/browse/CALCITE-6408 Project: Calcite Issue Type: Improvement

[jira] [Commented] (CALCITE-6397) Add NVL2 function (enabled in Spark library)

2024-05-10 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845468#comment-17845468 ] Julian Hyde commented on CALCITE-6397: -- The Spark specification is not always great. According to

[jira] [Commented] (CALCITE-6403) Rule AGGREGATE_EXPAND_DISTINCT_AGGREGATES is unsound

2024-05-08 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17844800#comment-17844800 ] Julian Hyde commented on CALCITE-6403: -- Does the same problem occur when the input relation is

[jira] [Comment Edited] (CALCITE-6402) Aggregates implied in grouping sets have a wrong nullability at validation stage

2024-05-08 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17844737#comment-17844737 ] Julian Hyde edited comment on CALCITE-6402 at 5/8/24 6:41 PM: -- I agree

[jira] [Commented] (CALCITE-6402) Aggregates implied in grouping sets have a wrong nullability at validation stage

2024-05-08 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17844737#comment-17844737 ] Julian Hyde commented on CALCITE-6402: -- I agree with your analysis. It seems we need a means

[jira] [Commented] (CALCITE-6400) MAP_ENTRIES does not allow null as a map key

2024-05-08 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17844732#comment-17844732 ] Julian Hyde commented on CALCITE-6400: -- When I read the current summary, 'MAP_ENTRIES does not

[jira] [Commented] (CALCITE-6396) Add ADD_MONTHS function (enabled in Spark library)

2024-05-07 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17844481#comment-17844481 ] Julian Hyde commented on CALCITE-6396: -- The first argument, and the return, should be a

[jira] [Comment Edited] (CALCITE-6400) MAP_ENTRIES does not allow the key to be empty

2024-05-04 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17843477#comment-17843477 ] Julian Hyde edited comment on CALCITE-6400 at 5/4/24 5:27 PM: -- Can you

[jira] [Comment Edited] (CALCITE-6400) MAP_ENTRIES does not allow the key to be empty

2024-05-04 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17843477#comment-17843477 ] Julian Hyde edited comment on CALCITE-6400 at 5/4/24 5:26 PM: -- Can you

[jira] [Commented] (CALCITE-6400) MAP_ENTRIES does not allow the key to be empty

2024-05-04 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17843477#comment-17843477 ] Julian Hyde commented on CALCITE-6400: -- Can you improve the summary? It's not clear whether you

[jira] [Updated] (CALCITE-6393) Byte code of SqlFunctions is invalid

2024-04-30 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6393?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Hyde updated CALCITE-6393: - Affects Version/s: 1.36.0 > Byte code of SqlFunctions is invalid >

[jira] [Commented] (CALCITE-4496) Measure columns ("SELECT ... AS MEASURE")

2024-04-30 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17842472#comment-17842472 ] Julian Hyde commented on CALCITE-4496: -- An update on the development of this feature. Basic

[jira] [Commented] (CALCITE-6300) Function MAP_VALUES/MAP_KEYS gives exception when mapVauleType and mapKeyType not equals map Biggest mapKeytype or mapValueType

2024-04-28 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17841666#comment-17841666 ] Julian Hyde commented on CALCITE-6300: -- Maybe it could get away with it, but it probably

[jira] [Updated] (CALCITE-6386) Elasticsearch adapter throws NullPointerException when used with with model.json and no username, password or pathPrefix

2024-04-27 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Hyde updated CALCITE-6386: - Summary: Elasticsearch adapter throws NullPointerException when used with with model.json and

[jira] [Commented] (CALCITE-6386) NPE when using ES adapter with model.json and no specified username, password or pathPrefix

2024-04-27 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17841501#comment-17841501 ] Julian Hyde commented on CALCITE-6386: -- I changed the summary to remove abbreviations. Please

[jira] [Commented] (CALCITE-6373) Distinct optimization produces broken sql query

2024-04-26 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17841285#comment-17841285 ] Julian Hyde commented on CALCITE-6373: -- I suspect that the fix only fixes the special case of one

[jira] [Commented] (CALCITE-6383) The class SameOperandTypeChecker is incorrectly documented

2024-04-26 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17841062#comment-17841062 ] Julian Hyde commented on CALCITE-6383: -- Pr looks good except than you can’t use “*” for emphasis

[jira] [Commented] (CALCITE-6374) LatticeSuggester throw npe when agg call covered with cast

2024-04-18 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17838774#comment-17838774 ] Julian Hyde commented on CALCITE-6374: -- [~allendang], Can you please remove the PNG and replace it

[jira] [Commented] (CALCITE-6375) Fix failing quidem tests for FORMAT in CAST

2024-04-18 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17838773#comment-17838773 ] Julian Hyde commented on CALCITE-6375: -- [~jerin_john], Jira summaries should not use the word

[jira] [Commented] (CALCITE-6373) Distinct optimization produces broken sql query

2024-04-17 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17838248#comment-17838248 ] Julian Hyde commented on CALCITE-6373: -- I agree that any SQL-to-SQL transformation that alters the

[jira] [Commented] (CALCITE-6367) Add timezone support for FORMAT clause in CAST (enabled in BigQuery)

2024-04-15 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837465#comment-17837465 ] Julian Hyde commented on CALCITE-6367: -- [~jerin_john] Can you add links to any related cases (not

[jira] [Commented] (CALCITE-6363) Introduce a rule to derive more filters from inner join condition

2024-04-15 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837462#comment-17837462 ] Julian Hyde commented on CALCITE-6363: -- Thanks for finding JoinConditionPushRule (CALCITE-5073).

[jira] [Commented] (CALCITE-6363) Introduce a rule to derive more filters from inner join condition

2024-04-15 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837461#comment-17837461 ] Julian Hyde commented on CALCITE-6363: -- On the mailing list [~jamesstarr] replied: {quote}The

[jira] [Commented] (CALCITE-6363) Introduce a rule to derive more filters from inner join condition

2024-04-14 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836988#comment-17836988 ] Julian Hyde commented on CALCITE-6363: -- I really wish you had logged the case BEFORE writing a big

[jira] [Commented] (CALCITE-6363) Introduce a rule to derive more filters from inner join condition

2024-04-14 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836987#comment-17836987 ] Julian Hyde commented on CALCITE-6363: -- Don’t we have some existing rules (metadata) for this? Can

[jira] [Commented] (CALCITE-6357) Calcite enforces select arguments count to be same as row schema fields which causes aliases to be ignored

2024-04-11 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836338#comment-17836338 ] Julian Hyde commented on CALCITE-6357: -- We added {{RelRoot}} way back in CALCITE-819 to express

[jira] [Commented] (CALCITE-6358) Support all PostgreSQL 14 date/time patterns

2024-04-11 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836284#comment-17836284 ] Julian Hyde commented on CALCITE-6358: -- Yes, in theory, it might. I don't have time to look at the

[jira] [Commented] (CALCITE-6358) Support all PostgreSQL 14 date/time patterns

2024-04-11 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836261#comment-17836261 ] Julian Hyde commented on CALCITE-6358: -- In Calcite, the set of format elements is tied to

[jira] [Commented] (CALCITE-6361) Uncollect.deriveUncollectRowType crashes if the input data is not a collection

2024-04-10 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836014#comment-17836014 ] Julian Hyde commented on CALCITE-6361: -- By the way, please don't say 'crashes'. Say what error is

[jira] [Commented] (CALCITE-6361) Uncollect.deriveUncollectRowType crashes if the input data is not a collection

2024-04-10 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17836013#comment-17836013 ] Julian Hyde commented on CALCITE-6361: -- Is there a SQL query that reproduces this problem? It's

[jira] [Commented] (CALCITE-6358) Support all PostgreSQL 14 date/time patterns

2024-04-10 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17835918#comment-17835918 ] Julian Hyde commented on CALCITE-6358: -- [~njordan], To be clear, which functions are you proposing

[jira] [Commented] (CALCITE-6357) Calcite enforces select arguments count to be same as row schema fields which causes aliases to be ignored

2024-04-10 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17835917#comment-17835917 ] Julian Hyde commented on CALCITE-6357: -- [~brachi_packter], It might be useful to reduce this to a

[jira] [Commented] (CALCITE-6357) Calcite enforces select arguments count to be same as row schema fields which causes aliases to be ignored

2024-04-10 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17835893#comment-17835893 ] Julian Hyde commented on CALCITE-6357: -- *Caveat*: I haven't read every word you've written above;

[jira] [Commented] (CALCITE-6357) Calcite enforces select arguments count to be same as row schema fields which causes aliases to be ignored

2024-04-10 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17835833#comment-17835833 ] Julian Hyde commented on CALCITE-6357: -- If the number of fields does not match, that's probably a

[jira] [Commented] (CALCITE-6345) Intervals with more than 100 years are not supported

2024-04-03 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17833710#comment-17833710 ] Julian Hyde commented on CALCITE-6345: -- Can you reframe this as a feature request, rather than a

[jira] [Commented] (CALCITE-6321) Add copy(List constants) method to Window class.

2024-04-02 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17833029#comment-17833029 ] Julian Hyde commented on CALCITE-6321: -- [~mbudiu], Which commit fixed this? > Add copy(List

[jira] [Commented] (CALCITE-6343) AS alias operator strips MEASUREness from measures

2024-03-26 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17831113#comment-17831113 ] Julian Hyde commented on CALCITE-6343: -- Your PR looks fine, but I would like you to add a simple

[jira] [Commented] (CALCITE-6343) AS alias operator strips MEASUREness from measures

2024-03-26 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17831110#comment-17831110 ] Julian Hyde commented on CALCITE-6343: -- I edited the description, removing the explicit link. Note

[jira] [Updated] (CALCITE-6343) AS alias operator strips MEASUREness from measures

2024-03-26 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Hyde updated CALCITE-6343: - Description: CALCITE-5869 introduced a change which removes MEASURE when inferring the return

[jira] [Commented] (CALCITE-6315) Support PostgreSQL TO_CHAR, TO_DATE, TO_TIMESTAMP

2024-03-22 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17829930#comment-17829930 ] Julian Hyde commented on CALCITE-6315: -- OK, great, make sure that it tests all format elements. >

[jira] [Commented] (CALCITE-6338) RelMdCollation#project can return an incomplete list of collations

2024-03-21 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17829666#comment-17829666 ] Julian Hyde commented on CALCITE-6338: -- Makes sense. I would mention 'in the presence of aliasing'

[jira] [Commented] (CALCITE-5155) Custom time frames

2024-03-20 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17829343#comment-17829343 ] Julian Hyde commented on CALCITE-5155: -- I'm not aware of any SQL systems that have a SQL syntax.

[jira] [Commented] (CALCITE-6315) Support PostgreSQL TO_CHAR, TO_DATE, TO_TIMESTAMP

2024-03-19 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17828522#comment-17828522 ] Julian Hyde commented on CALCITE-6315: -- If you want to help, add some tests. For CALCITE-2980 I

[jira] [Commented] (CALCITE-6335) Quidem tests should allow specifying optimization passes to apply to programs

2024-03-18 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17828131#comment-17828131 ] Julian Hyde commented on CALCITE-6335: -- I agree. Currently we look over XML plans produced by

[jira] [Commented] (CALCITE-2980) Implement the FORMAT clause of the CAST operator

2024-03-18 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-2980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17828130#comment-17828130 ] Julian Hyde commented on CALCITE-2980: -- It's a judgment call for you to make. I think it's based

[jira] [Commented] (CALCITE-6270) Support FORMAT in CAST from Numeric and BYTES to String (Enabled in BigQuery)

2024-03-16 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17827761#comment-17827761 ] Julian Hyde commented on CALCITE-6270: -- [~jerin_john], Please use Calcite's type names in jira

[jira] [Commented] (CALCITE-6327) getValidatedNodeTypeIfKnown should never throw

2024-03-16 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17827760#comment-17827760 ] Julian Hyde commented on CALCITE-6327: -- A test case would be useful. >

[jira] [Commented] (CALCITE-6327) getValidatedNodeTypeIfKnown should never throw

2024-03-16 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17827759#comment-17827759 ] Julian Hyde commented on CALCITE-6327: -- That sounds right. However, mutations of the AST make me

[jira] [Commented] (CALCITE-6317) Incorrect constant replacement when group keys are NULL

2024-03-16 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17827758#comment-17827758 ] Julian Hyde commented on CALCITE-6317: -- Since the root cause is {{RelMdPredicates}}, can you add a

[jira] [Commented] (CALCITE-6209) Long queries are failing with "java.net.SocketTimeoutException: Read timed out" after 3 minutes

2024-03-16 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17827756#comment-17827756 ] Julian Hyde commented on CALCITE-6209: -- Thank you for adding the link. And, thanks for the fix! >

[jira] [Commented] (CALCITE-6314) Add RANDOM function (enabled in Postgres library)

2024-03-16 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17827755#comment-17827755 ] Julian Hyde commented on CALCITE-6314: -- Looks like you figured it out. By the way, when we're

[jira] [Commented] (CALCITE-2980) Implement the FORMAT clause of the CAST operator

2024-03-16 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-2980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17827753#comment-17827753 ] Julian Hyde commented on CALCITE-2980: -- A good test is really valuable. I wouldn't disable the

[jira] [Commented] (CALCITE-6332) Optimization CoreRules.AGGREGATE_EXPAND_DISTINCT_AGGREGATES_TO_JOIN produces incorrect results for aggregates with groupSets

2024-03-16 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17827752#comment-17827752 ] Julian Hyde commented on CALCITE-6332: -- There are two algorithms to rewrite distinct aggregates.

[jira] [Commented] (CALCITE-6333) Queries with distinct aggregations with filter throw NPE when planned using joins

2024-03-15 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17827570#comment-17827570 ] Julian Hyde commented on CALCITE-6333: -- Your PR seems to make the NPE go away by removing the

[jira] [Commented] (CALCITE-6324) Type inferred for result of STDDEV, VAR_SAMP, etc. is incorrect

2024-03-12 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17825877#comment-17825877 ] Julian Hyde commented on CALCITE-6324: -- You can't say the type is 'incorrect' when the standard

[jira] [Commented] (CALCITE-6309) Add REGEXP_LIKE function (enabled in Postgres library)

2024-03-12 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17825856#comment-17825856 ] Julian Hyde commented on CALCITE-6309: -- Thank you for doing this excellent research. I think that

[jira] [Commented] (CALCITE-6309) Add REGEXP_LIKE function (enabled in Postgres library)

2024-03-12 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17825839#comment-17825839 ] Julian Hyde commented on CALCITE-6309: -- I think it would be OK (and simpler) to make the third

[jira] [Commented] (CALCITE-6209) Long queries are failing with "java.net.SocketTimeoutException: Read timed out" after 3 minutes

2024-03-12 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17825753#comment-17825753 ] Julian Hyde commented on CALCITE-6209: -- [~stoty], Please add a link to the commit on main branch.

[jira] [Commented] (CALCITE-6319) Add negative test to pow and power functions

2024-03-10 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17825094#comment-17825094 ] Julian Hyde commented on CALCITE-6319: -- None of the tests you added are negative tests. > Add

[jira] [Commented] (CALCITE-6319) Add negative test to pow and power functions

2024-03-10 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17825093#comment-17825093 ] Julian Hyde commented on CALCITE-6319: -- It's much easier to read your case summary if you use

[jira] [Commented] (CALCITE-6278) Add REGEXP, REGEXP_LIKE function (enabled in Spark library)

2024-03-10 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17825091#comment-17825091 ] Julian Hyde commented on CALCITE-6278: -- Regarding the character literal syntax. That's

[jira] [Commented] (CALCITE-6278) Add REGEXP, REGEXP_LIKE function (enabled in Spark library)

2024-03-09 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17824994#comment-17824994 ] Julian Hyde commented on CALCITE-6278: -- I think by 'unescaping' you mean handling backslashes in

[jira] [Commented] (CALCITE-6278) Add REGEXP, REGEXP_LIKE function (enabled in Spark library)

2024-03-07 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17824456#comment-17824456 ] Julian Hyde commented on CALCITE-6278: -- Can you expand on “Since Spark 2.0, string literals

[jira] [Commented] (CALCITE-6305) Increase coverage of unit tests for arrow adapter

2024-03-07 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17824453#comment-17824453 ] Julian Hyde commented on CALCITE-6305: -- Should be “Arrow” not “arrow”. Sorry to be pedantic, but

[jira] [Commented] (CALCITE-6306) FILTER clauses for aggregate functions are not supported in MySQL, MariaDB and Starrocks

2024-03-07 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17824451#comment-17824451 ] Julian Hyde commented on CALCITE-6306: -- Can you change the subject so it’s clear which calcite

[jira] [Commented] (CALCITE-6284) Invalid conversion triggers ClassCastException

2024-03-06 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17824169#comment-17824169 ] Julian Hyde commented on CALCITE-6284: -- Thank you! > Invalid conversion triggers

[jira] [Commented] (CALCITE-6293) Support OR condition in arrow adapter

2024-03-06 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17824168#comment-17824168 ] Julian Hyde commented on CALCITE-6293: -- [~asolimando], +1 on merging what we have. The new tickets

[jira] [Updated] (CALCITE-6302) Release Calcite 1.37.0

2024-03-06 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Hyde updated CALCITE-6302: - Fix Version/s: 1.37.0 > Release Calcite 1.37.0 > -- > >

[jira] [Commented] (CALCITE-6248) Illegal dates are accepted by casts

2024-03-05 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17823772#comment-17823772 ] Julian Hyde commented on CALCITE-6248: -- Postel's law applies: "be conservative in what you send,

[jira] [Commented] (CALCITE-6284) Invalid conversion triggers ClassCastException

2024-03-05 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17823770#comment-17823770 ] Julian Hyde commented on CALCITE-6284: -- Can you fill out the description? Describe what's going on

[jira] [Commented] (CALCITE-6239) Add a PostGIS dialect that supports ST_ functions

2024-03-05 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17823753#comment-17823753 ] Julian Hyde commented on CALCITE-6239: -- [~bchapuis], In my

[jira] [Commented] (CALCITE-6292) Support more arrow type

2024-03-05 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17823745#comment-17823745 ] Julian Hyde commented on CALCITE-6292: -- Arrow types are very similar to SQL and JDBC types. You

[jira] [Commented] (CALCITE-6293) Support OR condition in arrow adapter

2024-03-05 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17823744#comment-17823744 ] Julian Hyde commented on CALCITE-6293: -- Can you provide more details? This case (and others you

[jira] [Commented] (CALCITE-6297) Support sub-queries in arrow adapter

2024-03-04 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17823468#comment-17823468 ] Julian Hyde commented on CALCITE-6297: -- I don’t understand what this means. Add description.  >

[jira] [Commented] (CALCITE-6278) Add REGEXP、REGEXP_LIKE function (enabled in Spark library)

2024-03-04 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17823342#comment-17823342 ] Julian Hyde commented on CALCITE-6278: -- Use a real comma in the subject, please. Does RLIKE have

[jira] [Resolved] (CALCITE-6288) Error while compiling LIKE function after update to 1.36

2024-03-04 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Hyde resolved CALCITE-6288. -- Resolution: Not A Problem Make sure that the column has SQL type {{{}MAP{}}}. Add some test

[jira] [Commented] (CALCITE-6289) View in union cannot be reused

2024-03-04 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17823332#comment-17823332 ] Julian Hyde commented on CALCITE-6289: -- What would the plan look like if reuse was occurring?

[jira] [Commented] (CALCITE-6288) Error while compiling LIKE function after update to 1.36

2024-03-04 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17823070#comment-17823070 ] Julian Hyde commented on CALCITE-6288: -- The SQL doesn’t seem to have a valid type. An item in

[jira] [Commented] (CALCITE-6281) Add test infrastructure to ensure that Calcite is consistent with the SQL dialects it is trying to emulate

2024-02-26 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17820939#comment-17820939 ] Julian Hyde commented on CALCITE-6281: -- Work in progress, based on Stamatis' [PR

[jira] [Assigned] (CALCITE-6281) Add test infrastructure to ensure that Calcite is consistent with the SQL dialects it is trying to emulate

2024-02-26 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Hyde reassigned CALCITE-6281: Assignee: Julian Hyde > Add test infrastructure to ensure that Calcite is consistent

[jira] [Resolved] (CALCITE-6219) Support SQL Validation for Tables with columns tagged as 'filter required'

2024-02-26 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6219?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julian Hyde resolved CALCITE-6219. -- Fix Version/s: 1.37.0 Resolution: Fixed Fixed in

[jira] [Commented] (CALCITE-6281) Add test infrastructure to ensure that Calcite is consistent with the SQL dialects it is trying to emulate

2024-02-26 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17820926#comment-17820926 ] Julian Hyde commented on CALCITE-6281: -- The only goal is to compare specifications: given an

[jira] [Commented] (CALCITE-6219) Support SQL Validation for Tables with columns tagged as 'filter required'

2024-02-26 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17820898#comment-17820898 ] Julian Hyde commented on CALCITE-6219: -- [~oliverlee], Looks like we've resolved your comment

[jira] [Created] (CALCITE-6281) Add test infrastructure to ensure that Calcite is consistent with the SQL dialects it is trying to emulate

2024-02-26 Thread Julian Hyde (Jira)
Julian Hyde created CALCITE-6281: Summary: Add test infrastructure to ensure that Calcite is consistent with the SQL dialects it is trying to emulate Key: CALCITE-6281 URL:

[jira] [Commented] (CALCITE-6275) Parser for data types ignores element nullability in collections

2024-02-23 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17820199#comment-17820199 ] Julian Hyde commented on CALCITE-6275: -- In standard SQL, I don't think that NOT NULL is strictly

[jira] [Commented] (CALCITE-5638) Assertion Failure during planning correlated query with orderby

2024-02-23 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-5638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17820172#comment-17820172 ] Julian Hyde commented on CALCITE-5638: -- The problem still occurs if I remove the {{{}ORDER BY{}}}.

[jira] [Commented] (CALCITE-6279) Use Null to replace the results of some Math functions that return NaN.

2024-02-23 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17820166#comment-17820166 ] Julian Hyde commented on CALCITE-6279: -- Also, do not talk about what Java does. Calcite users do

[jira] [Commented] (CALCITE-6279) Use Null to replace the results of some Math functions that return NaN.

2024-02-23 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17820164#comment-17820164 ] Julian Hyde commented on CALCITE-6279: -- What you mean by “SQL rules”? Imprecise specifications

[jira] [Comment Edited] (CALCITE-6210) Cast to VARBINARY causes an assertion failure

2024-02-22 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17819856#comment-17819856 ] Julian Hyde edited comment on CALCITE-6210 at 2/23/24 12:14 AM: {quote}

[jira] [Commented] (CALCITE-6210) Cast to VARBINARY causes an assertion failure

2024-02-22 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17819856#comment-17819856 ] Julian Hyde commented on CALCITE-6210: -- {quote}The problem with my approach is that other dialects

[jira] [Commented] (CALCITE-6261) RelBuilder.aggregate() field pruning does not use permuted field indices when used with force project and duplicate agg calls

2024-02-22 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17819849#comment-17819849 ] Julian Hyde commented on CALCITE-6261: -- [~zrlpar] and [~phanimahidhar], Thanks for figuring it

[jira] [Commented] (CALCITE-6272) Improved LogicalPlan representation of distinct keyword

2024-02-19 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-6272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17818595#comment-17818595 ] Julian Hyde commented on CALCITE-6272: -- I think you’re saying the current behavior is fine, and

  1   2   3   4   5   6   7   8   9   10   >