[jira] [Commented] (CALCITE-3427) Some subquery correlated cases are not fully implemented

2019-10-20 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16955739#comment-16955739 ] Chunwei Lei commented on CALCITE-3427: -- It would be great if you can provide a test to reproduce

[jira] [Updated] (CALCITE-3427) Some subquery correlated cases are not fully implemented

2019-10-20 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chunwei Lei updated CALCITE-3427: - Summary: Some subquery correlated cases are not fully implemented (was: some subquery

[jira] [Commented] (CALCITE-3355) Deduce whether CASE and COALESCE may produce NULL values

2019-09-19 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16933972#comment-16933972 ] Chunwei Lei commented on CALCITE-3355: -- Thanks, [~kirillkozlov]. I can assign this issue to

[jira] [Commented] (CALCITE-3360) SqlValidator throws NEP for unregistered function without implicit type coercion

2019-09-19 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16933971#comment-16933971 ] Chunwei Lei commented on CALCITE-3360: -- Just a little confused. What does {{NEP}} mean? Or it is

[jira] [Assigned] (CALCITE-3355) Deduce whether CASE and COALESCE may produce NULL values

2019-09-19 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chunwei Lei reassigned CALCITE-3355: Assignee: Chunwei Lei > Deduce whether CASE and COALESCE may produce NULL values >

[jira] [Commented] (CALCITE-3355) Deduce whether CASE and COALESCE may produce NULL values

2019-09-18 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16933010#comment-16933010 ] Chunwei Lei commented on CALCITE-3355: -- [~kirillkozlov] , I would like to task this issue if you

[jira] [Comment Edited] (CALCITE-3355) Deduce whether CASE and COALESCE may produce NULL values

2019-09-18 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16933010#comment-16933010 ] Chunwei Lei edited comment on CALCITE-3355 at 9/19/19 2:46 AM: ---

[jira] [Commented] (CALCITE-3330) propagateCostImprovements() could result in stack overflow

2019-09-09 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16925409#comment-16925409 ] Chunwei Lei commented on CALCITE-3330: -- It seems to be the same with CALCITE-2204. >

[jira] [Commented] (CALCITE-3246) RelJsonReader throws NullPointerException while deserializing from JSON a call to a user-defined function (UDF)

2019-08-23 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16914022#comment-16914022 ] Chunwei Lei commented on CALCITE-3246: -- [~julianhyde] , Sorry for the late reply. I spent some

[jira] [Resolved] (CALCITE-3228) Error while applying rule ProjectScanRule: interpreter

2019-08-22 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3228?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chunwei Lei resolved CALCITE-3228. -- Resolution: Fixed Fixed in 

[jira] [Commented] (CALCITE-3257) RelMetadataQuery cache is not invalidated when log trace is enabled

2019-08-21 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16912847#comment-16912847 ] Chunwei Lei commented on CALCITE-3257: --  I agree that this is not the same problem with 

[jira] [Commented] (CALCITE-1581) UDTF like in hive

2019-08-20 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-1581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16911931#comment-16911931 ] Chunwei Lei commented on CALCITE-1581: -- I am +1 on the patch, overall. Thanks for the effort! >

[jira] [Reopened] (CALCITE-3246) NullPointerException while deserializing of udf.

2019-08-15 Thread Chunwei Lei (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chunwei Lei reopened CALCITE-3246: -- Assignee: Chunwei Lei Reopen it to make sure that it does not introduce security holes. >

[jira] [Comment Edited] (CALCITE-3246) NullPointerException while deserializing of udf.

2019-08-15 Thread Chunwei Lei (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16908647#comment-16908647 ] Chunwei Lei edited comment on CALCITE-3246 at 8/16/19 2:40 AM: --- Sorry,

[jira] [Resolved] (CALCITE-3246) NullPointerException while deserializing of udf.

2019-08-15 Thread Chunwei Lei (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chunwei Lei resolved CALCITE-3246. -- Resolution: Fixed Fix Version/s: 1.21.0 Fixed in 

[jira] [Commented] (CALCITE-1581) UDTF like in hive

2019-08-15 Thread Chunwei Lei (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16908641#comment-16908641 ] Chunwei Lei commented on CALCITE-1581: -- Hi [~pzw2018], I left some comments. Would you please take

[jira] [Resolved] (CALCITE-3229) UnsupportedOperationException for UPDATE with IN query

2019-08-14 Thread Chunwei Lei (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chunwei Lei resolved CALCITE-3229. -- Resolution: Fixed Fix Version/s: 1.21.0 Fixed in 

[jira] [Comment Edited] (CALCITE-3229) UnsupportedOperationException for UPDATE with IN query

2019-08-14 Thread Chunwei Lei (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16907746#comment-16907746 ] Chunwei Lei edited comment on CALCITE-3229 at 8/15/19 1:50 AM: --- Fixed in 

[jira] [Commented] (CALCITE-1581) UDTF like in hive

2019-08-14 Thread Chunwei Lei (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16907079#comment-16907079 ] Chunwei Lei commented on CALCITE-1581: -- [~zabetak], Sorry for the delay. I will review it this

[jira] [Assigned] (CALCITE-3229) UnsupportedOperationException for UPDATE with IN query

2019-08-08 Thread Chunwei Lei (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chunwei Lei reassigned CALCITE-3229: Assignee: Chunwei Lei (was: Danny Chan) > UnsupportedOperationException for UPDATE

[jira] [Resolved] (CALCITE-2835) Markdown errors on the Geode adapter page

2019-08-08 Thread Chunwei Lei (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chunwei Lei resolved CALCITE-2835. -- Resolution: Fixed Fix Version/s: 1.21.0 Fixed in 

[jira] [Commented] (CALCITE-482) Implement sql and planner hints

2019-08-07 Thread Chunwei Lei (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16901774#comment-16901774 ] Chunwei Lei commented on CALCITE-482: - Thank you for pushing this forward, [~danny0405].  I have

[jira] [Commented] (CALCITE-3229) UnsupportedOperationException for UPDATE with IN query

2019-08-06 Thread Chunwei Lei (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16900677#comment-16900677 ] Chunwei Lei commented on CALCITE-3229: -- Thanks, [~danny0405]. I found CALCITE-2427 causes this

[jira] [Commented] (CALCITE-2835) Markdown errors on the Geode adapter page

2019-08-05 Thread Chunwei Lei (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16900623#comment-16900623 ] Chunwei Lei commented on CALCITE-2835: -- I opened a pull request: 

[jira] [Assigned] (CALCITE-2835) Markdown errors on the Geode adapter page

2019-08-05 Thread Chunwei Lei (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chunwei Lei reassigned CALCITE-2835: Assignee: Chunwei Lei > Markdown errors on the Geode adapter page >

[jira] [Commented] (CALCITE-2427) Sub-queries not supported in DML statements

2019-08-05 Thread Chunwei Lei (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16899903#comment-16899903 ] Chunwei Lei commented on CALCITE-2427: -- Thanks for raising this, [~psockali]! Let's discuss in 

[jira] [Commented] (CALCITE-3228) Error while applying rule ProjectScanRule: interpreter

2019-08-05 Thread Chunwei Lei (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16899902#comment-16899902 ] Chunwei Lei commented on CALCITE-3228: -- [~jinxing6...@126.com], could you please review

[jira] [Commented] (CALCITE-3229) UnsupportedOperationException for UPDATE with IN query

2019-08-04 Thread Chunwei Lei (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16899743#comment-16899743 ] Chunwei Lei commented on CALCITE-3229: -- [~danny0405], could you please look into this issue since

[jira] [Created] (CALCITE-3229) UnsupportedOperationException for UPDATE with IN query

2019-08-04 Thread Chunwei Lei (JIRA)
Chunwei Lei created CALCITE-3229: Summary: UnsupportedOperationException for UPDATE with IN query Key: CALCITE-3229 URL: https://issues.apache.org/jira/browse/CALCITE-3229 Project: Calcite

[jira] [Comment Edited] (CALCITE-3228) Error while applying rule ProjectScanRule: interpreter

2019-08-04 Thread Chunwei Lei (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16899736#comment-16899736 ] Chunwei Lei edited comment on CALCITE-3228 at 8/5/19 3:15 AM: -- Thanks 

[jira] [Comment Edited] (CALCITE-3228) Error while applying rule ProjectScanRule: interpreter

2019-08-04 Thread Chunwei Lei (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16899736#comment-16899736 ] Chunwei Lei edited comment on CALCITE-3228 at 8/5/19 3:02 AM: -- Thanks 

[jira] [Assigned] (CALCITE-3228) Error while applying rule ProjectScanRule: interpreter

2019-08-04 Thread Chunwei Lei (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3228?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chunwei Lei reassigned CALCITE-3228: Assignee: Chunwei Lei (was: Danny Chan) > Error while applying rule ProjectScanRule:

[jira] [Commented] (CALCITE-3228) Error while applying rule ProjectScanRule: interpreter

2019-08-04 Thread Chunwei Lei (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16899736#comment-16899736 ] Chunwei Lei commented on CALCITE-3228: -- Thanks  [~jinxing6...@126.com]. I am working on this issue

[jira] [Updated] (CALCITE-3228) Error while applying rule ProjectScanRule: interpreter

2019-08-04 Thread Chunwei Lei (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3228?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chunwei Lei updated CALCITE-3228: - Description: The following test can reproduce the issue.   {code:java} // FrameworksTest.java

[jira] [Created] (CALCITE-3228) Error while applying rule ProjectScanRule: interpreter

2019-08-03 Thread Chunwei Lei (JIRA)
Chunwei Lei created CALCITE-3228: Summary: Error while applying rule ProjectScanRule: interpreter Key: CALCITE-3228 URL: https://issues.apache.org/jira/browse/CALCITE-3228 Project: Calcite

[jira] [Commented] (CALCITE-2835) Markdown errors on the Geode adapter page

2019-08-02 Thread Chunwei Lei (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16898693#comment-16898693 ] Chunwei Lei commented on CALCITE-2835: -- I tried in many markdown editors, but it shows correctly.

[jira] [Commented] (CALCITE-3220) HiveSqlDialect transform function trim to correct hive format

2019-07-31 Thread Chunwei Lei (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16896887#comment-16896887 ] Chunwei Lei commented on CALCITE-3220: -- Could you please put the pr link into attachment? >

[jira] [Resolved] (CALCITE-2496) EXTRACT function: MILLI/MICRO/NANOSECOND parts of a DATE must be zero

2019-07-29 Thread Chunwei Lei (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2496?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chunwei Lei resolved CALCITE-2496. -- Resolution: Fixed Fix Version/s: 1.21.0 Fixed in 

[jira] [Commented] (CALCITE-2496) EXTRACT function: MILLI/MICRO/NANOSECOND parts of a DATE must be zero

2019-07-24 Thread Chunwei Lei (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16891655#comment-16891655 ] Chunwei Lei commented on CALCITE-2496: -- Hey [~Sergey Nuyanzin], are you going to address Julian's

[jira] [Commented] (CALCITE-1581) UDTF like in hive

2019-07-24 Thread Chunwei Lei (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16891652#comment-16891652 ] Chunwei Lei commented on CALCITE-1581: -- Let us try best to make it in 1.21.0. I will spend some

[jira] [Assigned] (CALCITE-2496) EXTRACT function: MILLI/MICRO/NANOSECOND parts of a DATE must be zero

2019-07-24 Thread Chunwei Lei (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2496?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chunwei Lei reassigned CALCITE-2496: Assignee: Chunwei Lei > EXTRACT function: MILLI/MICRO/NANOSECOND parts of a DATE must

[jira] [Resolved] (CALCITE-2510) Add CHR built-in function (Oracle only)

2019-07-23 Thread Chunwei Lei (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2510?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chunwei Lei resolved CALCITE-2510. -- Resolution: Fixed Fix Version/s: 1.21.0 > Add CHR built-in function (Oracle only) >

[jira] [Commented] (CALCITE-2510) Add CHR built-in function (Oracle only)

2019-07-23 Thread Chunwei Lei (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16890792#comment-16890792 ] Chunwei Lei commented on CALCITE-2510: -- Fixed in 

[jira] [Commented] (CALCITE-2510) Add CHR built-in function (Oracle only)

2019-06-10 Thread Chunwei Lei (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16859877#comment-16859877 ] Chunwei Lei commented on CALCITE-2510: -- I rebased and made some fix-up in 

[jira] [Assigned] (CALCITE-2510) Add CHR built-in function (Oracle only)

2019-06-10 Thread Chunwei Lei (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2510?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chunwei Lei reassigned CALCITE-2510: Assignee: Chunwei Lei > Add CHR built-in function (Oracle only) >

[jira] [Commented] (CALCITE-3005) Implement string functions: LEFT, RIGHT

2019-05-30 Thread Chunwei Lei (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16851594#comment-16851594 ] Chunwei Lei commented on CALCITE-3005: -- [~x1q1j1], you can reference how it deal with function

[jira] [Comment Edited] (CALCITE-2992) Enhance implicit conversions when generating hash join keys for an equiCondition

2019-05-28 Thread Chunwei Lei (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16850357#comment-16850357 ] Chunwei Lei edited comment on CALCITE-2992 at 5/29/19 3:17 AM: ---

[jira] [Commented] (CALCITE-2992) Enhance implicit conversions when generating hash join keys for an equiCondition

2019-05-28 Thread Chunwei Lei (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16850357#comment-16850357 ] Chunwei Lei commented on CALCITE-2992: -- [~michaelmior], [~hhlai1990] there are more discussion

[jira] [Resolved] (CALCITE-3084) Implement JDBC string functions: ASCII, REPEAT, SPACE, SOUNDEX, DIFFERENCE

2019-05-24 Thread Chunwei Lei (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chunwei Lei resolved CALCITE-3084. -- Resolution: Fixed Assignee: Chunwei Lei Fix Version/s: 1.20.0 Fixed in 

[jira] [Commented] (CALCITE-2601) Add REVERSE function

2019-05-20 Thread Chunwei Lei (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16844503#comment-16844503 ] Chunwei Lei commented on CALCITE-2601: -- Fixed in 

[jira] [Assigned] (CALCITE-2601) Add REVERSE function

2019-05-20 Thread Chunwei Lei (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chunwei Lei reassigned CALCITE-2601: Assignee: Chunwei Lei > Add REVERSE function > > >

[jira] [Resolved] (CALCITE-2601) Add REVERSE function

2019-05-20 Thread Chunwei Lei (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chunwei Lei resolved CALCITE-2601. -- Resolution: Fixed Fix Version/s: 1.20.0 > Add REVERSE function >

[jira] [Resolved] (CALCITE-3068) testSubprogram() does't test whether subprogram gets re-executed

2019-05-19 Thread Chunwei Lei (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3068?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chunwei Lei resolved CALCITE-3068. -- Resolution: Fixed Fix Version/s: 1.20.0 > testSubprogram() does't test whether

[jira] [Commented] (CALCITE-3068) testSubprogram() does't test whether subprogram gets re-executed

2019-05-19 Thread Chunwei Lei (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16843581#comment-16843581 ] Chunwei Lei commented on CALCITE-3068: -- Fixed in 

[jira] [Commented] (CALCITE-3071) Cache the whole sql plan to reduce the latency and improve the performance

2019-05-18 Thread Chunwei Lei (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16843182#comment-16843182 ] Chunwei Lei commented on CALCITE-3071: -- It is really a interesting topic. There are more to think

[jira] [Resolved] (CALCITE-2712) Add rule to remove null-generating side of a Join

2019-05-17 Thread Chunwei Lei (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2712?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chunwei Lei resolved CALCITE-2712. -- Resolution: Fixed Fix Version/s: 1.20.0 > Add rule to remove null-generating side of

[jira] [Commented] (CALCITE-2712) Add rule to remove null-generating side of a Join

2019-05-17 Thread Chunwei Lei (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16842299#comment-16842299 ] Chunwei Lei commented on CALCITE-2712: -- Fixed in 

[jira] [Resolved] (CALCITE-2965) Implement string functions: REPEAT, SPACE, SOUNDEX, DIFFERENCE

2019-05-16 Thread Chunwei Lei (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chunwei Lei resolved CALCITE-2965. -- Resolution: Fixed > Implement string functions: REPEAT, SPACE, SOUNDEX, DIFFERENCE >

[jira] [Commented] (CALCITE-2965) Implement string functions: REPEAT, SPACE, SOUNDEX, DIFFERENCE

2019-05-16 Thread Chunwei Lei (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16841904#comment-16841904 ] Chunwei Lei commented on CALCITE-2965: -- Fixed in 

[jira] [Commented] (CALCITE-2712) Add rule to remove null-generating side of a Join

2019-05-16 Thread Chunwei Lei (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16841439#comment-16841439 ] Chunwei Lei commented on CALCITE-2712: -- Thank you very much for your review

[jira] [Commented] (CALCITE-2601) Add REVERSE function

2019-05-15 Thread Chunwei Lei (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16840372#comment-16840372 ] Chunwei Lei commented on CALCITE-2601: -- I have changed the title to "Add REVERSE function". > Add

[jira] [Updated] (CALCITE-2601) Add REVERSE function

2019-05-15 Thread Chunwei Lei (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chunwei Lei updated CALCITE-2601: - Summary: Add REVERSE function (was: Support REVERSE(str) in SqlFunctions) > Add REVERSE

[jira] [Comment Edited] (CALCITE-3050) Integrate SqlDialect and SqlParser.Config

2019-05-15 Thread Chunwei Lei (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16840276#comment-16840276 ] Chunwei Lei edited comment on CALCITE-3050 at 5/15/19 10:20 AM:

[jira] [Commented] (CALCITE-3050) Integrate SqlDialect and SqlParser.Config

2019-05-15 Thread Chunwei Lei (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16840276#comment-16840276 ] Chunwei Lei commented on CALCITE-3050: -- [~julianhyde], the PR looks good and I left some comments

[jira] [Created] (CALCITE-3068) testSubprogram() does't test whether subprogram gets re-executed

2019-05-15 Thread Chunwei Lei (JIRA)
Chunwei Lei created CALCITE-3068: Summary: testSubprogram() does't test whether subprogram gets re-executed Key: CALCITE-3068 URL: https://issues.apache.org/jira/browse/CALCITE-3068 Project: Calcite

[jira] [Commented] (CALCITE-3068) testSubprogram() does't test whether subprogram gets re-executed

2019-05-15 Thread Chunwei Lei (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16840222#comment-16840222 ] Chunwei Lei commented on CALCITE-3068: -- I opened a PR: 

[jira] [Commented] (CALCITE-3062) Do not populate provenanceMap if not used

2019-05-14 Thread Chunwei Lei (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16839943#comment-16839943 ] Chunwei Lei commented on CALCITE-3062: -- I am not pretty sure what I worry about makes sense. So

[jira] [Commented] (CALCITE-3050) Integrate SqlDialect and SqlParser.Config

2019-05-14 Thread Chunwei Lei (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16839920#comment-16839920 ] Chunwei Lei commented on CALCITE-3050: -- [~julianhyde], I would like to review it. > Integrate

[jira] [Commented] (CALCITE-2965) Implement string functions: REPEAT, SPACE, SOUNDEX, DIFFERENCE

2019-05-14 Thread Chunwei Lei (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16839420#comment-16839420 ] Chunwei Lei commented on CALCITE-2965: -- [~julianhyde],PR is updated. Could you please review it?

[jira] [Commented] (CALCITE-2965) Implement string functions: REPEAT, SPACE, SOUNDEX, DIFFERENCE

2019-05-13 Thread Chunwei Lei (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16839047#comment-16839047 ] Chunwei Lei commented on CALCITE-2965: -- Sure. Will do soon. > Implement string functions: REPEAT,

[jira] [Resolved] (CALCITE-3064) [JDBC function escape] String not implemented REPEAT

2019-05-13 Thread Chunwei Lei (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3064?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chunwei Lei resolved CALCITE-3064. -- Resolution: Duplicate Fix Version/s: (was: 1.19.0) > [JDBC function escape]

[jira] [Reopened] (CALCITE-3064) [JDBC function escape] String not implemented REPEAT

2019-05-13 Thread Chunwei Lei (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3064?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chunwei Lei reopened CALCITE-3064: -- Reopen to mark it duplicated. > [JDBC function escape] String not implemented REPEAT >

[jira] [Commented] (CALCITE-3064) [JDBC function escape] String not implemented REPEAT

2019-05-13 Thread Chunwei Lei (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16838292#comment-16838292 ] Chunwei Lei commented on CALCITE-3064: -- It seems duplicate with CALCITE-2965. > [JDBC function

[jira] [Commented] (CALCITE-3062) Do not populate provenanceMap if not used

2019-05-11 Thread Chunwei Lei (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16837987#comment-16837987 ] Chunwei Lei commented on CALCITE-3062: -- In your proposal, if user does't set log level to DEBUG

[jira] [Commented] (CALCITE-3062) Do not populate provenanceMap if not used

2019-05-11 Thread Chunwei Lei (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16837878#comment-16837878 ] Chunwei Lei commented on CALCITE-3062: -- [~laurentgo], thanks for raising this. It sounds good. But

[jira] [Commented] (CALCITE-907) Add AggregateExchangeTransposeRule

2019-05-10 Thread Chunwei Lei (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16837104#comment-16837104 ] Chunwei Lei commented on CALCITE-907: - [~julianhyde], do we still need this rule? If yes, I would

[jira] [Assigned] (CALCITE-907) Add AggregateExchangeTransposeRule

2019-05-10 Thread Chunwei Lei (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-907?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chunwei Lei reassigned CALCITE-907: --- Assignee: Chunwei Lei > Add AggregateExchangeTransposeRule >

[jira] [Resolved] (CALCITE-3039) In Interpreter, min() incorrectly returns maximum double value

2019-05-07 Thread Chunwei Lei (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3039?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chunwei Lei resolved CALCITE-3039. -- Resolution: Fixed Fix Version/s: 1.20.0 > In Interpreter, min() incorrectly returns

[jira] [Updated] (CALCITE-3039) In Interpreter, min() incorrectly returns maximum double value

2019-05-07 Thread Chunwei Lei (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3039?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chunwei Lei updated CALCITE-3039: - Affects Version/s: (was: 1.17.0) 1.19.0 > In Interpreter, min()

[jira] [Commented] (CALCITE-3039) In Interpreter, min() incorrectly returns maximum double value

2019-05-07 Thread Chunwei Lei (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16834475#comment-16834475 ] Chunwei Lei commented on CALCITE-3039: -- Fixed in

[jira] [Assigned] (CALCITE-3039) In Interpreter, min() incorrectly returns maximum double value

2019-05-07 Thread Chunwei Lei (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3039?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chunwei Lei reassigned CALCITE-3039: Assignee: Chunwei Lei > In Interpreter, min() incorrectly returns maximum double value

[jira] [Resolved] (CALCITE-3003) AssertionError when GROUP BY nested field

2019-05-04 Thread Chunwei Lei (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3003?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chunwei Lei resolved CALCITE-3003. -- Resolution: Fixed Fix Version/s: 1.20.0 > AssertionError when GROUP BY nested field >

[jira] [Commented] (CALCITE-3003) AssertionError when GROUP BY nested field

2019-05-04 Thread Chunwei Lei (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16833201#comment-16833201 ] Chunwei Lei commented on CALCITE-3003: -- Fixed in

[jira] [Commented] (CALCITE-2712) Add rule to remove null-generating side of a Join

2019-05-03 Thread Chunwei Lei (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16832602#comment-16832602 ] Chunwei Lei commented on CALCITE-2712: -- [~julianhyde], [~hyuan] any other comments?:):):) > Add

[jira] [Resolved] (CALCITE-337) Support IGNORE NULLS in window aggregates

2019-04-27 Thread Chunwei Lei (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chunwei Lei resolved CALCITE-337. - Resolution: Duplicate Fix Version/s: 1.20.0 > Support IGNORE NULLS in window aggregates

[jira] [Commented] (CALCITE-337) Support IGNORE NULLS in window aggregates

2019-04-26 Thread Chunwei Lei (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16826959#comment-16826959 ] Chunwei Lei commented on CALCITE-337: - Duplicate with 

[jira] [Commented] (CALCITE-2292) Query result is wrong when table is implemented with FilterableTable and the sql has multiple where conditions

2019-04-26 Thread Chunwei Lei (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16826913#comment-16826913 ] Chunwei Lei commented on CALCITE-2292: -- I opened a PR: 

[jira] [Assigned] (CALCITE-2292) Query result is wrong when table is implemented with FilterableTable and the sql has multiple where conditions

2019-04-25 Thread Chunwei Lei (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2292?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chunwei Lei reassigned CALCITE-2292: Assignee: Chunwei Lei > Query result is wrong when table is implemented with

[jira] [Comment Edited] (CALCITE-2292) Query result is wrong when table is implemented with FilterableTable and the sql has multiple where conditions

2019-04-25 Thread Chunwei Lei (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16825790#comment-16825790 ] Chunwei Lei edited comment on CALCITE-2292 at 4/25/19 7:21 AM: --- I think

[jira] [Comment Edited] (CALCITE-2292) Query result is wrong when table is implemented with FilterableTable and the sql has multiple where conditions

2019-04-25 Thread Chunwei Lei (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16825790#comment-16825790 ] Chunwei Lei edited comment on CALCITE-2292 at 4/25/19 6:50 AM: --- I think

[jira] [Commented] (CALCITE-2292) Query result is wrong when table is implemented with FilterableTable and the sql has multiple where conditions

2019-04-25 Thread Chunwei Lei (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16825790#comment-16825790 ] Chunwei Lei commented on CALCITE-2292: -- It seems always return {{null }}for  {{(inp1_ == null ||

[jira] [Commented] (CALCITE-2846) Document Oracle-specific functions, such as NVL and LTRIM, in the SQL reference

2019-04-24 Thread Chunwei Lei (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16825715#comment-16825715 ] Chunwei Lei commented on CALCITE-2846: -- Good job, [~danny0405]. I left some comments. > Document

[jira] [Commented] (CALCITE-3009) DiffRepository should fail if XML resource file contains duplicate test names

2019-04-24 Thread Chunwei Lei (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16825642#comment-16825642 ] Chunwei Lei commented on CALCITE-3009: -- Got it! Thanks for your kindly reminder~~ >

[jira] [Updated] (CALCITE-3015) Add rule to remove constants in group keys

2019-04-24 Thread Chunwei Lei (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3015?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chunwei Lei updated CALCITE-3015: - Description: Constants in group keys can be removed to reduce shuffle. For instance,   

[jira] [Resolved] (CALCITE-3009) DiffRepository should fail if XML resource file contains duplicate test names

2019-04-24 Thread Chunwei Lei (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chunwei Lei resolved CALCITE-3009. -- Resolution: Fixed > DiffRepository should fail if XML resource file contains duplicate test

[jira] [Commented] (CALCITE-3009) DiffRepository should fail if XML resource file contains duplicate test names

2019-04-24 Thread Chunwei Lei (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16824875#comment-16824875 ] Chunwei Lei commented on CALCITE-3009: -- Fixed in 

[jira] [Commented] (CALCITE-3015) Add rule to remove constants in group keys

2019-04-24 Thread Chunwei Lei (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16824874#comment-16824874 ] Chunwei Lei commented on CALCITE-3015: -- Makes sense. Thanks [~zabetak]. > Add rule to remove

[jira] [Comment Edited] (CALCITE-2453) Enhance the SQL parser in order to optionally support semicolon at the end of the sql statements

2019-04-22 Thread Chunwei Lei (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16823643#comment-16823643 ] Chunwei Lei edited comment on CALCITE-2453 at 4/23/19 3:13 AM: --- Thanks

[jira] [Comment Edited] (CALCITE-2453) Enhance the SQL parser in order to optionally support semicolon at the end of the sql statements

2019-04-22 Thread Chunwei Lei (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16823643#comment-16823643 ] Chunwei Lei edited comment on CALCITE-2453 at 4/23/19 3:11 AM: --- Thanks

[jira] [Comment Edited] (CALCITE-2453) Enhance the SQL parser in order to optionally support semicolon at the end of the sql statements

2019-04-22 Thread Chunwei Lei (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16823643#comment-16823643 ] Chunwei Lei edited comment on CALCITE-2453 at 4/23/19 3:10 AM: --- Thanks

  1   2   3   4   >