[jira] [Commented] (CALCITE-3414) Unify Expression'type cast and conversion as a robust one

2019-10-16 Thread Feng Zhu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16952645#comment-16952645 ] Feng Zhu commented on CALCITE-3414: --- (1)According to the figures posted above, there are 19

[jira] [Commented] (CALCITE-3414) Unify Expression'type cast and conversion as a robust one

2019-10-15 Thread Feng Zhu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16952491#comment-16952491 ] Feng Zhu commented on CALCITE-3414: --- [~danny0405], there are two reasons: (1)some implementation in

[jira] [Comment Edited] (CALCITE-3414) Unify Expression'type cast and conversion as a robust one

2019-10-15 Thread Feng Zhu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16952470#comment-16952470 ] Feng Zhu edited comment on CALCITE-3414 at 10/16/19 3:11 AM: - Hi,

[jira] [Comment Edited] (CALCITE-3414) Unify Expression'type cast and conversion as a robust one

2019-10-15 Thread Feng Zhu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16952470#comment-16952470 ] Feng Zhu edited comment on CALCITE-3414 at 10/16/19 3:09 AM: - Hi,

[jira] [Commented] (CALCITE-3414) Unify Expression'type cast and conversion as a robust one

2019-10-15 Thread Feng Zhu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16952470#comment-16952470 ] Feng Zhu commented on CALCITE-3414: --- Hi, [~julianhyde] , thanks for your clarification on the role of

[jira] [Commented] (CALCITE-3414) Unify Expression'type cast and conversion as a robust one

2019-10-15 Thread Feng Zhu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16952468#comment-16952468 ] Feng Zhu commented on CALCITE-3414: --- Hi, [~danny0405], we find both of them have limitations. If we

[jira] [Created] (CALCITE-3414) Unify Expression'type cast and conversion as a robust one

2019-10-15 Thread Feng Zhu (Jira)
Feng Zhu created CALCITE-3414: - Summary: Unify Expression'type cast and conversion as a robust one Key: CALCITE-3414 URL: https://issues.apache.org/jira/browse/CALCITE-3414 Project: Calcite

[jira] [Created] (CALCITE-3411) Incorrect code generated for BigDecimal ConstantExpression

2019-10-14 Thread Feng Zhu (Jira)
Feng Zhu created CALCITE-3411: - Summary: Incorrect code generated for BigDecimal ConstantExpression Key: CALCITE-3411 URL: https://issues.apache.org/jira/browse/CALCITE-3411 Project: Calcite

[jira] [Commented] (CALCITE-3081) Literal NULL should be generated in SqlDialect

2019-10-14 Thread Feng Zhu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16950887#comment-16950887 ] Feng Zhu commented on CALCITE-3081: --- Hey, [~danny0405]. Thanks for your reminder! I will take a look

[jira] [Commented] (CALCITE-3224) New RexNode-to-Expression CodeGen Implementation

2019-09-19 Thread Feng Zhu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16934044#comment-16934044 ] Feng Zhu commented on CALCITE-3224: --- [~jinxing6...@126.com]Yeah, it is used to mark whether the value

[jira] [Assigned] (CALCITE-3332) Query failed with AssertionError: cannot cast null as class java.math.BigDecimal

2019-09-09 Thread Feng Zhu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Feng Zhu reassigned CALCITE-3332: - Assignee: Feng Zhu > Query failed with AssertionError: cannot cast null as class >

[jira] [Updated] (CALCITE-3332) Query failed with AssertionError: cannot cast null as class java.math.BigDecimal

2019-09-09 Thread Feng Zhu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Feng Zhu updated CALCITE-3332: -- Description: The problem can be reproduced by the following test case in ReflectiveSchemaTest

[jira] [Updated] (CALCITE-3332) Query failed with AssertionError: cannot cast null as class java.math.BigDecimal

2019-09-09 Thread Feng Zhu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Feng Zhu updated CALCITE-3332: -- Description: The problem can be reproduced by the following test case in ReflectiveSchemaTest

[jira] [Updated] (CALCITE-3332) Query failed with AssertionError: cannot cast null as class java.math.BigDecimal

2019-09-09 Thread Feng Zhu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Feng Zhu updated CALCITE-3332: -- Description: The problem can be reproduced by the following test case in ReflectiveSchemaTest

[jira] [Created] (CALCITE-3332) Query failed with AssertionError: cannot cast null as class java.math.BigDecimal

2019-09-09 Thread Feng Zhu (Jira)
Feng Zhu created CALCITE-3332: - Summary: Query failed with AssertionError: cannot cast null as class java.math.BigDecimal Key: CALCITE-3332 URL: https://issues.apache.org/jira/browse/CALCITE-3332

[jira] [Assigned] (CALCITE-3245) CompileException in Janino when a query contains a division between a Double and a BigDecimal

2019-08-14 Thread Feng Zhu (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Feng Zhu reassigned CALCITE-3245: - Assignee: Feng Zhu > CompileException in Janino when a query contains a division between a

[jira] [Commented] (CALCITE-3245) CompileException in Janino when a query contains a division between a Double and a BigDecimal

2019-08-14 Thread Feng Zhu (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16907769#comment-16907769 ] Feng Zhu commented on CALCITE-3245: --- Thanks [~zabetak], I'd like to solve this problem since it is

[jira] [Commented] (CALCITE-3236) Handle issues found in static code analysis

2019-08-14 Thread Feng Zhu (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16907235#comment-16907235 ] Feng Zhu commented on CALCITE-3236: --- Hi, [~krisden], thank for your comments and advice. Maybe we can

[jira] [Commented] (CALCITE-3245) CompileException in Janino when a query contains a division between a Double and a BigDecimal

2019-08-14 Thread Feng Zhu (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16907231#comment-16907231 ] Feng Zhu commented on CALCITE-3245: --- Hi, [~zabetak]. Could you post your modification on CATCHALL? I

[jira] [Created] (CALCITE-3236) Handle issues found in static code analysis

2019-08-07 Thread Feng Zhu (JIRA)
Feng Zhu created CALCITE-3236: - Summary: Handle issues found in static code analysis Key: CALCITE-3236 URL: https://issues.apache.org/jira/browse/CALCITE-3236 Project: Calcite Issue Type: Bug

[jira] [Commented] (CALCITE-3224) New RexNode-to-Expression CodeGen Implementation

2019-08-04 Thread Feng Zhu (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16899597#comment-16899597 ] Feng Zhu commented on CALCITE-3224: --- Hi, [~zabetak], [~julianhyde] Really thanks for the feedback

[jira] [Commented] (CALCITE-3224) New RexNode-to-Expression CodeGen Implementation

2019-08-02 Thread Feng Zhu (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16898872#comment-16898872 ] Feng Zhu commented on CALCITE-3224: --- Hi, [~zabetak]. Thanks for your clarification. As your

[jira] [Updated] (CALCITE-3173) RexNode Code Generation Problem

2019-08-01 Thread Feng Zhu (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Feng Zhu updated CALCITE-3173: -- Labels: pull-request-available (was: ) > RexNode Code Generation Problem >

[jira] [Updated] (CALCITE-3173) RexNode Code Generation Problem

2019-08-01 Thread Feng Zhu (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Feng Zhu updated CALCITE-3173: -- Affects Version/s: (was: next) 1.20.0 > RexNode Code Generation Problem >

[jira] [Updated] (CALCITE-3173) RexNode Code Generation Problem

2019-08-01 Thread Feng Zhu (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Feng Zhu updated CALCITE-3173: -- Fix Version/s: 1.21.0 > RexNode Code Generation Problem > --- > >

[jira] [Updated] (CALCITE-3150) NPE in UPPER when repeated and combine with LIKE

2019-08-01 Thread Feng Zhu (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Feng Zhu updated CALCITE-3150: -- Labels: pull-request-available (was: ) > NPE in UPPER when repeated and combine with LIKE >

[jira] [Updated] (CALCITE-3143) Dividing NULLIF clause may cause Division by zero error

2019-08-01 Thread Feng Zhu (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Feng Zhu updated CALCITE-3143: -- Fix Version/s: 1.21.0 > Dividing NULLIF clause may cause Division by zero error >

[jira] [Updated] (CALCITE-3143) Dividing NULLIF clause may cause Division by zero error

2019-08-01 Thread Feng Zhu (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Feng Zhu updated CALCITE-3143: -- Labels: pull-request-available (was: ) > Dividing NULLIF clause may cause Division by zero error >

[jira] [Updated] (CALCITE-3143) Dividing NULLIF clause may cause Division by zero error

2019-08-01 Thread Feng Zhu (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Feng Zhu updated CALCITE-3143: -- Component/s: core > Dividing NULLIF clause may cause Division by zero error >

[jira] [Updated] (CALCITE-3142) An NPE when rounding a nullable numeric

2019-08-01 Thread Feng Zhu (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3142?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Feng Zhu updated CALCITE-3142: -- Labels: pull-request-available (was: ) > An NPE when rounding a nullable numeric >

[jira] [Updated] (CALCITE-3142) An NPE when rounding a nullable numeric

2019-08-01 Thread Feng Zhu (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3142?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Feng Zhu updated CALCITE-3142: -- Labels: (was: pull-request-available) > An NPE when rounding a nullable numeric >

[jira] [Commented] (CALCITE-3224) New RexNode-to-Expression CodeGen Implementation

2019-08-01 Thread Feng Zhu (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16897886#comment-16897886 ] Feng Zhu commented on CALCITE-3224: --- Yes, [~zabetak], I agree with you. It brings heavy work to

[jira] [Assigned] (CALCITE-3173) RexNode Code Generation Problem

2019-08-01 Thread Feng Zhu (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Feng Zhu reassigned CALCITE-3173: - Assignee: Feng Zhu > RexNode Code Generation Problem > --- > >

[jira] [Updated] (CALCITE-3224) New RexNode-to-Expression CodeGen Implementation

2019-08-01 Thread Feng Zhu (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Feng Zhu updated CALCITE-3224: -- Description: h3. *Background*     Current RexNode-to-Expression implementation relies on

[jira] [Updated] (CALCITE-3224) New RexNode-to-Expression CodeGen Implementation

2019-08-01 Thread Feng Zhu (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Feng Zhu updated CALCITE-3224: -- Description: h3. *Background*     Current RexNode-to-Expression implementation relies on

[jira] [Created] (CALCITE-3224) New RexNode-to-Expression CodeGen Implementation

2019-08-01 Thread Feng Zhu (JIRA)
Feng Zhu created CALCITE-3224: - Summary: New RexNode-to-Expression CodeGen Implementation Key: CALCITE-3224 URL: https://issues.apache.org/jira/browse/CALCITE-3224 Project: Calcite Issue Type:

[jira] [Commented] (CALCITE-3081) Literal NULL should be generated in SqlDialect

2019-07-29 Thread Feng Zhu (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16895711#comment-16895711 ] Feng Zhu commented on CALCITE-3081: --- Hi, [~julianhyde], we can do something to solve this issue. But

[jira] [Commented] (CALCITE-3142) An NPE when rounding a nullable numeric

2019-07-25 Thread Feng Zhu (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16893285#comment-16893285 ] Feng Zhu commented on CALCITE-3142: --- Hi [~zabetak] Yes, the PR can be ready for review and discuss.

[jira] [Updated] (CALCITE-3195) Handle UDF that throws checked exceptions in enumerable code generator

2019-07-17 Thread Feng Zhu (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Feng Zhu updated CALCITE-3195: -- Labels: pull-request-available (was: ) > Handle UDF that throws checked exceptions in enumerable

[jira] [Updated] (CALCITE-3195) Handle UDF that throws checked exceptions in enumerable code generator

2019-07-17 Thread Feng Zhu (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Feng Zhu updated CALCITE-3195: -- Summary: Handle UDF that throws checked exceptions in enumerable code generator (was: Fix

[jira] [Assigned] (CALCITE-3195) Fix enumerable code generator to handle UDFs that throws checked Exceptions

2019-07-17 Thread Feng Zhu (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Feng Zhu reassigned CALCITE-3195: - Assignee: Feng Zhu > Fix enumerable code generator to handle UDFs that throws checked

[jira] [Commented] (CALCITE-3195) Fix enumerable code generator to handle UDFs that throws checked Exceptions

2019-07-16 Thread Feng Zhu (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16885875#comment-16885875 ] Feng Zhu commented on CALCITE-3195: --- Hi, [~khaitran]. I opend a PR

[jira] [Commented] (CALCITE-3142) An NPE when rounding a nullable numeric

2019-07-14 Thread Feng Zhu (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16884611#comment-16884611 ] Feng Zhu commented on CALCITE-3142: --- Thanks, [~julianhyde]. I will address your comments and create

[jira] [Comment Edited] (CALCITE-3142) An NPE when rounding a nullable numeric

2019-07-11 Thread Feng Zhu (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16882691#comment-16882691 ] Feng Zhu edited comment on CALCITE-3142 at 7/11/19 7:05 AM: Hi

[jira] [Commented] (CALCITE-3142) An NPE when rounding a nullable numeric

2019-07-11 Thread Feng Zhu (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16882691#comment-16882691 ] Feng Zhu commented on CALCITE-3142: --- Hi [~vladimirsitnikov] [~zabetak] [~julianhyde], I opened an

[jira] [Updated] (CALCITE-3142) An NPE when rounding a nullable numeric

2019-07-11 Thread Feng Zhu (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3142?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Feng Zhu updated CALCITE-3142: -- Attachment: newcodegen.png > An NPE when rounding a nullable numeric >

[jira] [Commented] (CALCITE-3113) Equivalent MutableAggregates with different row types fail with AssertionError

2019-07-09 Thread Feng Zhu (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16881659#comment-16881659 ] Feng Zhu commented on CALCITE-3113: ---  I am not working on it. [~jinxing6...@126.com] Thanks for your

[jira] [Commented] (CALCITE-3173) RexNode Code Generation Problem

2019-07-08 Thread Feng Zhu (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16880861#comment-16880861 ] Feng Zhu commented on CALCITE-3173: --- Hi, [~zabetak]. Thanks for your response and suggestions. Yes,

[jira] [Comment Edited] (CALCITE-3182) Trim unused fields for plan of materialized-view before matching.

2019-07-08 Thread Feng Zhu (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16880267#comment-16880267 ] Feng Zhu edited comment on CALCITE-3182 at 7/8/19 12:30 PM: Hi,

[jira] [Commented] (CALCITE-3182) Trim unused fields for plan of materialized-view before matching.

2019-07-08 Thread Feng Zhu (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16880267#comment-16880267 ] Feng Zhu commented on CALCITE-3182: --- Hi, [~jinxing6...@126.com]. Can you take CALCITE-3113 i[nto

[jira] [Comment Edited] (CALCITE-3182) Trim unused fields for plan of materialized-view before matching.

2019-07-08 Thread Feng Zhu (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16880267#comment-16880267 ] Feng Zhu edited comment on CALCITE-3182 at 7/8/19 12:29 PM: Hi,

[jira] [Commented] (CALCITE-3173) RexNode Code Generation Problem

2019-07-07 Thread Feng Zhu (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16880005#comment-16880005 ] Feng Zhu commented on CALCITE-3173: --- [~vladimirsitnikov], No, it has nothing to do with Scala or any

[jira] [Updated] (CALCITE-3173) RexNode Code Generation Problem

2019-07-07 Thread Feng Zhu (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Feng Zhu updated CALCITE-3173: -- Attachment: codegen.png > RexNode Code Generation Problem > --- > >

[jira] [Updated] (CALCITE-3173) RexNode Code Generation Problem

2019-07-07 Thread Feng Zhu (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Feng Zhu updated CALCITE-3173: -- Attachment: (was: codegen.png) > RexNode Code Generation Problem >

[jira] [Updated] (CALCITE-3173) RexNode Code Generation Problem

2019-07-07 Thread Feng Zhu (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Feng Zhu updated CALCITE-3173: -- Attachment: codegen.png > RexNode Code Generation Problem > --- > >

[jira] [Comment Edited] (CALCITE-3173) RexNode Code Generation Problem

2019-07-05 Thread Feng Zhu (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16879334#comment-16879334 ] Feng Zhu edited comment on CALCITE-3173 at 7/5/19 2:42 PM: ---

[jira] [Commented] (CALCITE-3173) RexNode Code Generation Problem

2019-07-05 Thread Feng Zhu (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16879334#comment-16879334 ] Feng Zhu commented on CALCITE-3173: --- [~vladimirsitnikov]. Thanks for your response. I get your

[jira] [Updated] (CALCITE-3173) RexNode Code Generation Problem

2019-07-05 Thread Feng Zhu (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Feng Zhu updated CALCITE-3173: -- Description: *Abstract:* Both RexImpTable and BlockBuilder have codegen issues, but it is

[jira] [Updated] (CALCITE-3173) RexNode Code Generation Problem

2019-07-05 Thread Feng Zhu (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Feng Zhu updated CALCITE-3173: -- Description: *Abstract:* Both RexImpTable and BlockBuilder have codegen issues, but it is

[jira] [Updated] (CALCITE-3173) RexNode Code Generation Problem

2019-07-05 Thread Feng Zhu (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Feng Zhu updated CALCITE-3173: -- Description: *Abstract:* Both RexImpTable and BlockBuilder have codegen issues, but it is

[jira] [Updated] (CALCITE-3173) RexNode Code Generation Problem

2019-07-05 Thread Feng Zhu (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Feng Zhu updated CALCITE-3173: -- Attachment: code.png > RexNode Code Generation Problem > --- > >

[jira] [Updated] (CALCITE-3173) RexNode Code Generation Problem

2019-07-05 Thread Feng Zhu (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Feng Zhu updated CALCITE-3173: -- Attachment: (was: pic.png) > RexNode Code Generation Problem > --- >

[jira] [Updated] (CALCITE-3173) RexNode Code Generation Problem

2019-07-05 Thread Feng Zhu (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Feng Zhu updated CALCITE-3173: -- Description: *Abstract:* Both RexImpTable and BlockBuilder have codegen issues, but it is

[jira] [Created] (CALCITE-3173) RexNode Code Generation Problem

2019-07-05 Thread Feng Zhu (JIRA)
Feng Zhu created CALCITE-3173: - Summary: RexNode Code Generation Problem Key: CALCITE-3173 URL: https://issues.apache.org/jira/browse/CALCITE-3173 Project: Calcite Issue Type: Improvement

[jira] [Commented] (CALCITE-3160) Failed to materialize when the aggregate function uses group key

2019-07-03 Thread Feng Zhu (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16878279#comment-16878279 ] Feng Zhu commented on CALCITE-3160: --- [~julianhyde], [~hyuan]. Thanks for advice, I will change the

[jira] [Commented] (CALCITE-3160) TrivialRule should conduct replacement when it matches

2019-07-03 Thread Feng Zhu (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16877598#comment-16877598 ] Feng Zhu commented on CALCITE-3160: --- I incline to fix the TrivialRule because

[jira] [Assigned] (CALCITE-3160) TrivialRule should conduct replacement when it matches

2019-07-03 Thread Feng Zhu (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Feng Zhu reassigned CALCITE-3160: - Assignee: Feng Zhu > TrivialRule should conduct replacement when it matches >

[jira] [Updated] (CALCITE-3160) TrivialRule should conduct replacement when it matches

2019-07-03 Thread Feng Zhu (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Feng Zhu updated CALCITE-3160: -- Summary: TrivialRule should conduct replacement when it matches (was: Failed to materialize when

[jira] [Commented] (CALCITE-3164) Averaging an all-nulls values after grouping produce NaN instead of NULL

2019-07-03 Thread Feng Zhu (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16877529#comment-16877529 ] Feng Zhu commented on CALCITE-3164: --- Hi, [~mgelbana], I cannot reproduce the issue in current master

[jira] [Commented] (CALCITE-3160) Failed to materialize when the aggregate function uses group key

2019-07-01 Thread Feng Zhu (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16876680#comment-16876680 ] Feng Zhu commented on CALCITE-3160: --- I have also noticed such kind of issues. (1)When sum(empid),

[jira] [Commented] (CALCITE-3155) Bug in RelToSqlConversion when visiting Values node with no tuples

2019-06-29 Thread Feng Zhu (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16875430#comment-16875430 ] Feng Zhu commented on CALCITE-3155: --- Hi [~MusbahELFIL], could you post the exception stacktrace? >

[jira] [Assigned] (CALCITE-3150) NPE in UPPER when repeated and combine with LIKE

2019-06-28 Thread Feng Zhu (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Feng Zhu reassigned CALCITE-3150: - Assignee: Feng Zhu > NPE in UPPER when repeated and combine with LIKE >

[jira] [Commented] (CALCITE-3150) NPE in UPPER when repeated and combine with LIKE

2019-06-27 Thread Feng Zhu (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16874628#comment-16874628 ] Feng Zhu commented on CALCITE-3150: --- [~zabetak] Yes, your finding reveals two major aspects in this

[jira] [Commented] (CALCITE-3150) NPE in UPPER when repeated and combine with LIKE

2019-06-27 Thread Feng Zhu (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16873939#comment-16873939 ] Feng Zhu commented on CALCITE-3150: --- This issue is also similar to CALCITE-3142 and CALCITE-3143. We

[jira] [Assigned] (CALCITE-3143) Dividing NULLIF clause may cause Division by zero error

2019-06-26 Thread Feng Zhu (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Feng Zhu reassigned CALCITE-3143: - Assignee: Feng Zhu > Dividing NULLIF clause may cause Division by zero error >

[jira] [Comment Edited] (CALCITE-3143) Dividing NULLIF clause may cause Division by zero error

2019-06-26 Thread Feng Zhu (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16873781#comment-16873781 ] Feng Zhu edited comment on CALCITE-3143 at 6/27/19 3:15 AM: This issue is

[jira] [Commented] (CALCITE-3143) Dividing NULLIF clause may cause Division by zero error

2019-06-26 Thread Feng Zhu (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16873781#comment-16873781 ] Feng Zhu commented on CALCITE-3143: --- This issue is similar to CALCITE-3142. Apache Spark's codegen

[jira] [Commented] (CALCITE-3142) An NPE when rounding a nullable numeric

2019-06-26 Thread Feng Zhu (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16873773#comment-16873773 ] Feng Zhu commented on CALCITE-3142: --- It is caused by the codegen issue when translating Rex

[jira] [Assigned] (CALCITE-3142) An NPE when rounding a nullable numeric

2019-06-26 Thread Feng Zhu (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3142?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Feng Zhu reassigned CALCITE-3142: - Assignee: Feng Zhu > An NPE when rounding a nullable numeric >

[jira] [Comment Edited] (CALCITE-3128) Joining two tables producing only NULLs will return 0 rows

2019-06-24 Thread Feng Zhu (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16871116#comment-16871116 ] Feng Zhu edited comment on CALCITE-3128 at 6/24/19 12:20 PM: - [~danny0405]

[jira] [Comment Edited] (CALCITE-3128) Joining two tables producing only NULLs will return 0 rows

2019-06-24 Thread Feng Zhu (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16871116#comment-16871116 ] Feng Zhu edited comment on CALCITE-3128 at 6/24/19 12:20 PM: - [~danny0405]

[jira] [Commented] (CALCITE-3128) Joining two tables producing only NULLs will return 0 rows

2019-06-24 Thread Feng Zhu (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16871116#comment-16871116 ] Feng Zhu commented on CALCITE-3128: --- [~danny0405] I ever executed the query in PG. It will produce a

[jira] [Commented] (CALCITE-3128) Joining two tables producing only NULLs will return 0 rows

2019-06-24 Thread Feng Zhu (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16870827#comment-16870827 ] Feng Zhu commented on CALCITE-3128: --- The generated code for query seems to be OK. {code:java} public

[jira] [Commented] (CALCITE-771) Use materialization for scan-project-sort query

2019-06-21 Thread Feng Zhu (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16869221#comment-16869221 ] Feng Zhu commented on CALCITE-771: -- Hi, [~julianhyde], I opened a PR on this feature, do you have time

[jira] [Commented] (CALCITE-3087) AggregateOnProjectToAggregateUnifyRule ignores Project incorrectly when its Mapping breaks ordering

2019-06-17 Thread Feng Zhu (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16865510#comment-16865510 ] Feng Zhu commented on CALCITE-3087: --- Hi, [~hyuan]. The issue is about the mapping in

[jira] [Comment Edited] (CALCITE-3060) Materialized view: "target out of range" error

2019-06-13 Thread Feng Zhu (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16862799#comment-16862799 ] Feng Zhu edited comment on CALCITE-3060 at 6/13/19 7:46 AM:  Hi, [~hyuan].

[jira] [Assigned] (CALCITE-3060) Materialized view: "target out of range" error

2019-06-13 Thread Feng Zhu (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3060?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Feng Zhu reassigned CALCITE-3060: - Assignee: Feng Zhu > Materialized view: "target out of range" error >

[jira] [Commented] (CALCITE-3060) Materialized view: "target out of range" error

2019-06-13 Thread Feng Zhu (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16862799#comment-16862799 ] Feng Zhu commented on CALCITE-3060: ---   Hi, [~hyuan]. This issue is similar to the issue I found in

[jira] [Created] (CALCITE-3113) Equivalent MutableAggregates with different row types fail with AssertionError

2019-06-06 Thread Feng Zhu (JIRA)
Feng Zhu created CALCITE-3113: - Summary: Equivalent MutableAggregates with different row types fail with AssertionError Key: CALCITE-3113 URL: https://issues.apache.org/jira/browse/CALCITE-3113 Project:

[jira] [Commented] (CALCITE-3087) AggregateOnProjectToAggregateUnifyRule ignores Project incorrectly when its Mapping breaks ordering

2019-06-06 Thread Feng Zhu (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16857333#comment-16857333 ] Feng Zhu commented on CALCITE-3087: --- Therefore, when a posList generates IdentifyMapping or

[jira] [Created] (CALCITE-3112) Support Window in RelToSqlConverter

2019-06-05 Thread Feng Zhu (JIRA)
Feng Zhu created CALCITE-3112: - Summary: Support Window in RelToSqlConverter Key: CALCITE-3112 URL: https://issues.apache.org/jira/browse/CALCITE-3112 Project: Calcite Issue Type: Improvement

[jira] [Commented] (CALCITE-3087) AggregateOnProjectToAggregateUnifyRule ignores Project incorrectly when its Mapping breaks ordering

2019-06-05 Thread Feng Zhu (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16857228#comment-16857228 ] Feng Zhu commented on CALCITE-3087: --- In *MutableRels.createProject*: Given List posList = \{1, 2, 0}

[jira] [Commented] (CALCITE-3087) AggregateOnProjectToAggregateUnifyRule ignores Project incorrectly when its Mapping breaks ordering

2019-06-04 Thread Feng Zhu (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16856357#comment-16856357 ] Feng Zhu commented on CALCITE-3087: --- Thanks for insightful comments and test case. I made a mistake.

[jira] [Commented] (CALCITE-3087) AggregateOnProjectToAggregateUnifyRule cannot ignore Project when its Mapping breaks ordering

2019-06-03 Thread Feng Zhu (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16855352#comment-16855352 ] Feng Zhu commented on CALCITE-3087: --- I add a test case for ROLLUP. {code:java} Query

[jira] [Commented] (CALCITE-3087) AggregateOnProjectToAggregateUnifyRule cannot ignore Project when its Mapping breaks ordering

2019-06-03 Thread Feng Zhu (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16855345#comment-16855345 ] Feng Zhu commented on CALCITE-3087: --- For the pattern: *Query(Aggregate)->Project->Child1* &

[jira] [Updated] (CALCITE-3087) AggregateOnProjectToAggregateUnifyRule cannot ignore Project when its Mapping breaks ordering

2019-06-03 Thread Feng Zhu (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3087?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Feng Zhu updated CALCITE-3087: -- Summary: AggregateOnProjectToAggregateUnifyRule cannot ignore Project when its Mapping breaks

[jira] [Updated] (CALCITE-3087) AggregateOnProjectToAggregateUnifyRule ignores Project unsafely

2019-06-03 Thread Feng Zhu (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3087?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Feng Zhu updated CALCITE-3087: -- Summary: AggregateOnProjectToAggregateUnifyRule ignores Project unsafely (was: Mappings.apply2

[jira] [Updated] (CALCITE-3087) AggregateOnProjectToAggregateUnifyRule ignores Project unsafely

2019-06-03 Thread Feng Zhu (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3087?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Feng Zhu updated CALCITE-3087: -- Component/s: core > AggregateOnProjectToAggregateUnifyRule ignores Project unsafely >

[jira] [Assigned] (CALCITE-3087) Mappings.apply2 doesn't keep order

2019-06-03 Thread Feng Zhu (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3087?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Feng Zhu reassigned CALCITE-3087: - Assignee: Feng Zhu > Mappings.apply2 doesn't keep order > --

[jira] [Commented] (CALCITE-3087) Mappings.apply2 doesn't keep order

2019-06-03 Thread Feng Zhu (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-3087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16854304#comment-16854304 ] Feng Zhu commented on CALCITE-3087: --- Another way is to add a Project after UnifyAggregate. For this

  1   2   >