[jira] [Commented] (CALCITE-3366) RelDecorrelator supports Union

2021-05-26 Thread Jin Xing (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17351626#comment-17351626 ] Jin Xing commented on CALCITE-3366: --- I means it's good if some other people could take this jira and

[jira] [Commented] (CALCITE-3366) RelDecorrelator supports Union

2021-05-26 Thread Jin Xing (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17351545#comment-17351545 ] Jin Xing commented on CALCITE-3366: --- I closed pr-1468 for now. It's good if someone could take over.

[jira] [Comment Edited] (CALCITE-3935) Materialization-Failed, when querying with LeftJoinWithFilter

2020-06-12 Thread Jin Xing (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17134120#comment-17134120 ] Jin Xing edited comment on CALCITE-3935 at 6/12/20, 10:46 AM: -- Please

[jira] [Commented] (CALCITE-3935) Materialization-Failed, when querying with LeftJoinWithFilter

2020-06-12 Thread Jin Xing (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17134120#comment-17134120 ] Jin Xing commented on CALCITE-3935: --- Refine the Jira title and give some basic analysis in the

[jira] [Updated] (CALCITE-4040) Materialized View matching failed with NPE if aggregate function doesn't support roll up

2020-06-12 Thread Jin Xing (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4040?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jin Xing updated CALCITE-4040: -- Summary: Materialized View matching failed with NPE if aggregate function doesn't support roll up

[jira] [Commented] (CALCITE-3786) Add Digest interface to enable efficient hashCode(equals) for RexNode and RelNode

2020-06-10 Thread Jin Xing (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17132926#comment-17132926 ] Jin Xing commented on CALCITE-3786: --- In my environment, some users use program to generate big

[jira] [Commented] (CALCITE-4022) After SqlInsert is traversed by SqlShuttle, SqlBasicCall throws UnsupportedOperationException

2020-05-25 Thread Jin Xing (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17116348#comment-17116348 ] Jin Xing commented on CALCITE-4022: --- Can you please give the Sql and the stacktrace ? Or some

[jira] [Comment Edited] (CALCITE-2997) Avoid pushing down join condition in SqlToRelConverter

2020-05-19 Thread Jin Xing (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-2997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17111699#comment-17111699 ] Jin Xing edited comment on CALCITE-2997 at 5/20/20, 2:36 AM: - Thanks

[jira] [Commented] (CALCITE-2997) Avoid pushing down join condition in SqlToRelConverter

2020-05-19 Thread Jin Xing (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-2997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17111699#comment-17111699 ] Jin Xing commented on CALCITE-2997: --- Thanks [~swtalbot] and [~julianhyde] to bring this up ~ Yes, In

[jira] [Commented] (CALCITE-4003) In MaterializationTest, FilterProjectTransposeRule matches with logical and physical convention

2020-05-16 Thread Jin Xing (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17109081#comment-17109081 ] Jin Xing commented on CALCITE-4003: --- Hi, [~hyuan] , thanks for ping me ~ In my project, all

[jira] [Commented] (CALCITE-3366) RelDecorrelator supports Union

2020-05-08 Thread Jin Xing (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17103065#comment-17103065 ] Jin Xing commented on CALCITE-3366: --- Thanks [~Juhwan] There's a PR there. You may take a look or

[jira] [Commented] (CALCITE-3958) revise description of gradle.properties and SubstitutionVisitor

2020-04-26 Thread Jin Xing (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17092551#comment-17092551 ] Jin Xing commented on CALCITE-3958: --- # Seems artifact.name and description in gradle.properties are

[jira] [Commented] (CALCITE-3959) Implement INSTR function

2020-04-26 Thread Jin Xing (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17092544#comment-17092544 ] Jin Xing commented on CALCITE-3959: --- Do we also need to update reference.md ? BTW, please link the

[jira] [Assigned] (CALCITE-3950) Doc of SqlGroupingFunction contradicts its behavior

2020-04-23 Thread Jin Xing (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3950?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jin Xing reassigned CALCITE-3950: - Assignee: Jin Xing > Doc of SqlGroupingFunction contradicts its behavior >

[jira] [Updated] (CALCITE-3950) Doc of SqlGroupingFunction contradicts its behavior

2020-04-23 Thread Jin Xing (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3950?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jin Xing updated CALCITE-3950: -- Summary: Doc of SqlGroupingFunction contradicts its behavior (was: Doc of SqlGroupingFunction

[jira] [Commented] (CALCITE-3952) Improve SortRemoveRule to remove Sort based on rowcount

2020-04-23 Thread Jin Xing (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17090431#comment-17090431 ] Jin Xing commented on CALCITE-3952: --- Yes, [~julianhyde], it should be getMaxRowCount :D > Improve

[jira] [Commented] (CALCITE-3952) Improve SortRemoveRule to remove Sort based on rowcount

2020-04-23 Thread Jin Xing (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17090322#comment-17090322 ] Jin Xing commented on CALCITE-3952: --- Given a rel which emit at most 1 row

[jira] [Issue Comment Deleted] (CALCITE-3952) Improve SortRemoveRule to remove Sort based on rowcount

2020-04-23 Thread Jin Xing (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3952?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jin Xing updated CALCITE-3952: -- Comment: was deleted (was: Given a rel which emit at most 1 row (RelMetadataQuery.getRowCount(rel)

[jira] [Commented] (CALCITE-3952) Improve SortRemoveRule to remove Sort based on rowcount

2020-04-23 Thread Jin Xing (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17090309#comment-17090309 ] Jin Xing commented on CALCITE-3952: --- Given a rel which emit at most 1 row

[jira] [Commented] (CALCITE-3758) FilterTableScanRule generate wrong mapping for filter condition when underlying is BindableTableScan

2020-04-22 Thread Jin Xing (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17090185#comment-17090185 ] Jin Xing commented on CALCITE-3758: --- Thanks for merging ! > FilterTableScanRule generate wrong

[jira] [Commented] (CALCITE-3936) RelToSqlConverter changes target of ambiguous HAVING clause with a Project on Filter on Aggregate

2020-04-22 Thread Jin Xing (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17090180#comment-17090180 ] Jin Xing commented on CALCITE-3936: --- Yes [~julianhyde], the generated SQL is invalid. We need to fix

[jira] [Comment Edited] (CALCITE-3948) Improve operand's RelSubset matching handling in VolcanoRuleCall

2020-04-22 Thread Jin Xing (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17089563#comment-17089563 ] Jin Xing edited comment on CALCITE-3948 at 4/22/20, 11:11 AM: -- [~Chunwei

[jira] [Commented] (CALCITE-3948) Improve operand's RelSubset matching handling in VolcanoRuleCall

2020-04-22 Thread Jin Xing (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17089563#comment-17089563 ] Jin Xing commented on CALCITE-3948: --- [~Chunwei Lei] Yes, I've also found some PRs failed to be

[jira] [Updated] (CALCITE-3950) Doc of SqlGroupingFunction contradicts with its behavior

2020-04-22 Thread Jin Xing (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3950?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jin Xing updated CALCITE-3950: -- Description: Currently doc of SqlGroupingFunctions says: {code:java} /** * The {@code GROUPING}

[jira] [Updated] (CALCITE-3950) Doc of SqlGroupingFunction contradicts with its behavior

2020-04-22 Thread Jin Xing (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3950?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jin Xing updated CALCITE-3950: -- Description: Currently doc of SqlGroupingFunctions says: {code:java} /** * The {@code GROUPING}

[jira] [Created] (CALCITE-3950) Doc of SqlGroupingFunction contradicts with its behavior

2020-04-22 Thread Jin Xing (Jira)
Jin Xing created CALCITE-3950: - Summary: Doc of SqlGroupingFunction contradicts with its behavior Key: CALCITE-3950 URL: https://issues.apache.org/jira/browse/CALCITE-3950 Project: Calcite Issue

[jira] [Commented] (CALCITE-3946) Add parser support for MULTISET/SET and VOLATILE modifiers in CREATE TABLE statements

2020-04-22 Thread Jin Xing (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17089321#comment-17089321 ] Jin Xing commented on CALCITE-3946: --- Shall we go by PostgreSQL grammar [1] ? For MULTISET/SET, we

[jira] [Commented] (CALCITE-3928) Canonicalization doesn't do field trimming before materialized view matching

2020-04-21 Thread Jin Xing (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17089277#comment-17089277 ] Jin Xing commented on CALCITE-3928: --- [~xzh_dz] Thanks for PR ~ comments left. > Canonicalization

[jira] [Updated] (CALCITE-3928) Canonicalization doesn't do field trimming before materialized view matching

2020-04-21 Thread Jin Xing (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3928?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jin Xing updated CALCITE-3928: -- Description: If we have query and materialized view as below: {code:java} query:

[jira] [Commented] (CALCITE-3928) Canonicalization doesn't do field trimming before materialized view matching

2020-04-21 Thread Jin Xing (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17089249#comment-17089249 ] Jin Xing commented on CALCITE-3928: --- The case I mentioned is not accurate, [~xzh_dz] I updated your

[jira] [Commented] (CALCITE-3925) Support materialized view matching for LogicalCorrelate in SubsitutionVisitor

2020-04-21 Thread Jin Xing (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17088631#comment-17088631 ] Jin Xing commented on CALCITE-3925: --- [~xzh_dz] Thanks a lot for PR, comments left ~ > Support

[jira] [Assigned] (CALCITE-3447) Fix equivalents in method SubstitutionVisitor#go

2020-04-20 Thread Jin Xing (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jin Xing reassigned CALCITE-3447: - Assignee: Jin Xing > Fix equivalents in method SubstitutionVisitor#go >

[jira] [Commented] (CALCITE-3938) implement visit LogicalCalc in RelShuttleImpl

2020-04-19 Thread Jin Xing (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17086999#comment-17086999 ] Jin Xing commented on CALCITE-3938: --- How about rename the title as "Support LogicalCalc in

[jira] [Commented] (CALCITE-3936) RelToSqlConverter changes target of ambiguous HAVING clause with a Project on Filter on Aggregate

2020-04-18 Thread Jin Xing (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17086382#comment-17086382 ] Jin Xing commented on CALCITE-3936: --- Add a simpler test case: {code:java} // Sql: isHaving = false

[jira] [Comment Edited] (CALCITE-3935) Materialization-Failed, when querying with LeftJoinWithFilter

2020-04-17 Thread Jin Xing (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17085707#comment-17085707 ] Jin Xing edited comment on CALCITE-3935 at 4/17/20, 12:45 PM: -- Thanks ! I

[jira] [Commented] (CALCITE-3935) Materialization-Failed, when querying with LeftJoinWithFilter

2020-04-17 Thread Jin Xing (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17085707#comment-17085707 ] Jin Xing commented on CALCITE-3935: --- Thanks ! I really appreciate your fix ~ I can take a review

[jira] [Comment Edited] (CALCITE-3935) Materialization-Failed, when querying with LeftJoinWithFilter

2020-04-17 Thread Jin Xing (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17085701#comment-17085701 ] Jin Xing edited comment on CALCITE-3935 at 4/17/20, 12:37 PM: -- Thanks for

[jira] [Commented] (CALCITE-3935) Materialization-Failed, when querying with LeftJoinWithFilter

2020-04-17 Thread Jin Xing (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17085701#comment-17085701 ] Jin Xing commented on CALCITE-3935: --- Seems the check in [1] is too strict, we should allow

[jira] [Updated] (CALCITE-3928) Canonicalization doesn't do field trimming before materialized view matching

2020-04-15 Thread Jin Xing (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3928?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jin Xing updated CALCITE-3928: -- Summary: Canonicalization doesn't do field trimming before materialized view matching (was:

[jira] [Updated] (CALCITE-3928) Canonicalization doesn't do field trimming before materialized matching

2020-04-15 Thread Jin Xing (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3928?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jin Xing updated CALCITE-3928: -- Description: If we have query and materialized view as below: {code:java} query:

[jira] [Created] (CALCITE-3928) Canonicalization doesn't do field trimming before materialized matching

2020-04-15 Thread Jin Xing (Jira)
Jin Xing created CALCITE-3928: - Summary: Canonicalization doesn't do field trimming before materialized matching Key: CALCITE-3928 URL: https://issues.apache.org/jira/browse/CALCITE-3928 Project: Calcite

[jira] [Commented] (CALCITE-3925) Support materialized view matching for LogicalCorrelate in SubsitutionVisitor

2020-04-15 Thread Jin Xing (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17084064#comment-17084064 ] Jin Xing commented on CALCITE-3925: --- Sure ~ You can refer to matching implementation for Join when

[jira] [Updated] (CALCITE-3758) FilterTableScanRule generate wrong mapping for filter condition when underlying is BindableTableScan

2020-04-15 Thread Jin Xing (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jin Xing updated CALCITE-3758: -- Description: When FilterTableScanRule push filter condition into ProjectableFilterableTable, the

[jira] [Updated] (CALCITE-3925) Support materialized view matching for LogicalCorrelate in SubsitutionVisitor

2020-04-15 Thread Jin Xing (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jin Xing updated CALCITE-3925: -- Description: LogicalCorrelate is widely used in user SQLs to performs nested-loop join.  We need to

[jira] [Updated] (CALCITE-3925) Support materialized view matching for LogicalCorrelate in SubsitutionVisitor

2020-04-15 Thread Jin Xing (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jin Xing updated CALCITE-3925: -- Description: LogicalCorrelate is widely used in user SQLs to performs nested-loop join.  We need to

[jira] [Created] (CALCITE-3925) Support materialized view matching for LogicalCorrelate in SubsitutionVisitor

2020-04-15 Thread Jin Xing (Jira)
Jin Xing created CALCITE-3925: - Summary: Support materialized view matching for LogicalCorrelate in SubsitutionVisitor Key: CALCITE-3925 URL: https://issues.apache.org/jira/browse/CALCITE-3925 Project:

[jira] [Comment Edited] (CALCITE-3716) ResultSetMetaData.getTableName should return empty string, not null, when column does not map to a table

2020-02-05 Thread Jin Xing (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17030352#comment-17030352 ] Jin Xing edited comment on CALCITE-3716 at 2/6/20 1:49 AM: --- Thanks a lot

[jira] [Comment Edited] (CALCITE-3716) ResultSetMetaData.getTableName should return empty string, not null, when column does not map to a table

2020-02-04 Thread Jin Xing (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17030352#comment-17030352 ] Jin Xing edited comment on CALCITE-3716 at 2/5/20 4:37 AM: --- Thanks a lot

[jira] [Commented] (CALCITE-3716) ResultSetMetaData.getTableName should return empty string, not null, when column does not map to a table

2020-02-04 Thread Jin Xing (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17030352#comment-17030352 ] Jin Xing commented on CALCITE-3716: --- Thanks a lot Julian ~ I also want mention that the behavior of

[jira] [Commented] (CALCITE-3729) Filters failed to be pushed down when it's identical to join condition.

2020-02-01 Thread Jin Xing (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17028284#comment-17028284 ] Jin Xing commented on CALCITE-3729: --- Thanks a lot for merging [~vladimirsitnikov] ! > Filters failed

[jira] [Assigned] (CALCITE-3763) RelBuilder.aggregate should prune unused fields from the input, if the input is a Project

2020-01-31 Thread Jin Xing (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jin Xing reassigned CALCITE-3763: - Assignee: Jin Xing > RelBuilder.aggregate should prune unused fields from the input, if the

[jira] [Commented] (CALCITE-3760) Rewriting non-deterministic function can break query semantics

2020-01-31 Thread Jin Xing (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17027518#comment-17027518 ] Jin Xing commented on CALCITE-3760: --- {quote}As we discussed recently, it would be illegal to merge

[jira] [Comment Edited] (CALCITE-3760) Rewriting non-deterministic function can break query semantics

2020-01-31 Thread Jin Xing (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17027507#comment-17027507 ] Jin Xing edited comment on CALCITE-3760 at 1/31/20 1:50 PM: Thanks a lot

[jira] [Commented] (CALCITE-3760) Rewriting non-deterministic function can break query semantics

2020-01-31 Thread Jin Xing (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17027507#comment-17027507 ] Jin Xing commented on CALCITE-3760: --- Thanks a lot for your kind help [~julianhyde] ~ Actually in my

[jira] [Comment Edited] (CALCITE-3716) ResultSetMetaData.getTableName should return empty string, not null, when column does not map to a table

2020-01-31 Thread Jin Xing (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17027285#comment-17027285 ] Jin Xing edited comment on CALCITE-3716 at 1/31/20 8:45 AM:

[jira] [Comment Edited] (CALCITE-3716) ResultSetMetaData.getTableName should return empty string, not null, when column does not map to a table

2020-01-31 Thread Jin Xing (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17027285#comment-17027285 ] Jin Xing edited comment on CALCITE-3716 at 1/31/20 8:39 AM:

[jira] [Comment Edited] (CALCITE-3716) ResultSetMetaData.getTableName should return empty string, not null, when column does not map to a table

2020-01-31 Thread Jin Xing (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17027285#comment-17027285 ] Jin Xing edited comment on CALCITE-3716 at 1/31/20 8:39 AM:

[jira] [Commented] (CALCITE-3716) ResultSetMetaData.getTableName should return empty string, not null, when column does not map to a table

2020-01-31 Thread Jin Xing (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17027285#comment-17027285 ] Jin Xing commented on CALCITE-3716: --- {color:#172b4d}Thanks a lot [~julianhyde] for review ~{color} *

[jira] [Comment Edited] (CALCITE-3760) Rewriting non-deterministic function can break query semantics

2020-01-30 Thread Jin Xing (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17027196#comment-17027196 ] Jin Xing edited comment on CALCITE-3760 at 1/31/20 5:06 AM: Hi,

[jira] [Commented] (CALCITE-3760) Rewriting non-deterministic function can break query semantics

2020-01-30 Thread Jin Xing (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17027196#comment-17027196 ] Jin Xing commented on CALCITE-3760: --- Hi, [~julianhyde] [~amaliujia] Thanks a lot for feedback ~ Yes,

[jira] [Updated] (CALCITE-3760) Rewriting non-deterministic function can break query semantics

2020-01-30 Thread Jin Xing (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jin Xing updated CALCITE-3760: -- Summary: Rewriting non-deterministic function can break query semantics (was: Rewriting function

[jira] [Created] (CALCITE-3760) Rewriting function without considering determinism can break query semantics

2020-01-30 Thread Jin Xing (Jira)
Jin Xing created CALCITE-3760: - Summary: Rewriting function without considering determinism can break query semantics Key: CALCITE-3760 URL: https://issues.apache.org/jira/browse/CALCITE-3760 Project:

[jira] [Commented] (CALCITE-3716) ResultSetMetaData.getTableName should return empty string, not null, when column does not map to a table

2020-01-28 Thread Jin Xing (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17025103#comment-17025103 ] Jin Xing commented on CALCITE-3716: --- Hi, Julian ~ I made a PR and try to fix this issue. Please take

[jira] [Created] (CALCITE-3758) FilterTableScanRule generate wrong mapping for filter condition when underlying is BindableTableScan

2020-01-28 Thread Jin Xing (Jira)
Jin Xing created CALCITE-3758: - Summary: FilterTableScanRule generate wrong mapping for filter condition when underlying is BindableTableScan Key: CALCITE-3758 URL: https://issues.apache.org/jira/browse/CALCITE-3758

[jira] [Updated] (CALCITE-2010) Cannot plan query that is UNION ALL applied to VALUES

2020-01-27 Thread Jin Xing (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-2010?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jin Xing updated CALCITE-2010: -- Attachment: graphviz (1).svg > Cannot plan query that is UNION ALL applied to VALUES >

[jira] [Comment Edited] (CALCITE-2885) SqlValidatorImpl fails when processing an InferTypes.FIRST_KNOWN function containing a function with a dynamic parameter as first operand

2020-01-26 Thread Jin Xing (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-2885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17023793#comment-17023793 ] Jin Xing edited comment on CALCITE-2885 at 1/26/20 12:58 PM: - Hi, Ruben ~

[jira] [Commented] (CALCITE-2885) SqlValidatorImpl fails when processing an InferTypes.FIRST_KNOWN function containing a function with a dynamic parameter as first operand

2020-01-26 Thread Jin Xing (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-2885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17023793#comment-17023793 ] Jin Xing commented on CALCITE-2885: --- Hi, Ruben ~ I also came across this issue. *FIRST_KNOWN* infers

[jira] [Commented] (CALCITE-3731) Add IF function for BigQuery, Hive and Spark Dialects

2020-01-16 Thread Jin Xing (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17016823#comment-17016823 ] Jin Xing commented on CALCITE-3731: --- [~vaibhavjain-dm] You can refer to 

[jira] [Commented] (CALCITE-3593) RelToSqlConverter changes target of ambiguous HAVING clause with a Project on Filter on Aggregate

2020-01-13 Thread Jin Xing (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17014815#comment-17014815 ] Jin Xing commented on CALCITE-3593: --- Thanks a lot, [~julianhyde] ~ > RelToSqlConverter changes

[jira] [Assigned] (CALCITE-3716) ResultSetMetaData.getTableName should return empty string, not null, when column does not map to a table

2020-01-13 Thread Jin Xing (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3716?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jin Xing reassigned CALCITE-3716: - Assignee: Jin Xing > ResultSetMetaData.getTableName should return empty string, not null,

[jira] [Created] (CALCITE-3729) Filters failed to be pushed down when it's identical to join condition.

2020-01-13 Thread Jin Xing (Jira)
Jin Xing created CALCITE-3729: - Summary: Filters failed to be pushed down when it's identical to join condition. Key: CALCITE-3729 URL: https://issues.apache.org/jira/browse/CALCITE-3729 Project: Calcite

[jira] [Commented] (CALCITE-3725) RelMetadataTest fails with NPE due to unsafe RelMetadataQuery.instance call

2020-01-12 Thread Jin Xing (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17014034#comment-17014034 ] Jin Xing commented on CALCITE-3725: --- Hi, [~vladimirsitnikov] I proposed a fix for this issue, please

[jira] [Comment Edited] (CALCITE-3505) Infinite matching of FilterProjectTransposeRule causes stackoverflow

2020-01-12 Thread Jin Xing (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16979910#comment-16979910 ] Jin Xing edited comment on CALCITE-3505 at 1/13/20 5:08 AM: [~hyuan] I

[jira] [Created] (CALCITE-3727) Deduce nullability of RelDataTypeField for Join

2020-01-12 Thread Jin Xing (Jira)
Jin Xing created CALCITE-3727: - Summary: Deduce nullability of RelDataTypeField for Join Key: CALCITE-3727 URL: https://issues.apache.org/jira/browse/CALCITE-3727 Project: Calcite Issue Type:

[jira] [Commented] (CALCITE-3667) EnumerableMergeJoin should not use take-while enumerator

2020-01-07 Thread Jin Xing (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17010288#comment-17010288 ] Jin Xing commented on CALCITE-3667: --- Hi, Julian ~ I think I didn't make myself clear ~ What I want

[jira] [Commented] (CALCITE-3667) EnumerableMergeJoin should not use take-while enumerator

2020-01-06 Thread Jin Xing (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17009310#comment-17009310 ] Jin Xing commented on CALCITE-3667: --- Hi, [~julianhyde] ~ Thanks again looking into this, and I

[jira] [Commented] (CALCITE-3155) AssertionError in RelToSqlConverter when visiting empty Values node

2020-01-06 Thread Jin Xing (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17008857#comment-17008857 ] Jin Xing commented on CALCITE-3155: --- Hi [~danny0405] and [~MusbahELFIL] PR-1286 add a test cases like

[jira] [Commented] (CALCITE-3710) MaterializationService#defineMaterialization should inherit connection properties

2020-01-05 Thread Jin Xing (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17008600#comment-17008600 ] Jin Xing commented on CALCITE-3710: --- Hi [~vladimirsitnikov] I think this duplicates to CALCITE-3549.

[jira] [Comment Edited] (CALCITE-3667) EnumerableMergeJoin should not use take-while enumerator

2020-01-03 Thread Jin Xing (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17007901#comment-17007901 ] Jin Xing edited comment on CALCITE-3667 at 1/4/20 3:37 AM: --- Hi Julian ~

[jira] [Commented] (CALCITE-3667) EnumerableMergeJoin should not use take-while enumerator

2020-01-03 Thread Jin Xing (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17007901#comment-17007901 ] Jin Xing commented on CALCITE-3667: --- Hi Julian ~ Thanks for look into this ~ I think PR-1717 doesn't

[jira] [Commented] (CALCITE-3285) EnumerableMergeJoin should support non-equi join conditions

2020-01-03 Thread Jin Xing (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17007899#comment-17007899 ] Jin Xing commented on CALCITE-3285: --- Hi, [~vladimirsitnikov] ~ Thanks a lot for the fix PR-1702 ~ Now

[jira] [Commented] (CALCITE-3285) EnumerableMergeJoin should support non-equi join conditions

2020-01-02 Thread Jin Xing (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17006842#comment-17006842 ] Jin Xing commented on CALCITE-3285: --- Hi [~vladimirsitnikov] Yes, you are right, it's a bug. I filed a

[jira] [Updated] (CALCITE-3667) EnumerableMergeJoin should not use take-while enumerator

2020-01-02 Thread Jin Xing (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3667?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jin Xing updated CALCITE-3667: -- Description: Currently EnumerableMergeJoin use take-while enumerator [1] to emit values satisfy

[jira] [Created] (CALCITE-3667) EnumerableMergeJoin should not use take-while enumerator

2020-01-02 Thread Jin Xing (Jira)
Jin Xing created CALCITE-3667: - Summary: EnumerableMergeJoin should not use take-while enumerator Key: CALCITE-3667 URL: https://issues.apache.org/jira/browse/CALCITE-3667 Project: Calcite

[jira] [Commented] (CALCITE-3285) EnumerableMergeJoin should support non-equi join conditions

2020-01-02 Thread Jin Xing (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17006820#comment-17006820 ] Jin Xing commented on CALCITE-3285: --- Thanks for ping me [~vladimirsitnikov] I will verify soon ~ >

[jira] [Commented] (CALCITE-3664) Sort in subquery is lost when converting SqlNode to Relnode

2020-01-02 Thread Jin Xing (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17006813#comment-17006813 ] Jin Xing commented on CALCITE-3664: --- Is it because collation of emp already satisfied the *order by

[jira] [Assigned] (CALCITE-3593) RelToSqlConverter changes target of ambiguous HAVING clause with a Project on Filter on Aggregate

2020-01-01 Thread Jin Xing (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3593?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jin Xing reassigned CALCITE-3593: - Assignee: Jin Xing > RelToSqlConverter changes target of ambiguous HAVING clause with a

[jira] [Updated] (CALCITE-3658) TableModify of Update contains correlated variable by mistake.

2020-01-01 Thread Jin Xing (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jin Xing updated CALCITE-3658: -- Description: UPDATE clause like below {code:java} update emp set empno = empno + 1 {code} will be

[jira] [Updated] (CALCITE-3658) TableModify of Update contains correlated variable by mistake.

2020-01-01 Thread Jin Xing (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jin Xing updated CALCITE-3658: -- Description: UPDATE clause like below {code:java} update emp set empno = empno + 1 {code} will be

[jira] [Created] (CALCITE-3658) TableModify of Update contains correlated variable by mistake.

2020-01-01 Thread Jin Xing (Jira)
Jin Xing created CALCITE-3658: - Summary: TableModify of Update contains correlated variable by mistake. Key: CALCITE-3658 URL: https://issues.apache.org/jira/browse/CALCITE-3658 Project: Calcite

[jira] [Comment Edited] (CALCITE-3644) Calc on the Intersect in target is not being matched

2019-12-30 Thread Jin Xing (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17005949#comment-17005949 ] Jin Xing edited comment on CALCITE-3644 at 12/31/19 6:31 AM: - Could you

[jira] [Commented] (CALCITE-3606) batch insert failed

2019-12-26 Thread Jin Xing (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17003595#comment-17003595 ] Jin Xing commented on CALCITE-3606: --- Hi Ran ~ I proposed a PR to fix the case you provided ~ Please

[jira] [Commented] (CALCITE-3624) Getting java.lang.NullPointerException at org.apache.calcite.schema.Schemas.queryable(Schemas.java:211)

2019-12-23 Thread Jin Xing (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17002316#comment-17002316 ] Jin Xing commented on CALCITE-3624: --- Could you please format your code by annotation like below ?

[jira] [Commented] (CALCITE-3621) JDBC adapter can't push down sort to DB

2019-12-22 Thread Jin Xing (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17001957#comment-17001957 ] Jin Xing commented on CALCITE-3621: --- # Why the change in 

[jira] [Commented] (CALCITE-3387) Query with GROUP BY and JOIN ... USING wrongly fails with "Column 'DEPTNO' is ambiguous" error

2019-12-19 Thread Jin Xing (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17000630#comment-17000630 ] Jin Xing commented on CALCITE-3387: --- Thanks for ping me, Chunwei ~ I just added minor comments. >

[jira] [Commented] (CALCITE-3609) calite for hive struct Ineffective optimization

2019-12-18 Thread Jin Xing (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16999168#comment-16999168 ] Jin Xing commented on CALCITE-3609: --- Seems the patch is not against latest code base. This issue is

[jira] [Commented] (CALCITE-3495) RelDecorrelator generate plan with different semantics when handle Aggregate

2019-12-17 Thread Jin Xing (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16998820#comment-16998820 ] Jin Xing commented on CALCITE-3495: --- Rather than failing the decorrelation when COUNT, do we consider

[jira] [Commented] (CALCITE-3606) batch insert failed

2019-12-17 Thread Jin Xing (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16998815#comment-16998815 ] Jin Xing commented on CALCITE-3606: --- Hi, Ran Cao ~ Yes, seems current RelBuilder#projectNamed failed

[jira] [Comment Edited] (CALCITE-3387) Query with GROUP BY and JOIN ... USING wrongly fails with "Column 'DEPTNO' is ambiguous" error

2019-12-17 Thread Jin Xing (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16997997#comment-16997997 ] Jin Xing edited comment on CALCITE-3387 at 12/17/19 10:37 AM: -- Given

[jira] [Comment Edited] (CALCITE-3387) Query with GROUP BY and JOIN ... USING wrongly fails with "Column 'DEPTNO' is ambiguous" error

2019-12-17 Thread Jin Xing (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16997997#comment-16997997 ] Jin Xing edited comment on CALCITE-3387 at 12/17/19 10:34 AM: -- Given

  1   2   3   4   >