[jira] [Commented] (CALCITE-1258) JDK9 support
[ https://issues.apache.org/jira/browse/CALCITE-1258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15771445#comment-15771445 ] Julian Hyde commented on CALCITE-1258: -- The Java dev team just fixed https://bugs.openjdk.java.net/browse/JDK-8075793 in http://hg.openjdk.java.net/jdk9/dev/langtools/rev/49170d831308. It isn't yet in the latest build (149): see http://download.java.net/java/jdk9/changes/jdk-9+149.html. > JDK9 support > > > Key: CALCITE-1258 > URL: https://issues.apache.org/jira/browse/CALCITE-1258 > Project: Calcite > Issue Type: Bug >Reporter: Julian Hyde >Assignee: Julian Hyde > > I notice that Travis now offers JDK9. Let's get Calcite building & running on > JDK9. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CALCITE-1258) JDK9 support
[ https://issues.apache.org/jira/browse/CALCITE-1258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15336722#comment-15336722 ] Julian Hyde commented on CALCITE-1258: -- That worked, thanks. > JDK9 support > > > Key: CALCITE-1258 > URL: https://issues.apache.org/jira/browse/CALCITE-1258 > Project: Calcite > Issue Type: Bug >Reporter: Julian Hyde >Assignee: Julian Hyde > > I notice that Travis now offers JDK9. Let's get Calcite building & running on > JDK9. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CALCITE-1258) JDK9 support
[
https://issues.apache.org/jira/browse/CALCITE-1258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15336711#comment-15336711
]
Julian Hyde commented on CALCITE-1258:
--
I've now pushed a version that builds on 1.9 (provided you specify
{{-Djavac.source=1.9 -Djavac.target=1.9}}) and continues to build on 1.7 and
1.8.
It looks as if there are janino problems when I run the tests.
> JDK9 support
>
>
> Key: CALCITE-1258
> URL: https://issues.apache.org/jira/browse/CALCITE-1258
> Project: Calcite
> Issue Type: Bug
>Reporter: Julian Hyde
>Assignee: Julian Hyde
>
> I notice that Travis now offers JDK9. Let's get Calcite building & running on
> JDK9.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CALCITE-1258) JDK9 support
[ https://issues.apache.org/jira/browse/CALCITE-1258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15336707#comment-15336707 ] Vladimir Sitnikov commented on CALCITE-1258: For jmh, just upgrade to new version was sufficient: https://github.com/pgjdbc/pgjdbc/commit/bbb0d3521378d8c4515c844cd9bb3d656f95a739#diff-69610471700c4c1525608a7262215ab8R70 > JDK9 support > > > Key: CALCITE-1258 > URL: https://issues.apache.org/jira/browse/CALCITE-1258 > Project: Calcite > Issue Type: Bug >Reporter: Julian Hyde >Assignee: Julian Hyde > > I notice that Travis now offers JDK9. Let's get Calcite building & running on > JDK9. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CALCITE-1258) JDK9 support
[
https://issues.apache.org/jira/browse/CALCITE-1258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15336664#comment-15336664
]
Julian Hyde commented on CALCITE-1258:
--
Wow, there are a lot of these.
I don't see how the OpenJDK folks can justify making {{source=1.7}} stricter
than JDK 1.7's javac, even if javac had a bug and didn't comply with the 1.7
language specification. Who cares about compatibility with the 1.7 JLS? I care
about compatibility with the 1.7 JDK.
As a workaround, I'm setting {{souce=1.9 target=1.9}}. Obviously we can't
commit this to master, because we will support 1.7 for a while.
> JDK9 support
>
>
> Key: CALCITE-1258
> URL: https://issues.apache.org/jira/browse/CALCITE-1258
> Project: Calcite
> Issue Type: Bug
>Reporter: Julian Hyde
>Assignee: Julian Hyde
>
> I notice that Travis now offers JDK9. Let's get Calcite building & running on
> JDK9.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CALCITE-1258) JDK9 support
[ https://issues.apache.org/jira/browse/CALCITE-1258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15336648#comment-15336648 ] Julian Hyde commented on CALCITE-1258: -- I had to disable the ubenchmark module due to https://bugs.openjdk.java.net/browse/JDK-8152842. > JDK9 support > > > Key: CALCITE-1258 > URL: https://issues.apache.org/jira/browse/CALCITE-1258 > Project: Calcite > Issue Type: Bug >Reporter: Julian Hyde >Assignee: Julian Hyde > > I notice that Travis now offers JDK9. Let's get Calcite building & running on > JDK9. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CALCITE-1258) JDK9 support
[
https://issues.apache.org/jira/browse/CALCITE-1258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15336513#comment-15336513
]
Julian Hyde commented on CALCITE-1258:
--
Thanks [~vlsi], that helped. I've committed and pushed to my dev branch.
Now I'm bumping into "incompatible types" compilation errors, apparently
https://bugs.openjdk.java.net/browse/JDK-8075793. Per that issue, we need to
fix the code:
{noformat}
$ mvn -Pjdk9-workarounds clean package
...
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-compiler-plugin:3.2:compile (default-compile) on
project calcite-linq4j: Compilation failure: Compilation failure:
[ERROR]
/home/jhyde/open1/calcite.2/linq4j/src/main/java/org/apache/calcite/linq4j/Linq4j.java:[116,12]
incompatible types:
org.apache.calcite.linq4j.Linq4j.IterableEnumerator
cannot be converted to org.apache.calcite.linq4j.Enumerator
[ERROR]
/home/jhyde/open1/calcite.2/linq4j/src/main/java/org/apache/calcite/linq4j/Linq4j.java:[194,30]
incompatible types: org.apache.calcite.linq4j.Enumerator cannot be converted to org.apache.calcite.linq4j.Enumerator
...
{noformat}
> JDK9 support
>
>
> Key: CALCITE-1258
> URL: https://issues.apache.org/jira/browse/CALCITE-1258
> Project: Calcite
> Issue Type: Bug
>Reporter: Julian Hyde
>Assignee: Julian Hyde
>
> I notice that Travis now offers JDK9. Let's get Calcite building & running on
> JDK9.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CALCITE-1258) JDK9 support
[
https://issues.apache.org/jira/browse/CALCITE-1258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15335998#comment-15335998
]
Vladimir Sitnikov commented on CALCITE-1258:
{noformat}Caused by: java.lang.ArrayIndexOutOfBoundsException: 1
at
org.codehaus.plexus.archiver.zip.AbstractZipArchiver.(AbstractZipArchiver.java:113){noformat}
This one can be worked around by downgrading plexus-archiver like in
https://github.com/pgjdbc/pgjdbc/commit/bbb0d3521378d8c4515c844cd9bb3d656f95a739#diff-a5f7928a522b31a6cf69b1366423b9adR201
> JDK9 support
>
>
> Key: CALCITE-1258
> URL: https://issues.apache.org/jira/browse/CALCITE-1258
> Project: Calcite
> Issue Type: Bug
>Reporter: Julian Hyde
>Assignee: Julian Hyde
>
> I notice that Travis now offers JDK9. Let's get Calcite building & running on
> JDK9.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CALCITE-1258) JDK9 support
[ https://issues.apache.org/jira/browse/CALCITE-1258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15332630#comment-15332630 ] Julian Hyde commented on CALCITE-1258: -- No, but feel free to rebase. > JDK9 support > > > Key: CALCITE-1258 > URL: https://issues.apache.org/jira/browse/CALCITE-1258 > Project: Calcite > Issue Type: Bug >Reporter: Julian Hyde >Assignee: Julian Hyde > > I notice that Travis now offers JDK9. Let's get Calcite building & running on > JDK9. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CALCITE-1258) JDK9 support
[ https://issues.apache.org/jira/browse/CALCITE-1258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15332624#comment-15332624 ] Josh Elser commented on CALCITE-1258: - bq. I couldn't figure out what maven plugins to use. I can try to help out with this. Your branch up to date with your latest? > JDK9 support > > > Key: CALCITE-1258 > URL: https://issues.apache.org/jira/browse/CALCITE-1258 > Project: Calcite > Issue Type: Bug >Reporter: Julian Hyde >Assignee: Julian Hyde > > I notice that Travis now offers JDK9. Let's get Calcite building & running on > JDK9. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CALCITE-1258) JDK9 support
[ https://issues.apache.org/jira/browse/CALCITE-1258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15332541#comment-15332541 ] Julian Hyde commented on CALCITE-1258: -- I like the matrix approach. We've been getting a lot of spurious errors from Travis recently and I think it's just that the build takes too long and uses too much memory. Separating javadoc from tests would help. That said, I'm nowhere near getting Calcite working on JDK9, even on my local Linux box. I couldn't figure out what maven plugins to use. > JDK9 support > > > Key: CALCITE-1258 > URL: https://issues.apache.org/jira/browse/CALCITE-1258 > Project: Calcite > Issue Type: Bug >Reporter: Julian Hyde >Assignee: Julian Hyde > > I notice that Travis now offers JDK9. Let's get Calcite building & running on > JDK9. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CALCITE-1258) JDK9 support
[
https://issues.apache.org/jira/browse/CALCITE-1258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15331310#comment-15331310
]
Vladimir Sitnikov commented on CALCITE-1258:
[~julianhyde], I've succeeded with jdk9-ea at Travis.
This approach works fine (even with {{sudo:false}}):
https://github.com/travis-ci/travis-ci/issues/4178#issuecomment-119321586.
I suggest using `matrix - include` configuration with explicit separation of
checkstyle, javadoc, and test jobs.
Here's what I mean: https://travis-ci.org/pgjdbc/pgjdbc/builds/134757943
Any objections?
> JDK9 support
>
>
> Key: CALCITE-1258
> URL: https://issues.apache.org/jira/browse/CALCITE-1258
> Project: Calcite
> Issue Type: Bug
>Reporter: Julian Hyde
>Assignee: Julian Hyde
>
> I notice that Travis now offers JDK9. Let's get Calcite building & running on
> JDK9.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CALCITE-1258) JDK9 support
[ https://issues.apache.org/jira/browse/CALCITE-1258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15306032#comment-15306032 ] Julian Hyde commented on CALCITE-1258: -- Yeah, I ran into problems with plexus-archiver. I tried setting the version to 3.0.3, but maven couldn't find that version (despite it being in maven central). And based on your experience, it looks as if travis isn't ready just yet. > JDK9 support > > > Key: CALCITE-1258 > URL: https://issues.apache.org/jira/browse/CALCITE-1258 > Project: Calcite > Issue Type: Bug >Reporter: Julian Hyde >Assignee: Julian Hyde > > I notice that Travis now offers JDK9. Let's get Calcite building & running on > JDK9. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
