[jira] [Commented] (CALCITE-1263) Case-insensitive match and null default value for enum properties
[
https://issues.apache.org/jira/browse/CALCITE-1263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15321337#comment-15321337
]
Julian Hyde commented on CALCITE-1263:
--
It's not urgent. No need for a 1.8.1 if 1.9 arrives at the usual release
cadence.
> Case-insensitive match and null default value for enum properties
> -
>
> Key: CALCITE-1263
> URL: https://issues.apache.org/jira/browse/CALCITE-1263
> Project: Calcite
> Issue Type: Bug
> Components: avatica
>Reporter: Julian Hyde
>Assignee: Julian Hyde
> Fix For: next
>
>
> In ConnectionConfigImpl, we allow properties based on enum classes. The
> getEnum method throws "Required property 'name' not specified" if the default
> value is null, but it should not; we should allow enum properties whose
> default value is null.
> Also, when resolving an enum property we should check the exact string first,
> then look for case-insensitive matches. This will help if people write
> 'p=foo' if 'p' is a property of type enum \{ FOO, BAZ \}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CALCITE-1263) Case-insensitive match and null default value for enum properties
[
https://issues.apache.org/jira/browse/CALCITE-1263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15321220#comment-15321220
]
Josh Elser commented on CALCITE-1263:
-
https://github.com/apache/calcite/pull/240 looks good to me. If you'd like it
to go into a 1.8.1, feel free to land it in branch-avatica-1.8 as well as
master; otherwise, it'll hit avatica 1.9.0.
> Case-insensitive match and null default value for enum properties
> -
>
> Key: CALCITE-1263
> URL: https://issues.apache.org/jira/browse/CALCITE-1263
> Project: Calcite
> Issue Type: Bug
> Components: avatica
>Reporter: Julian Hyde
>Assignee: Julian Hyde
> Fix For: next
>
>
> In ConnectionConfigImpl, we allow properties based on enum classes. The
> getEnum method throws "Required property 'name' not specified" if the default
> value is null, but it should not; we should allow enum properties whose
> default value is null.
> Also, when resolving an enum property we should check the exact string first,
> then look for case-insensitive matches. This will help if people write
> 'p=foo' if 'p' is a property of type enum \{ FOO, BAZ \}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CALCITE-1263) Case-insensitive match and null default value for enum properties
[
https://issues.apache.org/jira/browse/CALCITE-1263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15321207#comment-15321207
]
Josh Elser commented on CALCITE-1263:
-
Wow, sorry, I totally missed your ping on this. So sorry. We can look into a
1.8.1 if you'd like with this one.
> Case-insensitive match and null default value for enum properties
> -
>
> Key: CALCITE-1263
> URL: https://issues.apache.org/jira/browse/CALCITE-1263
> Project: Calcite
> Issue Type: Bug
> Components: avatica
>Reporter: Julian Hyde
>Assignee: Julian Hyde
> Fix For: next
>
>
> In ConnectionConfigImpl, we allow properties based on enum classes. The
> getEnum method throws "Required property 'name' not specified" if the default
> value is null, but it should not; we should allow enum properties whose
> default value is null.
> Also, when resolving an enum property we should check the exact string first,
> then look for case-insensitive matches. This will help if people write
> 'p=foo' if 'p' is a property of type enum { FOO, BAZ }.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CALCITE-1263) Case-insensitive match and null default value for enum properties
[
https://issues.apache.org/jira/browse/CALCITE-1263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15321206#comment-15321206
]
Josh Elser commented on CALCITE-1263:
-
Wow, sorry, I totally missed your ping on this. So sorry. We can look into a
1.8.1 if you'd like with this one.
> Case-insensitive match and null default value for enum properties
> -
>
> Key: CALCITE-1263
> URL: https://issues.apache.org/jira/browse/CALCITE-1263
> Project: Calcite
> Issue Type: Bug
> Components: avatica
>Reporter: Julian Hyde
>Assignee: Julian Hyde
> Fix For: next
>
>
> In ConnectionConfigImpl, we allow properties based on enum classes. The
> getEnum method throws "Required property 'name' not specified" if the default
> value is null, but it should not; we should allow enum properties whose
> default value is null.
> Also, when resolving an enum property we should check the exact string first,
> then look for case-insensitive matches. This will help if people write
> 'p=foo' if 'p' is a property of type enum { FOO, BAZ }.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
