[jira] [Commented] (CALCITE-767) Commit functionality not exposed by the RPC server
[ https://issues.apache.org/jira/browse/CALCITE-767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15060514#comment-15060514 ] Josh Elser commented on CALCITE-767: This was fixed in https://git1-us-west.apache.org/repos/asf?p=calcite.git;a=commit;h=322b97300d460cf7c98b6002e4f0d5dab455f188 > Commit functionality not exposed by the RPC server > -- > > Key: CALCITE-767 > URL: https://issues.apache.org/jira/browse/CALCITE-767 > Project: Calcite > Issue Type: Improvement > Components: avatica >Reporter: Lukas Lalinsky >Assignee: Josh Elser > Fix For: 1.6.0 > > > It seems that the commit/rollback functionality is not exposed by the RPC > server, which means that it's only usable in autocommit mode. Avatica itself > doesn't have a concept of commit in the RPC and the remote JDBC connection > raises an exception when calling commit() on it, but Phoenix's native JDBC > connection does implement commit(), so the RPC needs to be extended to allow > calling that remotely. > The easiest way to test this, "!autocommit off" and then "!commit" fails in > "sqline-thin.py", but works in "sqline.py". -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CALCITE-767) Commit functionality not exposed by the RPC server
[ https://issues.apache.org/jira/browse/CALCITE-767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15059491#comment-15059491 ] Josh Elser commented on CALCITE-767: bq. I'd be interested in seeing your Pherf scenario, Josh Elser. 5x is more degradation that I'd have expected, but I'm sure it depends on the workload. The frustrating part at the moment is that I have no good means to understand where time is being spent. I'm still working through some, what I think is, nonsense logging in pherf, but I'll get back to you on that over in Phoenixlandia :) bq. FWIW, I'm about to implement PHOENIX-2411 which would support the "dumb" load balancer scenario you mentioned. Sick! > Commit functionality not exposed by the RPC server > -- > > Key: CALCITE-767 > URL: https://issues.apache.org/jira/browse/CALCITE-767 > Project: Calcite > Issue Type: Improvement > Components: avatica >Reporter: Lukas Lalinsky >Assignee: Josh Elser > Fix For: next > > > It seems that the commit/rollback functionality is not exposed by the RPC > server, which means that it's only usable in autocommit mode. Avatica itself > doesn't have a concept of commit in the RPC and the remote JDBC connection > raises an exception when calling commit() on it, but Phoenix's native JDBC > connection does implement commit(), so the RPC needs to be extended to allow > calling that remotely. > The easiest way to test this, "!autocommit off" and then "!commit" fails in > "sqline-thin.py", but works in "sqline.py". -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (CALCITE-767) Commit functionality not exposed by the RPC server
[ https://issues.apache.org/jira/browse/CALCITE-767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15059451#comment-15059451 ] Josh Elser commented on CALCITE-767: Did some prelim testing of this using Phoenix and protobuf. Using Phoenix's pherf tool, I was able to run the same test against the normal Phoenix driver and the Avatica-based Phoenix thin driver. For those curious, performance degredation without any thought of optimization in Avatica: 5x. Pretty good for a first pass, IMO. I'm going to rebase/merge this in tonight. > Commit functionality not exposed by the RPC server > -- > > Key: CALCITE-767 > URL: https://issues.apache.org/jira/browse/CALCITE-767 > Project: Calcite > Issue Type: Improvement > Components: avatica >Reporter: Lukas Lalinsky >Assignee: Josh Elser > Fix For: next > > > It seems that the commit/rollback functionality is not exposed by the RPC > server, which means that it's only usable in autocommit mode. Avatica itself > doesn't have a concept of commit in the RPC and the remote JDBC connection > raises an exception when calling commit() on it, but Phoenix's native JDBC > connection does implement commit(), so the RPC needs to be extended to allow > calling that remotely. > The easiest way to test this, "!autocommit off" and then "!commit" fails in > "sqline-thin.py", but works in "sqline.py". -- This message was sent by Atlassian JIRA (v6.3.4#6332)
