[ 
https://issues.apache.org/jira/browse/CALCITE-3423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Wang Yanlin reassigned CALCITE-3423:
------------------------------------

    Assignee: Wang Yanlin

> Support using CAST operation and BOOLEAN type value in table macro
> ------------------------------------------------------------------
>
>                 Key: CALCITE-3423
>                 URL: https://issues.apache.org/jira/browse/CALCITE-3423
>             Project: Calcite
>          Issue Type: New Feature
>            Reporter: Wang Yanlin
>            Assignee: Wang Yanlin
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Currently, using bool type or cast operation in table macro, got exception.
> Add the code snippet below in *JdbcTest* to reproduce.
>   
> {code:java}
>   @Test public void testTableMacroWithCastOrBoolean() throws SQLException {
>     Connection connection =
>         DriverManager.getConnection("jdbc:calcite:");
>     addTableMacro(connection, Smalls.STR_METHOD);
>     // check for cast
>     ResultSet resultSet = connection.createStatement().executeQuery(
>         "select * from table(\"s\".\"str\"(MAP['a', 1, 'baz', 2], cast(1 as 
> bigint))) as t(n)");
>     assertThat(CalciteAssert.toString(resultSet),
>         equalTo("N={'a'=1, 'baz'=2}\n"
>             + "N=1               \n"));
>     // check for Boolean type
>     resultSet = connection.createStatement().executeQuery(
>         "select * from table(\"s\".\"str\"(MAP['a', 1, 'baz', 2], true)) as 
> t(n)");
>     assertThat(CalciteAssert.toString(resultSet),
>         equalTo("N={'a'=1, 'baz'=2}\n"
>             + "N=true            \n"));
>     // check for nested cast
>     resultSet = connection.createStatement().executeQuery(
>         "select * from table(\"s\".\"str\"(MAP['a', 1, 'baz', 2],"
>             + "cast(cast(1 as int) as varchar(1)))) as t(n)");
>     assertThat(CalciteAssert.toString(resultSet),
>         equalTo("N={'a'=1, 'baz'=2}\n"
>             + "N=1               \n"));
>     resultSet = connection.createStatement().executeQuery(
>         "select * from table(\"s\".\"str\"(MAP['a', 1, 'baz', 2],"
>             + "cast(cast(cast('2019-10-18 10:35:23' as TIMESTAMP) as BIGINT) 
> as VARCHAR))) as t(n)");
>     assertThat(CalciteAssert.toString(resultSet),
>         equalTo("N={'a'=1, 'baz'=2}     \n"
>             + "N='2019-10-18 10:35:23'\n"));
>     connection.close();
>   }
> {code}
> for using CAST, the stack trace is
> {code:java}
> java.sql.SQLException: Error while executing SQL "select * from 
> table("s"."str"(MAP['a', 1, 'baz', 2], cast(1 as bigint))) as t(n)": All 
> arguments of call to macro s.str should be literal. Actual argument #1 (arg1) 
> is not literal: CAST(1 AS BIGINT)
>       at org.apache.calcite.avatica.Helper.createException(Helper.java:56)
>       at org.apache.calcite.avatica.Helper.createException(Helper.java:41)
>       at 
> org.apache.calcite.avatica.AvaticaStatement.executeInternal(AvaticaStatement.java:163)
>       at 
> org.apache.calcite.avatica.AvaticaStatement.executeQuery(AvaticaStatement.java:227)
>       at 
> org.apache.calcite.test.JdbcTest.testTableMacroWithCastOrBoolean(JdbcTest.java:476)
>       at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>       at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>       at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>       at java.lang.reflect.Method.invoke(Method.java:498)
>       at 
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
>       at 
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
>       at 
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
>       at 
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
>       at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
>       at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
>       at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
>       at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
>       at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
>       at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
>       at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
> {code}
>  
> for using BOOLEAN type value, the stack trace is
> {code:java}
> java.sql.SQLException: Error while executing SQL "select * from 
> table("s"."str"(MAP['a', 1, 'baz', 2], true)) as t(n)": 
> java.lang.reflect.InvocationTargetException
>       at org.apache.calcite.avatica.Helper.createException(Helper.java:56)
>       at org.apache.calcite.avatica.Helper.createException(Helper.java:41)
>       at 
> org.apache.calcite.avatica.AvaticaStatement.executeInternal(AvaticaStatement.java:163)
>       at 
> org.apache.calcite.avatica.AvaticaStatement.executeQuery(AvaticaStatement.java:227)
>       at 
> org.apache.calcite.test.JdbcTest.testTableMacroWithCastOrBoolean(JdbcTest.java:484)
>       at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>       at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>       at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>       at java.lang.reflect.Method.invoke(Method.java:498)
>       at 
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
>       at 
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
>       at 
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
>       at 
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
>       at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
>       at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
>       at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
>       at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
>       at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
>       at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
>       at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
>       at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
>       at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
>       at org.junit.runner.JUnitCore.run(JUnitCore.java:137)
>       at 
> com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:68)
>       at 
> com.intellij.rt.execution.junit.IdeaTestRunner$Repeater.startRunnerWithArgs(IdeaTestRunner.java:47)
>       at 
> com.intellij.rt.execution.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:242)
>       at 
> com.intellij.rt.execution.junit.JUnitStarter.main(JUnitStarter.java:70)
> Caused by: java.lang.RuntimeException: 
> java.lang.reflect.InvocationTargetException
>       at 
> org.apache.calcite.schema.impl.TableMacroImpl.apply(TableMacroImpl.java:91)
>       at 
> org.apache.calcite.sql.validate.SqlUserDefinedTableMacro.getTable(SqlUserDefinedTableMacro.java:86)
>       at 
> org.apache.calcite.sql.validate.ProcedureNamespace.validateImpl(ProcedureNamespace.java:68)
>       at 
> org.apache.calcite.sql.validate.AbstractNamespace.validate(AbstractNamespace.java:84)
>       at 
> org.apache.calcite.sql.validate.SqlValidatorImpl.validateNamespace(SqlValidatorImpl.java:1009)
>       at 
> org.apache.calcite.sql.validate.SqlValidatorImpl.validateQuery(SqlValidatorImpl.java:969)
>       at 
> org.apache.calcite.sql.validate.SqlValidatorImpl.validateFrom(SqlValidatorImpl.java:3129)
>       at 
> org.apache.calcite.sql.validate.SqlValidatorImpl.validateFrom(SqlValidatorImpl.java:3111)
>       at 
> org.apache.calcite.sql.validate.SqlValidatorImpl.validateSelect(SqlValidatorImpl.java:3383)
>       at 
> org.apache.calcite.sql.validate.SelectNamespace.validateImpl(SelectNamespace.java:60)
>       at 
> org.apache.calcite.sql.validate.AbstractNamespace.validate(AbstractNamespace.java:84)
>       at 
> org.apache.calcite.sql.validate.SqlValidatorImpl.validateNamespace(SqlValidatorImpl.java:1009)
>       at 
> org.apache.calcite.sql.validate.SqlValidatorImpl.validateQuery(SqlValidatorImpl.java:969)
>       at org.apache.calcite.sql.SqlSelect.validate(SqlSelect.java:216)
>       at 
> org.apache.calcite.sql.validate.SqlValidatorImpl.validateScopedExpression(SqlValidatorImpl.java:944)
>       at 
> org.apache.calcite.sql.validate.SqlValidatorImpl.validate(SqlValidatorImpl.java:651)
>       at 
> org.apache.calcite.sql2rel.SqlToRelConverter.convertQuery(SqlToRelConverter.java:558)
>       at org.apache.calcite.prepare.Prepare.prepareSql(Prepare.java:265)
>       at org.apache.calcite.prepare.Prepare.prepareSql(Prepare.java:231)
>       at 
> org.apache.calcite.prepare.CalcitePrepareImpl.prepare2_(CalcitePrepareImpl.java:638)
>       at 
> org.apache.calcite.prepare.CalcitePrepareImpl.prepare_(CalcitePrepareImpl.java:502)
>       at 
> org.apache.calcite.prepare.CalcitePrepareImpl.prepareSql(CalcitePrepareImpl.java:472)
>       at 
> org.apache.calcite.jdbc.CalciteConnectionImpl.parseQuery(CalciteConnectionImpl.java:231)
>       at 
> org.apache.calcite.jdbc.CalciteMetaImpl.prepareAndExecute(CalciteMetaImpl.java:550)
>       at 
> org.apache.calcite.avatica.AvaticaConnection.prepareAndExecuteInternal(AvaticaConnection.java:675)
>       at 
> org.apache.calcite.avatica.AvaticaStatement.executeInternal(AvaticaStatement.java:156)
>       ... 24 more
> Caused by: java.lang.reflect.InvocationTargetException
>       at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>       at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>       at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>       at java.lang.reflect.Method.invoke(Method.java:498)
>       at 
> org.apache.calcite.schema.impl.TableMacroImpl.apply(TableMacroImpl.java:83)
>       ... 49 more
> Caused by: java.lang.AssertionError: not a constant: true
>       at org.apache.calcite.util.Litmus$1.fail(Litmus.java:31)
>       at org.apache.calcite.rex.RexLiteral.validConstant(RexLiteral.java:483)
>       at org.apache.calcite.util.Smalls.str(Smalls.java:348)
>       ... 54 more
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to