[ https://issues.apache.org/jira/browse/CALCITE-3433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16960957#comment-16960957 ]
Danny Chen edited comment on CALCITE-3433 at 10/28/19 11:46 AM: ---------------------------------------------------------------- Thanks [~donnyzone], can we gen code without {code:java} inp0_ == null || inp1_ == null ? (Boolean) null {code} It seems that for EQUALS and NOT EQUALS, this "null check" is redundant and unnecessary. was (Author: danny0405): Thanks [~donnyzone], can we gen code with out {code:java} inp0_ == null || inp1_ == null ? (Boolean) null {code} It seems that for EQUALS and NOT EQUALS, this "null check" is redundant and unnecessary. > EQUALS operator between date/timestamp types returns false if the type is > nullable > ---------------------------------------------------------------------------------- > > Key: CALCITE-3433 > URL: https://issues.apache.org/jira/browse/CALCITE-3433 > Project: Calcite > Issue Type: Bug > Components: core > Affects Versions: 1.17.0, 1.18.0, 1.19.0, 1.20.0, 1.21.0 > Reporter: jiezouSH > Assignee: Feng Zhu > Priority: Major > Labels: pull-request-available > Time Spent: 0.5h > Remaining Estimate: 0h > > sql > select time0=time1 from (select timestamp'2000-12-30 21:07:32'as > time0,timestamp'2000-12-30 21:07:32'as time1 union all select cast(null as > timestamp) as time0,cast(null as timestamp) as time1) calcs > answer is false > but > sql > select time0=time1 from (select timestamp'2000-12-30 21:07:32'as > time0,timestamp'2000-12-30 21:07:32'as time1) calcs > answer is true > -- This message was sent by Atlassian Jira (v8.3.4#803005)