[jira] [Commented] (CALCITE-1040) ColumnValue and TypedValue are unnecessarily both repeated
[
https://issues.apache.org/jira/browse/CALCITE-1040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15095063#comment-15095063
]
Julian Hyde commented on CALCITE-1040:
--
Revised fix http://git-wip-us.apache.org/repos/asf/calcite/commit/361096ba.
> ColumnValue and TypedValue are unnecessarily both repeated
> --
>
> Key: CALCITE-1040
> URL: https://issues.apache.org/jira/browse/CALCITE-1040
> Project: Calcite
> Issue Type: Bug
> Components: avatica
>Affects Versions: 1.5.0
>Reporter: Carter Shanklin
>Assignee: Josh Elser
> Fix For: 1.6.0
>
>
> [~cartershanklin] sent me some nice notes from working on a Python interface
> to the Phoenix QueryServer. He saw this strange thing in the code he had to
> write:
> {code}
> count = response.results[0].first_frame.rows[0].value[0].value[0].number_value
> {code}
> The {{value\[0\].value\[0\]}} is strange. Looking at the protobuf definition,
> it seems like both {{ColumnValue}} and {{TypedValue}} are repeated which is
> causing this. Only one of them should be repeated, not both. This creates the
> equivalent of a 2dim array inside each row instead of just a 1dim array.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CALCITE-1040) ColumnValue and TypedValue are unnecessarily both repeated
[
https://issues.apache.org/jira/browse/CALCITE-1040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15095068#comment-15095068
]
Josh Elser commented on CALCITE-1040:
-
Thanks, Julian.
> ColumnValue and TypedValue are unnecessarily both repeated
> --
>
> Key: CALCITE-1040
> URL: https://issues.apache.org/jira/browse/CALCITE-1040
> Project: Calcite
> Issue Type: Bug
> Components: avatica
>Affects Versions: 1.5.0
>Reporter: Carter Shanklin
>Assignee: Josh Elser
> Fix For: 1.6.0
>
>
> [~cartershanklin] sent me some nice notes from working on a Python interface
> to the Phoenix QueryServer. He saw this strange thing in the code he had to
> write:
> {code}
> count = response.results[0].first_frame.rows[0].value[0].value[0].number_value
> {code}
> The {{value\[0\].value\[0\]}} is strange. Looking at the protobuf definition,
> it seems like both {{ColumnValue}} and {{TypedValue}} are repeated which is
> causing this. Only one of them should be repeated, not both. This creates the
> equivalent of a 2dim array inside each row instead of just a 1dim array.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CALCITE-1040) ColumnValue and TypedValue are unnecessarily both repeated
[
https://issues.apache.org/jira/browse/CALCITE-1040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15094896#comment-15094896
]
Julian Hyde commented on CALCITE-1040:
--
Minor nit: Please remember to use descriptive verb phrase for method javadoc:
"Determines if this message ..." not "Determine if this message ...".
> ColumnValue and TypedValue are unnecessarily both repeated
> --
>
> Key: CALCITE-1040
> URL: https://issues.apache.org/jira/browse/CALCITE-1040
> Project: Calcite
> Issue Type: Bug
> Components: avatica
>Affects Versions: 1.5.0
>Reporter: Carter Shanklin
>Assignee: Josh Elser
> Fix For: 1.6.0
>
>
> [~cartershanklin] sent me some nice notes from working on a Python interface
> to the Phoenix QueryServer. He saw this strange thing in the code he had to
> write:
> {code}
> count = response.results[0].first_frame.rows[0].value[0].value[0].number_value
> {code}
> The {{value\[0\].value\[0\]}} is strange. Looking at the protobuf definition,
> it seems like both {{ColumnValue}} and {{TypedValue}} are repeated which is
> causing this. Only one of them should be repeated, not both. This creates the
> equivalent of a 2dim array inside each row instead of just a 1dim array.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (CALCITE-1040) ColumnValue and TypedValue are unnecessarily both repeated
[
https://issues.apache.org/jira/browse/CALCITE-1040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15094899#comment-15094899
]
Josh Elser commented on CALCITE-1040:
-
Ack, thanks for the catch! I can amend if you'd like?
> ColumnValue and TypedValue are unnecessarily both repeated
> --
>
> Key: CALCITE-1040
> URL: https://issues.apache.org/jira/browse/CALCITE-1040
> Project: Calcite
> Issue Type: Bug
> Components: avatica
>Affects Versions: 1.5.0
>Reporter: Carter Shanklin
>Assignee: Josh Elser
> Fix For: 1.6.0
>
>
> [~cartershanklin] sent me some nice notes from working on a Python interface
> to the Phoenix QueryServer. He saw this strange thing in the code he had to
> write:
> {code}
> count = response.results[0].first_frame.rows[0].value[0].value[0].number_value
> {code}
> The {{value\[0\].value\[0\]}} is strange. Looking at the protobuf definition,
> it seems like both {{ColumnValue}} and {{TypedValue}} are repeated which is
> causing this. Only one of them should be repeated, not both. This creates the
> equivalent of a 2dim array inside each row instead of just a 1dim array.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
