[ 
https://issues.apache.org/jira/browse/CALCITE-1298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15336274#comment-15336274
 ] 

Josh Elser commented on CALCITE-1298:
-------------------------------------

Did a quick check to make sure that Joiner wasn't on the chopping block for 
Guava (as they tend to liberally do). Sounds fine to me to replace.

> Consider removing Util.toString
> -------------------------------
>
>                 Key: CALCITE-1298
>                 URL: https://issues.apache.org/jira/browse/CALCITE-1298
>             Project: Calcite
>          Issue Type: Improvement
>            Reporter: Michael Mior
>            Assignee: Julian Hyde
>            Priority: Minor
>
> {{Util.toString}} seems unnecessary in light of 
> {{com.google.common.base.Joiner}}. There are ~16 total usages of this across 
> the entire code base. One inside {{SubstitutionVisitor}} and the rest 
> scattered around the Mongo, Cassandra, and Elasticsearch adapters. If there 
> are no objections, I'll remove this and replace with {{Joiner}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to