subject:"\[jira\] \[Commented\] \(CALCITE\-1520\) org.apache.calcite.avatica.AvaticaConnection\: support isValid\(\)"

[jira] [Commented] (CALCITE-1520) org.apache.calcite.avatica.AvaticaConnection: support isValid()

2021-09-30 Thread Josh Elser (Jira)



[ 
https://issues.apache.org/jira/browse/CALCITE-1520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17422946#comment-17422946
 ] 

Josh Elser commented on CALCITE-1520:
-

Thanks Rymar!

> org.apache.calcite.avatica.AvaticaConnection: support isValid()
> ---
>
> Key: CALCITE-1520
> URL: https://issues.apache.org/jira/browse/CALCITE-1520
> Project: Calcite
>  Issue Type: Improvement
>  Components: avatica
>Affects Versions: 1.10.0
> Environment: Windows
>Reporter: Ningli Fang
>Assignee: Kevin Risden
>Priority: Major
> Fix For: avatica-1.12.0
>
>
> Currently the calss org.apache.calcite.avatica.AvaticaConnection does not  
> support isValid():
> {code}
>  public boolean isValid(int timeout) throws SQLException {
> throw helper.unsupported();
>   }
> {code}
> On JasperSoft server, we created a dataSource using Calcite jdbc driver. When 
> use JasperSoft "test connection" feature, it failed with the exception:
> {noformat}
> java.sql.SQLFeatureNotSupportedException
>   at org.apache.calcite.avatica.Helper.unsupported(Helper.java:68)
>   at 
> org.apache.calcite.avatica.AvaticaConnection.isValid(AvaticaConnection.java:373)
>   at 
> org.apache.commons.dbcp.DelegatingConnection.isValid(DelegatingConnection.java:626)
>   at 
> org.apache.commons.dbcp.DelegatingConnection.isValid(DelegatingConnection.java:626)
>   at 
> com.jaspersoft.jasperserver.api.engine.jasperreports.service.impl.JdbcDataSourceService.isConnectionValid(JdbcDataSourceService.java:102)
>   at 
> com.jaspersoft.jasperserver.api.engine.jasperreports.service.impl.JdbcDataSourceService.testConnection(JdbcDataSourceService.java:86)
>   at 
> com.jaspersoft.jasperserver.remote.connection.JdbcConnectionStrategy.createConnection(JdbcConnectionStrategy.java:76)
>   at 
> com.jaspersoft.jasperserver.remote.connection.JdbcConnectionStrategy.createConnection(JdbcConnectionStrategy.java:45)
>   at 
> com.jaspersoft.jasperserver.remote.connection.ConnectionsManager.createConnection(ConnectionsManager.java:72)
>   at 
> com.jaspersoft.jasperserver.jaxrs.connection.ConnectionsJaxrsService.createConnection(ConnectionsJaxrsService.java:84)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
>   at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
>   at java.lang.reflect.Method.invoke(Unknown Source)
>   at 
> com.sun.jersey.spi.container.JavaMethodInvokerFactory$1.invoke(JavaMethodInvokerFactory.java:60)
>   at 
> com.sun.jersey.server.impl.model.method.dispatch.AbstractResourceMethodDispatchProvider$ResponseOutInvoker._dispatch(AbstractResourceMethodDispatchProvider.java:205)
>   at 
> com.sun.jersey.server.impl.model.method.dispatch.ResourceJavaMethodDispatcher.dispatch(ResourceJavaMethodDispatcher.java:75)
>   at 
> com.sun.jersey.server.impl.uri.rules.HttpMethodRule.accept(HttpMethodRule.java:302)
>   at 
> com.sun.jersey.server.impl.uri.rules.ResourceClassRule.accept(ResourceClassRule.java:108)
>   at 
> com.sun.jersey.server.impl.uri.rules.RightHandPathRule.accept(RightHandPathRule.java:147)
>   at 
> com.sun.jersey.server.impl.uri.rules.RootResourceClassesRule.accept(RootResourceClassesRule.java:84)
>   at 
> com.sun.jersey.server.impl.application.WebApplicationImpl._handleRequest(WebApplicationImpl.java:1483)
>   at 
> com.sun.jersey.server.impl.application.WebApplicationImpl._handleRequest(WebApplicationImpl.java:1414)
>   at 
> com.sun.jersey.server.impl.application.WebApplicationImpl.handleRequest(WebApplicationImpl.java:1363)
>   at 
> com.sun.jersey.server.impl.application.WebApplicationImpl.handleRequest(WebApplicationImpl.java:1353)
>   at 
> com.sun.jersey.spi.container.servlet.WebComponent.service(WebComponent.java:414)
>   at 
> com.sun.jersey.spi.container.servlet.ServletContainer.service(ServletContainer.java:537)
>   at 
> com.sun.jersey.spi.container.servlet.ServletContainer.service(ServletContainer.java:708)
>   at javax.servlet.http.HttpServlet.service(HttpServlet.java:729)
>   at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:292)
>   at 
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:207)
>   at 
> org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:52)
>   at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:240)
>   at 
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:207)
>   at 
>

[jira] [Commented] (CALCITE-1520) org.apache.calcite.avatica.AvaticaConnection: support isValid()

2021-09-30 Thread Rymar Maksym (Jira)



[ 
https://issues.apache.org/jira/browse/CALCITE-1520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17422791#comment-17422791
 ] 

Rymar Maksym commented on CALCITE-1520:
---

[~elserj] thank you for your quick response! I've raised a new Jira issue: 
CALCITE-4814

> org.apache.calcite.avatica.AvaticaConnection: support isValid()
> ---
>
> Key: CALCITE-1520
> URL: https://issues.apache.org/jira/browse/CALCITE-1520
> Project: Calcite
>  Issue Type: Improvement
>  Components: avatica
>Affects Versions: 1.10.0
> Environment: Windows
>Reporter: Ningli Fang
>Assignee: Kevin Risden
>Priority: Major
> Fix For: avatica-1.12.0
>
>
> Currently the calss org.apache.calcite.avatica.AvaticaConnection does not  
> support isValid():
> {code}
>  public boolean isValid(int timeout) throws SQLException {
> throw helper.unsupported();
>   }
> {code}
> On JasperSoft server, we created a dataSource using Calcite jdbc driver. When 
> use JasperSoft "test connection" feature, it failed with the exception:
> {noformat}
> java.sql.SQLFeatureNotSupportedException
>   at org.apache.calcite.avatica.Helper.unsupported(Helper.java:68)
>   at 
> org.apache.calcite.avatica.AvaticaConnection.isValid(AvaticaConnection.java:373)
>   at 
> org.apache.commons.dbcp.DelegatingConnection.isValid(DelegatingConnection.java:626)
>   at 
> org.apache.commons.dbcp.DelegatingConnection.isValid(DelegatingConnection.java:626)
>   at 
> com.jaspersoft.jasperserver.api.engine.jasperreports.service.impl.JdbcDataSourceService.isConnectionValid(JdbcDataSourceService.java:102)
>   at 
> com.jaspersoft.jasperserver.api.engine.jasperreports.service.impl.JdbcDataSourceService.testConnection(JdbcDataSourceService.java:86)
>   at 
> com.jaspersoft.jasperserver.remote.connection.JdbcConnectionStrategy.createConnection(JdbcConnectionStrategy.java:76)
>   at 
> com.jaspersoft.jasperserver.remote.connection.JdbcConnectionStrategy.createConnection(JdbcConnectionStrategy.java:45)
>   at 
> com.jaspersoft.jasperserver.remote.connection.ConnectionsManager.createConnection(ConnectionsManager.java:72)
>   at 
> com.jaspersoft.jasperserver.jaxrs.connection.ConnectionsJaxrsService.createConnection(ConnectionsJaxrsService.java:84)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
>   at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
>   at java.lang.reflect.Method.invoke(Unknown Source)
>   at 
> com.sun.jersey.spi.container.JavaMethodInvokerFactory$1.invoke(JavaMethodInvokerFactory.java:60)
>   at 
> com.sun.jersey.server.impl.model.method.dispatch.AbstractResourceMethodDispatchProvider$ResponseOutInvoker._dispatch(AbstractResourceMethodDispatchProvider.java:205)
>   at 
> com.sun.jersey.server.impl.model.method.dispatch.ResourceJavaMethodDispatcher.dispatch(ResourceJavaMethodDispatcher.java:75)
>   at 
> com.sun.jersey.server.impl.uri.rules.HttpMethodRule.accept(HttpMethodRule.java:302)
>   at 
> com.sun.jersey.server.impl.uri.rules.ResourceClassRule.accept(ResourceClassRule.java:108)
>   at 
> com.sun.jersey.server.impl.uri.rules.RightHandPathRule.accept(RightHandPathRule.java:147)
>   at 
> com.sun.jersey.server.impl.uri.rules.RootResourceClassesRule.accept(RootResourceClassesRule.java:84)
>   at 
> com.sun.jersey.server.impl.application.WebApplicationImpl._handleRequest(WebApplicationImpl.java:1483)
>   at 
> com.sun.jersey.server.impl.application.WebApplicationImpl._handleRequest(WebApplicationImpl.java:1414)
>   at 
> com.sun.jersey.server.impl.application.WebApplicationImpl.handleRequest(WebApplicationImpl.java:1363)
>   at 
> com.sun.jersey.server.impl.application.WebApplicationImpl.handleRequest(WebApplicationImpl.java:1353)
>   at 
> com.sun.jersey.spi.container.servlet.WebComponent.service(WebComponent.java:414)
>   at 
> com.sun.jersey.spi.container.servlet.ServletContainer.service(ServletContainer.java:537)
>   at 
> com.sun.jersey.spi.container.servlet.ServletContainer.service(ServletContainer.java:708)
>   at javax.servlet.http.HttpServlet.service(HttpServlet.java:729)
>   at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:292)
>   at 
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:207)
>   at 
> org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:52)
>   at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:240)
>   at 
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:207)
>   at 
>

[jira] [Commented] (CALCITE-1520) org.apache.calcite.avatica.AvaticaConnection: support isValid()

2021-09-30 Thread Josh Elser (Jira)



[ 
https://issues.apache.org/jira/browse/CALCITE-1520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17422750#comment-17422750
 ] 

Josh Elser commented on CALCITE-1520:
-

[~mrymar] no, we won't open this issue because it was committed over 3 years 
ago. If we were to do this and make a second code change, it will cause 
confusion with users as to when the issue here was actually fixed.

Please file a new Jira issue with an explanation about what specifically is 
wrong with the current implementation, ideally also with a patch to address 
that problem. Thanks.

> org.apache.calcite.avatica.AvaticaConnection: support isValid()
> ---
>
> Key: CALCITE-1520
> URL: https://issues.apache.org/jira/browse/CALCITE-1520
> Project: Calcite
>  Issue Type: Improvement
>  Components: avatica
>Affects Versions: 1.10.0
> Environment: Windows
>Reporter: Ningli Fang
>Assignee: Kevin Risden
>Priority: Major
> Fix For: avatica-1.12.0
>
>
> Currently the calss org.apache.calcite.avatica.AvaticaConnection does not  
> support isValid():
> {code}
>  public boolean isValid(int timeout) throws SQLException {
> throw helper.unsupported();
>   }
> {code}
> On JasperSoft server, we created a dataSource using Calcite jdbc driver. When 
> use JasperSoft "test connection" feature, it failed with the exception:
> {noformat}
> java.sql.SQLFeatureNotSupportedException
>   at org.apache.calcite.avatica.Helper.unsupported(Helper.java:68)
>   at 
> org.apache.calcite.avatica.AvaticaConnection.isValid(AvaticaConnection.java:373)
>   at 
> org.apache.commons.dbcp.DelegatingConnection.isValid(DelegatingConnection.java:626)
>   at 
> org.apache.commons.dbcp.DelegatingConnection.isValid(DelegatingConnection.java:626)
>   at 
> com.jaspersoft.jasperserver.api.engine.jasperreports.service.impl.JdbcDataSourceService.isConnectionValid(JdbcDataSourceService.java:102)
>   at 
> com.jaspersoft.jasperserver.api.engine.jasperreports.service.impl.JdbcDataSourceService.testConnection(JdbcDataSourceService.java:86)
>   at 
> com.jaspersoft.jasperserver.remote.connection.JdbcConnectionStrategy.createConnection(JdbcConnectionStrategy.java:76)
>   at 
> com.jaspersoft.jasperserver.remote.connection.JdbcConnectionStrategy.createConnection(JdbcConnectionStrategy.java:45)
>   at 
> com.jaspersoft.jasperserver.remote.connection.ConnectionsManager.createConnection(ConnectionsManager.java:72)
>   at 
> com.jaspersoft.jasperserver.jaxrs.connection.ConnectionsJaxrsService.createConnection(ConnectionsJaxrsService.java:84)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
>   at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
>   at java.lang.reflect.Method.invoke(Unknown Source)
>   at 
> com.sun.jersey.spi.container.JavaMethodInvokerFactory$1.invoke(JavaMethodInvokerFactory.java:60)
>   at 
> com.sun.jersey.server.impl.model.method.dispatch.AbstractResourceMethodDispatchProvider$ResponseOutInvoker._dispatch(AbstractResourceMethodDispatchProvider.java:205)
>   at 
> com.sun.jersey.server.impl.model.method.dispatch.ResourceJavaMethodDispatcher.dispatch(ResourceJavaMethodDispatcher.java:75)
>   at 
> com.sun.jersey.server.impl.uri.rules.HttpMethodRule.accept(HttpMethodRule.java:302)
>   at 
> com.sun.jersey.server.impl.uri.rules.ResourceClassRule.accept(ResourceClassRule.java:108)
>   at 
> com.sun.jersey.server.impl.uri.rules.RightHandPathRule.accept(RightHandPathRule.java:147)
>   at 
> com.sun.jersey.server.impl.uri.rules.RootResourceClassesRule.accept(RootResourceClassesRule.java:84)
>   at 
> com.sun.jersey.server.impl.application.WebApplicationImpl._handleRequest(WebApplicationImpl.java:1483)
>   at 
> com.sun.jersey.server.impl.application.WebApplicationImpl._handleRequest(WebApplicationImpl.java:1414)
>   at 
> com.sun.jersey.server.impl.application.WebApplicationImpl.handleRequest(WebApplicationImpl.java:1363)
>   at 
> com.sun.jersey.server.impl.application.WebApplicationImpl.handleRequest(WebApplicationImpl.java:1353)
>   at 
> com.sun.jersey.spi.container.servlet.WebComponent.service(WebComponent.java:414)
>   at 
> com.sun.jersey.spi.container.servlet.ServletContainer.service(ServletContainer.java:537)
>   at 
> com.sun.jersey.spi.container.servlet.ServletContainer.service(ServletContainer.java:708)
>   at javax.servlet.http.HttpServlet.service(HttpServlet.java:729)
>   at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:292)
>   at 
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:207)
>   at 
>

[jira] [Commented] (CALCITE-1520) org.apache.calcite.avatica.AvaticaConnection: support isValid()

2021-09-30 Thread Rymar Maksym (Jira)



[ 
https://issues.apache.org/jira/browse/CALCITE-1520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17422662#comment-17422662
 ] 

Rymar Maksym commented on CALCITE-1520:
---

This method wasn't right implemented. According to [Java documentation of JDBC 
API|https://docs.oracle.com/javase/7/docs/api/java/sql/Connection.html#isValid(int)],
 this method should also check, whether connection is valid, in most cases, it 
is done by some test/sample request. Here how it is done in [MySQL JDBC 
driver|https://github.com/mysql/mysql-connector-j/blob/18bbd5e68195d0da083cbd5bd0d05d76320df7cd/src/main/user-impl/java/com/mysql/cj/jdbc/ConnectionImpl.java#L2546]
 and in [Postgres JDBC 
driver|https://github.com/pgjdbc/pgjdbc/blob/3a2bbd77969903f8a4ce721d45905c72bd1688d6/pgjdbc/src/main/java/org/postgresql/jdbc/PgConnection.java#L1407]
 for example.

This method is very important for connection pools and any other frameworks and 
applications which expect, that implementation of JDBC API is proper. With 
current implementation, connections may freeze forever until application 
restart.

Please, reopen this ticket.

> org.apache.calcite.avatica.AvaticaConnection: support isValid()
> ---
>
> Key: CALCITE-1520
> URL: https://issues.apache.org/jira/browse/CALCITE-1520
> Project: Calcite
>  Issue Type: Improvement
>  Components: avatica
>Affects Versions: 1.10.0
> Environment: Windows
>Reporter: Ningli Fang
>Assignee: Kevin Risden
>Priority: Major
> Fix For: avatica-1.12.0
>
>
> Currently the calss org.apache.calcite.avatica.AvaticaConnection does not  
> support isValid():
> {code}
>  public boolean isValid(int timeout) throws SQLException {
> throw helper.unsupported();
>   }
> {code}
> On JasperSoft server, we created a dataSource using Calcite jdbc driver. When 
> use JasperSoft "test connection" feature, it failed with the exception:
> {noformat}
> java.sql.SQLFeatureNotSupportedException
>   at org.apache.calcite.avatica.Helper.unsupported(Helper.java:68)
>   at 
> org.apache.calcite.avatica.AvaticaConnection.isValid(AvaticaConnection.java:373)
>   at 
> org.apache.commons.dbcp.DelegatingConnection.isValid(DelegatingConnection.java:626)
>   at 
> org.apache.commons.dbcp.DelegatingConnection.isValid(DelegatingConnection.java:626)
>   at 
> com.jaspersoft.jasperserver.api.engine.jasperreports.service.impl.JdbcDataSourceService.isConnectionValid(JdbcDataSourceService.java:102)
>   at 
> com.jaspersoft.jasperserver.api.engine.jasperreports.service.impl.JdbcDataSourceService.testConnection(JdbcDataSourceService.java:86)
>   at 
> com.jaspersoft.jasperserver.remote.connection.JdbcConnectionStrategy.createConnection(JdbcConnectionStrategy.java:76)
>   at 
> com.jaspersoft.jasperserver.remote.connection.JdbcConnectionStrategy.createConnection(JdbcConnectionStrategy.java:45)
>   at 
> com.jaspersoft.jasperserver.remote.connection.ConnectionsManager.createConnection(ConnectionsManager.java:72)
>   at 
> com.jaspersoft.jasperserver.jaxrs.connection.ConnectionsJaxrsService.createConnection(ConnectionsJaxrsService.java:84)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
>   at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
>   at java.lang.reflect.Method.invoke(Unknown Source)
>   at 
> com.sun.jersey.spi.container.JavaMethodInvokerFactory$1.invoke(JavaMethodInvokerFactory.java:60)
>   at 
> com.sun.jersey.server.impl.model.method.dispatch.AbstractResourceMethodDispatchProvider$ResponseOutInvoker._dispatch(AbstractResourceMethodDispatchProvider.java:205)
>   at 
> com.sun.jersey.server.impl.model.method.dispatch.ResourceJavaMethodDispatcher.dispatch(ResourceJavaMethodDispatcher.java:75)
>   at 
> com.sun.jersey.server.impl.uri.rules.HttpMethodRule.accept(HttpMethodRule.java:302)
>   at 
> com.sun.jersey.server.impl.uri.rules.ResourceClassRule.accept(ResourceClassRule.java:108)
>   at 
> com.sun.jersey.server.impl.uri.rules.RightHandPathRule.accept(RightHandPathRule.java:147)
>   at 
> com.sun.jersey.server.impl.uri.rules.RootResourceClassesRule.accept(RootResourceClassesRule.java:84)
>   at 
> com.sun.jersey.server.impl.application.WebApplicationImpl._handleRequest(WebApplicationImpl.java:1483)
>   at 
> com.sun.jersey.server.impl.application.WebApplicationImpl._handleRequest(WebApplicationImpl.java:1414)
>   at 
> com.sun.jersey.server.impl.application.WebApplicationImpl.handleRequest(WebApplicationImpl.java:1363)
>   at 
> com.sun.jersey.server.impl.application.WebApplicationImpl.handleRequest(WebApplicationImpl.java:1353)
>   at 
>

[jira] [Commented] (CALCITE-1520) org.apache.calcite.avatica.AvaticaConnection: support isValid()

2018-05-29 Thread Kevin Risden (JIRA)



[ 
https://issues.apache.org/jira/browse/CALCITE-1520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16494566#comment-16494566
 ] 

Kevin Risden commented on CALCITE-1520:
---

Fixed Calcite in 
[https://git-wip-us.apache.org/repos/asf?p=calcite.git;a=commit;h=542d51265d683dfd736c5e04f556e065b3667667]
 to avoid the problem now and when Avatica is upgraded to 1.12.0.

> org.apache.calcite.avatica.AvaticaConnection: support isValid()
> ---
>
> Key: CALCITE-1520
> URL: https://issues.apache.org/jira/browse/CALCITE-1520
> Project: Calcite
>  Issue Type: Improvement
>  Components: avatica
>Affects Versions: 1.10.0
> Environment: Windows
>Reporter: Ningli Fang
>Assignee: Kevin Risden
>Priority: Major
> Fix For: avatica-1.12.0
>
>
> Currently the calss org.apache.calcite.avatica.AvaticaConnection does not  
> support isValid():
> {code}
>  public boolean isValid(int timeout) throws SQLException {
> throw helper.unsupported();
>   }
> {code}
> On JasperSoft server, we created a dataSource using Calcite jdbc driver. When 
> use JasperSoft "test connection" feature, it failed with the exception:
> {noformat}
> java.sql.SQLFeatureNotSupportedException
>   at org.apache.calcite.avatica.Helper.unsupported(Helper.java:68)
>   at 
> org.apache.calcite.avatica.AvaticaConnection.isValid(AvaticaConnection.java:373)
>   at 
> org.apache.commons.dbcp.DelegatingConnection.isValid(DelegatingConnection.java:626)
>   at 
> org.apache.commons.dbcp.DelegatingConnection.isValid(DelegatingConnection.java:626)
>   at 
> com.jaspersoft.jasperserver.api.engine.jasperreports.service.impl.JdbcDataSourceService.isConnectionValid(JdbcDataSourceService.java:102)
>   at 
> com.jaspersoft.jasperserver.api.engine.jasperreports.service.impl.JdbcDataSourceService.testConnection(JdbcDataSourceService.java:86)
>   at 
> com.jaspersoft.jasperserver.remote.connection.JdbcConnectionStrategy.createConnection(JdbcConnectionStrategy.java:76)
>   at 
> com.jaspersoft.jasperserver.remote.connection.JdbcConnectionStrategy.createConnection(JdbcConnectionStrategy.java:45)
>   at 
> com.jaspersoft.jasperserver.remote.connection.ConnectionsManager.createConnection(ConnectionsManager.java:72)
>   at 
> com.jaspersoft.jasperserver.jaxrs.connection.ConnectionsJaxrsService.createConnection(ConnectionsJaxrsService.java:84)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
>   at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
>   at java.lang.reflect.Method.invoke(Unknown Source)
>   at 
> com.sun.jersey.spi.container.JavaMethodInvokerFactory$1.invoke(JavaMethodInvokerFactory.java:60)
>   at 
> com.sun.jersey.server.impl.model.method.dispatch.AbstractResourceMethodDispatchProvider$ResponseOutInvoker._dispatch(AbstractResourceMethodDispatchProvider.java:205)
>   at 
> com.sun.jersey.server.impl.model.method.dispatch.ResourceJavaMethodDispatcher.dispatch(ResourceJavaMethodDispatcher.java:75)
>   at 
> com.sun.jersey.server.impl.uri.rules.HttpMethodRule.accept(HttpMethodRule.java:302)
>   at 
> com.sun.jersey.server.impl.uri.rules.ResourceClassRule.accept(ResourceClassRule.java:108)
>   at 
> com.sun.jersey.server.impl.uri.rules.RightHandPathRule.accept(RightHandPathRule.java:147)
>   at 
> com.sun.jersey.server.impl.uri.rules.RootResourceClassesRule.accept(RootResourceClassesRule.java:84)
>   at 
> com.sun.jersey.server.impl.application.WebApplicationImpl._handleRequest(WebApplicationImpl.java:1483)
>   at 
> com.sun.jersey.server.impl.application.WebApplicationImpl._handleRequest(WebApplicationImpl.java:1414)
>   at 
> com.sun.jersey.server.impl.application.WebApplicationImpl.handleRequest(WebApplicationImpl.java:1363)
>   at 
> com.sun.jersey.server.impl.application.WebApplicationImpl.handleRequest(WebApplicationImpl.java:1353)
>   at 
> com.sun.jersey.spi.container.servlet.WebComponent.service(WebComponent.java:414)
>   at 
> com.sun.jersey.spi.container.servlet.ServletContainer.service(ServletContainer.java:537)
>   at 
> com.sun.jersey.spi.container.servlet.ServletContainer.service(ServletContainer.java:708)
>   at javax.servlet.http.HttpServlet.service(HttpServlet.java:729)
>   at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:292)
>   at 
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:207)
>   at 
> org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:52)
>   at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:240)
>   at 
>

[jira] [Commented] (CALCITE-1520) org.apache.calcite.avatica.AvaticaConnection: support isValid()

2018-05-29 Thread Kevin Risden (JIRA)



[ 
https://issues.apache.org/jira/browse/CALCITE-1520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16494564#comment-16494564
 ] 

Kevin Risden commented on CALCITE-1520:
---

Even better is to fix the test so that the exception occurs correctly. Right 
now the only reason the Calcite test broke is because Avatica wasn't 
implementing the isValid method correctly. I'll fix the Calcite test to send in 
-1 so that a SQLException is always thrown correctly.

> org.apache.calcite.avatica.AvaticaConnection: support isValid()
> ---
>
> Key: CALCITE-1520
> URL: https://issues.apache.org/jira/browse/CALCITE-1520
> Project: Calcite
>  Issue Type: Improvement
>  Components: avatica
>Affects Versions: 1.10.0
> Environment: Windows
>Reporter: Ningli Fang
>Assignee: Kevin Risden
>Priority: Major
> Fix For: avatica-1.12.0
>
>
> Currently the calss org.apache.calcite.avatica.AvaticaConnection does not  
> support isValid():
> {code}
>  public boolean isValid(int timeout) throws SQLException {
> throw helper.unsupported();
>   }
> {code}
> On JasperSoft server, we created a dataSource using Calcite jdbc driver. When 
> use JasperSoft "test connection" feature, it failed with the exception:
> {noformat}
> java.sql.SQLFeatureNotSupportedException
>   at org.apache.calcite.avatica.Helper.unsupported(Helper.java:68)
>   at 
> org.apache.calcite.avatica.AvaticaConnection.isValid(AvaticaConnection.java:373)
>   at 
> org.apache.commons.dbcp.DelegatingConnection.isValid(DelegatingConnection.java:626)
>   at 
> org.apache.commons.dbcp.DelegatingConnection.isValid(DelegatingConnection.java:626)
>   at 
> com.jaspersoft.jasperserver.api.engine.jasperreports.service.impl.JdbcDataSourceService.isConnectionValid(JdbcDataSourceService.java:102)
>   at 
> com.jaspersoft.jasperserver.api.engine.jasperreports.service.impl.JdbcDataSourceService.testConnection(JdbcDataSourceService.java:86)
>   at 
> com.jaspersoft.jasperserver.remote.connection.JdbcConnectionStrategy.createConnection(JdbcConnectionStrategy.java:76)
>   at 
> com.jaspersoft.jasperserver.remote.connection.JdbcConnectionStrategy.createConnection(JdbcConnectionStrategy.java:45)
>   at 
> com.jaspersoft.jasperserver.remote.connection.ConnectionsManager.createConnection(ConnectionsManager.java:72)
>   at 
> com.jaspersoft.jasperserver.jaxrs.connection.ConnectionsJaxrsService.createConnection(ConnectionsJaxrsService.java:84)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
>   at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
>   at java.lang.reflect.Method.invoke(Unknown Source)
>   at 
> com.sun.jersey.spi.container.JavaMethodInvokerFactory$1.invoke(JavaMethodInvokerFactory.java:60)
>   at 
> com.sun.jersey.server.impl.model.method.dispatch.AbstractResourceMethodDispatchProvider$ResponseOutInvoker._dispatch(AbstractResourceMethodDispatchProvider.java:205)
>   at 
> com.sun.jersey.server.impl.model.method.dispatch.ResourceJavaMethodDispatcher.dispatch(ResourceJavaMethodDispatcher.java:75)
>   at 
> com.sun.jersey.server.impl.uri.rules.HttpMethodRule.accept(HttpMethodRule.java:302)
>   at 
> com.sun.jersey.server.impl.uri.rules.ResourceClassRule.accept(ResourceClassRule.java:108)
>   at 
> com.sun.jersey.server.impl.uri.rules.RightHandPathRule.accept(RightHandPathRule.java:147)
>   at 
> com.sun.jersey.server.impl.uri.rules.RootResourceClassesRule.accept(RootResourceClassesRule.java:84)
>   at 
> com.sun.jersey.server.impl.application.WebApplicationImpl._handleRequest(WebApplicationImpl.java:1483)
>   at 
> com.sun.jersey.server.impl.application.WebApplicationImpl._handleRequest(WebApplicationImpl.java:1414)
>   at 
> com.sun.jersey.server.impl.application.WebApplicationImpl.handleRequest(WebApplicationImpl.java:1363)
>   at 
> com.sun.jersey.server.impl.application.WebApplicationImpl.handleRequest(WebApplicationImpl.java:1353)
>   at 
> com.sun.jersey.spi.container.servlet.WebComponent.service(WebComponent.java:414)
>   at 
> com.sun.jersey.spi.container.servlet.ServletContainer.service(ServletContainer.java:537)
>   at 
> com.sun.jersey.spi.container.servlet.ServletContainer.service(ServletContainer.java:708)
>   at javax.servlet.http.HttpServlet.service(HttpServlet.java:729)
>   at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:292)
>   at 
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:207)
>   at 
> org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:52)
>   at 
>

[jira] [Commented] (CALCITE-1520) org.apache.calcite.avatica.AvaticaConnection: support isValid()

2018-05-29 Thread Kevin Risden (JIRA)



[ 
https://issues.apache.org/jira/browse/CALCITE-1520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16494554#comment-16494554
 ] 

Kevin Risden commented on CALCITE-1520:
---

[~julianhyde] - Yes I can take a look at this. 

> org.apache.calcite.avatica.AvaticaConnection: support isValid()
> ---
>
> Key: CALCITE-1520
> URL: https://issues.apache.org/jira/browse/CALCITE-1520
> Project: Calcite
>  Issue Type: Improvement
>  Components: avatica
>Affects Versions: 1.10.0
> Environment: Windows
>Reporter: Ningli Fang
>Assignee: Kevin Risden
>Priority: Major
> Fix For: avatica-1.12.0
>
>
> Currently the calss org.apache.calcite.avatica.AvaticaConnection does not  
> support isValid():
> {code}
>  public boolean isValid(int timeout) throws SQLException {
> throw helper.unsupported();
>   }
> {code}
> On JasperSoft server, we created a dataSource using Calcite jdbc driver. When 
> use JasperSoft "test connection" feature, it failed with the exception:
> {noformat}
> java.sql.SQLFeatureNotSupportedException
>   at org.apache.calcite.avatica.Helper.unsupported(Helper.java:68)
>   at 
> org.apache.calcite.avatica.AvaticaConnection.isValid(AvaticaConnection.java:373)
>   at 
> org.apache.commons.dbcp.DelegatingConnection.isValid(DelegatingConnection.java:626)
>   at 
> org.apache.commons.dbcp.DelegatingConnection.isValid(DelegatingConnection.java:626)
>   at 
> com.jaspersoft.jasperserver.api.engine.jasperreports.service.impl.JdbcDataSourceService.isConnectionValid(JdbcDataSourceService.java:102)
>   at 
> com.jaspersoft.jasperserver.api.engine.jasperreports.service.impl.JdbcDataSourceService.testConnection(JdbcDataSourceService.java:86)
>   at 
> com.jaspersoft.jasperserver.remote.connection.JdbcConnectionStrategy.createConnection(JdbcConnectionStrategy.java:76)
>   at 
> com.jaspersoft.jasperserver.remote.connection.JdbcConnectionStrategy.createConnection(JdbcConnectionStrategy.java:45)
>   at 
> com.jaspersoft.jasperserver.remote.connection.ConnectionsManager.createConnection(ConnectionsManager.java:72)
>   at 
> com.jaspersoft.jasperserver.jaxrs.connection.ConnectionsJaxrsService.createConnection(ConnectionsJaxrsService.java:84)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
>   at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
>   at java.lang.reflect.Method.invoke(Unknown Source)
>   at 
> com.sun.jersey.spi.container.JavaMethodInvokerFactory$1.invoke(JavaMethodInvokerFactory.java:60)
>   at 
> com.sun.jersey.server.impl.model.method.dispatch.AbstractResourceMethodDispatchProvider$ResponseOutInvoker._dispatch(AbstractResourceMethodDispatchProvider.java:205)
>   at 
> com.sun.jersey.server.impl.model.method.dispatch.ResourceJavaMethodDispatcher.dispatch(ResourceJavaMethodDispatcher.java:75)
>   at 
> com.sun.jersey.server.impl.uri.rules.HttpMethodRule.accept(HttpMethodRule.java:302)
>   at 
> com.sun.jersey.server.impl.uri.rules.ResourceClassRule.accept(ResourceClassRule.java:108)
>   at 
> com.sun.jersey.server.impl.uri.rules.RightHandPathRule.accept(RightHandPathRule.java:147)
>   at 
> com.sun.jersey.server.impl.uri.rules.RootResourceClassesRule.accept(RootResourceClassesRule.java:84)
>   at 
> com.sun.jersey.server.impl.application.WebApplicationImpl._handleRequest(WebApplicationImpl.java:1483)
>   at 
> com.sun.jersey.server.impl.application.WebApplicationImpl._handleRequest(WebApplicationImpl.java:1414)
>   at 
> com.sun.jersey.server.impl.application.WebApplicationImpl.handleRequest(WebApplicationImpl.java:1363)
>   at 
> com.sun.jersey.server.impl.application.WebApplicationImpl.handleRequest(WebApplicationImpl.java:1353)
>   at 
> com.sun.jersey.spi.container.servlet.WebComponent.service(WebComponent.java:414)
>   at 
> com.sun.jersey.spi.container.servlet.ServletContainer.service(ServletContainer.java:537)
>   at 
> com.sun.jersey.spi.container.servlet.ServletContainer.service(ServletContainer.java:708)
>   at javax.servlet.http.HttpServlet.service(HttpServlet.java:729)
>   at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:292)
>   at 
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:207)
>   at 
> org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:52)
>   at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:240)
>   at 
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:207)
>   at 
>

[jira] [Commented] (CALCITE-1520) org.apache.calcite.avatica.AvaticaConnection: support isValid()

2018-05-25 Thread Julian Hyde (JIRA)


[ 
https://issues.apache.org/jira/browse/CALCITE-1520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16491133#comment-16491133
 ] 

Julian Hyde commented on CALCITE-1520:
--

When I run latest Calcite against latest Avatica, I get a test failure, which I 
presume is caused by this Avatica change:
{noformat}[ERROR] Failures: 
[ERROR]   CalciteRemoteDriverTest.testAvaticaConnectionException Expected 
exception: java.sql.SQLException
[INFO] 
[ERROR] Tests run: 4411, Failures: 1, Errors: 0, Skipped: 109{noformat}

[~risdenk], Can you please create a fix for Calcite which we can apply after 
the Avatica release? Before it's too late to change what is in Avatica.

> org.apache.calcite.avatica.AvaticaConnection: support isValid()
> ---
>
> Key: CALCITE-1520
> URL: https://issues.apache.org/jira/browse/CALCITE-1520
> Project: Calcite
>  Issue Type: Improvement
>  Components: avatica
>Affects Versions: 1.10.0
> Environment: Windows
>Reporter: Ningli Fang
>Assignee: Kevin Risden
>Priority: Major
> Fix For: avatica-1.12.0
>
>
> Currently the calss org.apache.calcite.avatica.AvaticaConnection does not  
> support isValid():
> {code}
>  public boolean isValid(int timeout) throws SQLException {
> throw helper.unsupported();
>   }
> {code}
> On JasperSoft server, we created a dataSource using Calcite jdbc driver. When 
> use JasperSoft "test connection" feature, it failed with the exception:
> {noformat}
> java.sql.SQLFeatureNotSupportedException
>   at org.apache.calcite.avatica.Helper.unsupported(Helper.java:68)
>   at 
> org.apache.calcite.avatica.AvaticaConnection.isValid(AvaticaConnection.java:373)
>   at 
> org.apache.commons.dbcp.DelegatingConnection.isValid(DelegatingConnection.java:626)
>   at 
> org.apache.commons.dbcp.DelegatingConnection.isValid(DelegatingConnection.java:626)
>   at 
> com.jaspersoft.jasperserver.api.engine.jasperreports.service.impl.JdbcDataSourceService.isConnectionValid(JdbcDataSourceService.java:102)
>   at 
> com.jaspersoft.jasperserver.api.engine.jasperreports.service.impl.JdbcDataSourceService.testConnection(JdbcDataSourceService.java:86)
>   at 
> com.jaspersoft.jasperserver.remote.connection.JdbcConnectionStrategy.createConnection(JdbcConnectionStrategy.java:76)
>   at 
> com.jaspersoft.jasperserver.remote.connection.JdbcConnectionStrategy.createConnection(JdbcConnectionStrategy.java:45)
>   at 
> com.jaspersoft.jasperserver.remote.connection.ConnectionsManager.createConnection(ConnectionsManager.java:72)
>   at 
> com.jaspersoft.jasperserver.jaxrs.connection.ConnectionsJaxrsService.createConnection(ConnectionsJaxrsService.java:84)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
>   at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
>   at java.lang.reflect.Method.invoke(Unknown Source)
>   at 
> com.sun.jersey.spi.container.JavaMethodInvokerFactory$1.invoke(JavaMethodInvokerFactory.java:60)
>   at 
> com.sun.jersey.server.impl.model.method.dispatch.AbstractResourceMethodDispatchProvider$ResponseOutInvoker._dispatch(AbstractResourceMethodDispatchProvider.java:205)
>   at 
> com.sun.jersey.server.impl.model.method.dispatch.ResourceJavaMethodDispatcher.dispatch(ResourceJavaMethodDispatcher.java:75)
>   at 
> com.sun.jersey.server.impl.uri.rules.HttpMethodRule.accept(HttpMethodRule.java:302)
>   at 
> com.sun.jersey.server.impl.uri.rules.ResourceClassRule.accept(ResourceClassRule.java:108)
>   at 
> com.sun.jersey.server.impl.uri.rules.RightHandPathRule.accept(RightHandPathRule.java:147)
>   at 
> com.sun.jersey.server.impl.uri.rules.RootResourceClassesRule.accept(RootResourceClassesRule.java:84)
>   at 
> com.sun.jersey.server.impl.application.WebApplicationImpl._handleRequest(WebApplicationImpl.java:1483)
>   at 
> com.sun.jersey.server.impl.application.WebApplicationImpl._handleRequest(WebApplicationImpl.java:1414)
>   at 
> com.sun.jersey.server.impl.application.WebApplicationImpl.handleRequest(WebApplicationImpl.java:1363)
>   at 
> com.sun.jersey.server.impl.application.WebApplicationImpl.handleRequest(WebApplicationImpl.java:1353)
>   at 
> com.sun.jersey.spi.container.servlet.WebComponent.service(WebComponent.java:414)
>   at 
> com.sun.jersey.spi.container.servlet.ServletContainer.service(ServletContainer.java:537)
>   at 
> com.sun.jersey.spi.container.servlet.ServletContainer.service(ServletContainer.java:708)
>   at javax.servlet.http.HttpServlet.service(HttpServlet.java:729)
>   at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:292)
>   at 
>

[jira] [Commented] (CALCITE-1520) org.apache.calcite.avatica.AvaticaConnection: support isValid()

2018-03-12 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CALCITE-1520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16395426#comment-16395426
 ] 

ASF GitHub Bot commented on CALCITE-1520:
-

Github user joshelser commented on the issue:

https://github.com/apache/calcite-avatica/pull/26
  
Yeah, not your problem. Will try to merge this sucka in today. Thanks for 
the PR!


> org.apache.calcite.avatica.AvaticaConnection: support isValid()
> ---
>
> Key: CALCITE-1520
> URL: https://issues.apache.org/jira/browse/CALCITE-1520
> Project: Calcite
>  Issue Type: Improvement
>  Components: avatica
>Affects Versions: 1.10.0
> Environment: Windows
>Reporter: Ningli Fang
>Assignee: Kevin Risden
>Priority: Major
>
> Currently the calss org.apache.calcite.avatica.AvaticaConnection does not  
> support isValid():
> {code}
>  public boolean isValid(int timeout) throws SQLException {
> throw helper.unsupported();
>   }
> {code}
> On JasperSoft server, we created a dataSource using Calcite jdbc driver. When 
> use JasperSoft "test connection" feature, it failed with the exception:
> {noformat}
> java.sql.SQLFeatureNotSupportedException
>   at org.apache.calcite.avatica.Helper.unsupported(Helper.java:68)
>   at 
> org.apache.calcite.avatica.AvaticaConnection.isValid(AvaticaConnection.java:373)
>   at 
> org.apache.commons.dbcp.DelegatingConnection.isValid(DelegatingConnection.java:626)
>   at 
> org.apache.commons.dbcp.DelegatingConnection.isValid(DelegatingConnection.java:626)
>   at 
> com.jaspersoft.jasperserver.api.engine.jasperreports.service.impl.JdbcDataSourceService.isConnectionValid(JdbcDataSourceService.java:102)
>   at 
> com.jaspersoft.jasperserver.api.engine.jasperreports.service.impl.JdbcDataSourceService.testConnection(JdbcDataSourceService.java:86)
>   at 
> com.jaspersoft.jasperserver.remote.connection.JdbcConnectionStrategy.createConnection(JdbcConnectionStrategy.java:76)
>   at 
> com.jaspersoft.jasperserver.remote.connection.JdbcConnectionStrategy.createConnection(JdbcConnectionStrategy.java:45)
>   at 
> com.jaspersoft.jasperserver.remote.connection.ConnectionsManager.createConnection(ConnectionsManager.java:72)
>   at 
> com.jaspersoft.jasperserver.jaxrs.connection.ConnectionsJaxrsService.createConnection(ConnectionsJaxrsService.java:84)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
>   at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
>   at java.lang.reflect.Method.invoke(Unknown Source)
>   at 
> com.sun.jersey.spi.container.JavaMethodInvokerFactory$1.invoke(JavaMethodInvokerFactory.java:60)
>   at 
> com.sun.jersey.server.impl.model.method.dispatch.AbstractResourceMethodDispatchProvider$ResponseOutInvoker._dispatch(AbstractResourceMethodDispatchProvider.java:205)
>   at 
> com.sun.jersey.server.impl.model.method.dispatch.ResourceJavaMethodDispatcher.dispatch(ResourceJavaMethodDispatcher.java:75)
>   at 
> com.sun.jersey.server.impl.uri.rules.HttpMethodRule.accept(HttpMethodRule.java:302)
>   at 
> com.sun.jersey.server.impl.uri.rules.ResourceClassRule.accept(ResourceClassRule.java:108)
>   at 
> com.sun.jersey.server.impl.uri.rules.RightHandPathRule.accept(RightHandPathRule.java:147)
>   at 
> com.sun.jersey.server.impl.uri.rules.RootResourceClassesRule.accept(RootResourceClassesRule.java:84)
>   at 
> com.sun.jersey.server.impl.application.WebApplicationImpl._handleRequest(WebApplicationImpl.java:1483)
>   at 
> com.sun.jersey.server.impl.application.WebApplicationImpl._handleRequest(WebApplicationImpl.java:1414)
>   at 
> com.sun.jersey.server.impl.application.WebApplicationImpl.handleRequest(WebApplicationImpl.java:1363)
>   at 
> com.sun.jersey.server.impl.application.WebApplicationImpl.handleRequest(WebApplicationImpl.java:1353)
>   at 
> com.sun.jersey.spi.container.servlet.WebComponent.service(WebComponent.java:414)
>   at 
> com.sun.jersey.spi.container.servlet.ServletContainer.service(ServletContainer.java:537)
>   at 
> com.sun.jersey.spi.container.servlet.ServletContainer.service(ServletContainer.java:708)
>   at javax.servlet.http.HttpServlet.service(HttpServlet.java:729)
>   at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:292)
>   at 
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:207)
>   at 
> org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:52)
>   at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:240)
>   at 
>

[jira] [Commented] (CALCITE-1520) org.apache.calcite.avatica.AvaticaConnection: support isValid()

2018-03-11 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CALCITE-1520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16394553#comment-16394553
 ] 

ASF GitHub Bot commented on CALCITE-1520:
-

Github user risdenk commented on the issue:

https://github.com/apache/calcite-avatica/pull/26
  
Looks like the test failure is related to JDK7 and bumping the hsqldb 
version?


> org.apache.calcite.avatica.AvaticaConnection: support isValid()
> ---
>
> Key: CALCITE-1520
> URL: https://issues.apache.org/jira/browse/CALCITE-1520
> Project: Calcite
>  Issue Type: Improvement
>  Components: avatica
>Affects Versions: 1.10.0
> Environment: Windows
>Reporter: Ningli Fang
>Assignee: Kevin Risden
>Priority: Major
>
> Currently the calss org.apache.calcite.avatica.AvaticaConnection does not  
> support isValid():
> {code}
>  public boolean isValid(int timeout) throws SQLException {
> throw helper.unsupported();
>   }
> {code}
> On JasperSoft server, we created a dataSource using Calcite jdbc driver. When 
> use JasperSoft "test connection" feature, it failed with the exception:
> {noformat}
> java.sql.SQLFeatureNotSupportedException
>   at org.apache.calcite.avatica.Helper.unsupported(Helper.java:68)
>   at 
> org.apache.calcite.avatica.AvaticaConnection.isValid(AvaticaConnection.java:373)
>   at 
> org.apache.commons.dbcp.DelegatingConnection.isValid(DelegatingConnection.java:626)
>   at 
> org.apache.commons.dbcp.DelegatingConnection.isValid(DelegatingConnection.java:626)
>   at 
> com.jaspersoft.jasperserver.api.engine.jasperreports.service.impl.JdbcDataSourceService.isConnectionValid(JdbcDataSourceService.java:102)
>   at 
> com.jaspersoft.jasperserver.api.engine.jasperreports.service.impl.JdbcDataSourceService.testConnection(JdbcDataSourceService.java:86)
>   at 
> com.jaspersoft.jasperserver.remote.connection.JdbcConnectionStrategy.createConnection(JdbcConnectionStrategy.java:76)
>   at 
> com.jaspersoft.jasperserver.remote.connection.JdbcConnectionStrategy.createConnection(JdbcConnectionStrategy.java:45)
>   at 
> com.jaspersoft.jasperserver.remote.connection.ConnectionsManager.createConnection(ConnectionsManager.java:72)
>   at 
> com.jaspersoft.jasperserver.jaxrs.connection.ConnectionsJaxrsService.createConnection(ConnectionsJaxrsService.java:84)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
>   at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
>   at java.lang.reflect.Method.invoke(Unknown Source)
>   at 
> com.sun.jersey.spi.container.JavaMethodInvokerFactory$1.invoke(JavaMethodInvokerFactory.java:60)
>   at 
> com.sun.jersey.server.impl.model.method.dispatch.AbstractResourceMethodDispatchProvider$ResponseOutInvoker._dispatch(AbstractResourceMethodDispatchProvider.java:205)
>   at 
> com.sun.jersey.server.impl.model.method.dispatch.ResourceJavaMethodDispatcher.dispatch(ResourceJavaMethodDispatcher.java:75)
>   at 
> com.sun.jersey.server.impl.uri.rules.HttpMethodRule.accept(HttpMethodRule.java:302)
>   at 
> com.sun.jersey.server.impl.uri.rules.ResourceClassRule.accept(ResourceClassRule.java:108)
>   at 
> com.sun.jersey.server.impl.uri.rules.RightHandPathRule.accept(RightHandPathRule.java:147)
>   at 
> com.sun.jersey.server.impl.uri.rules.RootResourceClassesRule.accept(RootResourceClassesRule.java:84)
>   at 
> com.sun.jersey.server.impl.application.WebApplicationImpl._handleRequest(WebApplicationImpl.java:1483)
>   at 
> com.sun.jersey.server.impl.application.WebApplicationImpl._handleRequest(WebApplicationImpl.java:1414)
>   at 
> com.sun.jersey.server.impl.application.WebApplicationImpl.handleRequest(WebApplicationImpl.java:1363)
>   at 
> com.sun.jersey.server.impl.application.WebApplicationImpl.handleRequest(WebApplicationImpl.java:1353)
>   at 
> com.sun.jersey.spi.container.servlet.WebComponent.service(WebComponent.java:414)
>   at 
> com.sun.jersey.spi.container.servlet.ServletContainer.service(ServletContainer.java:537)
>   at 
> com.sun.jersey.spi.container.servlet.ServletContainer.service(ServletContainer.java:708)
>   at javax.servlet.http.HttpServlet.service(HttpServlet.java:729)
>   at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:292)
>   at 
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:207)
>   at 
> org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:52)
>   at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:240)
>   at 
>

[jira] [Commented] (CALCITE-1520) org.apache.calcite.avatica.AvaticaConnection: support isValid()

2018-03-06 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CALCITE-1520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16388844#comment-16388844
 ] 

ASF GitHub Bot commented on CALCITE-1520:
-

Github user risdenk commented on the issue:

https://github.com/apache/calcite-avatica/pull/26
  
@joshelser - thanks for the quick review. Added a test case to 
`RemoteDriverTest`


> org.apache.calcite.avatica.AvaticaConnection: support isValid()
> ---
>
> Key: CALCITE-1520
> URL: https://issues.apache.org/jira/browse/CALCITE-1520
> Project: Calcite
>  Issue Type: Improvement
>  Components: avatica
>Affects Versions: 1.10.0
> Environment: Windows
>Reporter: Ningli Fang
>Assignee: Kevin Risden
>Priority: Major
>
> Currently the calss org.apache.calcite.avatica.AvaticaConnection does not  
> support isValid():
> {code}
>  public boolean isValid(int timeout) throws SQLException {
> throw helper.unsupported();
>   }
> {code}
> On JasperSoft server, we created a dataSource using Calcite jdbc driver. When 
> use JasperSoft "test connection" feature, it failed with the exception:
> {noformat}
> java.sql.SQLFeatureNotSupportedException
>   at org.apache.calcite.avatica.Helper.unsupported(Helper.java:68)
>   at 
> org.apache.calcite.avatica.AvaticaConnection.isValid(AvaticaConnection.java:373)
>   at 
> org.apache.commons.dbcp.DelegatingConnection.isValid(DelegatingConnection.java:626)
>   at 
> org.apache.commons.dbcp.DelegatingConnection.isValid(DelegatingConnection.java:626)
>   at 
> com.jaspersoft.jasperserver.api.engine.jasperreports.service.impl.JdbcDataSourceService.isConnectionValid(JdbcDataSourceService.java:102)
>   at 
> com.jaspersoft.jasperserver.api.engine.jasperreports.service.impl.JdbcDataSourceService.testConnection(JdbcDataSourceService.java:86)
>   at 
> com.jaspersoft.jasperserver.remote.connection.JdbcConnectionStrategy.createConnection(JdbcConnectionStrategy.java:76)
>   at 
> com.jaspersoft.jasperserver.remote.connection.JdbcConnectionStrategy.createConnection(JdbcConnectionStrategy.java:45)
>   at 
> com.jaspersoft.jasperserver.remote.connection.ConnectionsManager.createConnection(ConnectionsManager.java:72)
>   at 
> com.jaspersoft.jasperserver.jaxrs.connection.ConnectionsJaxrsService.createConnection(ConnectionsJaxrsService.java:84)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
>   at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
>   at java.lang.reflect.Method.invoke(Unknown Source)
>   at 
> com.sun.jersey.spi.container.JavaMethodInvokerFactory$1.invoke(JavaMethodInvokerFactory.java:60)
>   at 
> com.sun.jersey.server.impl.model.method.dispatch.AbstractResourceMethodDispatchProvider$ResponseOutInvoker._dispatch(AbstractResourceMethodDispatchProvider.java:205)
>   at 
> com.sun.jersey.server.impl.model.method.dispatch.ResourceJavaMethodDispatcher.dispatch(ResourceJavaMethodDispatcher.java:75)
>   at 
> com.sun.jersey.server.impl.uri.rules.HttpMethodRule.accept(HttpMethodRule.java:302)
>   at 
> com.sun.jersey.server.impl.uri.rules.ResourceClassRule.accept(ResourceClassRule.java:108)
>   at 
> com.sun.jersey.server.impl.uri.rules.RightHandPathRule.accept(RightHandPathRule.java:147)
>   at 
> com.sun.jersey.server.impl.uri.rules.RootResourceClassesRule.accept(RootResourceClassesRule.java:84)
>   at 
> com.sun.jersey.server.impl.application.WebApplicationImpl._handleRequest(WebApplicationImpl.java:1483)
>   at 
> com.sun.jersey.server.impl.application.WebApplicationImpl._handleRequest(WebApplicationImpl.java:1414)
>   at 
> com.sun.jersey.server.impl.application.WebApplicationImpl.handleRequest(WebApplicationImpl.java:1363)
>   at 
> com.sun.jersey.server.impl.application.WebApplicationImpl.handleRequest(WebApplicationImpl.java:1353)
>   at 
> com.sun.jersey.spi.container.servlet.WebComponent.service(WebComponent.java:414)
>   at 
> com.sun.jersey.spi.container.servlet.ServletContainer.service(ServletContainer.java:537)
>   at 
> com.sun.jersey.spi.container.servlet.ServletContainer.service(ServletContainer.java:708)
>   at javax.servlet.http.HttpServlet.service(HttpServlet.java:729)
>   at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:292)
>   at 
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:207)
>   at 
> org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:52)
>   at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:240)
>   at 
>

[jira] [Commented] (CALCITE-1520) org.apache.calcite.avatica.AvaticaConnection: support isValid()

2018-03-06 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CALCITE-1520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16388265#comment-16388265
 ] 

ASF GitHub Bot commented on CALCITE-1520:
-

Github user risdenk commented on the issue:

https://github.com/apache/calcite-avatica/pull/26
  
Sure will add that today hopefully


> org.apache.calcite.avatica.AvaticaConnection: support isValid()
> ---
>
> Key: CALCITE-1520
> URL: https://issues.apache.org/jira/browse/CALCITE-1520
> Project: Calcite
>  Issue Type: Improvement
>  Components: avatica
>Affects Versions: 1.10.0
> Environment: Windows
>Reporter: Ningli Fang
>Assignee: Kevin Risden
>Priority: Major
>
> Currently the calss org.apache.calcite.avatica.AvaticaConnection does not  
> support isValid():
> {code}
>  public boolean isValid(int timeout) throws SQLException {
> throw helper.unsupported();
>   }
> {code}
> On JasperSoft server, we created a dataSource using Calcite jdbc driver. When 
> use JasperSoft "test connection" feature, it failed with the exception:
> {noformat}
> java.sql.SQLFeatureNotSupportedException
>   at org.apache.calcite.avatica.Helper.unsupported(Helper.java:68)
>   at 
> org.apache.calcite.avatica.AvaticaConnection.isValid(AvaticaConnection.java:373)
>   at 
> org.apache.commons.dbcp.DelegatingConnection.isValid(DelegatingConnection.java:626)
>   at 
> org.apache.commons.dbcp.DelegatingConnection.isValid(DelegatingConnection.java:626)
>   at 
> com.jaspersoft.jasperserver.api.engine.jasperreports.service.impl.JdbcDataSourceService.isConnectionValid(JdbcDataSourceService.java:102)
>   at 
> com.jaspersoft.jasperserver.api.engine.jasperreports.service.impl.JdbcDataSourceService.testConnection(JdbcDataSourceService.java:86)
>   at 
> com.jaspersoft.jasperserver.remote.connection.JdbcConnectionStrategy.createConnection(JdbcConnectionStrategy.java:76)
>   at 
> com.jaspersoft.jasperserver.remote.connection.JdbcConnectionStrategy.createConnection(JdbcConnectionStrategy.java:45)
>   at 
> com.jaspersoft.jasperserver.remote.connection.ConnectionsManager.createConnection(ConnectionsManager.java:72)
>   at 
> com.jaspersoft.jasperserver.jaxrs.connection.ConnectionsJaxrsService.createConnection(ConnectionsJaxrsService.java:84)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
>   at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
>   at java.lang.reflect.Method.invoke(Unknown Source)
>   at 
> com.sun.jersey.spi.container.JavaMethodInvokerFactory$1.invoke(JavaMethodInvokerFactory.java:60)
>   at 
> com.sun.jersey.server.impl.model.method.dispatch.AbstractResourceMethodDispatchProvider$ResponseOutInvoker._dispatch(AbstractResourceMethodDispatchProvider.java:205)
>   at 
> com.sun.jersey.server.impl.model.method.dispatch.ResourceJavaMethodDispatcher.dispatch(ResourceJavaMethodDispatcher.java:75)
>   at 
> com.sun.jersey.server.impl.uri.rules.HttpMethodRule.accept(HttpMethodRule.java:302)
>   at 
> com.sun.jersey.server.impl.uri.rules.ResourceClassRule.accept(ResourceClassRule.java:108)
>   at 
> com.sun.jersey.server.impl.uri.rules.RightHandPathRule.accept(RightHandPathRule.java:147)
>   at 
> com.sun.jersey.server.impl.uri.rules.RootResourceClassesRule.accept(RootResourceClassesRule.java:84)
>   at 
> com.sun.jersey.server.impl.application.WebApplicationImpl._handleRequest(WebApplicationImpl.java:1483)
>   at 
> com.sun.jersey.server.impl.application.WebApplicationImpl._handleRequest(WebApplicationImpl.java:1414)
>   at 
> com.sun.jersey.server.impl.application.WebApplicationImpl.handleRequest(WebApplicationImpl.java:1363)
>   at 
> com.sun.jersey.server.impl.application.WebApplicationImpl.handleRequest(WebApplicationImpl.java:1353)
>   at 
> com.sun.jersey.spi.container.servlet.WebComponent.service(WebComponent.java:414)
>   at 
> com.sun.jersey.spi.container.servlet.ServletContainer.service(ServletContainer.java:537)
>   at 
> com.sun.jersey.spi.container.servlet.ServletContainer.service(ServletContainer.java:708)
>   at javax.servlet.http.HttpServlet.service(HttpServlet.java:729)
>   at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:292)
>   at 
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:207)
>   at 
> org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:52)
>   at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:240)
>   at 
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:207)
>

[jira] [Commented] (CALCITE-1520) org.apache.calcite.avatica.AvaticaConnection: support isValid()

2018-03-06 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CALCITE-1520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16388110#comment-16388110
 ] 

ASF GitHub Bot commented on CALCITE-1520:
-

Github user joshelser commented on the issue:

https://github.com/apache/calcite-avatica/pull/26
  
Change looks good to me, @risdenk.

My only ask would be if you could add a test case to `RemoveDriverTest` in 
the server module? Something simple/high-level that doesn't rely on mocking 
(e.g. create a connection, use it, check `isValid`, close the connection, 
ensure `isValid() == false`.


> org.apache.calcite.avatica.AvaticaConnection: support isValid()
> ---
>
> Key: CALCITE-1520
> URL: https://issues.apache.org/jira/browse/CALCITE-1520
> Project: Calcite
>  Issue Type: Improvement
>  Components: avatica
>Affects Versions: 1.10.0
> Environment: Windows
>Reporter: Ningli Fang
>Assignee: Kevin Risden
>Priority: Major
>
> Currently the calss org.apache.calcite.avatica.AvaticaConnection does not  
> support isValid():
> {code}
>  public boolean isValid(int timeout) throws SQLException {
> throw helper.unsupported();
>   }
> {code}
> On JasperSoft server, we created a dataSource using Calcite jdbc driver. When 
> use JasperSoft "test connection" feature, it failed with the exception:
> {noformat}
> java.sql.SQLFeatureNotSupportedException
>   at org.apache.calcite.avatica.Helper.unsupported(Helper.java:68)
>   at 
> org.apache.calcite.avatica.AvaticaConnection.isValid(AvaticaConnection.java:373)
>   at 
> org.apache.commons.dbcp.DelegatingConnection.isValid(DelegatingConnection.java:626)
>   at 
> org.apache.commons.dbcp.DelegatingConnection.isValid(DelegatingConnection.java:626)
>   at 
> com.jaspersoft.jasperserver.api.engine.jasperreports.service.impl.JdbcDataSourceService.isConnectionValid(JdbcDataSourceService.java:102)
>   at 
> com.jaspersoft.jasperserver.api.engine.jasperreports.service.impl.JdbcDataSourceService.testConnection(JdbcDataSourceService.java:86)
>   at 
> com.jaspersoft.jasperserver.remote.connection.JdbcConnectionStrategy.createConnection(JdbcConnectionStrategy.java:76)
>   at 
> com.jaspersoft.jasperserver.remote.connection.JdbcConnectionStrategy.createConnection(JdbcConnectionStrategy.java:45)
>   at 
> com.jaspersoft.jasperserver.remote.connection.ConnectionsManager.createConnection(ConnectionsManager.java:72)
>   at 
> com.jaspersoft.jasperserver.jaxrs.connection.ConnectionsJaxrsService.createConnection(ConnectionsJaxrsService.java:84)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
>   at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
>   at java.lang.reflect.Method.invoke(Unknown Source)
>   at 
> com.sun.jersey.spi.container.JavaMethodInvokerFactory$1.invoke(JavaMethodInvokerFactory.java:60)
>   at 
> com.sun.jersey.server.impl.model.method.dispatch.AbstractResourceMethodDispatchProvider$ResponseOutInvoker._dispatch(AbstractResourceMethodDispatchProvider.java:205)
>   at 
> com.sun.jersey.server.impl.model.method.dispatch.ResourceJavaMethodDispatcher.dispatch(ResourceJavaMethodDispatcher.java:75)
>   at 
> com.sun.jersey.server.impl.uri.rules.HttpMethodRule.accept(HttpMethodRule.java:302)
>   at 
> com.sun.jersey.server.impl.uri.rules.ResourceClassRule.accept(ResourceClassRule.java:108)
>   at 
> com.sun.jersey.server.impl.uri.rules.RightHandPathRule.accept(RightHandPathRule.java:147)
>   at 
> com.sun.jersey.server.impl.uri.rules.RootResourceClassesRule.accept(RootResourceClassesRule.java:84)
>   at 
> com.sun.jersey.server.impl.application.WebApplicationImpl._handleRequest(WebApplicationImpl.java:1483)
>   at 
> com.sun.jersey.server.impl.application.WebApplicationImpl._handleRequest(WebApplicationImpl.java:1414)
>   at 
> com.sun.jersey.server.impl.application.WebApplicationImpl.handleRequest(WebApplicationImpl.java:1363)
>   at 
> com.sun.jersey.server.impl.application.WebApplicationImpl.handleRequest(WebApplicationImpl.java:1353)
>   at 
> com.sun.jersey.spi.container.servlet.WebComponent.service(WebComponent.java:414)
>   at 
> com.sun.jersey.spi.container.servlet.ServletContainer.service(ServletContainer.java:537)
>   at 
> com.sun.jersey.spi.container.servlet.ServletContainer.service(ServletContainer.java:708)
>   at javax.servlet.http.HttpServlet.service(HttpServlet.java:729)
>   at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:292)
>   at 
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:207)
>   at 
>

[jira] [Commented] (CALCITE-1520) org.apache.calcite.avatica.AvaticaConnection: support isValid()

2018-03-05 Thread Kevin Risden (JIRA)


[ 
https://issues.apache.org/jira/browse/CALCITE-1520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16387235#comment-16387235
 ] 

Kevin Risden commented on CALCITE-1520:
---

Opened PR https://github.com/apache/calcite-avatica/pull/26

> org.apache.calcite.avatica.AvaticaConnection: support isValid()
> ---
>
> Key: CALCITE-1520
> URL: https://issues.apache.org/jira/browse/CALCITE-1520
> Project: Calcite
>  Issue Type: Improvement
>  Components: avatica
>Affects Versions: 1.10.0
> Environment: Windows
>Reporter: Ningli Fang
>Priority: Major
>
> Currently the calss org.apache.calcite.avatica.AvaticaConnection does not  
> support isValid():
> {code}
>  public boolean isValid(int timeout) throws SQLException {
> throw helper.unsupported();
>   }
> {code}
> On JasperSoft server, we created a dataSource using Calcite jdbc driver. When 
> use JasperSoft "test connection" feature, it failed with the exception:
> {noformat}
> java.sql.SQLFeatureNotSupportedException
>   at org.apache.calcite.avatica.Helper.unsupported(Helper.java:68)
>   at 
> org.apache.calcite.avatica.AvaticaConnection.isValid(AvaticaConnection.java:373)
>   at 
> org.apache.commons.dbcp.DelegatingConnection.isValid(DelegatingConnection.java:626)
>   at 
> org.apache.commons.dbcp.DelegatingConnection.isValid(DelegatingConnection.java:626)
>   at 
> com.jaspersoft.jasperserver.api.engine.jasperreports.service.impl.JdbcDataSourceService.isConnectionValid(JdbcDataSourceService.java:102)
>   at 
> com.jaspersoft.jasperserver.api.engine.jasperreports.service.impl.JdbcDataSourceService.testConnection(JdbcDataSourceService.java:86)
>   at 
> com.jaspersoft.jasperserver.remote.connection.JdbcConnectionStrategy.createConnection(JdbcConnectionStrategy.java:76)
>   at 
> com.jaspersoft.jasperserver.remote.connection.JdbcConnectionStrategy.createConnection(JdbcConnectionStrategy.java:45)
>   at 
> com.jaspersoft.jasperserver.remote.connection.ConnectionsManager.createConnection(ConnectionsManager.java:72)
>   at 
> com.jaspersoft.jasperserver.jaxrs.connection.ConnectionsJaxrsService.createConnection(ConnectionsJaxrsService.java:84)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
>   at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
>   at java.lang.reflect.Method.invoke(Unknown Source)
>   at 
> com.sun.jersey.spi.container.JavaMethodInvokerFactory$1.invoke(JavaMethodInvokerFactory.java:60)
>   at 
> com.sun.jersey.server.impl.model.method.dispatch.AbstractResourceMethodDispatchProvider$ResponseOutInvoker._dispatch(AbstractResourceMethodDispatchProvider.java:205)
>   at 
> com.sun.jersey.server.impl.model.method.dispatch.ResourceJavaMethodDispatcher.dispatch(ResourceJavaMethodDispatcher.java:75)
>   at 
> com.sun.jersey.server.impl.uri.rules.HttpMethodRule.accept(HttpMethodRule.java:302)
>   at 
> com.sun.jersey.server.impl.uri.rules.ResourceClassRule.accept(ResourceClassRule.java:108)
>   at 
> com.sun.jersey.server.impl.uri.rules.RightHandPathRule.accept(RightHandPathRule.java:147)
>   at 
> com.sun.jersey.server.impl.uri.rules.RootResourceClassesRule.accept(RootResourceClassesRule.java:84)
>   at 
> com.sun.jersey.server.impl.application.WebApplicationImpl._handleRequest(WebApplicationImpl.java:1483)
>   at 
> com.sun.jersey.server.impl.application.WebApplicationImpl._handleRequest(WebApplicationImpl.java:1414)
>   at 
> com.sun.jersey.server.impl.application.WebApplicationImpl.handleRequest(WebApplicationImpl.java:1363)
>   at 
> com.sun.jersey.server.impl.application.WebApplicationImpl.handleRequest(WebApplicationImpl.java:1353)
>   at 
> com.sun.jersey.spi.container.servlet.WebComponent.service(WebComponent.java:414)
>   at 
> com.sun.jersey.spi.container.servlet.ServletContainer.service(ServletContainer.java:537)
>   at 
> com.sun.jersey.spi.container.servlet.ServletContainer.service(ServletContainer.java:708)
>   at javax.servlet.http.HttpServlet.service(HttpServlet.java:729)
>   at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:292)
>   at 
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:207)
>   at 
> org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:52)
>   at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:240)
>   at 
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:207)
>   at 
> com.jaspersoft.jasperserver.war.StaticFilesCacheControlFilter.doFilter(StaticFilesCacheControlFilter.java:161)
>

[jira] [Commented] (CALCITE-1520) org.apache.calcite.avatica.AvaticaConnection: support isValid()

2018-03-05 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CALCITE-1520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16387233#comment-16387233
 ] 

ASF GitHub Bot commented on CALCITE-1520:
-

GitHub user risdenk opened a pull request:

https://github.com/apache/calcite-avatica/pull/26

[CALCITE-1520] Implement isValid for AvaticaConnection

* Changed helper to a static variable on the connection so Mockito could 
instantiate it. Since the underlying helper INSTANCE is static, I didn't think 
this would be an issue. Most of the line changes come from fixing Checkstyle 
for static final variable being uppercase.
* Implemented isValid without fully checking the underlying connection is 
actually valid. Does check if the connection is closed.

There didn't seem to be a way to check if there is a valid connection to 
the Avatica server. I thought about adding to the service or trying to get to 
the underlying HttpClient. However, none of these expose a timeout that would 
be reasonable. This implementation although not complete is a start in the 
right direction.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/risdenk/calcite-avatica CALCITE-1520

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/calcite-avatica/pull/26.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #26


commit bb12b47822ada388b661a1e05baaa397917b7397
Author: Kevin Risden 
Date:   2018-03-06T03:44:38Z

[CALCITE-1520] Implement isValid for AvaticaConnection




> org.apache.calcite.avatica.AvaticaConnection: support isValid()
> ---
>
> Key: CALCITE-1520
> URL: https://issues.apache.org/jira/browse/CALCITE-1520
> Project: Calcite
>  Issue Type: Improvement
>  Components: avatica
>Affects Versions: 1.10.0
> Environment: Windows
>Reporter: Ningli Fang
>Priority: Major
>
> Currently the calss org.apache.calcite.avatica.AvaticaConnection does not  
> support isValid():
> {code}
>  public boolean isValid(int timeout) throws SQLException {
> throw helper.unsupported();
>   }
> {code}
> On JasperSoft server, we created a dataSource using Calcite jdbc driver. When 
> use JasperSoft "test connection" feature, it failed with the exception:
> {noformat}
> java.sql.SQLFeatureNotSupportedException
>   at org.apache.calcite.avatica.Helper.unsupported(Helper.java:68)
>   at 
> org.apache.calcite.avatica.AvaticaConnection.isValid(AvaticaConnection.java:373)
>   at 
> org.apache.commons.dbcp.DelegatingConnection.isValid(DelegatingConnection.java:626)
>   at 
> org.apache.commons.dbcp.DelegatingConnection.isValid(DelegatingConnection.java:626)
>   at 
> com.jaspersoft.jasperserver.api.engine.jasperreports.service.impl.JdbcDataSourceService.isConnectionValid(JdbcDataSourceService.java:102)
>   at 
> com.jaspersoft.jasperserver.api.engine.jasperreports.service.impl.JdbcDataSourceService.testConnection(JdbcDataSourceService.java:86)
>   at 
> com.jaspersoft.jasperserver.remote.connection.JdbcConnectionStrategy.createConnection(JdbcConnectionStrategy.java:76)
>   at 
> com.jaspersoft.jasperserver.remote.connection.JdbcConnectionStrategy.createConnection(JdbcConnectionStrategy.java:45)
>   at 
> com.jaspersoft.jasperserver.remote.connection.ConnectionsManager.createConnection(ConnectionsManager.java:72)
>   at 
> com.jaspersoft.jasperserver.jaxrs.connection.ConnectionsJaxrsService.createConnection(ConnectionsJaxrsService.java:84)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
>   at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
>   at java.lang.reflect.Method.invoke(Unknown Source)
>   at 
> com.sun.jersey.spi.container.JavaMethodInvokerFactory$1.invoke(JavaMethodInvokerFactory.java:60)
>   at 
> com.sun.jersey.server.impl.model.method.dispatch.AbstractResourceMethodDispatchProvider$ResponseOutInvoker._dispatch(AbstractResourceMethodDispatchProvider.java:205)
>   at 
> com.sun.jersey.server.impl.model.method.dispatch.ResourceJavaMethodDispatcher.dispatch(ResourceJavaMethodDispatcher.java:75)
>   at 
> com.sun.jersey.server.impl.uri.rules.HttpMethodRule.accept(HttpMethodRule.java:302)
>   at 
> com.sun.jersey.server.impl.uri.rules.ResourceClassRule.accept(ResourceClassRule.java:108)
>   at 
> com.sun.jersey.server.impl.uri.rules.RightHandPathRule.accept(RightHandPathRule.java:147)
>   at 
> com.sun.jersey.server.impl.uri.rules.RootResourceClassesRule.accept(RootResourceClassesRule.java:84)
>   at 
>

[jira] [Commented] (CALCITE-1520) org.apache.calcite.avatica.AvaticaConnection: support isValid()

2018-03-05 Thread Kevin Risden (JIRA)


[ 
https://issues.apache.org/jira/browse/CALCITE-1520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16387155#comment-16387155
 ] 

Kevin Risden commented on CALCITE-1520:
---

[https://docs.oracle.com/javase/8/docs/api/java/sql/Connection.html#isValid-int-]

Specification for isValid on a Connection.

> org.apache.calcite.avatica.AvaticaConnection: support isValid()
> ---
>
> Key: CALCITE-1520
> URL: https://issues.apache.org/jira/browse/CALCITE-1520
> Project: Calcite
>  Issue Type: Improvement
>  Components: avatica
>Affects Versions: 1.10.0
> Environment: Windows
>Reporter: Ningli Fang
>Priority: Major
>
> Currently the calss org.apache.calcite.avatica.AvaticaConnection does not  
> support isValid():
> {code}
>  public boolean isValid(int timeout) throws SQLException {
> throw helper.unsupported();
>   }
> {code}
> On JasperSoft server, we created a dataSource using Calcite jdbc driver. When 
> use JasperSoft "test connection" feature, it failed with the exception:
> {noformat}
> java.sql.SQLFeatureNotSupportedException
>   at org.apache.calcite.avatica.Helper.unsupported(Helper.java:68)
>   at 
> org.apache.calcite.avatica.AvaticaConnection.isValid(AvaticaConnection.java:373)
>   at 
> org.apache.commons.dbcp.DelegatingConnection.isValid(DelegatingConnection.java:626)
>   at 
> org.apache.commons.dbcp.DelegatingConnection.isValid(DelegatingConnection.java:626)
>   at 
> com.jaspersoft.jasperserver.api.engine.jasperreports.service.impl.JdbcDataSourceService.isConnectionValid(JdbcDataSourceService.java:102)
>   at 
> com.jaspersoft.jasperserver.api.engine.jasperreports.service.impl.JdbcDataSourceService.testConnection(JdbcDataSourceService.java:86)
>   at 
> com.jaspersoft.jasperserver.remote.connection.JdbcConnectionStrategy.createConnection(JdbcConnectionStrategy.java:76)
>   at 
> com.jaspersoft.jasperserver.remote.connection.JdbcConnectionStrategy.createConnection(JdbcConnectionStrategy.java:45)
>   at 
> com.jaspersoft.jasperserver.remote.connection.ConnectionsManager.createConnection(ConnectionsManager.java:72)
>   at 
> com.jaspersoft.jasperserver.jaxrs.connection.ConnectionsJaxrsService.createConnection(ConnectionsJaxrsService.java:84)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
>   at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
>   at java.lang.reflect.Method.invoke(Unknown Source)
>   at 
> com.sun.jersey.spi.container.JavaMethodInvokerFactory$1.invoke(JavaMethodInvokerFactory.java:60)
>   at 
> com.sun.jersey.server.impl.model.method.dispatch.AbstractResourceMethodDispatchProvider$ResponseOutInvoker._dispatch(AbstractResourceMethodDispatchProvider.java:205)
>   at 
> com.sun.jersey.server.impl.model.method.dispatch.ResourceJavaMethodDispatcher.dispatch(ResourceJavaMethodDispatcher.java:75)
>   at 
> com.sun.jersey.server.impl.uri.rules.HttpMethodRule.accept(HttpMethodRule.java:302)
>   at 
> com.sun.jersey.server.impl.uri.rules.ResourceClassRule.accept(ResourceClassRule.java:108)
>   at 
> com.sun.jersey.server.impl.uri.rules.RightHandPathRule.accept(RightHandPathRule.java:147)
>   at 
> com.sun.jersey.server.impl.uri.rules.RootResourceClassesRule.accept(RootResourceClassesRule.java:84)
>   at 
> com.sun.jersey.server.impl.application.WebApplicationImpl._handleRequest(WebApplicationImpl.java:1483)
>   at 
> com.sun.jersey.server.impl.application.WebApplicationImpl._handleRequest(WebApplicationImpl.java:1414)
>   at 
> com.sun.jersey.server.impl.application.WebApplicationImpl.handleRequest(WebApplicationImpl.java:1363)
>   at 
> com.sun.jersey.server.impl.application.WebApplicationImpl.handleRequest(WebApplicationImpl.java:1353)
>   at 
> com.sun.jersey.spi.container.servlet.WebComponent.service(WebComponent.java:414)
>   at 
> com.sun.jersey.spi.container.servlet.ServletContainer.service(ServletContainer.java:537)
>   at 
> com.sun.jersey.spi.container.servlet.ServletContainer.service(ServletContainer.java:708)
>   at javax.servlet.http.HttpServlet.service(HttpServlet.java:729)
>   at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:292)
>   at 
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:207)
>   at 
> org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:52)
>   at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:240)
>   at 
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:207)
>   at 
>

[jira] [Commented] (CALCITE-1520) org.apache.calcite.avatica.AvaticaConnection: support isValid()

2018-03-04 Thread Kevin Risden (JIRA)


[ 
https://issues.apache.org/jira/browse/CALCITE-1520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16385423#comment-16385423
 ] 

Kevin Risden commented on CALCITE-1520:
---

In SOLR-8574, I needed to implement isValid() on the connection since as the 
reporter says some tools use it to see if the connection is alive. This support 
would be needed to integrate Avatica into Solr for SOLR-9963. 

> org.apache.calcite.avatica.AvaticaConnection: support isValid()
> ---
>
> Key: CALCITE-1520
> URL: https://issues.apache.org/jira/browse/CALCITE-1520
> Project: Calcite
>  Issue Type: Improvement
>  Components: avatica
>Affects Versions: 1.10.0
> Environment: Windows
>Reporter: Ningli Fang
>Priority: Major
>
> Currently the calss org.apache.calcite.avatica.AvaticaConnection does not  
> support isValid():
> {code}
>  public boolean isValid(int timeout) throws SQLException {
> throw helper.unsupported();
>   }
> {code}
> On JasperSoft server, we created a dataSource using Calcite jdbc driver. When 
> use JasperSoft "test connection" feature, it failed with the exception:
> {noformat}
> java.sql.SQLFeatureNotSupportedException
>   at org.apache.calcite.avatica.Helper.unsupported(Helper.java:68)
>   at 
> org.apache.calcite.avatica.AvaticaConnection.isValid(AvaticaConnection.java:373)
>   at 
> org.apache.commons.dbcp.DelegatingConnection.isValid(DelegatingConnection.java:626)
>   at 
> org.apache.commons.dbcp.DelegatingConnection.isValid(DelegatingConnection.java:626)
>   at 
> com.jaspersoft.jasperserver.api.engine.jasperreports.service.impl.JdbcDataSourceService.isConnectionValid(JdbcDataSourceService.java:102)
>   at 
> com.jaspersoft.jasperserver.api.engine.jasperreports.service.impl.JdbcDataSourceService.testConnection(JdbcDataSourceService.java:86)
>   at 
> com.jaspersoft.jasperserver.remote.connection.JdbcConnectionStrategy.createConnection(JdbcConnectionStrategy.java:76)
>   at 
> com.jaspersoft.jasperserver.remote.connection.JdbcConnectionStrategy.createConnection(JdbcConnectionStrategy.java:45)
>   at 
> com.jaspersoft.jasperserver.remote.connection.ConnectionsManager.createConnection(ConnectionsManager.java:72)
>   at 
> com.jaspersoft.jasperserver.jaxrs.connection.ConnectionsJaxrsService.createConnection(ConnectionsJaxrsService.java:84)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
>   at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
>   at java.lang.reflect.Method.invoke(Unknown Source)
>   at 
> com.sun.jersey.spi.container.JavaMethodInvokerFactory$1.invoke(JavaMethodInvokerFactory.java:60)
>   at 
> com.sun.jersey.server.impl.model.method.dispatch.AbstractResourceMethodDispatchProvider$ResponseOutInvoker._dispatch(AbstractResourceMethodDispatchProvider.java:205)
>   at 
> com.sun.jersey.server.impl.model.method.dispatch.ResourceJavaMethodDispatcher.dispatch(ResourceJavaMethodDispatcher.java:75)
>   at 
> com.sun.jersey.server.impl.uri.rules.HttpMethodRule.accept(HttpMethodRule.java:302)
>   at 
> com.sun.jersey.server.impl.uri.rules.ResourceClassRule.accept(ResourceClassRule.java:108)
>   at 
> com.sun.jersey.server.impl.uri.rules.RightHandPathRule.accept(RightHandPathRule.java:147)
>   at 
> com.sun.jersey.server.impl.uri.rules.RootResourceClassesRule.accept(RootResourceClassesRule.java:84)
>   at 
> com.sun.jersey.server.impl.application.WebApplicationImpl._handleRequest(WebApplicationImpl.java:1483)
>   at 
> com.sun.jersey.server.impl.application.WebApplicationImpl._handleRequest(WebApplicationImpl.java:1414)
>   at 
> com.sun.jersey.server.impl.application.WebApplicationImpl.handleRequest(WebApplicationImpl.java:1363)
>   at 
> com.sun.jersey.server.impl.application.WebApplicationImpl.handleRequest(WebApplicationImpl.java:1353)
>   at 
> com.sun.jersey.spi.container.servlet.WebComponent.service(WebComponent.java:414)
>   at 
> com.sun.jersey.spi.container.servlet.ServletContainer.service(ServletContainer.java:537)
>   at 
> com.sun.jersey.spi.container.servlet.ServletContainer.service(ServletContainer.java:708)
>   at javax.servlet.http.HttpServlet.service(HttpServlet.java:729)
>   at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:292)
>   at 
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:207)
>   at 
> org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:52)
>   at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:240)
>   at 
>

[jira] [Commented] (CALCITE-1520) org.apache.calcite.avatica.AvaticaConnection: support isValid()

[jira] [Commented] (CALCITE-1520) org.apache.calcite.avatica.AvaticaConnection: support isValid()

[jira] [Commented] (CALCITE-1520) org.apache.calcite.avatica.AvaticaConnection: support isValid()

[jira] [Commented] (CALCITE-1520) org.apache.calcite.avatica.AvaticaConnection: support isValid()

[jira] [Commented] (CALCITE-1520) org.apache.calcite.avatica.AvaticaConnection: support isValid()

[jira] [Commented] (CALCITE-1520) org.apache.calcite.avatica.AvaticaConnection: support isValid()

[jira] [Commented] (CALCITE-1520) org.apache.calcite.avatica.AvaticaConnection: support isValid()

[jira] [Commented] (CALCITE-1520) org.apache.calcite.avatica.AvaticaConnection: support isValid()

[jira] [Commented] (CALCITE-1520) org.apache.calcite.avatica.AvaticaConnection: support isValid()

[jira] [Commented] (CALCITE-1520) org.apache.calcite.avatica.AvaticaConnection: support isValid()

[jira] [Commented] (CALCITE-1520) org.apache.calcite.avatica.AvaticaConnection: support isValid()

[jira] [Commented] (CALCITE-1520) org.apache.calcite.avatica.AvaticaConnection: support isValid()

[jira] [Commented] (CALCITE-1520) org.apache.calcite.avatica.AvaticaConnection: support isValid()

[jira] [Commented] (CALCITE-1520) org.apache.calcite.avatica.AvaticaConnection: support isValid()

[jira] [Commented] (CALCITE-1520) org.apache.calcite.avatica.AvaticaConnection: support isValid()

[jira] [Commented] (CALCITE-1520) org.apache.calcite.avatica.AvaticaConnection: support isValid()

[jira] [Commented] (CALCITE-1520) org.apache.calcite.avatica.AvaticaConnection: support isValid()

17 matches

Site Navigation

Mail list logo

Footer information