[jira] [Commented] (CALCITE-1740) Distinct aggregate flag in window function

[ https://issues.apache.org/jira/browse/CALCITE-1740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15979151#comment-15979151 ] radu commented on CALCITE-1740: --- [~julianhyde] I have updated the PR with the new code implementation that

[jira] [Commented] (CALCITE-1740) Distinct aggregate flag in window function

[ https://issues.apache.org/jira/browse/CALCITE-1740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15979003#comment-15979003 ] radu commented on CALCITE-1740: --- [~julianhyde] I have addressed the remarks except managing to create a

[jira] [Commented] (CALCITE-1740) Distinct aggregate flag in window function

[ https://issues.apache.org/jira/browse/CALCITE-1740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15978239#comment-15978239 ] radu commented on CALCITE-1740: --- [~julianhyde] Thanks a lot for the feedback. I will address these remarks

[jira] [Commented] (CALCITE-1740) Distinct aggregate flag in window function

[ https://issues.apache.org/jira/browse/CALCITE-1740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15965502#comment-15965502 ] radu commented on CALCITE-1740: --- [~julianhyde] Great. I will proceed to add this modification. I know

[jira] [Commented] (CALCITE-1740) Distinct aggregate flag in window function

[ https://issues.apache.org/jira/browse/CALCITE-1740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15964720#comment-15964720 ] Julian Hyde commented on CALCITE-1740: -- Looks like {{RexOver}} will need a {{distinct}} field.

[jira] [Commented] (CALCITE-1740) Distinct aggregate flag in window function

[ https://issues.apache.org/jira/browse/CALCITE-1740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15964086#comment-15964086 ] radu commented on CALCITE-1740: --- I have checked the tests in the RelOptRulesTest class, but i am not sure

[jira] [Commented] (CALCITE-1740) Distinct aggregate flag in window function

[ https://issues.apache.org/jira/browse/CALCITE-1740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15963471#comment-15963471 ] Julian Hyde commented on CALCITE-1740: -- I do not agree that the "distinct" flag should be part of

[jira] [Commented] (CALCITE-1740) Distinct aggregate flag in window function

[ https://issues.apache.org/jira/browse/CALCITE-1740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15963260#comment-15963260 ] radu commented on CALCITE-1740: --- [~julianhyde] I looked over the logic of passing the DISTINCT keyword.

[jira] [Commented] (CALCITE-1740) Distinct aggregate flag in window function

[ https://issues.apache.org/jira/browse/CALCITE-1740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15960463#comment-15960463 ] radu commented on CALCITE-1740: --- [~julianhyde] I can try to tackle this problem. My ambitious is to

[jira] [Commented] (CALCITE-1740) Distinct aggregate flag in window function

[ https://issues.apache.org/jira/browse/CALCITE-1740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15957845#comment-15957845 ] Julian Hyde commented on CALCITE-1740: -- We could solve in two ways: * Throw an error that DISTINCT